From: Tyler Retzlaff
Remove __rte_packed where it appears natural alignment without
packing would produce the same layout or the struct is internal.
Signed-off-by: Tyler Retzlaff
---
app/test-pmd/csumonly.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/csumon
The change below is replacing 1 rte_smp_rmb with 2 calls,
so no it is not what I am asking for.
Please could you check how to not calling this function at all?
This series is already merged in the main branch,
so any new change should be submitted as a new patch.
Thank you
19/11/2024 07:29, 王颢:
Hi Nandini,
One minor comment..
- Hemant
On 18-11-2024 22:43, Nandini Persad wrote:
This is a new document covering security protocols
implemented in DPDK.
+PDCP
+
+
+Packet Data Convergence Protocol (PDCP) is a sublayer in the LTE radio
protocol stack
+that provides security and
Dear Thomas,
After our discussion, we concluded that we can make the following changes. What
do you think? Additionally, I may not have been very clear in my last email.
Should I submit the entire series of changes as PATCH v9, or should I respond
with [PATCH v9 12/17] net/r8169: implement Tx p
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
app/test/test_efd.c| 1 +
app/test/test_hash.c | 1 +
app/test/test_member.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/app/test/tes
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Remove __rte_packed where it appears natural alignment without
packing would produce the same layout or the struct is internal.
Signed-off-by: Tyler Retzlaff
---
examples/common/neon
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
drivers/net/octeon_ep/otx_ep_mbox.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/octeon_ep/otx_ep_mbox.h
b/drivers/net/octeon_ep/
From: Shuanglin Wang
Add code for Thor2 to support the counter accumulation for
F1F2 vxlan parent-child flows.
Also, add a check for device state in the TF tunnel free API,
if it is zero then TF will skip the resource free as it
was already done by bnxt_free_all_hwrm_resources.
Fixes: 0513f0af03
This patch series fixes a few issues in TruFlow for Broadcom Thor2 NIC.
**
v1->v2:
- Added patch-5 to fix coverity errors
**
Kishore Padmanabha (2):
net/bnxt/tf_ulp: fix vfr clean up and stats lockup
net/bnxt/tf_ulp: update template files
Peter Spreadborough (2):
net/bnxt/tf_ulp: p
From: Kishore Padmanabha
The representor flows were not being deleted as part of the
vfr clean up. Added code to delete flows related to vfr interface.
Also fixed the stats counter thread lockup.
Fixes: 0513f0af034d ("net/bnxt/tf_ulp: add stats cache for Thor2")
Reviewed-by: Peter Spreadborough
From: Peter Spreadborough
This change adds changes the act get API to expect a physical
address for the host memory rather than a pointer to a local
virtual address. The change was made because the virt->phys
API call has a very high overhead. Also included in this change
to the mutex locks and d
From: Peter Spreadborough
This patch fixes a few coverity errors reported in the feature
patchset (merged) to support TruFlow on Thor2.
Fixes: 0513f0af034d ("net/bnxt/tf_ulp: add stats cache for Thor2")
Signed-off-by: Peter Spreadborough
Signed-off-by: Sriharsha Basavapatna
---
drivers/net/bn
Acked-by: Hemant Agrawal
On 15-11-2024 11:35, Stephen Hemminger wrote:
The dqrr_held mask is 64 bit but updates were getting truncated
because 1 is of type int (32 bit) and the result shift of int is of
type int (32 bit); therefore any value >= 32 would get truncated.
Link: https://pvs-studio.
Update HWRM API to select ring profile.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/hsi_struct_def_dpdk.h | 71 +-
1 file changed, 69 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h
b/drivers/net/bnxt/hsi_struct_def_dpdk.h
index 8
v1->v2: Rebasing patchset based on latest dpdk tree.
v2->v3: Dropped an incomplete patch which ended up on mailing list.
Please apply.
Ajit Khaparde (2):
net/bnxt: update HWRM API
net/bnxt: add support for Rx profile selection
drivers/net/bnxt/bnxt.h| 1 +
drivers/net/bnxt/
These patches provide next fixes:
1. The testpmd command “flow update…“ provides a nullptr as the
context variable.
2. Avoid removal of additional flows after requested number of flows has
been already removed.
v2:
1. Rephase commit messages.
2.
Some firmware versions can support the selection of Rx profile
during Rx and AGG ring allocation.
Check if the firmware sets the
HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT3_RX_RATE_PROFILE_SEL_SUPPORTED flag
and set the new Rx profile.
Signed-off-by: Ajit Khaparde
Reviewed-by: Andy Gospodarek
---
drivers
On 15-11-2024 11:35, Stephen Hemminger wrote:
The dqrr_held mask is 64 bit but updates were getting truncated
because 1 is of type int (32 bit) and the result shift of int is of
type int (32 bit); therefore any value >= 32 would get truncated.
Link: https://pvs-studio.com/en/blog/posts/cpp/118
> -Original Message-
> From: Danylo Vodopianov
> Sent: Monday, November 18, 2024 12:26
> To: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam
> ; mko-...@napatech.com; c...@napatech.com; Dariusz
> Sosnowski ; sil-...@napatech.com
> Cc:
If lock is acquired for write, it must be released for write
or a deadlock is likely.
Bugzilla ID: 1582
Fixes: 9fc93a1e2320 ("vhost: fix virtqueue access check in datapath")
Cc: david.march...@redhat.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
lib/vhost/virtio_net.c | 2 +-
1 f
The dqrr_held mask is 64 bit but updates were getting truncated
because 1 is of type int (32 bit) and the result shift of int is of
type int (32 bit); therefore any value >= 32 would get truncated.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 5e7455931442 ("net/dpaa: support Rx que
The dqrr_held mask is 64 bit but updates were getting truncated
because 1 is of type int (32 bit) and the result shift of int is of
type int (32 bit); therefore any value >= 32 would get truncated.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: a77db24643b7 ("crypto/dpaa2_sec: suppor
The log message would always refer to str variable which
is NULL here. Looks like author intended to print original
parameter.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Signed-off-by: Stephen Hemminger
---
drivers/net/cpfl/cpfl_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
More bug fixes from PVS studio bug reports.
And one other fix to ptpclient.
Stephen Hemminger (19):
common/cnxk: remove duplicate condition
net/cpfl: avoid calling log (printf) with null
raw/cnxk_gpio: fix file descriptor leak
net/ntnic: remove dead code
net/i40e: remove duplicate code
Hi Nick,
I second the comments already made. A couple of nits on top of those:
On 05/07/2024 18:13, Nicholas Pratte wrote:
Remove the list of devices from the schema, as these are unuesed.
Likewise, removed build-target information since these is not currently
used, and it is unlikely to be use
> -Original Message-
> From: sk...@marvell.com
> Sent: Thursday, November 14, 2024 1:08 PM
> To: Liron Himi ; Jerin Jacob
> Cc: dev@dpdk.org; alia...@nvidia.com; Sunil Kumar Kori
> ; sta...@dpdk.org
> Subject: [PATCH 2/3] regex/cn9k: fix build warnings on ubuntu 24.04
>
> From: Sunil
Same comments as Juraj again. Also the commit subject should be all
lower case, and the bugzilla tag should be split from the signed-off-by
here too.
If actions provided to “flow update…“ command contained an age
action, then testpmd did not update the age action context
accordingly.
Thus "flow aged destroy" command can not
execute successfully.
Fix was done with next steps
1. Generate new port flow entry to add/replace action(s).
2. Set age
Avoid removal of additional flows after requested number of flows has
been already removed.
port_flow_destroy() function goes through all flows and compares
given flow ‘id’ with them. However in some cases it can advance pointer
with “given ID” and thus remove additional flow.
port_flow_destroy()
If actions provided to “flow update…“ command contained an age
action, then testpmd did not update the age action context
accordingly.
Thus "flow aged destroy" command can not
execute successfully.
Fix was done with next steps
1. Generate new port flow entry to add/replace action(s).
2. Set age
These patches provide next fixes:
1. The testpmd command “flow update…“ provides a nullptr as the
context variable.
2. Avoid removal of additional flows after requested number of flows has
been already removed.
v2:
1. Rephase commit messages.
2.
14/11/2024 08:44, Hemant Agrawal:
> To avoid regressions on this topic, could you look into enabling clang
> thread safety check?
This original question is replaced with a proper description of the change:
bus/dpaa: enable clang thread safety check for FQ locks
Enable "annotate_locks
These patches provide next fixes:
1. The testpmd command “flow update…“ provides a nullptr as the
context variable.
2. Avoid removal of additional flows after requested number of flows has
been already removed.
v2:
1. Rephase commit messages.
2.
bnxt patchset rebased against the latest dpdk repository.
Ajit Khaparde (3):
net/bnxt: update HWRM API
net/bnxt: add support for Rx profile selection
net/bnxt: set max VFs count for P7
drivers/net/bnxt/bnxt.h| 2 +
drivers/net/bnxt/bnxt_hwrm.c | 15 +-
drive
port_flow_destroy() function never assumed that rule array can be freed
when it's executing, and port_flow_aged() just violated that assumption.
In case of flow async create failure, it tries to do a cleanup, but it
wrongly removes a 1st flow (with id 0). pf->id is not set at this
moment and it al
These patches provide next fixes:
1. The testpmd command “flow update…“ provides a nullptr as the
context variable.
2. Avoid removal of additional flows after requested number of flows has
been already removed.
v2:
1. Rephase commit messages.
The code for parsing layers in devargs could reference past
the end of layers[] array on stack.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 9a1a9e4a2ddd ("devargs: support path value with global device syntax")
Cc: xuemi...@nvidia.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hem
The array of debug status strings did not match possible enum
values. Add the missing element and a static assert to make sure
the table has all possible values.
For more complete description see.
Link: https://pvs-studio.com/en/blog/posts/cpp/1176/
Fixes: ec55c118792b ("net/qede: add infrastruct
There are two branches in the cascading if/else that have same
condition and code; remove one. Update the code to follow DPDK
style where all statements in if should have brackets if any
leg requires them.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 2ab5c84605f0 ("net/i40e: fix ESP
Don't use rte_memcpy() when not necessary. Structure assignment
is as fast and type safe.
Signed-off-by: Stephen Hemminger
---
examples/ptpclient/ptpclient.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.
The function would leak file if fscanf failed.
There is a working version in other file, clone that.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 0e6557b448fa ("raw/cnxk_gpio: add self test")
Cc: tduszyn...@marvell.com
Signed-off-by: Stephen Hemminger
---
drivers/raw/cnxk_gpio/c
Both sides of the if in uninit are using same code.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Signed-off-by: Stephen Hemminger
---
drivers/net/octeon_ep/otx_ep_ethdev.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c
More bitmask truncation from mask computation.
Fixes: 0ee17f79ebd0 ("event/dpaa: add enqueue/dequeue")
Cc: sunil.k...@nxp.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
Acked-by: Hemant Agrawal
---
drivers/event/dpaa/dpaa_eventdev.c | 10 +-
1 file changed, 5 insertions(+), 5
The dqrr_held mask is 64 bit but updates were getting truncated
because 1 is of type int (32 bit) and the result shift of int is of
type int (32 bit); therefore any value >= 32 would get truncated.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: fe3688ba7950 ("crypto/dpaa_sec: support
Using variable in outer loop, and inner loop is obvious bug.
This bug is in base code, so likely on other platforms as well.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 81dba2b2ff61 ("net/qede/base: add LLDP support")
Cc: rasesh.m...@cavium.com
Cc: sta...@dpdk.org
Signed-off-by: S
The type mask is 64 bit value, doing a shift of literal 1 (32 bit)
will result in int type (32 bit) and cause truncation.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: f4ca3fd54c4d ("net/hinic: create and destroy flow director filter")
Cc: cloud.wangxiao...@huawei.com
Cc: sta...@dpdk
The expression:
if ((socketid = rte_lcore_to_socket_id(lcore) != 0) &&
gets evaluated as sockeid = (rte_lcore_to_socket_id(lcore) != 0)
which is not what was intended. This is goes all the way back
to first release.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: af75078fece3 ("fir
The dqrr_held mask is 64 bit but updates were getting truncated
because 1 is of type int (32 bit) and the result shift of int is of
type int (32 bit); therefore any value >= 32 would get truncated.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: 2d3788631862 ("net/dpaa2: support atomi
> -Original Message-
> From: Danylo Vodopianov
> Sent: Monday, November 18, 2024 19:03
> To: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam
> ; mko-...@napatech.com; c...@napatech.com; Dariusz
> Sosnowski ; sil-...@napatech.com
> Cc:
17/11/2024 20:11, Mattias Rönnblom:
> On 2024-11-14 18:09, Thomas Monjalon wrote:
> > The lcore variables API is new in DPDK 24.11,
> > that's why the function rte_lcore_var_alloc() was marked experimental.
> > To be clearer, the whole header file (including all macros)
> > is marked experimental.
> -Original Message-
> From: Danylo Vodopianov
> Sent: Monday, November 18, 2024 19:03
> To: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam
> ; mko-...@napatech.com; c...@napatech.com; Dariusz
> Sosnowski ; sil-...@napatech.com
> Cc
The same condition is checked twice in an if statement.
Harmless, but redundant.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Signed-off-by: Stephen Hemminger
Acked-by: Anoob Joseph
---
drivers/common/cnxk/cnxk_security.c | 16 ++--
1 file changed, 10 insertions(+), 6 delet
The loop to update speed would not work because num_port_speeds
was always zero so it did nothing. And the array of pls_mbps
was only used inside the loop but never set.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Signed-off-by: Stephen Hemminger
---
drivers/net/ntnic/ntnic_ethdev.c |
The pointer mode is used then checked which is a bug reported
by PVS studio and Coverity.
Fixes: bd2fd34ab86f ("common/cnxk: sync eth mode change command with firmware")
Cc: tduszyn...@marvell.com
Signed-off-by: Stephen Hemminger
---
drivers/common/cnxk/roc_bphy_cgx.c | 12 ++--
1 file
This suite tests the ability of the Poll Mode Driver to enable
and disable Rx/Tx queues on a port.
Depends-on: patch-12 ("dts: add port queue modification
and forwarding stats to testpmd")
Signed-off-by: Dean Marx
Reviewed-by: Jeremy Spewock
---
dts/framework/config/conf_yaml_schema.json |
On 11/15/2024 8:33 AM, Jiawen Wu wrote:
> Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by
> default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity
> is set to 0xd by default too, which means these interrupts are rising-edge
> sensitive.
>
> So when unplug
> -Original Message-
> From: Danylo Vodopianov
> Sent: Monday, November 18, 2024 11:25
> To: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam
> ; mko-...@napatech.com; c...@napatech.com; Dariusz
> Sosnowski ; sil-...@napatech.com
> Cc:
Reviewed-by: Patrick Robb
On Tue, Nov 19, 2024 3:59 AM, Ferruh Yigit wrote:
> On 11/15/2024 8:33 AM, Jiawen Wu wrote:
> > Since firmware version 0x20010, GPIO interrupt enable is set to 0xd by
> > default, which means enable bit 0 'tx_fault'. And GPIO interrupt polarity
> > is set to 0xd by default too, which means these in
On Mon, Nov 18, 2024 at 8:07 AM Sriharsha Basavapatna
wrote:
>
> This patch series fixes a few issues in TruFlow for Broadcom Thor2 NIC.
Patchset applied to dpdk-next-net-brcm.
Fixed up a couple of typos during merge.
>
> Kishore Padmanabha (2):
> net/bnxt/tf_ulp: fix vfr clean up and stats loc
https://bugs.dpdk.org/show_bug.cgi?id=1584
Bug ID: 1584
Summary: dts: rxq info dataclass fields were dropped
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: minor
Applied to next-dts, thanks.
Reviewed-by: Patrick Robb
On Mon, Nov 18, 2024 at 1:13 PM Ajit Khaparde
wrote:
>
> v1->v2: Rebasing patchset based on latest dpdk tree.
> v2->v3: Dropped an incomplete patch which ended up on mailing list.
Patches rebased and applied to dpdk-next-net-brcm.
>
> Please apply.
>
> Ajit Khaparde (2):
> net/bnxt: update HWR
Although I don't think it's necessarily wrong, I wanted to note for the
broader group that this series is indeed dropping rxq info dataclass fields
which were previously supported. It is worth discussing at the next DTS
meeting so we have better clarity on how to handle these situations going
forwa
Dear Thomas,
I will consider that. By the way, should I make the changes and then upload
patch v9?
Thanks!
-邮件原件-
发件人: Thomas Monjalon
发送时间: 2024年11月18日 22:59
收件人: pro_nic_d...@realtek.com; 王颢
抄送: dev@dpdk.org; Ferruh Yigit
主题: Re: [PATCH v8 12/17] net/r8169: implement Tx path
Ext
Calling memcmp on same structure will always be true.
Replace with same conditional used elsewhere.
Link: https://pvs-studio.com/en/blog/posts/cpp/1183/
Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
Cc: danielx.t.mrzyg...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
lib/net/rte_arp.h | 2 ++
lib/net/rte_dtls.h | 1 +
lib/net/rte_esp.h | 2 ++
lib/net/rte_geneve.h | 1 +
lib/net/rte_gre.h | 4
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
drivers/common/mlx5/mlx5_common_mr.h| 4
drivers/common/mlx5/mlx5_common_utils.h | 1 +
drivers/common/mlx5/mlx5_prm.h | 30 +
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
drivers/common/idpf/base/idpf_osdep.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/common/idpf/base/idpf_osdep.h
b/drivers/common/i
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
drivers/net/ice/base/ice_osdep.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ice/base/ice_osdep.h b/drivers/net/ice/base/ice_os
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
drivers/net/mlx5/hws/mlx5dr.h | 1 +
drivers/net/mlx5/mlx5.h | 1 +
drivers/net/mlx5/mlx5_flow.h| 4
drivers/net/mlx5/mlx5_hws_cnt
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
drivers/common/iavf/iavf_osdep.h| 2 ++
drivers/common/iavf/virtchnl_inline_ipsec.h | 11 +++
2 files changed, 13 insertions(+)
From: Tyler Retzlaff
MSVC struct packing is not compatible with GCC. Provide a macro that
can be used to push existing pack value and sets packing to 1-byte.
The existing __rte_packed macro is then used to restore the pack value
prior to the push.
Instead of providing macros exclusively for MSVC
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Remove __rte_packed where it appears natural alignment without
packing would produce the same layout or the struct is internal.
Signed-off-by: Tyler Retzlaff
---
drivers/net/iavf/iav
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
drivers/net/i40e/base/i40e_osdep.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/i40e/base/i40e_osdep.h
b/drivers/net/i40e/base/
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
drivers/crypto/mlx5/mlx5_crypto.h | 2 ++
drivers/crypto/mlx5/mlx5_crypto_gcm.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/cry
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Remove __rte_packed where it appears natural alignment without
packing would produce the same layout or the struct is internal.
Signed-off-by: Tyler Retzlaff
---
lib/eal/common/eal_p
From: Andre Muezerie
MSVC struct packing is not compatible with GCC provide a macro that can
be used to push existing pack value and sets packing to 1-byte. The
existing __rte_packed macro is then used to restore the pack value
prior to the push.
Instead of providing macros exclusively for MSVC
From: Tyler Retzlaff
Add __rte_msvc_pack to all __rte_packed structs to cause packing
when building with MSVC.
Signed-off-by: Tyler Retzlaff
---
drivers/dma/ioat/ioat_hw_defs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/ioat/ioat_hw_defs.h b/drivers/dma/ioat/ioat_hw_defs.h
Add support for reading Intel x86_64 PMU events in runtime.
Signed-off-by: Tomasz Duszynski
---
app/test/test_pmu.c | 2 ++
lib/pmu/meson.build | 1 +
lib/pmu/rte_pmu.h| 2 ++
lib/pmu/rte_pmu_pmc_x86_64.h | 24
4 files changed, 29 inserti
> -Original Message-
> From: Danylo Vodopianov
> Sent: Monday, November 18, 2024 12:26
> To: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> aman.deep.si...@intel.com; yuying.zh...@intel.com; Ori Kam
> ; mko-...@napatech.com; c...@napatech.com; Dariusz
> Sosnowski ; sil-...@napatech.com
> Cc: G
> -Original Message-
> From: Jerin Jacob
> Sent: Monday, November 18, 2024 2:11 PM
> To: Sunil Kumar Kori ; Liron Himi
> Cc: dev@dpdk.org; alia...@nvidia.com; Sunil Kumar Kori
> ; sta...@dpdk.org
> Subject: RE: [PATCH 2/3] regex/cn9k: fix build warnings on ubuntu 24.04
>
>
>
> > -O
This is a new document covering security protocols
implemented in DPDK.
Signed-off-by: Nandini Persad
Signed-off-by: Thomas Monjalon
Reviewed-by: Stephen Hemminger
---
V2 - incorporate review feedback
doc/guides/index.rst | 1 +
doc/guides/security/security.rst | 337
Here again I am on the same level as Juraj. Repeating my previous
comments on commit subject and Bugzilla ID.
Moreover, the subject should be of imperative form according to the
contributing guidelines. In other words, the first word is always an
imperative verb. Something like this could work
Good one. My only comment – aside the usual ones – on top of Juraj's is
could try to make the commit subject more concise. For example:
dts: isolate config of dpdk arguments
The issue you mention should be resolved now with the Pydantic changes.
Do we still have reason to make this change? I guess we could make the
test suites in the config file optional, in which case you can just add
a default to the field and remove the constraint.
As Juraj already said this is no longer needed.
> > On Nov 14, 2024, at 8:41 AM, Konstantin Ananyev
> > wrote:
> >
> > Hi everyone,
> >
> > Looking at implementation of cryptodev callbacks
> > (it uses DPDK RCU), it seems like there is a bug here:
> >
> > at init time we don't call rte_rcu_qsbr_thread_register().
> > As I understand without
This is a good change, but I'd like to review it once you adapt it to
the Pydantic-based config, as it may look quite different.
While we are splitting things I suggest to create two new source files
under `config` for each sections:
conf/
__init__.py # where Configurations stays and br
Avoid removal of additional flows after requested number of flows has
been already removed.
port_flow_destroy() function goes through all flows and compares
given flow ‘id’ with them. However in some cases it can advance pointer
with “given ID” and thus remove additional flow.
port_flow_destroy()
Update HWRM API to select ring profile.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/hsi_struct_def_dpdk.h | 71 +-
1 file changed, 69 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/hsi_struct_def_dpdk.h
b/drivers/net/bnxt/hsi_struct_def_dpdk.h
index 8
The number of max VFs per PF is 128 for P7 devices.
Cap the vnic hash table creation if the number of max VNICs
is less than 8.
Signed-off-by: Kishore Padmanabha
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt.h | 1 +
drivers/net/bnxt/bnxt_vnic.c | 6 ++
2 files changed, 7 insert
Hello,
13/11/2024 10:28, Howard Wang:
> +static u32
> +rtl_get_opts1(struct rtl_tx_desc *txd)
> +{
> + rte_smp_rmb();
> +
> + return rte_le_to_cpu_32(txd->opts1);
> +}
We should avoid using such heavy memory barrier.
Is it possible to use a lighter fence or atomic API?
In the actions construction of NT2HWS, the `masks` parameter is
always set to NULL and all the actions will be translated in the
"construct" stage as non-fixed ones.
In the stage of translating actions template, the actions data would
be allocated from the pool and managed in a list. The list woul
This patch series fixes a few issues in TruFlow for Broadcom Thor2 NIC.
Kishore Padmanabha (2):
net/bnxt/tf_ulp: fix vfr clean up and stats lockup
net/bnxt/tf_ulp: update template files
Peter Spreadborough (1):
net/bnxt/tf_ulp: performance and tuning changes for thor2 stats cache
Shuanglin
From: Shuanglin Wang
Add code for Thor2 to support the counter accumulation for
F1F2 vxlan parent-child flows.
Also, add a check for device state in the TF tunnel free API,
if it is zero then TF will skip the resource free as it
was already done by bnxt_free_all_hwrm_resources.
Fixes: 0513f0af03
From: Kishore Padmanabha
The representor flows were not being deleted as part of the
vfr clean up. Added code to delete flows related to vfr interface.
Also fixed the stats counter thread lockup.
Fixes: 0513f0af034d ("net/bnxt/tf_ulp: add stats cache for Thor2")
Reviewed-by: Peter Spreadborough
From: Peter Spreadborough
This change adds changes the act get API to expect a physical
address for the host memory rather than a pointer to a local
virtual address. The change was made because the virt->phys
API call has a very high overhead. Also included in this change
to the mutex locks and d
If actions provided to “flow update…“ command contained an age
action, then testpmd did not update the age action context
accordingly.
Thus "flow aged destroy" command can not
execute successfully.
Fix was done with next steps
1. Generate new port flow entry to add/replace action(s).
2. Set age
1 - 100 of 110 matches
Mail list logo
