Hi Nick,
I second the comments already made. A couple of nits on top of those:
On 05/07/2024 18:13, Nicholas Pratte wrote:
Remove the list of devices from the schema, as these are unuesed.
Likewise, removed build-target information since these is not currently
used, and it is unlikely to be used in the future. Adjustments to the
dts.rst are made to reflect these changes.
There are no adjustments made to the dts.rst here, so it shouldn't be
mentioned.
Bugzilla ID: 1360
There should be an empty line between Signed-off-by and the metatags.
Signed-off-by: Nicholas Pratte <npra...@iol.unh.edu>
---
<snip>
@unique
class Compiler(StrEnum):
r"""The supported compilers of
:class:`~framework.testbed_model.node.Node`\s."""
@@ -341,28 +325,20 @@ class BuildTargetConfiguration:
The configuration used for building DPDK.
Attributes:
- arch: The target architecture to build for.
- os: The target os to build for.
- cpu: The target CPU to build for.
compiler: The compiler executable to use.
compiler_wrapper: This string will be put in front of the compiler
when
executing the build. Useful for adding wrapper commands, such as
``ccache``.
name: The name of the compiler.
I am a bit confused whether you are removing `name` or not, but if you
are you forgot to remove this entry from the docstring.
"""
- arch: Architecture
- os: OS
- cpu: CPUType
compiler: Compiler
compiler_wrapper: str
- name: str
