On 2024-09-12 08:38, Mattias Rönnblom wrote:
On 2024-09-12 03:33, Varghese, Vipin wrote:
[Public]
Snipped
Thank you Mattias for the comments and question, please let me
try to explain the same below
We shouldn't have a separate CPU/cache hierarchy API instead?
Based on the intention
On 2024/9/12 13:35, Mattias Rönnblom wrote:
> On 2024-09-12 04:33, fengchengwen wrote:
>> On 2024/9/12 1:04, Mattias Rönnblom wrote:
>>> Introduce DPDK per-lcore id variables, or lcore variables for short.
>>>
>>> An lcore variable has one value for every current and future lcore
>>> id-equipped th
On Thu, Sep 12, 2024 at 11:05 AM Mattias Rönnblom wrote:
>
> On 2024-09-12 04:33, fengchengwen wrote:
> > On 2024/9/12 1:04, Mattias Rönnblom wrote:
> >> Introduce DPDK per-lcore id variables, or lcore variables for short.
> >>
> >> An lcore variable has one value for every current and future lcor
This patch adds support for customizing firmware search path for
DDP package like the kernel behavior, it will read the search path
from "/sys/module/firmware_class/parameters/path", and try to load
DDP package.
Also, updates documentation for loading the DDP package in ice.rst.
Signed-off-by: Zh
On Wed, Sep 11, 2024 at 11:08 PM Mattias Rönnblom
wrote:
>
> Add test suite to exercise the API.
>
> Signed-off-by: Mattias Rönnblom
> Acked-by: Morten Brørup
>
> --
>
> RFC v5:
> * Adapt tests to reflect the removal of the GET() and SET() macros.
>
> RFC v4:
> * Check all lcore id's values f
This patch adds support for customizing firmware search path for
DDP package like the kernel behavior, it will read the search path
from "/sys/module/firmware_class/parameters/path", and try to load
DDP package.
Also, updates documentation for loading the DDP package in ice.rst.
Signed-off-by: Zh
On 9/11/2024 5:04 PM, Nandini Persad wrote:
> Hi Ferruh,
>
> I will work with Stephen on this. For the tone of the list, I believe we
> can try different ways to make the tone more friendly, while still being
> concise.
>
> What about something like this:
> # Avoid including unused headers (proce
On 2024/9/12 13:50, Stephen Hemminger wrote:
> On Thu, 12 Sep 2024 12:14:08 +0800
> "WanRenyong" wrote:
>
>>>
+};
+
>>> Does this device driver depend on some upstr
>> Yes, it depends on linux kernel driver of the device.
>>
>> Hello, Stephen,
>>
>> Thanks for your review, please see
On 9/12/2024 6:12 AM, Tyler Retzlaff wrote:
> On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote:
>> Redefining memcpy as rte_memcpy has no performance gain on
>> current compilers, and introduced bugs like this one where
>> rte_memcpy() will be detected as referencing past the desti
This is a continuation of the cleanup effort in logging macros.
As a reminder of what this series is about, RTE_LOG_LINE() has been
introduced to check that the format string does not contain a trailing \n.
The goal was to prevent from:
- introducing multilines log messages (ugly and unhelpful for
Do not stop at the first file that got warnings.
Signed-off-by: David Marchand
---
devtools/check-forbidden-tokens.awk | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/devtools/check-forbidden-tokens.awk
b/devtools/check-forbidden-tokens.awk
index 807dad7f48..d72d244d3a
If a patch contains multiple files, it is possible to pass through the
check because the count of token mentions is not reset between file
evaluation.
Example with a fake patch:
$ cat toto.patch
--- a/drivers/plop1
+++ b/drivers/plop1
- RTE_LOG(
- RTE_LOG(
+ RTE_LOG(
--- a/drivers/p
Those debug macros never worked as existing callers never passed a
'level' argument.
Remove them.
Signed-off-by: David Marchand
---
drivers/net/dpaa/fmlib/fm_ext.h | 21 ++---
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/drivers/net/dpaa/fmlib/fm_ext.h b/drivers
The net/sfc driver logtype was registered under pmd.net.sfc."driver".
Fixes: 0f39f32482a1 ("net/sfc: remove use of EAL logtype")
Signed-off-by: David Marchand
Reviewed-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
Nothing is fixed here, just reuse the value coming from the build
framework rather than use a fixed string that may get wrong in the
future.
Signed-off-by: David Marchand
Reviewed-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_log.h | 7 ++-
drivers/vdpa/sfc/sfc_vdpa_log.h | 7 ++-
Remove _RAW macros and directly call RTE_LOG() where needed in headers
providing wrappers for base drivers code.
This will help later when adding a check on RTE_LOG() use in drivers/.
Signed-off-by: David Marchand
---
drivers/common/iavf/iavf_osdep.h | 8
drivers/common/idpf/base/
BP_LOG() is only used in the base driver.
Signed-off-by: David Marchand
Acked-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_osdep.h | 8
drivers/net/txgbe/txgbe_logs.h | 7 ---
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/net/txgbe/base/txgbe_osdep.
DLB2_(HW_)?(INFO|ERR|DEBUG) are defined in osdep.h for base/ driver code
to log messages.
The base/ driver should not bypass those macros, directly calling
DLB2_LOG_(INFO|ERR|DEBUG).
Besides, DLB2_LOG_* macros always append a \n, meaning that most of the
logs coming from the base/ driver code have
Register a logtype for this driver and stop logging as EVENTDEV.
Signed-off-by: David Marchand
---
drivers/event/dsw/dsw_evdev.c | 1 +
drivers/event/dsw/dsw_evdev.h | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_ev
In the next commit, a (unrelated) change will be done on the logging
macros in this driver.
After this change, compilation with O3 fails with the following warning:
../drivers/net/octeon_ep/otx_ep_ethdev.c: In function
‘otx_ep_dev_mtu_set’:
../drivers/net/octeon_ep/otx_ep_ethdev.c:200:12:
Prepare for RTE_LOG_LINE conversion.
Signed-off-by: David Marchand
---
Changes since v1:
- added changes to event/dlb2 and net/bonding,
---
.../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 251 +-
drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 24 +-
drivers/crypto/caam_jr/caam
On 9/11/2024 8:32 PM, Maxime Coquelin wrote:
> This series enables importing Linux Kernel uAPI headers
> into the DPDK repository. It aims at solving alignment
> issues between the build system and the system applications
> linked ot DPDK libraries are run on.
>
Hi Maxime,
Is the imported Linux
On 2024/9/12 14:54, Chaoyong He wrote:
> From: James Hershaw
>
> Add command to change the state of a controllable LED on an ethdev port
> to on/off. This is for the purpose of identifying which physical port is
> associated with an ethdev.
>
> usage:
> testpmd> set port led
>
> Signed-off-
Release status meeting minutes 2024-09-12
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* AMD
* ARM
* Intel
* Marvell
* Nvidia
* Red Hat
Release Dates
-
The following are the current/updated working dat
Introduce DPDK per-lcore id variables, or lcore variables for short.
An lcore variable has one value for every current and future lcore
id-equipped thread.
The primary use case is for statically allocating
small, frequently-accessed data structures, for which one instance
should exist for each l
Keep per-lcore power intrinsics state in a lcore variable to reduce
cache working set size and avoid any CPU next-line-prefetching causing
false sharing.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
---
lib/eal/x86/rte_power_intrinsics.c | 17 +++--
1 file changed, 11 ins
Replace keeping PRNG state in a RTE_MAX_LCORE-sized static array of
cache-aligned and RTE_CACHE_GUARDed struct instances with keeping the
same state in a more cache-friendly lcore variable.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v3:
* Remove cache alignment on unregist
Add basic micro benchmark for lcore variables, in an attempt to assure
that the overhead isn't significantly greater than alternative
approaches, in scenarios where the benefits aren't expected to show up
(i.e., when plenty of cache is available compared to the working set
size of the per-lcore dat
Replace static array of cache-aligned structs with an lcore variable,
to slightly benefit code simplicity and performance.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v3:
* Replace for loop with FOREACH macro.
---
lib/power/rte_power_pmd_mgmt.c | 34 ---
Replace static array of cache-aligned structs with an lcore variable,
to slightly benefit code simplicity and performance.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v6:
* Remove a now-redundant lcore variable value memset().
RFC v5:
* Fix lcore value pointer bug introdu
Add functional test suite to exercise the API.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v5:
* Adapt tests to reflect the removal of the GET() and SET() macros.
RFC v4:
* Check all lcore id's values for all variables in the many variables
test case.
* Introduce tes
This patch set introduces a new API for static
per-lcore id data allocation.
Please refer to the API documentation for both a
rationale for this new API, and a comparison to the alternatives
available.
The adoption of this API would affect many different DPDK modules, but
the author updated onl
On 2024-09-12 09:35, Jerin Jacob wrote:
On Wed, Sep 11, 2024 at 11:08 PM Mattias Rönnblom
wrote:
Add test suite to exercise the API.
Signed-off-by: Mattias Rönnblom
Acked-by: Morten Brørup
--
RFC v5:
* Adapt tests to reflect the removal of the GET() and SET() macros.
RFC v4:
* Check
On 2024/9/12 14:54, Chaoyong He wrote:
> From: James Hershaw
>
> There is currently no means to test the .set_eeprom function callback of
> a given PMD in drivers/net/. This patch adds functionality to allow a
> user to set device eeprom from the testpmd cmdline.
>
> usage:
> testpmd> set port
> +#define LCORE_BUFFER_SIZE (RTE_MAX_LCORE_VAR * RTE_MAX_LCORE)
Considering hugepages...
Lcore variables may be allocated before DPDK's memory allocator (rte_malloc())
is ready, so rte_malloc() cannot be used for lcore variables.
And lcore variables are not usable (shared) for DPDK multi-proce
On Thu, Sep 12, 2024 at 02:19:07AM +, Varghese, Vipin wrote:
>[Public]
>
>
>
>
>
>> > > >
>
>> > > >
>
>> > > >>>
>
>> > > >>>
>
>> > > >>> Thank you Mattias for the comments and question, please let
>me
>
>> > > >>> try to explain the same below
>
> From: Mattias Rönnblom
> Sent: Monday, September 9, 2024 8:11 PM
> To: dev@dpdk.org
> Cc: hof...@lysator.liu.se ; Van Haaren, Harry
> ; Stefan Sundkvist
> ; Mattias Rönnblom
>
> Subject: [PATCH v2] service: extend service function call statistics
>
> Add two new per-service counters.
>
> RT
On 2024/9/12 16:19, WanRenyong wrote:
> On 2024/9/12 13:50, Stephen Hemminger wrote:
>> On Thu, 12 Sep 2024 12:14:08 +0800
>> "WanRenyong" wrote:
>>
> +};
> +
Does this device driver depend on some upstr
>>> Yes, it depends on linux kernel driver of the device.
>>>
>>> Hello,
> +struct lcore_state {
> + uint64_t a;
> + uint64_t b;
> + uint64_t sum;
> +};
> +
> +static __rte_always_inline void
> +update(struct lcore_state *state)
> +{
> + state->sum += state->a * state->b;
> +}
> +
> +static RTE_DEFINE_PER_LCORE(struct lcore_state, tls_lcore_state);
> +
>
[AMD Official Use Only - AMD Internal Distribution Only]
> Thank you Mattias for the information, as shared by in the reply
> with
> >> Anatoly we want expose a new API `rte_get_next_lcore_ex` which
> >> intakes a extra argument `u32 flags`.
> The flags can be RTE_GET_LCORE_L1 (S
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Huisong,
Please find my response inline.
> -Original Message-
> From: lihuisong (C)
> Sent: Tuesday, August 27, 2024 1:51 PM
> To: Tummala, Sivaprasad
> Cc: dev@dpdk.org; david.h...@intel.com; anatoly.bura...@intel.com;
> radu
[Public]
Snipped
>
>
> To to be clear; it's something like this I think of when I say "DOM-style"
> API.
>
> #ifndef RTE_HWTOPO_H
> #define RTE_HWTOPO_H
>
> struct rte_hwtopo_node;
>
> enum rte_hwtopo_node_type {
> RTE_HWTOPO_NODE_TYPE_CPU_CORE,
> RTE_HWTOPO_NODE_TYPE_CACHE,
> RT
[Public]
Snipped
> >
> >
> >Based on the discussions we agreed on sharing version-2 FRC for
> >extending API as `rte_get_next_lcore_extnd` with extra argument as
> >`flags`.
> >
> >As per my ideation, for the API ` rte_get_next_sibling_core`, the above
> >API can easily with f
On 2024-09-12 13:17, Varghese, Vipin wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
Thank you Mattias for the information, as shared by in the reply
with
>> Anatoly we want expose a new API `rte_get_next_lcore_ex` which
>> intakes a extra argument `u32 flags`.
T
Hi Ferruh,
On 9/12/24 10:30, Ferruh Yigit wrote:
On 9/11/2024 8:32 PM, Maxime Coquelin wrote:
This series enables importing Linux Kernel uAPI headers
into the DPDK repository. It aims at solving alignment
issues between the build system and the system applications
linked ot DPDK libraries are r
https://bugs.dpdk.org/show_bug.cgi?id=1540
Bug ID: 1540
Summary: update pw_maintainers_cli.py to apply some series to
next-dts
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNC
On 2024-09-12 13:23, Varghese, Vipin wrote:
[Public]
Snipped
To to be clear; it's something like this I think of when I say "DOM-style" API.
#ifndef RTE_HWTOPO_H
#define RTE_HWTOPO_H
struct rte_hwtopo_node;
enum rte_hwtopo_node_type {
RTE_HWTOPO_NODE_TYPE_CPU_CORE,
RTE_HWTOPO_N
This looks good, except for the fact that a method for sending a list
of packets has been added since you submitted this patch (which does
return the packet list, not that it matters for your application).
So, this will need to be resubmitted with your patch reformatted for
_adjust_addresses() to
Looks good to me, and I don't understand it as triggering a second
compile on the TG node.
I wonder whether the docstring for set_up_build_target() makes it
sound like it does though?
Reviewed-by: Patrick Robb
On 2024-09-12 11:39, Morten Brørup wrote:
+struct lcore_state {
+ uint64_t a;
+ uint64_t b;
+ uint64_t sum;
+};
+
+static __rte_always_inline void
+update(struct lcore_state *state)
+{
+ state->sum += state->a * state->b;
+}
+
+static RTE_DEFINE_PER_LCORE(struct lcore_stat
On Thu, Sep 12, 2024 at 2:34 PM Mattias Rönnblom
wrote:
>
> Add basic micro benchmark for lcore variables, in an attempt to assure
> that the overhead isn't significantly greater than alternative
> approaches, in scenarios where the benefits aren't expected to show up
> (i.e., when plenty of cache
On 9/12/2024 1:08 PM, Maxime Coquelin wrote:
> Hi Ferruh,
>
> On 9/12/24 10:30, Ferruh Yigit wrote:
>> On 9/11/2024 8:32 PM, Maxime Coquelin wrote:
>>> This series enables importing Linux Kernel uAPI headers
>>> into the DPDK repository. It aims at solving alignment
>>> issues between the build sy
On Thu, Sep 12, 2024 at 2:40 PM Morten Brørup
wrote:
>
> > +#define LCORE_BUFFER_SIZE (RTE_MAX_LCORE_VAR * RTE_MAX_LCORE)
>
> Considering hugepages...
>
> Lcore variables may be allocated before DPDK's memory allocator
> (rte_malloc()) is ready, so rte_malloc() cannot be used for lcore variables
I like the separation. I can include it in V4 and see, it would be helpful to
know if it’s more or less confusing that way.
For the prompt before each list, can we say something like “Avoid doing the
following” and “Suggested actions” or something a little better grammatically.
We could also ju
On 2024-09-12 11:17, Bruce Richardson wrote:
On Thu, Sep 12, 2024 at 02:19:07AM +, Varghese, Vipin wrote:
[Public]
> > > >
> > > >
> > > >>>
> > > >>>
> > > >>> Thank you Mattias for the comments and question, please let
me
> > > >>> try to exp
On 2024-09-12 15:09, Jerin Jacob wrote:
On Thu, Sep 12, 2024 at 2:34 PM Mattias Rönnblom
wrote:
Add basic micro benchmark for lcore variables, in an attempt to assure
that the overhead isn't significantly greater than alternative
approaches, in scenarios where the benefits aren't expected to s
https://bugs.dpdk.org/show_bug.cgi?id=1541
Bug ID: 1541
Summary: Add support for VM SR-IOV testing
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Pr
On Thu, Sep 12, 2024 at 01:59:34PM +0200, Mattias Rönnblom wrote:
> On 2024-09-12 13:17, Varghese, Vipin wrote:
> > [AMD Official Use Only - AMD Internal Distribution Only]
> >
> >
> > > Thank you Mattias for the information, as shared by in the reply
> > > with
> > > >> Anatoly we want
On 9/12/2024 2:18 PM, Nandini Persad wrote:
> I like the separation. I can include it in V4 and see, it would be
> helpful to know if it’s more or less confusing that way.
>
> For the prompt before each list, can we say something like “Avoid doing
> the following” and “Suggested actions” or somet
Excellent. Will send the update in accordingly.
From: Ferruh Yigit
Sent: Thursday, September 12, 2024 6:37:35 AM
To: Nandini Persad
Cc: dev@dpdk.org ; Thomas Mojalon ; Stephen
Hemminger
Subject: Re: [PATCH v3] doc: add new driver guidelines
On 9/12/2024 2:18 PM
> From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> Sent: Thursday, 12 September 2024 15.17
>
> On Thu, Sep 12, 2024 at 2:40 PM Morten Brørup
> wrote:
> >
> > > +#define LCORE_BUFFER_SIZE (RTE_MAX_LCORE_VAR * RTE_MAX_LCORE)
> >
> > Considering hugepages...
> >
> > Lcore variables may be allocate
On 9/12/24 15:16, Ferruh Yigit wrote:
On 9/12/2024 1:08 PM, Maxime Coquelin wrote:
Hi Ferruh,
On 9/12/24 10:30, Ferruh Yigit wrote:
On 9/11/2024 8:32 PM, Maxime Coquelin wrote:
This series enables importing Linux Kernel uAPI headers
into the DPDK repository. It aims at solving alignment
is
12/09/2024 10:26, David Marchand:
> --- a/devtools/check-forbidden-tokens.awk
> +++ b/devtools/check-forbidden-tokens.awk
> @@ -32,14 +32,11 @@ BEGIN {
> for (i in deny_expr) {
> forbidden_added = "^\\+.*" deny_expr[i];
> forbidden_removed="
12/09/2024 10:26, David Marchand:
> Do not stop at the first file that got warnings.
>
> Signed-off-by: David Marchand
It is always better to get all issues in one pass.
Acked-by: Thomas Monjalon
> -Original Message-
> From: Ferruh Yigit
> Sent: Thursday, September 12, 2024 11:20 AM
> To: Tyler Retzlaff ; Stephen Hemminger
> ; Brandes, Shai
> Cc: dev@dpdk.org; Schmeilin, Evgeny ; Beider, Ron
> ; Bernstein, Amit ;
> Atrash, Wajeeh ; Chauskin, Igor
> ; Michal Krawczyk ; Artur Roje
On Thu, Sep 12, 2024 at 6:50 PM Mattias Rönnblom wrote:
>
> On 2024-09-12 15:09, Jerin Jacob wrote:
> > On Thu, Sep 12, 2024 at 2:34 PM Mattias Rönnblom
> > wrote:
> >>
> >> Add basic micro benchmark for lcore variables, in an attempt to assure
> >> that the overhead isn't significantly greater t
On Thu, Sep 12, 2024 at 7:11 PM Morten Brørup
wrote:
>
> > From: Jerin Jacob [mailto:jerinjac...@gmail.com]
> > Sent: Thursday, 12 September 2024 15.17
> >
> > On Thu, Sep 12, 2024 at 2:40 PM Morten Brørup
> > wrote:
> > >
> > > > +#define LCORE_BUFFER_SIZE (RTE_MAX_LCORE_VAR * RTE_MAX_LCORE)
>
On Thu, 12 Sep 2024 14:12:55 +0200
Mattias Rönnblom wrote:
> On 2024-09-12 13:23, Varghese, Vipin wrote:
> > [Public]
> >
> > Snipped
> >>
> >>
> >> To to be clear; it's something like this I think of when I say "DOM-style"
> >> API.
> >>
> >> #ifndef RTE_HWTOPO_H
> >> #define RTE_HWTOPO_H
On Mon, Sep 02, 2024 at 10:54:12AM +0100, Anatoly Burakov wrote:
> Update the i40e base driver to the latest version of the snapshot.
>
Series-acked-by: Bruce Richardson
On apply I tagged a few more patches as bugfixes (including fixes line) for
backport to the older LTS releases.
Applied to dp
On 2024-09-12 15:30, Bruce Richardson wrote:
On Thu, Sep 12, 2024 at 01:59:34PM +0200, Mattias Rönnblom wrote:
On 2024-09-12 13:17, Varghese, Vipin wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
Thank you Mattias for the information, as shared by in the reply
with
Anatoly w
> >
> > For instance, in Neoverse N1 can disable the use of SLC as LLC (a BIOS
> > setting) If SLC is not used as LLC, then your script would report the
> > unified L2
> as an LLC.
>
> Does `disabling SLC as LLC` disable L3? I think not, and what you are
> implying is
> the ` ls -d /sys/bus/cpu
v5:
* Addressed some concerns on docstrings based on previous reviews.
Nicholas Pratte (2):
dts: add methods for setting mac and multicast addresses
dts: mac filter test suite refactored for new dts
dts/framework/config/conf_yaml_schema.json| 3 +-
dts/framework/remote_session/testpm
New methods have been added to TestPMDShell in order to produce the mac
filter's individual test cases:
- set_mac_addr
- set_multicast_mac_addr
set_mac_addr and set_multicast_addr were created for the mac filter test
suite, enabling users to both add or remove mac and multicast
addresses based o
The mac address filter test suite, whose test cases are based on old
DTS's test cases, has been refactored to interface with the new DTS
framework.
In porting over this test suite into the new framework, some
adjustments were made, namely in the EAL and TestPMD parameter provided
before executing
21/08/2024 17:02, Juraj Linkeš:
> +if 'dts' in src:
> +os.environ['DTS_BUILD'] = "y"
That's more precisely "DTS doc build".
I think the variable name DTS_BUILD may be confusing.
[...]
> --- /dev/null
> +++ b/buildtools/get-dts-runtime-deps.py
> @@ -0,0 +1,95 @@
> +#!/usr/bin/env python3
> +#
From: Nandini Persad
This document was created to assist contributors in creating DPDK drivers
and provides suggestions and guidelines on how to upstream effectively.
Co-authored-by: Ferruh Yigit
Co-authored-by: Thomas Monjalon
Signed-off-by: Nandini Persad
Reviewed-by: Stephen Hemminger
---
On Tue, Sep 10, 2024 at 7:30 AM Juraj Linkeš wrote:
>
> The subject line should be all lowercase (except for abbreviations and
> maybe some other exceptions).
Ack.
>
> On 5. 7. 2024 19:13, Nicholas Pratte wrote:
> > Remove the list of devices from the schema, as these are unuesed.
>
> Typo: unus
> > @classmethod
> > def from_dict(cls, d: BuildTargetConfigDict) -> Self:
> > r"""A convenience method that processes the inputs before creating
> > an instance.
> >
> > -`arch`, `os`, `cpu` and `compiler` are converted to
> > :class:`Enum`\s and
> > -`name` i
#
September 12, 2024
Attendees
* Patrick Robb
* Paul Szczepanek
* Alex Chapman
* Luca Vizzarro
* Jeremey Spewock
* Juraj Linkeš
#
Minutes
===
On 2024/9/12 17:18, fengchengwen wrote:
> On 2024/9/12 16:19, WanRenyong wrote:
>> On 2024/9/12 13:50, Stephen Hemminger wrote:
>>> On Thu, 12 Sep 2024 12:14:08 +0800
>>> "WanRenyong" wrote:
>>>
>
>> +};
>> +
> Does this device driver depend on some upstr
Yes, it depends o
On 2024/9/13 4:26, Stephen Hemminger wrote
> +
> +Finalizing
> +--
> +
> +Once the driver has been upstreamed, the author has
> +a responsibility to the community to maintain it.
> +
> +This includes the public test report. Authors must send a public
> +test report after the first upstreami
From: Vanshika Shukla
This series includes:
-> Fixes and enhancements for NXP DPAA2 drivers.
-> Upgrade with MC version 10.37
-> Enhancements in DPDMUX code
-> Fixes for coverity issues reported
Apeksha Gupta (2):
net/dpaa2: add proper MTU debugging print
net/dpaa2: store drop priority in mb
From: Jun Yang
Create TX SG pool only for primary process and lookup
this pool in secondary process.
Signed-off-by: Jun Yang
---
drivers/net/dpaa2/dpaa2_ethdev.c | 46 +++-
1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/drivers/net/dpaa2/dpaa2_ethde
From: Hemant Agrawal
This patch marks dpcon_close API as internal symbol and
also adds it into version map file
Signed-off-by: Hemant Agrawal
---
drivers/bus/fslmc/mc/fsl_dpcon.h | 3 ++-
drivers/bus/fslmc/version.map| 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/driv
From: Apeksha Gupta
This patch add proper debug info for check information of
max-pkt-len and configured params.
also store MTU
Signed-off-by: Apeksha Gupta
Signed-off-by: Jun Yang
---
drivers/net/dpaa2/dpaa2_ethdev.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/d
From: Vanshika Shukla
This patch adds PTP one-step timestamping support.
dpni_set_single_step_cfg() MC API is utilized with offset provided
to insert correction time on frame.
Signed-off-by: Vanshika Shukla
---
drivers/net/dpaa2/dpaa2_ethdev.c | 61 +++
drivers/net
From: Hemant Agrawal
This patch add supports to dump dpdmux counters as they are required
to identify the reasons for packet drop in dpdmux.
Signed-off-by: Hemant Agrawal
Signed-off-by: Rohit Raj
---
drivers/net/dpaa2/dpaa2_mux.c | 84 +++
drivers/net/dpaa2/rte
From: Rohit Raj
Add rte_fslmc_close API to close all the DPAA2 devices while
closing the DPDK application.
Signed-off-by: Rohit Raj
---
drivers/bus/fslmc/bus_fslmc_driver.h | 3 +
drivers/bus/fslmc/fslmc_bus.c| 13
drivers/bus/fslmc/fslmc_vfio.c | 87 +++
From: Vanshika Shukla
This patch adds the support for DPDMUX_METHOD_C_VLAN_MAC method
which implements DPDMUX based on C-VLAN and MAC address.
Signed-off-by: Vanshika Shukla
---
drivers/net/dpaa2/dpaa2_mux.c | 59 +--
drivers/net/dpaa2/mc/fsl_dpdmux.h | 18 +
From: Rohit Raj
This patch add support to update the duplex value along with
link status and link speed after setting the link UP.
Signed-off-by: Rohit Raj
---
drivers/net/dpaa2/dpaa2_ethdev.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/net/dpaa
From: Brick Yang
If SFP module is not connected to the port and flow control is
configured using flow control API, link will show DOWN even after
connecting the SFP module and fiber cable.
This issue cannot be reproduced if only SFP module is connected and
fiber cable is disconnected before conf
From: Jun Yang
This patch add support to check the DPAA platform type from
the applications.
Signed-off-by: Jun Yang
---
drivers/net/dpaa2/dpaa2_ethdev.c | 16 +---
drivers/net/dpaa2/dpaa2_flow.c| 5 ++---
drivers/net/dpaa2/rte_pmd_dpaa2.h | 4
drivers/net/dpaa2/version
From: Gagandeep Singh
This patch upgrades the MC version compaitbility to 10.37
Signed-off-by: Gagandeep Singh
Signed-off-by: Apeksha Gupta
---
doc/guides/platform/dpaa2.rst | 4 +-
drivers/bus/fslmc/mc/dpio.c | 94 -
drivers/bus/fslmc/mc/fsl_dpcon.h
From: Jun Yang
Ignore reserved bits of BMan acquire response number.
Signed-off-by: Jun Yang
---
drivers/bus/fslmc/qbman/qbman_portal.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c
b/drivers/bus/fslmc/q
From: Jun Yang
Get vfio group fd directly from file system instead of
from RTE API to avoid conflicting with PCIe VFIO.
FSL MC VFIO should have it's own logic which doe NOT depend on
RTE VFIO.
Signed-off-by: Jun Yang
---
drivers/bus/fslmc/fslmc_vfio.c | 88 ++
d
From: Rohit Raj
Free vfio_group_fd if add group fails to avoid ersource leak
NXP coverity-id: 26661846
Signed-off-by: Rohit Raj
---
drivers/bus/fslmc/fslmc_vfio.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_v
From: Jun Yang
MC VFIO is not registered into RTE VFIO. Primary process registers
MC vfio mp action for secondary process to request.
VFIO/Container handlers are provided via CMSG.
Primary process is responsible to connect MC VFIO group to container.
In addition, MC VFIO code is refactored accor
From: Jun Yang
Remove unused GITS translator VFIO mapping.
Signed-off-by: Jun Yang
---
drivers/bus/fslmc/fslmc_vfio.c | 50 --
1 file changed, 50 deletions(-)
diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c
index 31011b8532..f5d398c
From: Jun Yang
IOVA mode should not be configured with CFLAGS because
1) User can perform "--iova-mode" to configure IOVA.
2) IOVA mode is determined by negotiation between multiple devices.
Eal is in VA mode only when all devices support VA mode.
Hence:
1) Remove RTE_LIBRTE_DPAA2_USE_PHYS_IO
From: Jun Yang
Create dpaa2 device with object instead of object ID.
Assign each dpaa2 object with it's container.
Signed-off-by: Jun Yang
---
drivers/bus/fslmc/bus_fslmc_driver.h | 39
drivers/bus/fslmc/fslmc_vfio.c | 3 +-
drivers/bus/fslmc/portal/dpaa
1 - 100 of 127 matches
Mail list logo
