RE: [PATCH 1/4] ethdev: make parameters to TM node add fn constant

2024-08-07 Thread Xu, Rosen
Hi, > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, August 6, 2024 11:24 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Nithin Dabilpuram > ; Kiran Kumar K ; > Sunil Kumar Kori ; Satha Rao > ; Harman Kalra ; Hemant > Agrawal ; Sachin Saxena > ; Jie Hai ; Yisen Zhuang > ;

RE: [PATCH 2/4] ethdev: make parameters to TM profile add fn constant

2024-08-07 Thread Xu, Rosen
Hi, > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, August 6, 2024 11:24 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Xu, Rosen > ; Dumitrescu, Cristian > ; Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko > Subject: [PATCH 2/4] ethdev: make parameters to TM profi

RE: [PATCH 3/4] ethdev: make TM shaper parameters constant

2024-08-07 Thread Xu, Rosen
Hi, > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, August 6, 2024 11:24 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Nithin Dabilpuram > ; Kiran Kumar K ; > Sunil Kumar Kori ; Satha Rao > ; Harman Kalra ; Hemant > Agrawal ; Sachin Saxena > ; Jie Hai ; Yisen Zhuang > ;

Re: [PATCH v5] net/gve : Update EOP & csum bit in txd rte_mbuf chain

2024-08-07 Thread Ferruh Yigit
On 8/6/2024 3:44 PM, Tathagat Priyadarshi wrote: > hi Ferruh, > > Could you please accept the updated patch?! let us know what's pending. > > https://patches.dpdk.org/project/dpdk/patch/1722575288-2408630-1-git- > send-email-tathagat.d...@gmail.com/ > > TIA > Hi Tathagat, It is not waiting an

[DPDK/DTS Bug 1353] Add parallel functional testing support

2024-08-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1353 Juraj Linkeš (juraj.lin...@pantheon.tech) changed: What|Removed |Added Resolution|--- |WONTFIX S

[PATCH 00/15] Improve rte_tm support in ICE driver

2024-08-07 Thread Bruce Richardson
This patchset expands the capabilities of the traffic management support in the ICE driver. It allows the driver to support different sizes of topologies, and support >256 queues and more than 3 hierarchy layers. Bruce Richardson (15): net/ice: add traffic management node query function net/ic

[PATCH 01/15] net/ice: add traffic management node query function

2024-08-07 Thread Bruce Richardson
Implement the new node querying function for the "ice" net driver. Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_tm.c | 48 1 file changed, 48 insertions(+) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 8a29a9e744..4594

[PATCH 02/15] net/ice: detect stopping a flow-director queue twice

2024-08-07 Thread Bruce Richardson
If the flow-director queue is stopped at some point during the running of an application, the shutdown procedure for the port issues an error as it tries to stop the queue a second time, and fails to do so. We can eliminate this error by setting the tail-register pointer to NULL on stop, and checki

[PATCH 03/15] net/ice: improve Tx scheduler graph output

2024-08-07 Thread Bruce Richardson
The function to dump the TX scheduler topology only adds to the chart nodes connected to TX queues or for the flow director VSI. Change the function to work recursively from the root node and thereby include all scheduler nodes, whether in use or not, in the dump. Also, improve the output of the T

[PATCH 04/15] net/ice: add option to choose DDP package file

2024-08-07 Thread Bruce Richardson
The "Dynamic Device Personalization" package is loaded at initialization time by the driver, but the specific package file loaded depends upon what package file is found first by searching through a hard-coded list of firmware paths. To enable greater control over the package loading, we can add a

[PATCH 05/15] net/ice: add option to download scheduler topology

2024-08-07 Thread Bruce Richardson
The DDP package file being loaded at init time may contain an alternative Tx Scheduler topology in it. Add driver option to load this topology at init time. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_ddp.c | 18 +++--- drivers/net/ice/base/ice_ddp.h | 4 ++-- drive

[PATCH 06/15] net/ice/base: allow init without TC class sched nodes

2024-08-07 Thread Bruce Richardson
If DCB support is disabled via DDP image, there will not be any traffic class (TC) nodes in the scheduler tree immediately above the root level. To allow the driver to work with this scenario, we allow use of the root node as a dummy TC0 node in case where there are no TC nodes in the tree. For use

[PATCH 07/15] net/ice/base: set VSI index on newly created nodes

2024-08-07 Thread Bruce Richardson
The ice_sched_node type has got a field for the vsi to which the node belongs. This field was not getting set in "ice_sched_add_node", so add a line configuring this field for each node from its parent node. Similarly, when searching for a qgroup node, we can check for each node that the VSI inform

[PATCH 08/15] net/ice/base: read VSI layer info from VSI

2024-08-07 Thread Bruce Richardson
Rather than computing from the number of HW layers the layer of the VSI, we can instead just read that info from the VSI node itself. This allows the layer to be changed at runtime. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 09/15] net/ice/base: remove 255 limit on sched child nodes

2024-08-07 Thread Bruce Richardson
The Tx scheduler in the ice driver can be configured to have large numbers of child nodes at a given layer, but the driver code implicitly limited the number of nodes to 255 by using a u8 datatype for the number of children. Increase this to a 16-bit value throughout the code. Signed-off-by: Bruce

[PATCH 10/15] net/ice/base: optimize subtree searches

2024-08-07 Thread Bruce Richardson
In a number of places throughout the driver code, we want to confirm that a scheduler node is indeed a child of another node. Currently, this is confirmed by searching down the tree from the base until the desired node is hit, a search which may hit many irrelevant tree nodes when recursing down wr

[PATCH 11/15] net/ice/base: make functions non-static

2024-08-07 Thread Bruce Richardson
We will need to allocate more lanq contexts after a scheduler rework, so make that function non-static so accessible outside the file. For similar reasons, make the function to add a Tx scheduler node non-static Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_sched.c | 2 +- drivers

[PATCH 12/15] net/ice/base: remove flag checks before topology upload

2024-08-07 Thread Bruce Richardson
DPDK should support more than just 9-level or 5-level topologies, so remove the checks for those particular settings. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_ddp.c | 33 - 1 file changed, 33 deletions(-) diff --git a/drivers/net/ice/base/ice_

[PATCH 13/15] net/ice: limit the number of queues to sched capabilities

2024-08-07 Thread Bruce Richardson
Rather than assuming that each VSI can hold up to 256 queue pairs, or the reported device limit, query the available nodes in the scheduler tree to check that we are not overflowing the limit for number of child scheduling nodes at each level. Do this by multiplying max_children for each level beyo

[PATCH 14/15] net/ice: enhance Tx scheduler hierarchy support

2024-08-07 Thread Bruce Richardson
Increase the flexibility of the Tx scheduler hierarchy support in the driver. If the HW/firmware allows it, allow creating up to 2k child nodes per scheduler node. Also expand the number of supported layers to the max available, rather than always just having 3 layers. One restriction on this chan

[PATCH 15/15] net/ice: add minimal capability reporting API

2024-08-07 Thread Bruce Richardson
Incomplete but reports number of available layers Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_ethdev.h | 1 + drivers/net/ice/ice_tm.c | 17 + 2 files changed, 18 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h index cb1a7e

Re: [PATCH v5] net/gve : Update EOP & csum bit in txd rte_mbuf chain

2024-08-07 Thread Ferruh Yigit
On 8/2/2024 6:08 AM, Tathagat Priyadarshi wrote: > The EOP and csum bit was not set for all the packets in mbuf chain > causing packet transmission stalls for packets split across > mbuf in chain. > > Fixes: 4022f99 ("net/gve: support basic Tx data path for DQO") > Cc: sta...@dpdk.org > > Signed-

Re: [PATCH] net/gve: Add support for TSO in DQO RDA

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:33 AM, Tathagat Priyadarshi wrote: > The following patch depends on > https://patches.dpdk.org/project/dpdk/patch/1722443901-2400194-1-git- > send-email-tathagat.d...@gmail.com/ > Will retrigger git patch checks post its approved and upstreamed. To > avoid conflicts. > Hi Tathagat,

[PATCH v2 00/15] Improve rte_tm support in ICE driver

2024-08-07 Thread Bruce Richardson
This patchset expands the capabilities of the traffic management support in the ICE driver. It allows the driver to support different sizes of topologies, and support >256 queues and more than 3 hierarchy layers. --- Depends-on: series-32719 ("improve rte_rm APIs") v2: * Correct typo in commit lo

[PATCH v2 01/15] net/ice: add traffic management node query function

2024-08-07 Thread Bruce Richardson
Implement the new node querying function for the "ice" net driver. Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_tm.c | 48 1 file changed, 48 insertions(+) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 8a29a9e744..4594

[PATCH v2 02/15] net/ice: detect stopping a flow-director queue twice

2024-08-07 Thread Bruce Richardson
If the flow-director queue is stopped at some point during the running of an application, the shutdown procedure for the port issues an error as it tries to stop the queue a second time, and fails to do so. We can eliminate this error by setting the tail-register pointer to NULL on stop, and checki

[PATCH v2 03/15] net/ice: improve Tx scheduler graph output

2024-08-07 Thread Bruce Richardson
The function to dump the TX scheduler topology only adds to the chart nodes connected to TX queues or for the flow director VSI. Change the function to work recursively from the root node and thereby include all scheduler nodes, whether in use or not, in the dump. Also, improve the output of the T

[PATCH v2 04/15] net/ice: add option to choose DDP package file

2024-08-07 Thread Bruce Richardson
The "Dynamic Device Personalization" package is loaded at initialization time by the driver, but the specific package file loaded depends upon what package file is found first by searching through a hard-coded list of firmware paths. To enable greater control over the package loading, we can add a

[PATCH v2 05/15] net/ice: add option to download scheduler topology

2024-08-07 Thread Bruce Richardson
The DDP package file being loaded at init time may contain an alternative Tx Scheduler topology in it. Add driver option to load this topology at init time. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_ddp.c | 18 +++--- drivers/net/ice/base/ice_ddp.h | 4 ++-- drive

[PATCH v2 06/15] net/ice/base: allow init without TC class sched nodes

2024-08-07 Thread Bruce Richardson
If DCB support is disabled via DDP image, there will not be any traffic class (TC) nodes in the scheduler tree immediately above the root level. To allow the driver to work with this scenario, we allow use of the root node as a dummy TC0 node in case where there are no TC nodes in the tree. For use

[PATCH v2 07/15] net/ice/base: set VSI index on newly created nodes

2024-08-07 Thread Bruce Richardson
The ice_sched_node type has got a field for the vsi to which the node belongs. This field was not getting set in "ice_sched_add_node", so add a line configuring this field for each node from its parent node. Similarly, when searching for a qgroup node, we can check for each node that the VSI inform

[PATCH v2 08/15] net/ice/base: read VSI layer info from VSI

2024-08-07 Thread Bruce Richardson
Rather than computing from the number of HW layers the layer of the VSI, we can instead just read that info from the VSI node itself. This allows the layer to be changed at runtime. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v2 09/15] net/ice/base: remove 255 limit on sched child nodes

2024-08-07 Thread Bruce Richardson
The Tx scheduler in the ice driver can be configured to have large numbers of child nodes at a given layer, but the driver code implicitly limited the number of nodes to 255 by using a u8 datatype for the number of children. Increase this to a 16-bit value throughout the code. Signed-off-by: Bruce

[PATCH v2 10/15] net/ice/base: optimize subtree searches

2024-08-07 Thread Bruce Richardson
In a number of places throughout the driver code, we want to confirm that a scheduler node is indeed a child of another node. Currently, this is confirmed by searching down the tree from the base until the desired node is hit, a search which may hit many irrelevant tree nodes when recursing down wr

[PATCH v2 11/15] net/ice/base: make functions non-static

2024-08-07 Thread Bruce Richardson
We will need to allocate more lanq contexts after a scheduler rework, so make that function non-static so accessible outside the file. For similar reasons, make the function to add a Tx scheduler node non-static Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_sched.c | 2 +- drivers

[PATCH v2 12/15] net/ice/base: remove flag checks before topology upload

2024-08-07 Thread Bruce Richardson
DPDK should support more than just 9-level or 5-level topologies, so remove the checks for those particular settings. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_ddp.c | 33 - 1 file changed, 33 deletions(-) diff --git a/drivers/net/ice/base/ice_

[PATCH v2 13/15] net/ice: limit the number of queues to sched capabilities

2024-08-07 Thread Bruce Richardson
Rather than assuming that each VSI can hold up to 256 queue pairs, or the reported device limit, query the available nodes in the scheduler tree to check that we are not overflowing the limit for number of child scheduling nodes at each level. Do this by multiplying max_children for each level beyo

[PATCH v2 14/15] net/ice: enhance Tx scheduler hierarchy support

2024-08-07 Thread Bruce Richardson
Increase the flexibility of the Tx scheduler hierarchy support in the driver. If the HW/firmware allows it, allow creating up to 2k child nodes per scheduler node. Also expand the number of supported layers to the max available, rather than always just having 3 layers. One restriction on this chan

[PATCH v2 15/15] net/ice: add minimal capability reporting API

2024-08-07 Thread Bruce Richardson
Incomplete but reports number of available layers Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_ethdev.h | 1 + drivers/net/ice/ice_tm.c | 17 + 2 files changed, 18 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h index cb1a7e

Re: [PATCH v15 5/5] dts: add API doc generation

2024-08-07 Thread Thomas Monjalon
06/08/2024 17:19, Juraj Linkeš: > +"""Utilities for DTS dependencies. > + > +The module can be used as an executable script, > +which verifies that the running Python version meets the version requirement > of DTS. > +The script returns the standard exit codes in this mode (0 is success, 1 is > f

Re: [PATCH v15 5/5] dts: add API doc generation

2024-08-07 Thread Juraj Linkeš
On 7. 8. 2024 12:41, Thomas Monjalon wrote: 06/08/2024 17:19, Juraj Linkeš: +"""Utilities for DTS dependencies. + +The module can be used as an executable script, +which verifies that the running Python version meets the version requirement of DTS. +The script returns the standard exit codes

Re: [PATCH v15 5/5] dts: add API doc generation

2024-08-07 Thread Thomas Monjalon
07/08/2024 14:03, Juraj Linkeš: > On 7. 8. 2024 12:41, Thomas Monjalon wrote: > > 06/08/2024 17:19, Juraj Linkeš: > > [...] > >> +get_dts_deps = py3 + files('get-dts-deps.py') > > > > deps for runtime or doc? > > may be good to specify in the name > > > > It's getting both, actually. > Now that

Re: [PATCH v15 5/5] dts: add API doc generation

2024-08-07 Thread Juraj Linkeš
On 7. 8. 2024 14:27, Thomas Monjalon wrote: 07/08/2024 14:03, Juraj Linkeš: On 7. 8. 2024 12:41, Thomas Monjalon wrote: 06/08/2024 17:19, Juraj Linkeš: [...] +get_dts_deps = py3 + files('get-dts-deps.py') deps for runtime or doc? may be good to specify in the name It's getting both, ac

RE: [PATCH] doc: announce cryptodev changes to offload RSA in VirtIO

2024-08-07 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, July 31, 2024 4:27 PM > To: Gowrishankar Muthukrishnan > Cc: dev@dpdk.org; Kusztal, ArkadiuszX ; > dev@dpdk.org; Anoob Joseph ; Richardson, Bruce > ; ciara.po...@intel.com; Jerin Jacob > ; fanzhang@gmail.com; Ji, Kai ;

Re: [PATCH v15 2/5] dts: replace the or operator in third party types

2024-08-07 Thread Luca Vizzarro
Hi Juraj, In the past, I have noticed this problem appear only on Python versions prior to 3.10. Before PEP 604[1] – introduced in Python 3.10 – the pipe operator was always used as an operator between objects instead of an alias for Union in the annotations. A quick test verifies this: P

Re: [PATCH dpdk] buildtools/cmdline: fix meson error when used as a subproject

2024-08-07 Thread Bruce Richardson
On Thu, Aug 01, 2024 at 12:01:54PM +0200, Robin Jarry wrote: > Fix the following error when using dpdk as a subproject: > > subprojects/dpdk/buildtools/subproject/meson.build:28:56: > ERROR: Unknown function "file". > > This was obviously never tested in its submitted form. > > Cc: sta...@dpdk

[RFC v1 0/1] dts: separate allowed values from json schema

2024-08-07 Thread Nicholas Pratte
I started discussions with Juraj about potentially taking all of the 'test_suite' enums in the framework's json schema and putting them into its own smaller json file that can easily be referenced. The thought being that doing so might make it easier for outside developers to navigate when writing

[RFC v1 1/1] dts: split enums from primary json schema

2024-08-07 Thread Nicholas Pratte
Separating enums from the primary json schema might make it easier for incoming DTS developers and users to quickly identify what values are allowed in the config yaml file with relative ease. Moreover, separating values, such as available test suites, may streamline the test suite development proc

Re: [PATCH v15 2/5] dts: replace the or operator in third party types

2024-08-07 Thread Juraj Linkeš
On 7. 8. 2024 15:34, Luca Vizzarro wrote: Hi Juraj, In the past, I have noticed this problem appear only on Python versions prior to 3.10. Before PEP 604[1] – introduced in Python 3.10 – the pipe operator was always used as an operator between objects instead of an alias for Union in the a

Re: [RFC v1 0/1] dts: separate allowed values from json schema

2024-08-07 Thread Luca Vizzarro
Hi Nicholas, Thank you for the proposal. The way I see it is that JSON schema can be very developer unfriendly to read, therefore I would not rely on it for this purpose. Adding $refs as well could start making it more complicated for this purpose. It's helpful for structuring and maintaining

Re: [PATCH 02/17] net/dpaa: fix typecasting ch ID to u32

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:52 AM, Hemant Agrawal wrote: > From: Rohit Raj > > Avoid typecasting ch_id to u32 and passing it to another API since it > can corrupt other data. Instead, create new u32 variable and typecase > it back to u16 after it gets updated by the API. > Ack on the issue and the solution.

Re: [PATCH 04/17] bus/dpaa: add port buffer manager stats

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > Add BMI statistics and improving the existing extended > statistics > > Signed-off-by: Hemant Agrawal > Signed-off-by: Gagandeep Singh > --- > drivers/bus/dpaa/base/fman/fman_hw.c | 65 +++- > drivers/bus/dpaa/include/fman.h

Re: [PATCH 03/17] bus/dpaa: fix VSP for 1G fm1-mac9 and 10

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:52 AM, Hemant Agrawal wrote: > No need to classify interface separately for 1G and 10G > > Fixes: e0718bb2ca95 ("bus/dpaa: add virtual storage profile port init") > Cc: sta...@dpdk.org > > Signed-off-by: Hemant Agrawal > Can you please briefly explain what is VSP in the commit lo

Re: [PATCH 05/17] net/dpaa: support Tx confirmation to enable PTP

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > From: Vanshika Shukla > > TX confirmation provides dedicated confirmation > queues for transmitted packets. These queues are > used by software to get the status and release > transmitted packets buffers. > > Signed-off-by: Vanshika Shukla > Acked-b

Re: [PATCH 07/17] net/dpaa: share MAC FMC scheme and CC parse

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > From: Jun Yang > > For Shared MAC: > 1) Allocate RXQ from VSP scheme. > 2) Allocate RXQ from CC directed to VSP. > What is CC, please explain in the commit log. > 2) Remove RXQ allocated which is reconfigured without VSP. > 3) Don't alloc default qu

Re: [PATCH 11/17] net/dpaa: enhance DPAA frame display

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > This patch enhances the received packet debugging capability. > This help displaying the full packet parsing output. > > Signed-off-by: Jun Yang > Signed-off-by: Hemant Agrawal > --- > doc/guides/nics/dpaa.rst | 5 ++ > drivers/net/dpaa/dpaa

Re: [PATCH 09/17] net/dpaa: support IEEE 1588 PTP

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > From: Vanshika Shukla > > This patch adds the support for the ethdev APIs > to enable/disable and read/write/adjust IEEE1588 > PTP timestamps for DPAA platform. > > Signed-off-by: Vanshika Shukla > --- > doc/guides/nics/dpaa.rst | 1 + >

Re: [PATCH 10/17] net/dpaa: implement detailed packet parsing

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > This patch implements the detailed packet parsing using > the annotation info from the hardware. > > decode parser to set RX muf packet type by dpaa_slow_parsing. > Support to identify the IPSec ESP, GRE and SCTP packets. > > Signed-off-by: Jun Yang

Re: [PATCH 13/17] net/dpaa: add Tx rate limiting DPAA PMD API

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > From: Vinod Pullabhatla > > Add support to set Tx rate on DPAA platform through PMD APIs > > Signed-off-by: Vinod Pullabhatla > Signed-off-by: Rohit Raj <...> > diff --git a/drivers/net/dpaa/rte_pmd_dpaa.h b/drivers/net/dpaa/rte_pmd_dpaa.h > inde

Re: [PATCH 14/17] bus/dpaa: add OH port mode for dpaa eth

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > From: Rohit Raj > > NXP DPAA architecture supports the concept of DPAA > port as Offline Port - meaning - not connected to an actual MAC. > This is an virtual port to be used by application for exchanging data. > Is this for application sending some

Re: [PATCH 17/17] net/dpaa: improve dpaa errata A010022 handling

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:53 AM, Hemant Agrawal wrote: > From: Jun Yang > > This patch improves the errata handling for > "RTE_LIBRTE_DPAA_ERRATA_LS1043_A010022" > > Signed-off-by: Jun Yang > --- > drivers/net/dpaa/dpaa_rxtx.c | 40 > 1 file changed, 32 insertions(+),

Re: [PATCH 00/17] NXP DPAA ETH driver enhancement and fixes

2024-08-07 Thread Ferruh Yigit
On 8/1/2024 11:52 AM, Hemant Agrawal wrote: > This series adds several enhancement to the NXP DPAA Ethernet driver. > > Primarily: > 1. timestamp and IEEE 1588 support > 2. OH and ONIC based virtual port config in DPAA > 3. frame display and debugging infra > > Gagandeep Singh (3): > bus/dpaa:

Re: [PATCH v5 1/3] dts: add multicast set function to shell

2024-08-07 Thread Luca Vizzarro
Hi Dean, Apologies again for having replied to the wrong email thread. I'll copy my comments here. And thank you again for your contribution On 24/07/2024 20:21, Dean Marx wrote: added set multicast function for changing allmulticast mode within testpmd. Signed-off-by: Dean Marx --- dts/f

Re: [PATCH v5 2/3] dts: dynamic config conf schema

2024-08-07 Thread Luca Vizzarro
Similar to my other reply. Please follow contributing guidelines when writing your commit subject and body[1]. For example, an imperative subject: dts: add dynamic config test to conf schema Moreover, is there a reason to split this from the test suite commit? Thanks, Luca [1] https://d

RE: [EXTERNAL] Re: [PATCH] doc: announce cryptodev change to support EDDSA

2024-08-07 Thread Gowrishankar Muthukrishnan
> It means we are not able to add an algo without breaking ABI. > Is it something we can improve? > Sure Thomas, we will address it in our patch, ensuring the long term solution as well. Regards, Gowrishankar

Re: [PATCH v2 1/2] dts: add dual_vlan testing suite

2024-08-07 Thread Dean Marx
Reviewed-by: Dean Marx

[PATCH v6 0/2] dts: refactored dynamic config test suite

2024-08-07 Thread Dean Marx
*v6: combined conf schema patch with test suite patch Dean Marx (2): dts: add multicast set function to shell dts: dynamic config test suite dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session/testpmd_shell.py | 46 ++ dts/tests/TestSuite_dynamic_config.

[PATCH v6 2/2] dts: dynamic config test suite

2024-08-07 Thread Dean Marx
Suite for testing ability of Poll Mode Driver to turn promiscuous mode on/off, allmulticast mode on/off, and show expected behavior when sending packets with known, unknown, broadcast, and multicast destination MAC addresses. Depends-on: patch-1142113 ("add send_packets to test suites and rework p

[PATCH v6 1/2] dts: add multicast set function to shell

2024-08-07 Thread Dean Marx
added set multicast function for changing allmulticast mode within testpmd. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 46 +++ 1 file changed, 46 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_se

[PATCH v9 0/2] dts: refactored queue start/stop suite

2024-08-07 Thread Dean Marx
*v9: combined conf schema and test suite patches Dean Marx (2): dts: add functions to testpmd shell dts: initial queue start/stop suite implementation dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session/testpmd_shell.py | 232 +- dts/tests/Tes

[PATCH v9 1/2] dts: add functions to testpmd shell

2024-08-07 Thread Dean Marx
added set promisc, set verbose, and port stop commands to testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 232 +- 1 file changed, 231 insertions(+), 1 deletion(-) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framew

[PATCH v9 2/2] dts: initial queue start/stop suite implementation

2024-08-07 Thread Dean Marx
This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_queue_start_stop.py| 91 ++ 2 files changed, 93 insertions(+), 1 deletio

[PATCH v13 0/2] dts: refactored VLAN test suite

2024-08-07 Thread Dean Marx
*v13: combined conf schema and test suite patches Dean Marx (2): dts: add VLAN methods to testpmd shell dts: VLAN test suite implementation dts/framework/config/conf_yaml_schema.json| 3 +- dts/framework/remote_session/testpmd_shell.py | 245 +- dts/tests/TestSuite_vlan

[PATCH v13 1/2] dts: add VLAN methods to testpmd shell

2024-08-07 Thread Dean Marx
added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose fixed bug in vlan_offload for show port info, removed $ at end of regex Signed-off-by: Dean Marx --- dts/framework/

[PATCH v13 2/2] dts: VLAN test suite implementation

2024-08-07 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_vlan.py| 168 + 2 files changed, 170 insertions(+), 1 del

[PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits

2024-08-07 Thread Igor Gutorov
Hi, Slava > > Is an `int` appropriate for `log_max_wq_sz`? Seems like a `uint8_t` > > is sufficient, but I've left it an `int` for consistency with the > > other `log_max_*` values. > > Right, uint8_t looks to be enough. No objection to optimize others to > uint8_t. Changed log_max_wq_sz to uint

[PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes

2024-08-07 Thread Igor Gutorov
A number of `log_max_*` fields' types are unnecessarily large, and can be reduced to `uint8_t`. Signed-off-by: Igor Gutorov --- drivers/common/mlx5/mlx5_devx_cmds.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/

[PATCH v3 1/2] net/mlx5: fix reported Rx/Tx desc limits

2024-08-07 Thread Igor Gutorov
Currently, `rte_eth_dev_info.rx_desc_lim.nb_max` as well as `rte_eth_dev_info.tx_desc_lim.nb_max` shows 65535 as the limit, which results in a few problems: * It is not the actual Rx/Tx queue limit * Allocating an Rx queue and passing `rx_desc_lim.nb_max` results in an integer overflow and 0 rin

Re: [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits

2024-08-07 Thread Igor Gutorov
Hi, Sorry, I used the wrong --to and --cc switches. Adding Slava just in case. Sincerely, Igor. On Wed, Aug 7, 2024 at 11:44 PM Igor Gutorov wrote: > > Hi, Slava > > > > Is an `int` appropriate for `log_max_wq_sz`? Seems like a `uint8_t` > > > is sufficient, but I've left it an `int` for consis

[PATCH 0/3] net/enic: support VF and fix minor issues

2024-08-07 Thread Hyong Youb Kim
This series contains minor updates for net/enic. The first patch supports SR-IOV VF, which now requires the use of admin channel. The other patches are not related to VF, but included here to ease review. Hyong Youb Kim (3): net/enic: support SR-IOV VF using admin channel net/enic: add speed c

[PATCH 1/3] net/enic: support SR-IOV VF using admin channel

2024-08-07 Thread Hyong Youb Kim
The Linux VIC PF driver now requires the use of the admin channel between PF and VF drivers. Certain devcmds are disabled for VF. The VF driver is supposed to send control messages through the admin channel to the PF driver to perform those devcmds. This commit adds the admin channel to the VF driv

[PATCH 2/3] net/enic: add speed capabilities for newer models

2024-08-07 Thread Hyong Youb Kim
Add 1400/14000 and 15000 models to the speed_capa list. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index 5c967

[PATCH 3/3] net/enic: allow multicast in MAC address add callback

2024-08-07 Thread Hyong Youb Kim
enic_set_mac_address() (mac_addr_add callback) currently allows only non-zero, unicast address to be added. It is overly restrictive. rte_eth_dev_mac_addr_add() itself allows multicast addresses. And, some applications do use rte_eth_dev_mac_addr_add() to accept multicast addresses. So, remove the

[PATCH v2 0/3] net/enic: support VF and fix minor issues

2024-08-07 Thread Hyong Youb Kim
This series contains minor updates for net/enic. The first patch supports SR-IOV VF, which now requires the use of admin channel. The other patches are not related to VF, but included here to ease review. --- v2: * fix compiler warnings Hyong Youb Kim (3): net/enic: support SR-IOV VF using adm

[PATCH v2 1/3] net/enic: support SR-IOV VF using admin channel

2024-08-07 Thread Hyong Youb Kim
The Linux VIC PF driver now requires the use of the admin channel between PF and VF drivers. Certain devcmds are disabled for VF. The VF driver is supposed to send control messages through the admin channel to the PF driver to perform those devcmds. This commit adds the admin channel to the VF driv

[PATCH v2 2/3] net/enic: add speed capabilities for newer models

2024-08-07 Thread Hyong Youb Kim
Add 1400/14000 and 15000 models to the speed_capa list. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index 5c967

[PATCH v2 3/3] net/enic: allow multicast in MAC address add callback

2024-08-07 Thread Hyong Youb Kim
enic_set_mac_address() (mac_addr_add callback) currently allows only non-zero, unicast address to be added. It is overly restrictive. rte_eth_dev_mac_addr_add() itself allows multicast addresses. And, some applications do use rte_eth_dev_mac_addr_add() to accept multicast addresses. So, remove the