Hi, > -----Original Message----- > From: Richardson, Bruce <[email protected]> > Sent: Tuesday, August 6, 2024 11:24 PM > To: [email protected] > Cc: Richardson, Bruce <[email protected]>; Nithin Dabilpuram > <[email protected]>; Kiran Kumar K <[email protected]>; > Sunil Kumar Kori <[email protected]>; Satha Rao > <[email protected]>; Harman Kalra <[email protected]>; Hemant > Agrawal <[email protected]>; Sachin Saxena > <[email protected]>; Jie Hai <[email protected]>; Yisen Zhuang > <[email protected]>; Wu, Jingjing <[email protected]>; Xu, > Rosen <[email protected]>; Jiawen Wu <[email protected]>; Jian > Wang <[email protected]>; Dumitrescu, Cristian > <[email protected]>; Thomas Monjalon > <[email protected]>; Ferruh Yigit <[email protected]>; Andrew > Rybchenko <[email protected]> > Subject: [PATCH 1/4] ethdev: make parameters to TM node add fn constant > > The function to add a new scheduling node in rte_tm should not (and does > not) modify the actual node parameters passed in via struct pointer. We > should guarantee this by marking the parameter pointer as const. This allows > SW to create multiple scheduling nodes using the same parameter struct > without having to reset it each time. > > Signed-off-by: Bruce Richardson <[email protected]> > --- > drivers/net/ipn3ke/ipn3ke_tm.c | 4 ++-- > diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c > b/drivers/net/ipn3ke/ipn3ke_tm.c index 0260227900..cffe1fdaa4 100644 > --- a/drivers/net/ipn3ke/ipn3ke_tm.c > +++ b/drivers/net/ipn3ke/ipn3ke_tm.c > @@ -1010,7 +1010,7 @@ ipn3ke_tm_tdrop_profile_delete(struct > rte_eth_dev *dev, static int > ipn3ke_tm_node_add_check_parameter(uint32_t tm_id, > uint32_t node_id, uint32_t parent_node_id, uint32_t priority, > - uint32_t weight, uint32_t level_id, struct rte_tm_node_params > *params, > + uint32_t weight, uint32_t level_id, const struct rte_tm_node_params > +*params, > struct rte_tm_error *error) > { > uint32_t level_of_node_id; > @@ -1168,7 +1168,7 @@ ipn3ke_tm_node_add_check_mount(uint32_t > tm_id, static int ipn3ke_tm_node_add(struct rte_eth_dev *dev, > uint32_t node_id, uint32_t parent_node_id, uint32_t priority, > - uint32_t weight, uint32_t level_id, struct rte_tm_node_params > *params, > + uint32_t weight, uint32_t level_id, const struct rte_tm_node_params > +*params, > struct rte_tm_error *error) > { > struct ipn3ke_hw *hw = IPN3KE_DEV_PRIVATE_TO_HW(dev); diff -- > /** @internal Traffic manager node delete */ > -- > 2.43.0
Reviewed-by: Rosen Xu <[email protected]>
