Hi, > -----Original Message----- > From: Richardson, Bruce <[email protected]> > Sent: Tuesday, August 6, 2024 11:24 PM > To: [email protected] > Cc: Richardson, Bruce <[email protected]>; Nithin Dabilpuram > <[email protected]>; Kiran Kumar K <[email protected]>; > Sunil Kumar Kori <[email protected]>; Satha Rao > <[email protected]>; Harman Kalra <[email protected]>; Hemant > Agrawal <[email protected]>; Sachin Saxena > <[email protected]>; Jie Hai <[email protected]>; Yisen Zhuang > <[email protected]>; Wu, Jingjing <[email protected]>; Xu, > Rosen <[email protected]>; Liron Himi <[email protected]>; Jiawen Wu > <[email protected]>; Jian Wang <[email protected]>; > Dumitrescu, Cristian <[email protected]>; Thomas Monjalon > <[email protected]>; Ferruh Yigit <[email protected]>; Andrew > Rybchenko <[email protected]> > Subject: [PATCH 3/4] ethdev: make TM shaper parameters constant > > The function to add a new shaper profile in rte_tm should not (and does > not) modify the profile parameters passed in via struct pointer. We should > guarantee this by marking the parameter pointer as const. This allows SW to > create multiple profiles using the same parameter struct without having to > reset it each time. > > Signed-off-by: Bruce Richardson <[email protected]> > --- > drivers/net/ipn3ke/ipn3ke_tm.c | 4 ++-- > diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c > b/drivers/net/ipn3ke/ipn3ke_tm.c index 20a0ed0467..eec01bb037 100644 > --- a/drivers/net/ipn3ke/ipn3ke_tm.c > +++ b/drivers/net/ipn3ke/ipn3ke_tm.c > @@ -722,7 +722,7 @@ ipn3ke_tm_node_capabilities_get(struct > rte_eth_dev *dev, } > > static int > -ipn3ke_tm_shaper_parame_trans(struct rte_tm_shaper_params *profile, > +ipn3ke_tm_shaper_parame_trans(const struct rte_tm_shaper_params > +*profile, > struct ipn3ke_tm_shaper_profile *local_profile, > const struct ipn3ke_tm_shaper_params_range_type *ref_data) > { @@ -747,7 +747,7 @@ ipn3ke_tm_shaper_parame_trans(struct > rte_tm_shaper_params *profile, > > static int > ipn3ke_tm_shaper_profile_add(struct rte_eth_dev *dev, > - uint32_t shaper_profile_id, struct rte_tm_shaper_params *profile, > + uint32_t shaper_profile_id, const struct rte_tm_shaper_params > +*profile, > struct rte_tm_error *error) > { > struct ipn3ke_hw *hw = IPN3KE_DEV_PRIVATE_TO_HW(dev); diff -- > /** @internal Traffic manager shaper profile delete */ > -- > 2.43.0
Reviewed-by: Rosen Xu <[email protected]>
