Re: [PATCH 2/4] app/testpmd: fix burst option parsing

On Tue, Mar 12, 2024 at 5:47 PM Ferruh Yigit wrote: > > On 3/8/2024 2:48 PM, David Marchand wrote: > > rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but > > for the theoretical case when it would fail, raise an error rather than > > skip subsequent options. > > > > Fixes: 6f5

Re: [EXTERNAL] Re: [v11 0/4] PCI Dev and SG copy support

Hi Gowrishankar, On 2024/3/12 20:24, Gowrishankar Muthukrishnan wrote: > Hi Fengchengwen > >> >> Hi Thomas, >> >> On 2024/3/12 17:15, Thomas Monjalon wrote: >>> 07/03/2024 14:55, Gowrishankar Muthukrishnan: Hi Fengchengwen, >> Waiting for a confirmation that this series is good to g

Re: [PATCH 3/4] app/testpmd: check queue count for related options

On Tue, Mar 12, 2024 at 5:59 PM Ferruh Yigit wrote: > > On 3/8/2024 2:48 PM, David Marchand wrote: > > Checking the number of rxq/txq in the middle of option parsing is > > confusing. Move the check where nb_rxq / nb_txq are modified. > > > > Signed-off-by: David Marchand > > --- > > app/test-pm

RE: [PATCH 2/2] net/mlx5: fix IP-in-IP tunnels recognition

Hi, > -Original Message- > From: Gregory Etelson > Sent: Thursday, February 29, 2024 6:05 PM > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh ; Ori Kam > ; Dariusz Sosnowski ; Slava > Ovsiienko ; Suanming Mou > ; Matan Azrad ; Yongseok > Koh > Subject: [PATC

RE: [PATCH] net/mlx5: fix async flow create error handling

Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Tuesday, March 5, 2024 8:05 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix async flow create error handling > > Whenever processing of asyn

RE: [PATCH] net/mlx5: fix mlx5dr context release ordering

Hi, > -Original Message- > From: Maayan Kashani > Sent: Wednesday, March 6, 2024 8:02 AM > To: dev@dpdk.org > Cc: Maayan Kashani ; Raslan Darawsheh > ; sta...@dpdk.org; Dariusz Sosnowski > ; Slava Ovsiienko ; Ori > Kam ; Suanming Mou ; Matan > Azrad > Subject: [PATCH] net/mlx5: fix mlx5d

RE: [PATCH] net/mlx5: fix pattern template size validation

Hi, > -Original Message- > From: Gregory Etelson > Sent: Wednesday, March 6, 2024 9:39 AM > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh ; Dariusz > Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Matan Azrad > Subject: [PATCH] net/mlx5: fix pat

RE: [PATCH 1/4] net/mlx5/hws: fix direct index insert on dep wqe

Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, March 6, 2024 10:22 PM > To: Slava Ovsiienko ; Ori Kam ; > Suanming Mou ; Matan Azrad > ; Yevgeny Kliteynik > Cc: dev@dpdk.org; Alex Vesker ; sta...@dpdk.org > Subject: [PATCH 1/4] net/mlx5/hws: fix direct index insert

RE: [PATCH] net/mlx5: prevent ioctl failure log from flood

Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, March 7, 2024 8:14 AM > To: Slava Ovsiienko ; dev@dpdk.org; Raslan > Darawsheh > Cc: Ori Kam ; Dariusz Sosnowski > ; Suanming Mou ; > Matan Azrad ; Eli Britstein ; Ophir > Munk ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: pre

RE: [PATCH] net/mlx5: fix age position in hairpin split

Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, March 7, 2024 10:09 AM > To: Slava Ovsiienko ; dev@dpdk.org; Raslan > Darawsheh > Cc: Ori Kam ; Dariusz Sosnowski > ; Suanming Mou ; > Matan Azrad ; Michael Baum ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix age position

RE: [PATCH] net/mlx5: fix the timing of releasing drop action

Hi, > -Original Message- > From: Bing Zhao > Sent: Friday, March 8, 2024 5:23 AM > To: Suanming Mou ; dev@dpdk.org; Raslan > Darawsheh > Cc: Ori Kam ; Dariusz Sosnowski > ; Slava Ovsiienko ; > Matan Azrad ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the timing of releasing drop act

RE: [EXTERNAL] Re: [v11 0/4] PCI Dev and SG copy support

Hi Fengchengwen > Hi Gowrishankar, > > On 2024/3/12 20:24, Gowrishankar Muthukrishnan wrote: > > Hi Fengchengwen > > > >> > >> Hi Thomas, > >> > >> On 2024/3/12 17:15, Thomas Monjalon wrote: > >>> 07/03/2024 14:55, Gowrishankar Muthukrishnan: > Hi Fengchengwen, > > >> Waiting for a

[PATCH v2] app/test: fix rsa tests in qat suite

This commit fixes incorrectly set keys in the QAT testsuite for the RSA algorithm. Fixes: 9b5465867fb8 ("test/crypto: add RSA none padding cases") Cc: sta...@dpdk.org Signed-off-by: Arkadiusz Kusztal --- v2: - removed camel case app/test/test_cryptodev_asym.c | 102 ++--

RE: [PATCH 1/6] examples/l3fwd: fix lcore ID restriction

[AMD Official Use Only - General] Hi, > -Original Message- > From: David Marchand > Sent: Thursday, March 7, 2024 2:04 PM > To: Tummala, Sivaprasad > Cc: david.h...@intel.com; anatoly.bura...@intel.com; jer...@marvell.com; > radu.nico...@intel.com; gak...@marvell.com; cristian.dumitre..

RE: [PATCH 1/2] net/mlx5: update speed capabilities parsing on Linux

Hi, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 5, 2024 3:13 PM > To: dev@dpdk.org > Cc: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Matan Azrad > Subject: [PATCH 1/2] net/mlx5: update speed capabilities parsing on Linux > > Ease maintenanc

RE: [PATCH v2] app/dma-perf: calrify incorrect NUMA config

>Ok, the naming convention used by me is `CamelCase`. One suggested from your >end is `snake_case`. >Does DPDK has a constrain it can not use CamelCase. Please refer to: https://doc.dpdk.org/guides/contributing/coding_style.html In particular: 1.5.4. Variable Declarations In declarations, do

RE: [PATCH v7 3/4] net/mlx5: fix warning about rte_memcpy length

Hi, > -Original Message- > From: Morten Brørup > Sent: Monday, January 16, 2023 3:07 PM > To: dev@dpdk.org; roret...@linux.microsoft.com; rm...@marvell.com; > timothy.mcdan...@intel.com; Matan Azrad ; Slava > Ovsiienko > Cc: ruifeng.w...@arm.com; zhou...@loongson.cn; > d...@linux.vnet.ibm

RE: [EXTERNAL] [PATCH v2] app/test: fix rsa tests in qat suite

> This commit fixes incorrectly set keys in the > QAT testsuite for the RSA algorithm. > > Fixes: 9b5465867fb8 ("test/crypto: add RSA none padding cases") > Cc: sta...@dpdk.org > > Signed-off-by: Arkadiusz Kusztal > --- > v2: > - removed camel case Removing camel case should be a separate patch

[PATCH v3 1/1] net/mana: add vlan tagging support

For tx path, use LONG_PACKET_FORMAT if vlan tag is present. For rx, extract vlan id from oob, put into mbuf and set the vlan flags in mbuf. Signed-off-by: Wei Hu --- v3: - Adjust the pkt_idx position in the code so it will be executed even when adding vlan header fails. v2: - Use existing vlan

RE: flow create with queue range not working

Hi Team, Gentle reminder! Can somebody please help us on this query. We are validating the fdir with test-pmd tool. We are getting below error while trying to add the flow create rule for the same. Syntax: testpmd> flow create 0 ingress pattern eth / ipv4 src is ipv4 dst is / tcp src is d

Re: [PATCH 2/4] app/testpmd: fix burst option parsing

On 3/13/2024 7:24 AM, David Marchand wrote: > On Tue, Mar 12, 2024 at 5:47 PM Ferruh Yigit wrote: >> >> On 3/8/2024 2:48 PM, David Marchand wrote: >>> rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but >>> for the theoretical case when it would fail, raise an error rather than

Re: [PATCH 3/4] app/testpmd: check queue count for related options

On 3/13/2024 7:37 AM, David Marchand wrote: > On Tue, Mar 12, 2024 at 5:59 PM Ferruh Yigit wrote: >> >> On 3/8/2024 2:48 PM, David Marchand wrote: >>> Checking the number of rxq/txq in the middle of option parsing is >>> confusing. Move the check where nb_rxq / nb_txq are modified. >>> >>> Signed-

[PATCH v5 00/21] Improvements and new test cases

v5: * Define TEST_SEC_CIPHERTEXT_MAX_LEN based on existing MBUF_DATAPAYLOAD_SIZE macro. v4: * Set max ciphertext length for data walkthrough tests to 4k. v3: * Set max packet length for data walkthrough tests to 8k. v2: * Rebased. Aakash Sasidharan (7): test/security: enable AES-GCM in comb

[PATCH v5 01/21] test/security: enable AES-GCM in combined mode TLS

Enable AES-GCM AEAD tests in combined mode TLS test suite. Coverity issue: 414888 Fixes: 9157ccb8f876 ("test/crypto: verify TLS headers") Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev_security_tls_record.c | 10 -- app/test/test_security_proto.h| 3 +++ 2

[PATCH v5 02/21] test/security: add TLS 1.2 data walkthrough test

Add data walkthrough test for TLS 1.2. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 90 +-- app/test/test_cryptodev_security_tls_record.c | 25 -- app/test/test_cryptodev_security_tls_record.h | 41 - app/test/test_security_prot

[PATCH v5 03/21] test/security: add DTLS 1.2 data walkthrough test

Add data walkthrough test for DTLS 1.2 Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 17 + app/test/test_cryptodev_security_tls_record.c | 5 - 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/a

[PATCH v5 04/21] test/security: add TLS SG data walkthrough test

Add multi segment packet data walkthrough test for TLS 1.2 and DTLS 1.2. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 42 +++ app/test/test_cryptodev_security_tls_record.h | 2 +- 2 files changed, 43 insertions(+), 1 deletion(-) diff --gi

[PATCH v5 05/21] test/security: unit test for TLS packet corruption

From: Vidya Sagar Velumuri Add test to verify the corrupted TLS packet header Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 27 +-- app/test/test_cryptodev_security_tls_record.c | 4 +++ app/test/test_cryptodev_security_tls_record.h |

[PATCH v5 06/21] test/security: unit test for custom content verification

From: Vidya Sagar Velumuri Add unit test to verify the TLS header creation with custom content type Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 19 +++ app/test/test_cryptodev_security_tls_record.c | 3 +++ app/test/test_cryptodev_se

[PATCH v5 07/21] test/cryptodev: allow zero packet length buffers

From: Anoob Joseph The function 'create_segmented_mbuf' is updated to support zero packet length mbufs. This allows testing of zero packet length payload with TLS record processing. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.h | 20 +++- 1 file changed, 7 insertion

[PATCH v5 08/21] test/security: unit test to verify zero TLS records

From: Vidya Sagar Velumuri Add unit tests to verify the zero len TLS records. Zero len packets are allowed when content type is app data while zero packet length with other content type (such as handshake) would result in an error. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptode

[PATCH v5 09/21] test/security: add unit tests for DTLS-1.2

From: Vidya Sagar Velumuri Add unit tests to verify 1. DTLS record with zero length 2. DTLS record with header corruption 3. DTLS record with content type as custom Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 77 +++ 1 file changed, 7

[PATCH v5 10/21] test/security: add TLS/DTLS 1.2 AES-256-SHA384 vectors

From: Akhil Goyal Added vectors for TLS 1.2 and DTLS 1.2 using algos AES-256-CBC and HMAC-SHA384 Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 19 ++ app/test/test_cryptodev_security_tls_record.h | 2 + ...yptodev_security_tls_record_test_vectors.h | 200 +++

[PATCH v5 11/21] test/security: add DTLS 1.2 anti-replay tests

Add anti-replay test for DTLS 1.2. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 115 ++- app/test/test_cryptodev_security_tls_record.c | 132 ++ app/test/test_cryptodev_security_tls_record.h | 11 +- 3 files changed, 188 insert

[PATCH v5 12/21] test/security: add more DTLS anti-replay window sz

Add anti-replay tests for window sizes 128, 256, 512, 1024, 2048 and 4096 window sizes in DTLS 1.2 suite. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 72 +-- 1 file changed, 69 insertions(+), 3 deletions(-) diff --git a/app/test/test_cryp

[PATCH v5 13/21] test/crypto: update verification of header

From: Vidya Sagar Velumuri In TLS 1.3, the version in the header would be TLS 1.2 and the content type would be APP irrespective of the type of the payload. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev_security_tls_record.c | 20 +-- 1 file changed, 14 insert

[PATCH v5 14/21] test/crypto: add TLS 1.3 vectors

From: Akhil Goyal Added vectors and test suite for TLS 1.3 AES-128-GCM, AES-256-GCM and CHACHA20-POLY1305 vectors. The vectors are generated using gnuTLS client server application. Signed-off-by: Akhil Goyal --- app/test/test_cryptodev.c | 35 +++ app/test/test_cryptodev_s

[PATCH v5 16/21] test/crypto: test to verify hdr corruption in TLS

From: Vidya Sagar Velumuri Add unit tests to verify TLS-1.3 record with header corruption. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptod

[PATCH v5 17/21] test/crypto: test to verify custom content type in TLS

From: Vidya Sagar Velumuri Add unit tests to verify TLS-1.3 record with content type as custom. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index

[PATCH v5 18/21] test/crypto: test to verify zero len record in TLS

From: Vidya Sagar Velumuri Add unit tests to verify TLS-1.3 record with zero length. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptode

[PATCH v5 19/21] test/crypto: unit tests to verify padding in TLS

From: Vidya Sagar Velumuri Add unit tests to verify the padding for TLS-1.2. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 85 ++- app/test/test_cryptodev_security_tls_record.c | 28 -- app/test/test_cryptodev_security_tls_record.h

[PATCH v5 20/21] test/crypto: unit tests for padding in DTLS-1.2

From: Vidya Sagar Velumuri Add unit tests to verify the padding for DTLS-1.2. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 60 +++ 1 file changed, 60 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c ind

[PATCH v5 15/21] test/crypto: update framework to verify tls-1.3

From: Vidya Sagar Velumuri Update the fields in preparation of test descriptor. Signed-off-by: Vidya Sagar Velumuri --- app/test/test_cryptodev.c | 17 +--- app/test/test_cryptodev_security_tls_record.c | 43 --- app/test/test_cryptodev_security_tls_reco

[PATCH v5 21/21] test/security: add out of place sgl test case for TLS 1.2

Add TLS 1.2 out-of-place multi-segmented packet test. Signed-off-by: Aakash Sasidharan --- app/test/test_cryptodev.c | 52 ++- app/test/test_cryptodev_security_tls_record.h | 1 + 2 files changed, 51 insertions(+), 2 deletions(-) diff --git a/app/test/test_c

Re: [PATCH 3/4] app/testpmd: check queue count for related options

On Wed, Mar 13, 2024 at 11:52 AM Ferruh Yigit wrote: > > On 3/13/2024 7:37 AM, David Marchand wrote: > > On Tue, Mar 12, 2024 at 5:59 PM Ferruh Yigit wrote: > >> > >> On 3/8/2024 2:48 PM, David Marchand wrote: > >>> Checking the number of rxq/txq in the middle of option parsing is > >>> confusing

Re: [PATCH 2/4] app/testpmd: fix burst option parsing

On Wed, Mar 13, 2024 at 11:37 AM Ferruh Yigit wrote: > > On 3/13/2024 7:24 AM, David Marchand wrote: > > On Tue, Mar 12, 2024 at 5:47 PM Ferruh Yigit wrote: > >> > >> On 3/8/2024 2:48 PM, David Marchand wrote: > >>> rte_eth_dev_info_get() is not supposed to fail for a valid port_id, but > >>> for

Re: [PATCH v3 04/33] net/ena: sub-optimal configuration notifications support

On 3/10/2024 2:43 PM, Brandes, Shai wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, March 8, 2024 7:23 PM >> To: Brandes, Shai >> Cc: dev@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 04/33] net/ena: sub-optimal >> configuration notifications support >> >> CAUTIO

Re: [PATCH v3 07/33] net/ena: restructure the llq policy setting process

On 3/10/2024 2:29 PM, Brandes, Shai wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, March 8, 2024 7:24 PM >> To: Brandes, Shai >> Cc: dev@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 07/33] net/ena: restructure the llq policy >> setting process >> >> CAUTION: Th

Re: [PATCH v3 08/33] net/ena/hal: exponential backoff exp limit

On 3/12/2024 4:53 PM, Brandes, Shai wrote: > > >> -Original Message- >> From: Brandes, Shai >> Sent: Sunday, March 10, 2024 4:54 PM >> To: 'Ferruh Yigit' >> Cc: dev@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 08/33] net/ena/hal: exponential backoff >> exp limit >> >> >> >>> -Origin

Re: [PATCH v3 10/33] net/ena/hal: added a bus parameter to ena memcpy macro

On 3/10/2024 3:08 PM, Brandes, Shai wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, March 8, 2024 7:25 PM >> To: Brandes, Shai >> Cc: dev@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 10/33] net/ena/hal: added a bus >> parameter to ena memcpy macro >> >> CAUTION:

Re: [PATCH v3 00/33] net/ena: v2.9.0 driver release

On 3/10/2024 2:21 PM, Brandes, Shai wrote: > > >> -Original Message- >> From: Brandes, Shai >> Sent: Friday, March 8, 2024 10:27 PM >> To: Ferruh Yigit >> Cc: dev@dpdk.org >> Subject: RE: [PATCH v3 00/33] net/ena: v2.9.0 driver release >> >> Sure, will upload a new seried, thanks! >> >>

Re: [PATCH v3 05/33] net/ena: fix fast mbuf free

On 3/10/2024 2:58 PM, Brandes, Shai wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, March 8, 2024 7:23 PM >> To: Brandes, Shai >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 05/33] net/ena: fix fast mbuf free >> >> CAUTION: This email o

Re: [PATCH 2/4] app/testpmd: fix burst option parsing

On 3/13/2024 11:13 AM, David Marchand wrote: > On Wed, Mar 13, 2024 at 11:37 AM Ferruh Yigit wrote: >> >> On 3/13/2024 7:24 AM, David Marchand wrote: >>> On Tue, Mar 12, 2024 at 5:47 PM Ferruh Yigit wrote: On 3/8/2024 2:48 PM, David Marchand wrote: > rte_eth_dev_info_get() is not su

Re: [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

On Tue, Mar 12, 2024 at 3:53 PM Aaron Conole wrote: > > GitHub recently started using newer Ubuntu 22.04 LTS container images, > versioned 20240310.1.0 which use 32-bit entropy for ASLR: > > $ sudo sysctl -a | grep vm.mmap.rnd > vm.mmap_rnd_bits = 32 > vm.mmap_rnd_compat_bits = 16 > > This b

Re: [PATCH 3/4] app/testpmd: check queue count for related options

On 3/13/2024 11:10 AM, David Marchand wrote: > On Wed, Mar 13, 2024 at 11:52 AM Ferruh Yigit wrote: >> >> On 3/13/2024 7:37 AM, David Marchand wrote: >>> On Tue, Mar 12, 2024 at 5:59 PM Ferruh Yigit wrote: On 3/8/2024 2:48 PM, David Marchand wrote: > Checking the number of rxq/txq i

[PATCH v2 0/2] net/virtio: vhost-vdpa fixes

While investigating vhost-vdpa initialization issue with mlx5 vDPA, we found two issues fixed by following patches. In this v2, the control queue issue mentioned in v1 is fixed. It turned out to the control queue being enabled only if multiqueue was negotiated. It is fixed by enabling it at device

[PATCH v2 1/2] net/virtio: fix vDPA device init advertising control queue

If the vDPA device advertises control queue support, but the user neither passes "cq=1" as devarg nor requests multiple queues, the initialization fails because the driver tries to setup the control queue without negotiating related feature. This patch enables the control queue at driver level as

[PATCH v2 2/2] net/virtio: fix notification area initialization

Notification area is a Virtio feature that requires to be negotiated because not all devices support it. Currently, it is tried to be initialized as soon as the backend implements the callback, so it assumes all Vhost-vDPA devices support it. This patch skips calling the notification area map call

Re: [PATCH v4] app/eventdev: support DMA adapter test

On Tue, Mar 12, 2024 at 8:10 PM Amit Prakash Shukla wrote: > > Added performance test support for DMA adapter. > > Signed-off-by: Amit Prakash Shukla > Acked-by: Pavan Nikhilesh > --- > v4: > - Updated release notes. > > v3: > - Resolved review comments. > > v2: > - Fixed intel compilation error

RE: [PATCH v3 00/33] net/ena: v2.9.0 driver release

> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, March 13, 2024 1:28 PM > To: Brandes, Shai > Cc: dev@dpdk.org > Subject: RE: [EXTERNAL] [PATCH v3 00/33] net/ena: v2.9.0 driver release > > CAUTION: This email originated from outside of the organization. Do not click > links

Re: [PATCH v2 1/2] net/virtio: fix vDPA device init advertising control queue

On Wed, Mar 13, 2024 at 1:59 PM Maxime Coquelin wrote: > > If the vDPA device advertises control queue support, but > the user neither passes "cq=1" as devarg nor requests > multiple queues, the initialization fails because the > driver tries to setup the control queue without negotiating > relate

RE: [PATCH v5 00/21] Improvements and new test cases

> Subject: [PATCH v5 00/21] Improvements and new test cases > > v5: > * Define TEST_SEC_CIPHERTEXT_MAX_LEN based on existing > MBUF_DATAPAYLOAD_SIZE macro. > > v4: > * Set max ciphertext length for data walkthrough tests to 4k. > > v3: > * Set max packet length for data walkthrough tests to 8k

RE: [EXT] [PATCH v4] examples/ipsec-secgw: fix cryptodev to SA mapping

> > There are use cases where a SA should be able to use different cryptodevs on > > different lcores, for example there can be cryptodevs with just 1 qp per VF. > > For this purpose this patch relaxes the check in create lookaside session > > function. > > Also add a check to verify that a CQP is

Re: [PATCH v2] net/bnx2x: fix indentation

On Tue, Mar 12, 2024 at 8:55 PM Stephen Hemminger wrote: > > The DPDK style of indentation uses tabs not spaces. > This file had mix of both. Convert it. > > Signed-off-by: Stephen Hemminger Applied to dpdk-next-net-mrvl/for-main. Thanks > --- > v2 - fix resulting checkpatch warnings > > driv

Re: [PATCH] vhost: fix vring addr update with vDPA

On Thu, Mar 7, 2024 at 11:35 AM David Marchand wrote: > > For vDPA devices, vq are not locked once the device has been configured > at runtime. > > On the other hand, we need to hold the vq lock to evaluate vq->access_ok, > invalidate vring addresses and translate them. > > Move vring address upda

Re: [PATCH] vhost: fix virtqueue access lock check for handlers

On Thu, Mar 7, 2024 at 11:36 AM David Marchand wrote: > > As the vhost library may receive a request for an unsupported request, > it is necessary to check msg_handler before checking if locking queue > pairs is requested. > > Coverity issue: 415049 > Fixes: 5e8fcc60b59d ("vhost: enhance virtqueue

Re: [PATCH v2 0/2] net/virtio: vhost-vdpa fixes

On Wed, Mar 13, 2024 at 1:59 PM Maxime Coquelin wrote: > > While investigating vhost-vdpa initialization issue with mlx5 > vDPA, we found two issues fixed by following patches. > > In this v2, the control queue issue mentioned in v1 is > fixed. It turned out to the control queue being enabled > on

RE: [PATCH] compress/nitrox: fix dereference after null check

> Subject: [PATCH] compress/nitrox: fix dereference after null check > > In nitrox_check_comp_req() while updating the last byte during FINAL > flush there is possibility of accessing null mbuf in two rare cases. > First case is when the application changes the dst mbuf between > enqueue and deque

RE: [PATCH] common/qat: fix null dereference in release function

> > Subject: [PATCH] common/qat: fix null dereference in release function > > > > This commit fixes NULL dereference in the release function, and three > additional > > coverity issues related to NULL check. > > > > Coverity issue: 415038 > > Coverity issue: 415050 > > Coverity issue: 415052 > > Co

RE: [PATCH] crypto/qat: fix ccm null aad pointer segfault

> > Subject: [PATCH] crypto/qat: fix ccm null aad pointer segfault > > > > This commit fixes a segfault, that occurs when NULL pointer is being set to > > the > > aad pointer field. > > > > Fixes: a815a04cea05 ("crypto/qat: support symmetric build op request") > > Cc: sta...@dpdk.org > > > > Signe

[PATCH] app/crypto-perf-test: fix unset crc algorithm

Because net crc api is not thread-safe, setting crc algorithm by the application will prevent race condition in the calc function. Race condition still may occur when any of the threads will call this function again. Function is called with the highest possible SIMD extension, which is AVX512, but

Re: [PATCH 2/2] net/nfp: fix data endianness problem

On 3/11/2024 2:49 AM, Chaoyong He wrote: > From: Shihong Wang > > The algorithm key of the security framework is stored in the u8 > array according to big-endian, and the driver algorithm key is > CPU-endian of u32, so it maybe need to convert the endianness order > to ensure that the value assig

[PATCH v1 1/1] iavf: document limitation on MTU

When configuring a port, the configured MTU will not include VLAN tag size, but the physical function driver will add it automatically if the port has VLAN filtering configured, which may result in seemingly valid MTU to be rejected by the PF. Document the limitation. Signed-off-by: Anatoly Burak

[DPDK/ethdev Bug 1400] net/ena: Failed to initialize ENA device

https://bugs.dpdk.org/show_bug.cgi?id=1400 Bug ID: 1400 Summary: net/ena: Failed to initialize ENA device Product: DPDK Version: 23.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major

Re: [PATCH v4 13/31] net/ena/base: malformed Tx descriptor error reason

On 3/12/2024 6:06 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > Adding ENA_REGS_RESET_TX_DESCRIPTOR_MALFORMED to identify > cases where the returned TX completion descriptors are > corrupted. > "error reason"? Or "reset reason"? Updating title as: "net/ena/base: add malformed Tx desc

Re: [PATCH v4 15/31] net/ena/base: restructure interrupt handling

On 3/12/2024 6:07 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > When invoking an admin command, in interrupt mode, if the interrupt > is received after timeout and also after the calling function finished > running, the response will be written into a memory that is no longer > valid. >

Re: [PATCH v4 05/31] net/ena: fix fast mbuf free

On 3/12/2024 6:06 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > In case the application enables fast mbuf release optimization, > the driver releases 256 TX mbufs in bulk upon reaching the > TX free threshold. > The existing implementation utilizes rte_mempool_put_bulk for bulk > freein

Re: [PATCH v4 24/31] net/ena: cosmetic changes

On 3/12/2024 6:07 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > This patch makes several changes to improve > the style and readability of the code. > > Signed-off-by: Shai Brandes > Reviewed-by: Amit Bernstein Updated patch title while merging, as: net/ena: improve style and reada

Re: [PATCH v4 07/31] net/ena/base: limit exponential backoff exp

On 3/12/2024 6:06 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > Limit the value of the exponent used for this backoff > at (1<<16) to prevent it from reaching to an excessive > value (1<<32) or potentially even overflowing. > In addition, for uniformity and readability purposes, > the m

Re: [PATCH v4 08/31] net/ena/base: add a new csum offload bit

On 3/12/2024 6:06 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > Add a new driver supported feature bit for TX IPv6 checksum offload. > > Signed-off-by: Shai Brandes > Reviewed-by: Amit Bernstein > updated patch title as: net/ena/base: add IPv6 checksum offload feature

Re: [PATCH v4 03/31] net/ena: update imissed stat with Rx overruns

On 3/12/2024 6:06 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > Depending on its acceleration support, the device updates > a different statistic when an ingress packet is dropped > because no buffers are available to hold it. > - In AWS instance types from later generations > 'rx_overr

Re: [PATCH v4 00/31] net/ena: v2.9.0 driver release

On 3/12/2024 6:06 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > Hi all, the ena v2.9.0 release introduces: > 1. HAL upgrade: >- renamed the 'base' folder to be 'hal' >- separated the HAL patches instead of a bulk update. > 2. Restructured ena stats and metrics. > 3. Restructured

RE: [PATCH v2] app/test: fix rsa tests in qat suite

> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, March 13, 2024 9:14 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Power, Ciara ; Kusztal, > ArkadiuszX ; sta...@dpdk.org > Subject: [PATCH v2] app/test: fix rsa tests in qat suite > > This commit fixes incorrectly se

Re: [PATCH v2 1/5] app/test-mp: add multiprocess test

On 3/7/2024 8:01 AM, Artemy Kovalyov wrote: This commit adds a test scenario that initiates multiple processes concurrently. These processes attach to the same shared heap, with an automatic detection mechanism to identify the primary process. Signed-off-by: Artemy Kovalyov --- Acked-by: Anato

Re: [PATCH v2 2/5] eal: fix multiprocess hotplug race

On 3/7/2024 8:01 AM, Artemy Kovalyov wrote: There exists a time gap between the creation of the multiprocess channel and the registration of request action handlers. Within this window, a secondary process that receives an eal_dev_mp_request broadcast notification might respond with ENOTSUP. This

Re: [PATCH v2 3/5] ipc: fix mp channel closure to prevent message loss

On 3/7/2024 8:01 AM, Artemy Kovalyov wrote: This commit addresses an issue related to the cleanup of the multiprocess channel. Previously, when closing the channel, there was a risk of losing trailing messages. This issue was particularly noticeable when broadcast message from primary to secondar

Re: [PATCH v2 4/5] eal: fix first time primary autodetect

On 3/7/2024 8:01 AM, Artemy Kovalyov wrote: If the configuration file is absent, the autodetection function should generate and secure it. Otherwise, multiple simultaneous openings could erroneously identify themselves as primary instances. Fixes: af75078fece3 ("first public release") Cc: sta...

Re: [PATCH v2 5/5] eal: fix memzone fbarray cleanup

On 3/7/2024 8:01 AM, Artemy Kovalyov wrote: The initialization of the Memzone file-backed array ensures its uniqueness by employing an exclusive lock. This is crucial because only one primary process can exist per specific shm_id, which is further protected by the exclusive EAL runtime configurat

Re: [PATCH 2/4] app/testpmd: fix burst option parsing

On Wed, 13 Mar 2024 12:09:01 + Ferruh Yigit wrote: > > Which is really close to the existing log message. > > > > if (rec_nb_pkts == 0) > > rte_exit(EXIT_FAILURE, > >

Re: [PATCH 4/4] app/testpmd: enhance getopt_long usage

On Tue, Mar 12, 2024 at 6:03 PM Ferruh Yigit wrote: > > On 3/8/2024 2:48 PM, David Marchand wrote: > > This is a cleanup similar to previous ones in EAL and examples. > > Instead of using strcmp for every long options while getopt_long already > > did such parsing, rely on getopt_long return value

[PATCH] drivers/net/gve: add IPv4 checksum offloading capability

Gvnic's DQO format allows offloading IPv4 checksum. Made changes to Tx and Rx path to translate DPDK flags to descriptor for offloading (and vice-versa). Add ptype adminq support to only add this flags for supported L3/L4 packet-types. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington -

[PATCH] drivers/net/gve: add IPv4 checksum offloading capability

Gvnic's DQO format allows offloading IPv4 checksum. Made changes to Tx and Rx path to translate DPDK flags to descriptor for offloading (and vice-versa). Add ptype adminq support to only add this flags for supported L3/L4 packet-types. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington -

RE: [PATCH v4 00/31] net/ena: v2.9.0 driver release

Thank you Ferruh, I know it was last minute patchset. We appreciate your effort! All the best, Shai בתאריך 13 במרץ 2024 18:00,‏ Ferruh Yigit כתב: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the

Re: [PATCH 4/4] app/testpmd: enhance getopt_long usage

On Wed, Mar 13, 2024 at 5:51 PM David Marchand wrote: > > > > > + { TESTPMD_OPT_ETH_PEERS_CONFIGFILE, 1, NULL, > > > TESTPMD_OPT_ETH_PEERS_CONFIGFILE_NUM }, > > > + { TESTPMD_OPT_ETH_PEER, 1, NULL, TESTPMD_OPT_ETH_PEER_NUM }, > > > > > > > These long options are within "#ifdef RTE_LIB_CMD

RE: [PATCH v3 1/1] net/mana: add vlan tagging support

> Subject: [PATCH v3 1/1] net/mana: add vlan tagging support > > For tx path, use LONG_PACKET_FORMAT if vlan tag is present. For rx, extract > vlan > id from oob, put into mbuf and set the vlan flags in mbuf. > > Signed-off-by: Wei Hu Acked-by: Long Li > --- > > v3: > - Adjust the pkt_idx p

RE: RFC: Using and renaming 8-bit reserved field of rte_crypto_op for implementation specific

Hi Ganapati, >> Is it not possible to use rte_event_crypto_adapter_enqueue >> if you want to send the event context to cryptodev? > [Ganapati] No, event crypto adapter sends only ev::event_ptr as rte_crypto_op > to cryptodev and not event context. >> While using rte_cryptodev_enqueue() all pre

Re: [PATCH 0/2] fix problems about flow steering

On 3/12/2024 8:02 AM, Chaoyong He wrote: > This patch series fix some problems exist in the flow steering logic. > > Long Wu (2): > net/nfp: fix IP flow rule failed > net/nfp: fix incorrect queue index > Series applied to dpdk-next-net/main, thanks.

RE: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc algorithm

> Because net crc api is not thread-safe, setting crc algorithm > by the application will prevent race condition in the calc function. > Race condition still may occur when any of the threads will call this > function again. Function is called with the highest possible SIMD > extension, which is AV

RE: [EXTERNAL] [PATCH 1/2] examples/ipsec-secgw: fix SA salt endianness problem

> Subject: [EXTERNAL] [PATCH 1/2] examples/ipsec-secgw: fix SA salt endianness > problem > From: Shihong Wang > > The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s > value is stored in an array of encryption or authentication keys > according to big-endian. So it maybe need to

Re: [PATCH v3 1/1] net/mana: add vlan tagging support

Recheck-request: iol-broadcom-Performance I am seeing some increased throughput variance on this NIC recently (may be related to upgrading device firmware). The Community Lab team will look. This fail can be ignored of course, and should be overwritten once the retest is picked up.

  1   2   >