On 3/10/2024 3:08 PM, Brandes, Shai wrote: > > >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yi...@amd.com> >> Sent: Friday, March 8, 2024 7:25 PM >> To: Brandes, Shai <shaib...@amazon.com> >> Cc: dev@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v3 10/33] net/ena/hal: added a bus >> parameter to ena memcpy macro >> >> CAUTION: This email originated from outside of the organization. Do not click >> links or open attachments unless you can confirm the sender and know the >> content is safe. >> >> >> >> On 3/6/2024 12:24 PM, shaib...@amazon.com wrote: >>> From: Shai Brandes <shaib...@amazon.com> >>> >>> ENA_MEMCPY_TO_DEVICE_64 macro needs pci bus id in order to write to >>> the device memory when using llq. >>> >> >> As far as I can see macro doesn't use 'bus' at all, "(void)(bus);", how/why >> it is >> needed for LLQ? Can you please describe it more? > [Brandes, Shai] I understand the confusion. > This is part of a hal change that concerns mac OS and required to modify the > common ENA_MEMCPY_TO_DEVICE_64. > Since we expose only the DPDK-specific implementation, where this parameter > is unused, it appears as void. > Avoiding this will create differences between the internal and upstream > versions which will make it hard to maintain. >
It is OK to have it, as you said to reduce the diff, but please update the commit log with above detail, and it will be OK.
