RE: [PATCH v2 0/3] net/ice: simplified to 3 layer Tx scheduler

> -Original Message- > From: Zhang, Qi Z > Sent: Friday, January 5, 2024 10:11 PM > To: Yang, Qiming ; Wu, Wenjun1 > > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2 0/3] net/ice: simplified to 3 layer Tx scheduler > > Remove dummy layers, code refactor, complete document > > Qi Zh

[PATCH v2 0/2] net/cpfl: support flow offloading for P4

From: Wenjing Qiao Enable TDI flow engine which can program hardware offloading rules for a P4 programmable network controller. Wenjing Qiao (2): net/cpfl: parse flow offloading hint from P4 context file net/cpfl: add TDI to flow engine v2: - fix typos. - parse vsi id for key. doc/guides/

[PATCH v2 1/2] net/cpfl: parse flow offloading hint from P4 context file

From: Wenjing Qiao To supporting P4-programmed network controller, reuse devargs "flow_parser" to specify the path of a p4 context JSON configure file. The cpfl PMD use the JSON configuration file to translate rte_flow tokens into low level hardware representation. Note, the p4 context JSON file

[PATCH v2 2/2] net/cpfl: add TDI to flow engine

From: Wenjing Qiao Add TDI implementation to a flow engine. Signed-off-by: Wenjing Qiao --- doc/guides/nics/cpfl.rst| 10 + doc/guides/nics/features/cpfl.ini |1 + drivers/net/cpfl/cpfl_ethdev.h |8 + drivers/net/cpfl/cpfl_flow.c|5 +- d

RE: [PATCH v2 2/3] net/ice: refactor tm config data structure

> -Original Message- > From: Zhang, Qi Z > Sent: Friday, January 5, 2024 10:11 PM > To: Yang, Qiming ; Wu, Wenjun1 > > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2 2/3] net/ice: refactor tm config data structure > > Simplified struct ice_tm_conf by removing per level node list.

Re: [EXT] [PATCH v6 05/20] net/dpaa2: used dedicated logtype not PMD

What is the log level of DPAA2_PMD_INFO? I expect to print information by this as default. 获取 Outlook for iOS 发件人: Stephen Hemminger 发送时间: 星期六, 十二月 23, 2023 01:18 收件人: dev@dpdk.org 抄送: Stephen Hemminger ; Hemant Agrawal ; Sachin Saxena ;

[PATCH v2 1/2] telemetry: correct json empty dictionaries

Fix to allow telemetry to handle empty dictionaries correctly. This patch resolves an issue where empty dictionaries are reported by telemetry as '[]' rather than '{}'. Initializing the output buffer based on the container type resolves the issue. Signed-off-by: Jonathan Erb --- .mailmap

[PATCH v2 2/2] telemetry: correct json empty dictionaries

Fix use of incorrect enum name. Signed-off-by: Jonathan Erb --- lib/telemetry/telemetry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c index 0788a32210..eef4ac7bb7 100644 --- a/lib/telemetry/telemetry.c +++ b/lib/teleme

Re: [PATCH] dts: improve documentation

On 04/01/2024 10:52, Thomas Monjalon wrote: DTS needs to know which nodes to connect to and what hardware to use on those nodes. -Once that's configured, DTS needs a DPDK tarball and it's ready to run. +Once that's configured, DTS needs a DPDK tarball or a git ref ID and it's ready to run.

RE: [PATCH v4 1/2] net/mlx5/hws: add support for random number match

> -Original Message- > From: Michael Baum > Sent: Monday, December 25, 2023 11:25 > To: dev@dpdk.org > Cc: Matan Azrad ; Dariusz Sosnowski > ; Raslan Darawsheh ; Slava > Ovsiienko ; Ori Kam ; > Suanming Mou ; Erez Shitrit > Subject: [PATCH v4 1/2] net/mlx5/hws: add support for random numb

Minutes of Technical Board Meeting, 2023-December-13

Minutes of Technical Board Meeting, 2023-December-13 Members Attending - -Aaron -Hemant -Jerin (Chair) -Kevin -Konstantin -Maxime -Morten -Stephen -Thomas NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and

[PATCH] common/cnxk: update MACsec pkt ok count

In case of 103xx platform, the packet unchecked count is same as packet ok count when validate frames is set in secy configuration. And when validate frames is not set, then also unchecked count can be treated as ok count. Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_mcs_stats.c | 5 ++

Re: [dpdk-dev] [RFC] ethdev: support Tx queue free descriptor query

On Fri, Jan 5, 2024 at 4:04 AM Thomas Monjalon wrote: > > 19/12/2023 18:29, jer...@marvell.com: > > --- a/doc/guides/nics/features/default.ini > > +++ b/doc/guides/nics/features/default.ini > > @@ -59,6 +59,7 @@ Packet type parsing = > > > > Timesync = > > Rx descriptor status = > >

Re: [dpdk-dev] [RFC] ethdev: support Tx queue free descriptor query

On Thu, Jan 4, 2024 at 11:59 PM Thomas Monjalon wrote: > > 04/01/2024 15:21, Konstantin Ananyev: > > > > > > > Introduce a new API to retrieve the number of available free > > > > > descriptors > > > > > in a Tx queue. Applications can leverage this API in the fast path to > > > > > inspect the T

[PATCH] app/test-crypto-perf: add throughput OOP decryption

During throughput running, re-filling the test data will impact the performance test result. So for now, to run decrypt throughput testing is not supported since the test data is not filled. But if user requires OOP(out-of-place) mode, the test data from source mbuf will never be modified, and if

Re: [dpdk-dev] [RFC] ethdev: support Tx queue free descriptor query

05/01/2024 10:54, Jerin Jacob: > On Fri, Jan 5, 2024 at 4:04 AM Thomas Monjalon wrote: > > > > 19/12/2023 18:29, jer...@marvell.com: > > > --- a/doc/guides/nics/features/default.ini > > > +++ b/doc/guides/nics/features/default.ini > > > @@ -59,6 +59,7 @@ Packet type parsing = > > > > > > Timesyn

Re: [dpdk-dev] [RFC] ethdev: support Tx queue free descriptor query

05/01/2024 10:57, Jerin Jacob: > On Thu, Jan 4, 2024 at 11:59 PM Thomas Monjalon wrote: > > > > 04/01/2024 15:21, Konstantin Ananyev: > > > > > > > > > Introduce a new API to retrieve the number of available free > > > > > > descriptors > > > > > > in a Tx queue. Applications can leverage this AP

[PATCH v10] net/iavf: add diagnostic support in TX path

The only way to enable diagnostics for TX paths is to modify the application source code. Making it difficult to diagnose faults. In this patch, the devarg option "mbuf_check" is introduced and the parameters are configured to enable the corresponding diagnostics. supported cases: mbuf, size, seg

[PATCH v4] net/i40e: add diagnostic support in TX path

The only way to enable diagnostics for TX paths is to modify the application source code. Making it difficult to diagnose faults. In this patch, the devarg option "mbuf_check" is introduced and the parameters are configured to enable the corresponding diagnostics. supported cases: mbuf, size, seg

[PATCH v2] net/ice: add diagnostic support in TX path

The only way to enable diagnostics for TX paths is to modify the application source code. Making it difficult to diagnose faults. In this patch, the devarg option "mbuf_check" is introduced and the parameters are configured to enable the corresponding diagnostics. supported cases: mbuf, size, seg

RE: [dpdk-dev] [RFC] ethdev: support Tx queue free descriptor query

> -Original Message- > From: Thomas Monjalon > Sent: Friday, January 5, 2024 10:04 AM > To: Jerin Jacob > Cc: Dumitrescu, Cristian ; Konstantin Ananyev > ; > jer...@marvell.com; dev@dpdk.org; Ferruh Yigit ; Andrew > Rybchenko ; > ferruh.yi...@xilinx.com; ajit.khapa...@broadcom.com; ab

[PATCH v1] net/axgbe: read and save the port property register

From: Venkat Kumar Ande Read and save the port property registers once during the device probe and then use the saved values as they are needed. Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_ethdev.c | 21 + drivers/net/axgbe/axgbe_ethdev.h | 7 +++ drivers/net/axgb

[dpdk-dev] [v3] doc: define qualification criteria for external library

From: Jerin Jacob Define qualification criteria for external library based on a techboard meeting minutes [1] and past learnings from mailing list discussion. [1] http://mails.dpdk.org/archives/dev/2019-June/135847.html https://mails.dpdk.org/archives/dev/2024-January/284849.html Signed-off-by:

Re: [dpdk-dev] [v3] doc: define qualification criteria for external library

05/01/2024 13:12, jer...@marvell.com: > From: Jerin Jacob > > Define qualification criteria for external library > based on a techboard meeting minutes [1] and past > learnings from mailing list discussion. > > [1] > http://mails.dpdk.org/archives/dev/2019-June/135847.html > https://mails.dpdk.o

[dpdk-dev] [v4] doc: define qualification criteria for external library

From: Jerin Jacob Define qualification criteria for external library based on a techboard meeting minutes [1] and past learnings from mailing list discussion. [1] http://mails.dpdk.org/archives/dev/2019-June/135847.html https://mails.dpdk.org/archives/dev/2024-January/284849.html Signed-off-by:

[PATCH v3 0/3] net/ice: simplified to 3 layer Tx scheduler

Remove dummy layers, code refactor, complete document v3: - fix tm_node memory free. - fix corrupt when slibling node deletion is not in a reversed order. v2: - fix typos. Qi Zhang (3): net/ice: hide port and TC layer in Tx sched tree net/ice: refactor tm config data structure doc: update

[PATCH v3 1/3] net/ice: hide port and TC layer in Tx sched tree

In currently 5 layer tree implementation, the port and tc layer is not configurable, so its not necessary to expose them to application. The patch hides the top 2 layers and represented the root of the tree at VSI layer. From application's point of view, its a 3 layer scheduler tree: Port -> Queu

[PATCH v3 2/3] net/ice: refactor tm config data structure

Simplified struct ice_tm_conf by removing per level node list. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_ethdev.h | 5 +- drivers/net/ice/ice_tm.c | 244 --- 2 files changed, 111 insertions(+), 138 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.

[PATCH v3 3/3] doc: update ice document for qos

Add description for ice PMD's rte_tm capabilities. Signed-off-by: Qi Zhang Acked-by: Wenjun Wu --- doc/guides/nics/ice.rst | 19 +++ 1 file changed, 19 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index bafb3ba022..3d381a266b 100644 --- a/doc/gui

RE: [PATCH] net/ice: refine queue start stop

> -Original Message- > From: Wu, Wenjun1 > Sent: Friday, January 5, 2024 2:03 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/ice: refine queue start stop > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Friday, January 5, 2024 9:37

[Bug 1342] net/i40e rejects packet without any Tx offload on Tx prepare

https://bugs.dpdk.org/show_bug.cgi?id=1342 Bug ID: 1342 Summary: net/i40e rejects packet without any Tx offload on Tx prepare Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRME

[Bug 1343] net/i40e does not drop packet with too many segments

https://bugs.dpdk.org/show_bug.cgi?id=1343 Bug ID: 1343 Summary: net/i40e does not drop packet with too many segments Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

RE: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.

Hi Stephen, The BPF helper man pages implies in that way and the SKB data pointer access was working till 5.4 kernel also, however from Kernel-5.15 version, we do see eBPF verifier throws error when we use SKB data pointer access. So, I had used this helper functions and able to resolve the erro

RE: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.

Hi Stephen, As part of hash calculation logic, the hash value is going beyond 32-bits and thus the eBPF verifier throws error with the 32-bit hash variable. So, I need to modify as 64-bit hash variable to resolve the BPF verifier error. Here, in the code this rte_softrss_be() function is returni

RE: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.

Sure, will update accordingly. Thanks, Madhuker. -Original Message- From: Stephen Hemminger Sent: 05 January 2024 02:02 To: Madhuker Mythri Cc: ferruh.yi...@amd.com; dev@dpdk.org Subject: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade

RE: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.

By using this " bpf_skb_load_bytes_relative()" helper function we can directly retrieve the Network header data fields, so we no need to check for L2-header VLAN presence. Thanks, Madhuker. -Original Message- From: Stephen Hemminger Sent: 05 January 2024 02:11 To: Madhuker Mythri Cc:

Re: [PATCH] build: riscv is not a valid -march value

On Wed, Nov 22, 2023 at 5:41 PM David Marchand wrote: > > On Wed, Nov 22, 2023 at 5:17 PM Bruce Richardson > wrote: > > > > On Wed, Nov 22, 2023 at 05:02:56PM +0100, David Marchand wrote: > > > On Tue, Nov 21, 2023 at 5:49 PM wrote: > > > > > > > > From: Christian Ehrhardt > > > > > > > > If bu

[PATCH] doc: fix test eventdev example commands

From: Pavan Nikhilesh Fix incorrect core masks in testeventdev example commands. Fixes: f6dda59153f1 ("doc: add order queue test in eventdev test guide") Fixes: dd37027f2ba6 ("doc: add order all types queue test in eventdev test guide") Fixes: 43bc2fef79cd ("doc: add perf queue test in eventdev

Re: [PATCH] doc: update default value for config parameter

On Fri, Jan 05, 2024 at 10:44:17AM +0800, Simei Su wrote: > Update documentation value to match default value in code base. > > Signed-off-by: Simei Su > --- Acked-by: Tyler Retzlaff

Re: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.

On Fri, 5 Jan 2024 14:44:00 + Madhuker Mythri wrote: > Hi Stephen, > > The BPF helper man pages implies in that way and the SKB data pointer access > was working till 5.4 kernel also, however from Kernel-5.15 version, we do see > eBPF verifier throws error when we use SKB data pointer acce

Re: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.

On Fri, 5 Jan 2024 14:58:22 + Madhuker Mythri wrote: > Hi Stephen, > > As part of hash calculation logic, the hash value is going beyond 32-bits and > thus the eBPF verifier throws error with the 32-bit hash variable. > So, I need to modify as 64-bit hash variable to resolve the BPF verifie

Re: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.

On Fri, 5 Jan 2024 15:11:22 + Madhuker Mythri wrote: > By using this " bpf_skb_load_bytes_relative()" helper function we can > directly retrieve the Network header data fields, so we no need to check for > L2-header VLAN presence. > > Thanks, > Madhuker. No problem, the vlan code was alre

Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.

On Thu, 4 Jan 2024 22:57:56 +0530 madhuker.myt...@oracle.com wrote: > adhuker Mythri > > When multiple queues configured, internally RSS will be enabled and thus TAP > BPF RSS byte-code will be loaded on to the Kernel using BPF system calls. > > Here, the problem is loading the existing BPF b

[PATCH v4 0/4] changes for 24.03

v4: Targeting 24.03. Updated FPGA PMD based on review comments. v3: Made changes requested during review. v2: Targeting 23.11. Update in commits 1,2 based on review comments. v1: Targeting 23.07 if possible. Add support for AGX100 (N6000) and corner case fixes. Hernan Vargas (4): baseband/fpga_

[PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency

Rename generic functions and constants using the FPGA 5GNR prefix naming to prepare for code reuse for new FPGA implementation variant. No functional impact. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 117 +++-- .../fpga_5gnr_fe

[PATCH v4 2/4] baseband/fpga_5gnr_fec: add Vista Creek variant

Create a new file vc_5gnr_pmd.h to store structures and macros specific to Vista Creek 5G FPGA implementation and rename functions specific to the Vista Creek variant. Signed-off-by: Hernan Vargas --- .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 183 ++- .../fpga_5gnr_fec/rte_fpga_5gnr_fe

[PATCH v4 3/4] baseband/fpga_5gnr_fec: add AGX100 support

Add support for new FPGA variant AGX100 (on Arrow Creek N6000). Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/fpga_5gnr_fec.rst | 76 +- drivers/baseband/fpga_5gnr_fec/agx100_pmd.h | 273 .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 12 +- .../fpga_5gnr_fec/rte_fpga

[PATCH v4 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes

Cosmetic changes for comments. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/fpga_5gnr_fec/agx100_pmd.h | 4 +- .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 49 ++-- .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 248 +- .../fpga_5gnr_fec/rte_pm

Re: [PATCH v4 1/4] baseband/fpga_5gnr_fec: renaming for consistency

On Fri, 5 Jan 2024 13:15:16 -0800 Hernan Vargas wrote: > +#define FPGA_5GNR_QUEUE_FLUSH_TIMEOUT_US (1000) Just my opinion, no need it doesn't have to change but. These variable names are getting quite long which doesn't improve readability.

[RFC 0/5] BPF infrastructure enhancements

While investigating the BPF program load in TAP device found a number of minor issues that should be addressed. Stephen Hemminger (5): tap: move forward declaration of bpf_load tap: remove unnecessary bzero() calls in bpf api tap: remove unnecessary cast in call to bpf_load tap: get errors

[RFC 1/5] tap: move forward declaration of bpf_load

The local function bpf_load forward declaration should be in the one file using it. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_bpf.h | 3 --- drivers/net/tap/tap_bpf_api.c | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/tap/tap_bpf.h b/driver

[RFC 2/5] tap: remove unnecessary bzero() calls in bpf api

The structures are already fully initialized, bzero() or memset is redundant. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_bpf_api.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/tap/tap_bpf_api.c b/drivers/net/tap/tap_bpf_api.c index a6adec855dda..d176da0802eb 1

[RFC 3/5] tap: remove unnecessary cast in call to bpf_load

The callers already have the correct data type. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_bpf_api.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/tap/tap_bpf_api.c b/drivers/net/tap/tap_bpf_api.c index d176da0802eb..c754c167a764 100644

[RFC 4/5] tap: get errors from kernel on bpf load failure

The bpf load kernel API can provide some useful diagnostics on failure. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_bpf_api.c | 44 +++ drivers/net/tap/tap_flow.c| 16 - drivers/net/tap/tap_flow.h| 4 ++-- 3 files changed, 46 inse

[RFC 5/5] tap: stop "vendoring" linux bpf header

The proper place for finding bpf structures and functions is in linux/bpf.h. The original version was trying to workaround the case where the build environment was running on old pre BPF version of Glibc, but the target environment had BPF. This is not a supportable build method, and not how rest o

RE: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.

The flow creation worked well for us on the Azure/Hyper-V platform using failsafe/tap PMD, using Kernel-5.15.0 and 5.4 versions. So, does the original/existing code works well on Kernel-6.5 version ? Thanks, Madhuker. -Original Message- From: Stephen Hemminger Sent: 06 January 2024 01

RE: [External] : Re: [PATCH] net/tap: Modified TAP BPF program as per the new Kernel-version upgrade requirements.

I had tested with 5.4 and 5.15 kernel-versions with this new changes and works well. I found that the helper functions were introduced in Kernel 4.7 version. So, thinking this code should work from Kernel-4.9, as mentioned in the TAP PMD link: https://doc.dpdk.org/guides/nics/tap.html. Yes, I u