05/01/2024 13:12, jer...@marvell.com: > From: Jerin Jacob <jer...@marvell.com> > > Define qualification criteria for external library > based on a techboard meeting minutes [1] and past > learnings from mailing list discussion. > > [1] > http://mails.dpdk.org/archives/dev/2019-June/135847.html > https://mails.dpdk.org/archives/dev/2024-January/284849.html [...] > +#. **Documentation:** > + > + - Must have adequate documentation for the steps to build it. > + - Must have clear license documentation on distribution and usage aspects > of external library. > + > +#. **Free availability:** > + > + - The library must be freely available to build in either source or > binary form. > + - It shall be downloadable from a direct link. There shall not be any > requirement to explicitly > + login or sign a user agreement. > + > +#. **Usage License:** > + > + - Both permissive (e.g., BSD-3 or Apache) and non-permissive (e.g., > GPLv3) licenses are acceptable. > + - In the case of a permissive license, automatic inclusion in the build > process is assumed. > + For non-permissive licenses, an additional build configuration option > is required. > + > +#. **Distributions License:** > + > + - No specific constraints beyond documentation. > + > +#. **Compiler compatibility:** > + > + - The library must be able to compile with a DPDK supported compiler for > the given execution > + environment. For example, For Linux, the library must be able to > compile with GCC and/or clang.
Please go to next line when starting a sentence. There is an extra uppercasing in "For Linux". > + - Library may be limited to a specific OS. > + > +#. **Meson build integration:** > + > + - The library must have standard method like ``pkg-config`` for seamless > integration with > + DPDK's build environment. > + > +#. **Code readability:** > + > + - Optional dependencies should use stubs to minimize ``ifdef`` clutter, > promoting improved > + code readability. Acked-by: Thomas Monjalon <tho...@monjalon.net>
