Re: [PATCH v3 09/12] baseband/acc: add FFT support to VRB2 variant

2023-10-04 Thread Maxime Coquelin
On 10/3/23 20:20, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Tuesday, October 3, 2023 7:37 AM To: Chautru, Nicolas ; dev@dpdk.org Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan Subject: Re: [PATCH v3 09/12] baseband/acc:

Re: [PATCH v3 06/12] baseband/acc: refactor to allow unified driver extension

2023-10-04 Thread Maxime Coquelin
On 10/3/23 20:54, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Tuesday, October 3, 2023 6:15 AM To: Chautru, Nicolas ; dev@dpdk.org Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan Subject: Re: [PATCH v3 06/12] baseband/acc:

Re: [dpdk-dev] [PATCH] common/cnxk: fix direct rte symbol usage

2023-10-04 Thread David Marchand
On Wed, Oct 4, 2023 at 8:43 AM Jerin Jacob wrote: > > > diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c > > > b/drivers/common/cnxk/roc_nix_inl_dev.c > > > index 6aa191410b..614d0858e5 100644 > > > --- a/drivers/common/cnxk/roc_nix_inl_dev.c > > > +++ b/drivers/common/cnxk/roc_nix_inl_dev.c >

Re: [dpdk-dev] [PATCH] common/cnxk: fix direct rte symbol usage

2023-10-04 Thread Jerin Jacob
On Wed, Oct 4, 2023 at 1:06 PM David Marchand wrote: > > On Wed, Oct 4, 2023 at 8:43 AM Jerin Jacob wrote: > > > > diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c > > > > b/drivers/common/cnxk/roc_nix_inl_dev.c > > > > index 6aa191410b..614d0858e5 100644 > > > > --- a/drivers/common/cnxk/roc_

Re: [PATCH v3 02/12] baseband/acc: add FFT window width in the VRB PMD

2023-10-04 Thread Maxime Coquelin
On 10/3/23 21:06, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Tuesday, October 3, 2023 4:52 AM To: Chautru, Nicolas ; dev@dpdk.org Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan Subject: Re: [PATCH v3 02/12] baseband/acc:

Re: [PATCH v2 1/2] random: initialize the random state for non-EAL threads

2023-10-04 Thread David Marchand
On Mon, Oct 2, 2023 at 2:28 PM Mattias Rönnblom wrote: > > On 2023-09-07 17:24, Stephen Hemminger wrote: > > The per-lcore PRNG was not initializing the rand_state of all > > the lcores. Any usage of rte_random by a non-EAL lcore would > > "/../ by an unregistered non-EAL thread /../" > > > use ra

Re: [PATCH v2] net/axgbe: use CPUID to identify cpu

2023-10-04 Thread David Marchand
Hello Selwin, On Tue, Oct 3, 2023 at 1:40 PM Selwin Sebastian wrote: > > Using root complex to identify cpu will not work for vm passthrough. > CPUID is used to get family and modelid to identify cpu > > Fixes: b0db927b5eba ("net/axgbe: use PCI root complex device to distinguish > device") > Cc:

RE: [PATCH v2] app/dma-perf: fix physical address seg-fault

2023-10-04 Thread Varghese, Vipin
[AMD Official Use Only - General] Hi Jerrin, Apologies for the delay, I missed on the comment ``` > for (i = 0; i < nr_buf; i++) { > + void *src = rte_pktmbuf_mtod(dsts[i], void *); > + void *dst = rte_pktmbuf_mtod(srcs[i], void *); Us

RE: [RFC] cryptodev: refactor sm2, add plain message flag

2023-10-04 Thread Power, Ciara
Hi Akhil, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, August 11, 2023 6:40 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Power, Ciara > ; Kusztal, ArkadiuszX > Subject: [RFC] cryptodev: refactor sm2, add plain message flag > > SM2 asymmetric crypto opera

[PATCH v2 0/4] support offload of simple conntrack flow rules

2023-10-04 Thread Chaoyong He
This patch series add the support of simple conntrack flow rules offload through flower firmware by import the needed data structure and logic of flow merge. --- v2: * Fix one mis-spell in comment. * Revise logic and document to solve the 'devtools/check-doc-vs-code.sh' warning. * Adjust the com

[PATCH v2 1/4] net/nfp: prepare for the flow merge

2023-10-04 Thread Chaoyong He
Move data structure and macro from source file to header file. Export the needed function to header file. We add two more parameter for 'nfp_flow_process()' to prepare for the flow merge. The 'cookie' moved as parameter is because the flow merge logic need this cookie. The 'install' parameter is n

[PATCH v2 2/4] net/nfp: add infrastructure for conntrack flow merge

2023-10-04 Thread Chaoyong He
Add the logic to process the merge of items and actions of pre_ct and post_ct flow. The result will be stored in a field of merged flow. Signed-off-by: Chaoyong He --- doc/guides/nics/features/nfp.ini |2 + drivers/net/nfp/flower/nfp_conntrack.c | 1616 drivers

[PATCH v2 3/4] net/nfp: add call to add and delete the flows to firmware

2023-10-04 Thread Chaoyong He
Add the offload call to add and delete the flows to the firmware. Signed-off-by: Chaoyong He --- drivers/net/nfp/flower/nfp_conntrack.c | 112 - drivers/net/nfp/flower/nfp_conntrack.h | 5 ++ drivers/net/nfp/nfp_flow.c | 8 ++ 3 files changed, 122 insertio

[PATCH v2 4/4] net/nfp: add support for merged flows and conntrack stats

2023-10-04 Thread Chaoyong He
Adjust the original logic to make it valid for both normal flow and merged flow. Add the logic to update conntrack flow stats. Add the support of conntrack action. Signed-off-by: Chaoyong He --- drivers/net/nfp/flower/nfp_conntrack.c | 54 -- drivers/net/nfp/flower/nfp_conntrack.

RE: [PATCH v2] net/axgbe: use CPUID to identify cpu

2023-10-04 Thread Sebastian, Selwin
[AMD Official Use Only - General] Hi David, Thank you, I will push the updated patch soon. -Original Message- From: David Marchand Sent: Wednesday, October 4, 2023 2:27 PM To: Sebastian, Selwin Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org Subject: Re: [PATCH v2] net/axgbe: use CPUI

RE: [PATCH v3] bus/cdx: provide driver flag for optional resource mapping

2023-10-04 Thread Gangurde, Abhijit
[AMD Official Use Only - General] > wrote: > > @@ -383,10 +384,12 @@ cdx_probe_one_driver(struct rte_cdx_driver *dr, > > CDX_BUS_DEBUG(" probe device %s using driver: %s", dev_name, > > dr->driver.name); > > > > - ret = cdx_vfio_map_resource(dev); > > - if (re

[PATCH v3] net/axgbe: use CPUID to identify cpu

2023-10-04 Thread Selwin Sebastian
Using root complex to identify cpu will not work for vm passthrough. CPUID is used to get family and modelid to identify cpu Fixes: b0db927b5eba ("net/axgbe: use PCI root complex device to distinguish device") Cc: sta...@dpdk.org Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_ethd

RE: [PATCH v2 0/5] add TLS record processing security offload

2023-10-04 Thread Akhil Goyal
Hi Harry, Do you have any further comments on this series? Regards, Akhil > -Original Message- > From: Anoob Joseph > Sent: Tuesday, October 3, 2023 4:19 PM > To: Thomas Monjalon ; Akhil Goyal > ; Jerin Jacob Kollanukkaran ; Harry > van Haaren > Cc: Konstantin Ananyev ; Hemant Agrawal

[PATCH] random: clarify PRNG MT safety guarantees

2023-10-04 Thread Mattias Rönnblom
Clarify MT safety guarantees for unregistered non-EAL threads calling PRNG functions in rte_random.h. Clarify that rte_srand() is not MT safe in regards to calls to rte_rand_max() and rte_drand(). Signed-off-by: Mattias Rönnblom Suggested-by: Stephen Hemminger --- lib/eal/include/rte_random.h

RE: [PATCH v1 1/1] app/mldev: fix file and buffer handling

2023-10-04 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Wednesday, September 20, 2023 12:40 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Anup Prabhu ; > Prince Takkar ; sta...@dpdk.org > Subject: [PATCH v1 1/1] app/mldev: fix file and buffer h

Re: [PATCH v1 1/1] eal/random: fix random state initialization for non-eal threads

2023-10-04 Thread Burakov, Anatoly
On 10/2/2023 9:25 AM, David Marchand wrote: Hello guys, On Mon, Aug 28, 2023 at 2:07 PM Anatoly Burakov wrote: Currently, the rte_rand() state is initialized with seed, and each rand state is initialized up until RTE_MAX_LCORE'th rand state. However, rand state also has one extra rand state r

Re: [PATCH v3 0/4] rte_ether_unformat_addr related changes

2023-10-04 Thread Ferruh Yigit
On 10/3/2023 9:29 PM, Stephen Hemminger wrote: > This patchset makes rte_ether_unformat_addr allow other formats > for MAC address. Need to remove some inputs from existing > cmdline_etheraddr test, and add a new test in test suite > to cover this. There is some overlap between the two tests > but

Re: [PATCH v2 0/4] support offload of simple conntrack flow rules

2023-10-04 Thread Ferruh Yigit
On 10/4/2023 10:35 AM, Chaoyong He wrote: > This patch series add the support of simple conntrack flow rules offload > through flower firmware by import the needed data structure and logic of > flow merge. > > --- > v2: > * Fix one mis-spell in comment. > * Revise logic and document to solve the '

RE: [PATCH] random: clarify PRNG MT safety guarantees

2023-10-04 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 4 October 2023 12.55 random: clarify PRNG MT safety guarantees > > Clarify MT safety guarantees for unregistered non-EAL threads calling > PRNG functions in rte_random.h. > > Clarify that rte_srand() is not MT safe

Re: [PATCH] net/gve: allow GVE MTU greater than RTE_ETHER_MTU

2023-10-04 Thread Ferruh Yigit
On 9/29/2023 9:38 PM, Joshua Washington wrote: > This patch corrects the MTU setting behavior in the GVE DPDK driver to > remove the artificial upper limit of RTE_ETHER_MTU. Instead, the max MTU > is dictated by the default value of the MTU that the device sends during > initialization, which will

[dpdk-dev] [PATCH v2 1/2] common/cnxk: fix direct rte symbol usage

2023-10-04 Thread jerinj
From: Jerin Jacob The common code is shared between different driver environments, introduce missing plt_ abstractions of missing rte_ symbols and use plt symbols to avoid changing roc_* files. Fixes: 3d4e27fd7ff0 ("use abstracted bit count functions") Fixes: a7ba40b2b1bf ("drivers: convert to i

[dpdk-dev] [PATCH v2 2/2] common/cnxk: fix direct rte symbol usage in REE

2023-10-04 Thread jerinj
From: Jerin Jacob The common code is shared between different driver environments, introduce missing plt_ abstractions of missing rte_ symbols and use plt symbols to avoid changing roc_* files. Fixes: c88d3638c7fc ("common/cnxk: support REE") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob ---

[dpdk-dev] [PATCH 1/2] devtools: support skipping forbid rule check

2023-10-04 Thread jerinj
From: Jerin Jacob In some case, a set of files in directory may need to skip forbid rules check. Added an infrastructure to enable the same using SKIP_FILES variable. Signed-off-by: Jerin Jacob --- devtools/check-forbidden-tokens.awk | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-

[dpdk-dev] [PATCH 2/2] devtools: forbid rte symbols in cnxk base driver

2023-10-04 Thread jerinj
From: Jerin Jacob cnxk base code is shared between different driver environments. Forbid the direct usage of rte_ symbols instead use plt_ symbol as alternatives. roc_platform.[ch] files abstract the difference of driver environment, hence skip those files for rules check. Suggested-by: David

Re: [PATCH] bus/dpaa: fix outside array bounds error with GCC v13

2023-10-04 Thread David Marchand
On Fri, Jul 21, 2023 at 7:28 AM Gagandeep Singh wrote: > > when RTE_ENABLE_ASSERT is enable, DPAA driver is doing > wrong NULL check on frame queue which allows the code > to have access to NULL address. > GCC v13 is giving array bounds error if code is > accessing any memory region less than 4KB.

Re: [PATCH v3] bus/cdx: provide driver flag for optional resource mapping

2023-10-04 Thread David Marchand
On Wed, Oct 4, 2023 at 12:06 PM Gangurde, Abhijit wrote: > > > +/** > > > + * Map the CDX device resources in user space virtual memory address. > > > + * > > > + * Note that driver should not call this function when flag > > > + * RTE_CDX_DRV_NEED_MAPPING is set, as EAL will do that for > > > + *

Re: [PATCH v2] app/dma-perf: fix physical address seg-fault

2023-10-04 Thread Jerin Jacob
On Wed, Oct 4, 2023 at 3:46 PM Varghese, Vipin wrote: > > [AMD Official Use Only - General] > > Hi Jerrin, > > Apologies for the delay, I missed on the comment > > ``` > > for (i = 0; i < nr_buf; i++) { > > + void *src = rte_pktmbuf_mtod(dsts[i], void *); > >

[PATCH 2/2] net/cnxk: report undefined IPsec errors as PMD error

2023-10-04 Thread Nithin Dabilpuram
Report IPsec event subtype as PMD error for errors that are not defined in spec. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev_sec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c b/drivers/net/cnxk/cn10k_ethdev_s

[PATCH 1/2] ethdev: add IPsec event subtype range for PMD specific code

2023-10-04 Thread Nithin Dabilpuram
Add IPsec event subtype range for PMD specific code in order to accommodate wide range of errors that PMD supports. These IPsec event subtypes are used when an error doesn't match the spec defined subtypes between RTE_ETH_EVENT_IPSEC_UNKNOWN and RTE_ETH_EVENT_IPSEC_MAX. Adding this as -ve error ran

[PATCH] mem: allow using ASan in multi-process mode

2023-10-04 Thread Artur Paszkiewicz
Multi-process applications operate on shared hugepage memory but each process has its own ASan shadow region which is not synchronized with the other processes. This causes issues when different processes try to use the same memory because they have their own view of which addresses are valid. Fix

RE: [PATCH v4 1/3] mldev: add support for arbitrary shape dimensions

2023-10-04 Thread Anup Prabhu
> -Original Message- > From: Srikanth Yalavarthi > Sent: Monday, October 2, 2023 3:29 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Anup Prabhu ; > Prince Takkar > Subject: [PATCH v4 1/3] mldev: add support for arbitrary shape dimensions > > U

Re: [PATCH] mem: allow using ASan in multi-process mode

2023-10-04 Thread David Marchand
On Wed, Oct 4, 2023 at 4:23 PM Artur Paszkiewicz wrote: > > Multi-process applications operate on shared hugepage memory but each > process has its own ASan shadow region which is not synchronized with > the other processes. This causes issues when different processes try to > use the same memory

Minutes of Technical Board Meeting, 2023-09-11

2023-10-04 Thread Thomas Monjalon
Members Attending: 10/11 - Aaron Conole - Bruce Richardson - Ferruh Yigit - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Stephen Hemminger - Thomas Monjalon (Chair) NOTE:

Minutes of Technical Board Meeting, 2023-05-31

2023-10-04 Thread Aaron Conole
Attendees: - Aaron - Bruce - David - Ferruh - Jerin - Kevin - Konstantin - Maxime - Nathan - Patrick - Stephen - Tyler Minutes: - Bruce will be moderator on June 14, 2023 - Call for additional items - Userspace Dublin - CFP - Ready to go. - Awaiting on final TB review, feedback received fr

Re: [PATCH v4] app/test: add support for skipping tests

2023-10-04 Thread Aaron Conole
Patrick Robb writes: > Thanks, this should help greatly going forward in the community lab. > > As it relates to our arm64 unit testing, I will give it a few days (or longer > if needed) for next branches to rebase off of > main and then re-enable arm64 unit testing with the > eal_flags_file_pr

Re: [PATCH] eventdev: fix max link profiles info

2023-10-04 Thread Jerin Jacob
On Tue, Oct 3, 2023 at 10:47 PM Bruce Richardson wrote: > > On Tue, Oct 03, 2023 at 08:55:35PM +0530, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Since most of the drivers overwrite the info structure passed > > from the common layer it is not possible to set defaults in > >

RE: [PATCH v2 0/5] add TLS record processing security offload

2023-10-04 Thread Van Haaren, Harry
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, October 4, 2023 11:51 AM > To: Van Haaren, Harry ; Thomas Monjalon > > Cc: Konstantin Ananyev ; Hemant Agrawal > ; dev@dpdk.org; Jerin Jacob Kollanukkaran > ; Anoob Joseph ; Matz, Olivier > ; Vidya Sagar Velumuri > Subject: RE:

Re: [PATCH] net/cnxk: fix TAG read data offset

2023-10-04 Thread Jerin Jacob
On Thu, Sep 28, 2023 at 6:16 PM wrote: > > From: Pavan Nikhilesh > > The workslot structure elements were shuffled around to maintain > uniformity between CN9K and CN10K which moved the TAG data offset > from first dword to third dword. > > Fixes: 182767f70ef2 ("event/cnxk: add event port flow co

RE: [EXT] [PATCH] eventdev: drop custom OS defines

2023-10-04 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, October 3, 2023 10:31 PM > To: dev@dpdk.org > Cc: Bruce Richardson ; Jerin Jacob Kollanukkaran > ; Naga Harish K S V > Subject: [EXT] [PATCH] eventdev: drop custom OS defines > > External Email > > ---

[PATCH v2] eventdev: drop custom OS defines

2023-10-04 Thread Bruce Richardson
The eventdev library doesn't need to put in place its own defines for Linux and BSD. There are already defines for the OS environment in rte_config.h that can be re-used, but since these are just for identifying Linux/non-Linux, we can just check for the standard define '__linux__' instead. Signed

Re: [PATCH 4/4] pcapng: move timestamp calculation into pdump

2023-10-04 Thread Stephen Hemminger
On Mon, 2 Oct 2023 10:15:25 +0200 David Marchand wrote: > > > > Bugzilla ID: 1291 ? > > This patch (and patch 3) updates some pcapng API, is it worth a RN update? > > > Fixes: c882eb544842 ("pcapng: fix timestamp wrapping in output files") > > Is it worth backporting? > I would say no, as

Re: [PATCH v2] eventdev: drop custom OS defines

2023-10-04 Thread Jerin Jacob
On Wed, Oct 4, 2023 at 10:05 PM Bruce Richardson wrote: > > The eventdev library doesn't need to put in place its own defines for > Linux and BSD. There are already defines for the OS environment in > rte_config.h that can be re-used, but since these are just for > identifying Linux/non-Linux, we

Re: [PATCH] raw/cnxk_bphy: support multi-process mode

2023-10-04 Thread Jerin Jacob
On Wed, Oct 4, 2023 at 5:16 AM Tomasz Duszynski wrote: > > Add support for sharing BPHY PMD across multiple running processes. > In scenarios where resources need to be shared across processes > user-space need to ensure serialization. > > Signed-off-by: Tomasz Duszynski > Reviewed-by: Jerin Jaco

RE: [EXT] Re: [PATCH 1/2] raw/cnxk_gpio: support multi-process mode

2023-10-04 Thread Tomasz Duszynski
>-Original Message- >From: Stephen Hemminger >Sent: Wednesday, October 4, 2023 12:29 AM >To: Tomasz Duszynski >Cc: dev@dpdk.org; Jakub Palider ; Anatoly Burakov >; Jerin Jacob Kollanukkaran ; >tho...@monjalon.net >Subject: [EXT] Re: [PATCH 1/2] raw/cnxk_gpio: support multi-process mode >

RE: [EXT] Re: [PATCH 2/2] raw/cnxk_gpio: add bunch of newlines

2023-10-04 Thread Tomasz Duszynski
>-Original Message- >From: Stephen Hemminger >Sent: Wednesday, October 4, 2023 12:26 AM >To: Tomasz Duszynski >Cc: dev@dpdk.org; Jakub Palider ; Jerin Jacob >Kollanukkaran >; tho...@monjalon.net >Subject: [EXT] Re: [PATCH 2/2] raw/cnxk_gpio: add bunch of newlines > >External Email > >

RE: [PATCH v3 08/12] baseband/acc: add FEC capabilities for the VRB2 variant

2023-10-04 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 3, 2023 7:28 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan > > Subject: Re: [PATCH v3 08/12] baseband/acc: add FEC capabilities for the VRB

RE: [PATCH v3 09/12] baseband/acc: add FFT support to VRB2 variant

2023-10-04 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, October 4, 2023 12:11 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan > > Subject: Re: [PATCH v3 09/12] baseband/acc: add FFT support to VRB2 varia

RE: [PATCH v3 06/12] baseband/acc: refactor to allow unified driver extension

2023-10-04 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, October 4, 2023 12:36 AM > To: Chautru, Nicolas ; dev@dpdk.org > Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan > > Subject: Re: [PATCH v3 06/12] baseband/acc: refactor to allow unified dri

[PATCH 1/2] app/testpmd: enable cli for programmable action

2023-10-04 Thread Qi Zhang
Parsing command line for rte_flow_action_prog. Syntax: "prog name [arguments \ ... end]" Use parse_string0 to parse name string. Use parse_hex to parse hex string. Use struct action_prog_data to store parsed result. Example: Action with 2 arguments: "prog name action0 arguments field0 0

[PATCH v4 00/12] VRB2 bbdev PMD introduction

2023-10-04 Thread Nicolas Chautru
v4: updates based on Maxime's suggestions: - FFT windowing exposure tweaked to show number of windows as well in capacity to be more generic and future-proof. - few code refactor notably to avoid code duplication - cosmetic and doc update Thanks v3: updates based on v2 review: - split into smaller

[PATCH v4 01/12] bbdev: add FFT window width member in driver info

2023-10-04 Thread Nicolas Chautru
This exposes the width of each windowing shape being configured on the device. This allows to distinguish different version of the flexible pointwise windowing applied to the FFT and expose this platform configuration to the application. This also add the total number of windows supported in the ca

[PATCH v4 02/12] baseband/acc: add FFT window width in the VRB PMD

2023-10-04 Thread Nicolas Chautru
This allows to expose the FFT window width being introduced in previous commit based on what is configured dynamically on the device platform. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 6 + drivers/baseband/acc/rte_vrb_pmd.c | 39 +-

[PATCH v4 03/12] baseband/acc: remove the 4G SO capability for VRB1

2023-10-04 Thread Nicolas Chautru
This removes the specific capability and support of LTE Decoder Soft Output option on the VRB1 PMD. This is triggered as a vendor decision to defeature the related optional capability so that to avoid theoretical risk of race conditions impacting the device reliability. That optional APP LLR outpu

[PATCH v4 04/12] baseband/acc: allocate FCW memory separately

2023-10-04 Thread Nicolas Chautru
This allows more flexibility to the FCW size for the unified driver. No actual functional change. Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 4 +++- drivers/baseband/acc/rte_vrb_pmd.c | 25 - 2 files changed, 27

[PATCH v4 05/12] baseband/acc: add support for MLD operation

2023-10-04 Thread Nicolas Chautru
There is no functionality related to the MLD operation but allows the unified PMD to support the operation being added moving forward. Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 1 + drivers/baseband/acc/rte_vrb_pmd.c | 39 +

[PATCH v4 06/12] baseband/acc: refactor to allow unified driver extension

2023-10-04 Thread Nicolas Chautru
Adding a few functions and common code prior to extending the VRB driver. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 175 ++--- drivers/baseband/acc/rte_vrb_pmd.c | 58 +- 2 files changed, 190 insertions(+), 43 deletions(-) diff --gi

[PATCH v4 07/12] baseband/acc: adding VRB2 device variant

2023-10-04 Thread Nicolas Chautru
No functionality exposed only device enumeration and configuration. Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- doc/guides/bbdevs/features/vrb2.ini| 14 ++ doc/guides/bbdevs/index.rst| 1 + doc/guides/bbdevs/vrb2.rst | 206 +

[PATCH v4 08/12] baseband/acc: add FEC capabilities for the VRB2 variant

2023-10-04 Thread Nicolas Chautru
New implementation for some of the FEC features specific to the VRB2 variant. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 371 + 1 file changed, 329 insertions(+), 42 deletions(-) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/

[PATCH v4 09/12] baseband/acc: add FFT support to VRB2 variant

2023-10-04 Thread Nicolas Chautru
Support for the FFT the processing specific to the VRB2 variant. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 137 +++-- 1 file changed, 129 insertions(+), 8 deletions(-) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/r

[PATCH v4 10/12] baseband/acc: add MLD support in VRB2 variant

2023-10-04 Thread Nicolas Chautru
Adding the capability for the MLD-TS processing specific to the VRB2 variant. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 374 + 1 file changed, 374 insertions(+) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_

[PATCH v4 11/12] baseband/acc: add support for VRB2 engine error detection

2023-10-04 Thread Nicolas Chautru
Adding missing incremental functionality for the VRB2 variant. Notably detection of engine error during the dequeue. Minor cosmetic edits. Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 19 --- drivers/baseband/acc/vrb1_pf_e

[PATCH v4 12/12] baseband/acc: add configure helper for VRB2

2023-10-04 Thread Nicolas Chautru
This allows to configure the VRB2 device using a companion configuration function within the DPDK bbdev-test environment. Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc100_pmd.h | 2 + drivers/baseband/acc/rte_acc100_pmd.c | 6 +- drivers/baseba

[PATCH 0/8] Enhance the bond framework to support offload

2023-10-04 Thread Chaoyong He
This patch series try to enhance the bond framework to support the offload feature better: * Add new API to make the member port can access some information of the bond port which belongs. * Add new API to get the result of whether bond port is created by the member port. * Add two command li

[PATCH 1/8] ethdev: add member notification for bonding port

2023-10-04 Thread Chaoyong He
From: Long Wu Bonding PMD does not let member ports know the bonding port's information, like how many member ports the bonding port has, what mode the bonding port is in and so on. Add the notification interface for bonding port to let member port know it is added to a bonding port and what the

[PATCH 2/8] ethdev: add API to get hardware creation of bonding port

2023-10-04 Thread Chaoyong He
From: Long Wu After bonding port notification, member port hardware may create the bonding port. We want to get the result of creatition, so we add this API to do the getting action. Signed-off-by: Long Wu Reviewed-by: James Hershaw Reviewed-by: Chaoyong He --- drivers/net/bonding/rte_eth_bo

[PATCH 4/8] net/bonding: add bonding port arguments

2023-10-04 Thread Chaoyong He
From: Long Wu Include the following new arguments for bonding ports: - "notify_member" to enable/disable member notification. - "dedicated_queue" to enable/disable dedicated queue. Add these two arguments in initial argument. Signed-off-by: Long Wu Reviewed-by: James Hershaw Reviewed-by: Chao

[PATCH 3/8] net/bonding: modify interface comment format

2023-10-04 Thread Chaoyong He
From: Long Wu Most of the previous interface comment format does not meet the current standards and were not uniform. Modify them to meet current standards. Signed-off-by: Long Wu Reviewed-by: James Hershaw Reviewed-by: Chaoyong He --- drivers/net/bonding/eth_bond_8023ad_private.h | 52 +++

[PATCH 5/8] net/bonding: support add port by data name

2023-10-04 Thread Chaoyong He
From: Long Wu Several ports may share the same PCI address, like nfp representor. So we cannot add this type of ports to bonding port by "--vdev" argument in dpdk-testpmd. But the port's data name is unique between them, we include an option to add such ports to the bonding port. After adding th

[PATCH 6/8] net/bonding: create new rte flow header file

2023-10-04 Thread Chaoyong He
From: Long Wu Move the flow code to a new head file to make flow related code more clean and make the code architecture more reasonable in the future. There is no functional change, just moving verbatim code around. Signed-off-by: Long Wu Reviewed-by: James Hershaw Reviewed-by: Chaoyong He --

[PATCH 7/8] net/bonding: support checking valid bonding port ID

2023-10-04 Thread Chaoyong He
From: Long Wu Add API to support checking if the port id is a bonding port id. Signed-off-by: Long Wu Reviewed-by: James Hershaw Reviewed-by: Chaoyong He --- drivers/net/bonding/rte_eth_bond.h | 13 + drivers/net/bonding/rte_eth_bond_api.c | 7 +++ drivers/net/bonding/ve

[PATCH 8/8] net/bonding: add commands for bonding port notification

2023-10-04 Thread Chaoyong He
From: Long Wu Add some commands to support bonding port notification in dpdk-testpmd. 1. We can enable the notification by command: "set bonding notify_member (port_id) (enable|disable)" 2. If member port hardware try to create the bonding port after notification we can get the status by comman

Re: [EXT] Re: [PATCH 2/2] raw/cnxk_gpio: add bunch of newlines

2023-10-04 Thread Stephen Hemminger
On Wed, 4 Oct 2023 20:42:47 + Tomasz Duszynski wrote: > > > >No driver should be using the PMD logtype. It should always be using a > >dynamically allocated log > >type. > > Even though it uses old-fashioned logging that change could still > improve output for some users out there. > >

[PATCH v2] app/testpmd: enable cli for programmable action

2023-10-04 Thread Qi Zhang
Parsing command line for rte_flow_action_prog. Syntax: "prog name [arguments \ ... end]" Use parse_string0 to parse name string. Use parse_hex to parse hex string. Use struct action_prog_data to store parsed result. Example: Action with 2 arguments: "prog name action0 arguments field0 0

[PATCH 1/2] common/cnxk: fix handling up and down interrupts

2023-10-04 Thread Harman Kalra
Down messages should be processed only when down interrupt is received while UP messages should be processed when up interrupt is received. A scenario has been observed where processing down message on UP message interrupt causes processing of old message response while response of latest message i

[PATCH 2/2] common/cnxk: fix race condition between up and down mbox

2023-10-04 Thread Harman Kalra
Fixing a possible case for race condition where an up mbox interrupt over writes the down mbox message. Although mbox_wait_for_zero() makes sure no up/down message is pending before raising an up mbox interrupt. But there is a small window were a VF may send a down mbox request to PF after mbox_wai