>-----Original Message-----
>From: Stephen Hemminger <step...@networkplumber.org>
>Sent: Wednesday, October 4, 2023 12:26 AM
>To: Tomasz Duszynski <tduszyn...@marvell.com>
>Cc: dev@dpdk.org; Jakub Palider <jpali...@marvell.com>; Jerin Jacob
>Kollanukkaran
><jer...@marvell.com>; tho...@monjalon.net
>Subject: [EXT] Re: [PATCH 2/2] raw/cnxk_gpio: add bunch of newlines
>
>External Email
>
>----------------------------------------------------------------------
>On Tue, 3 Oct 2023 22:46:03 +0200
>Tomasz Duszynski <tduszyn...@marvell.com> wrote:
>
>> Improve log output by adding some newlines.
>>
>> Signed-off-by: Tomasz Duszynski <tduszyn...@marvell.com>
>> Reviewed-by: Jerin Jacob Kollanukkaran <jer...@marvell.com>
>> Tested-by: Jerin Jacob Kollanukkaran <jer...@marvell.com>
>> ---
>> drivers/raw/cnxk_gpio/cnxk_gpio.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c
>> b/drivers/raw/cnxk_gpio/cnxk_gpio.c
>> index dcd646397e..6c4e4f5eae 100644
>> --- a/drivers/raw/cnxk_gpio/cnxk_gpio.c
>> +++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c
>> @@ -713,7 +713,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev)
>> cnxk_gpio_format_name(name, sizeof(name));
>> rawdev = rte_rawdev_pmd_allocate(name, sizeof(*gpiochip),
>> rte_socket_id());
>> if (!rawdev) {
>> - RTE_LOG(ERR, PMD, "failed to allocate %s rawdev", name);
>> + RTE_LOG(ERR, PMD, "failed to allocate %s rawdev\n", name);
>> return -ENOMEM;
>> }
>>
>> @@ -753,7 +753,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev)
>> snprintf(buf, sizeof(buf), "%s/gpiochip%d/base", CNXK_GPIO_CLASS_PATH,
>> gpiochip->num);
>> ret = cnxk_gpio_read_attr_int(buf, &gpiochip->base);
>> if (ret) {
>> - RTE_LOG(ERR, PMD, "failed to read %s", buf);
>> + RTE_LOG(ERR, PMD, "failed to read %s\n", buf);
>> goto out;
>> }
>>
>> @@ -761,7 +761,7 @@ cnxk_gpio_probe(struct rte_vdev_device *dev)
>> snprintf(buf, sizeof(buf), "%s/gpiochip%d/ngpio", CNXK_GPIO_CLASS_PATH,
>> gpiochip->num);
>> ret = cnxk_gpio_read_attr_int(buf, &gpiochip->num_gpios);
>> if (ret) {
>> - RTE_LOG(ERR, PMD, "failed to read %s", buf);
>> + RTE_LOG(ERR, PMD, "failed to read %s\n", buf);
>> goto out;
>> }
>> gpiochip->num_queues = gpiochip->num_gpios; @@ -774,7 +774,7 @@
>> cnxk_gpio_probe(struct rte_vdev_device *dev)
>>
>> gpiochip->gpios = rte_calloc(NULL, gpiochip->num_gpios, sizeof(struct
>> cnxk_gpio *), 0);
>> if (!gpiochip->gpios) {
>> - RTE_LOG(ERR, PMD, "failed to allocate gpios memory");
>> + RTE_LOG(ERR, PMD, "failed to allocate gpios memory\n");
>> ret = -ENOMEM;
>> goto out;
>> }
>
>
>No driver should be using the PMD logtype. It should always be using a
>dynamically allocated log
>type.
Even though it uses old-fashioned logging that change could still
improve output for some users out there.
Anyway, if you don't want any extra commit noise let's abandon that and these
improvements will show up in dynamic logging patch.
