Re: [PATCH 00/11] Fixes for clang 15

On Sat, Nov 19, 2022 at 1:13 AM Tyler Retzlaff wrote: > > On Fri, Nov 18, 2022 at 09:53:02AM +0100, David Marchand wrote: > > Fedora 37 has just been released with clang 15. > > The latter seems more picky wrt unused variable. > > > > Fixes have been tested in GHA with a simple patch I used in my

Re: [PATCH] bus/pci: fix bus info memleak during PCI scan

On Fri, Nov 18, 2022 at 2:36 PM Tomasz Zawadzki wrote: > > During pci_scan_one() for devices that were already registered > the pci_common_set() is called to set some of the fields again. > > This resulted in bus_info allocation leaking, so this patch > ensures they are always freed beforehand. >

[PATCH] doc: add tested platforms with NVIDIA NICs

Add tested platforms with NVIDIA NICs to the 22.11 release notes. Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_22_11.rst | 155 + 1 file changed, 155 insertions(+) diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_

[PATCH v2] doc: fix max supported packet len for virtio driver

From: Yi Li According to VIRTIO_MAX_RX_PKTLEN macro definition, for virtio driver currently supported pkt size is 9728. Fixes: fc1f2750a3ec ("doc: programmers guide") Signed-off-by: Yi Li --- v2 change: Add "Fixes:" description in commit message. doc/guides/nics/virtio.rst | 2 +- 1 file ch

Re: [EXT] Re: [PATCH v4 1/1] app/testpmd: add valid check to verify multi mempool feature

On 11/19/2022 12:00 AM, Hanumanth Reddy Pothula wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Saturday, November 19, 2022 2:26 AM >> To: Hanumanth Reddy Pothula ; >> tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Nithin Kumar >> Dabilpuram >> Cc: dev@dpdk.org; yux

Re: [PATCH 00/11] Fixes for clang 15

On Fri, Nov 18, 2022 at 9:55 AM David Marchand wrote: > > Fedora 37 has just been released with clang 15. > The latter seems more picky wrt unused variable. > > Fixes have been tested in GHA with a simple patch I used in my own repo: > https://github.com/david-marchand/dpdk/commit/82cd57ae5490 > h

Re: [PATCH] ring: build with global includes

On Fri, Nov 18, 2022 at 03:22:07PM -0800, Tyler Retzlaff wrote: > ring has no dependencies and should be able to be built standalone but > cannot be since it cannot find rte_config.h. this change directs meson > to include global_inc paths just like is done with other libraries > e.g. telemetry. >

RE: [EXT] Re: [PATCH v4 1/1] app/testpmd: add valid check to verify multi mempool feature

> -Original Message- > From: Ferruh Yigit > Sent: Monday, November 21, 2022 3:38 PM > To: Hanumanth Reddy Pothula ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Nithin Kumar > Dabilpuram > Cc: dev@dpdk.org; yux.ji...@intel.com; Jerin Jacob Kollanukkaran > ; Aman Singh ; Yuying

Re: [EXT] [dpdk-dev v6] doc: support IPsec Multi-buffer lib v1.3

Hi Akhil, From 22.11 the ipsec-mb PMDs will be working on two different libraries that may or may not work the same. We also have two different contributor groups working on adding features on top of each library, again one may or may not be compatible to another. I believe there should be

[PATCH] bus/pci: fix leak with multiple bus scan

The addition of the bus_info field did not account for the fact that the PCI bus can be scanned multiple times (like for device hotplug and other uses in SPDK). Indeed, during pci_scan_one() for devices that were already registered, the pci_common_set() overwrites the bus_info field, leaking the pr

RE: [EXT] [dpdk-dev v6] doc: support IPsec Multi-buffer lib v1.3

Hi Fan, > Hi Akhil, > > > From 22.11 the ipsec-mb PMDs will be working on two different libraries > that may or may not work the same. > > We also have two different contributor groups working on adding features > on top of each library, again one may or may not be compatible to another. > > I

[PATCH v2 0/4] add support for self monitoring

This series adds self monitoring support i.e allows to configure and read performance measurement unit (PMU) counters in runtime without using perf utility. This has certain adventages when application runs on isolated cores with nohz_full kernel parameter. Events can be read directly using rte_pm

[PATCH v2 1/4] eal: add generic support for reading PMU events

Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated (nohz_full) i.e run dedicated tasks. In such cases one cannot use standard perf utility without sacrificing latency and performa

[PATCH v2 2/4] eal/arm: support reading ARM PMU events in runtime

Add support for reading ARM PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 4 ++ lib/eal/arm/include/meson.build | 1 + lib/eal/arm/include/rte_pmu_pmc.h | 39 +++ lib/eal/arm/meson.build | 4 ++ lib/eal/arm/rte_pmu.c

[PATCH v2 3/4] eal/x86: support reading Intel PMU events in runtime

Add support for reading Intel PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 2 ++ lib/eal/include/rte_pmu.h | 2 +- lib/eal/x86/include/meson.build | 1 + lib/eal/x86/include/rte_pmu_pmc.h | 33 +++ 4 files

[PATCH v2 4/4] eal: add PMU support to tracing library

In order to profile app one needs to store significant amount of samples somewhere for an analysis latern on. Since trace library supports storing data in a CTF format lets take adventage of that and add a dedicated PMU tracepoint. Signed-off-by: Tomasz Duszynski --- app/test/test_trace_perf.c

[PATCH v5 1/1] app/testpmd: add valid check to verify multi mempool feature

Validate ethdev parameter 'max_rx_mempools' to know whether device supports multi-mempool feature or not. Also, add new testpmd command line argument, multi-mempool, to control multi-mempool feature. By default its disabled. Bugzilla ID: 1128 Fixes: 4f04edcda769 ("app/testpmd: support multiple mb

Re: [PATCH v5 1/1] app/testpmd: add valid check to verify multi mempool feature

On 11/21/2022 12:45 PM, Hanumanth Pothula wrote: > Validate ethdev parameter 'max_rx_mempools' to know whether > device supports multi-mempool feature or not. > > Also, add new testpmd command line argument, multi-mempool, > to control multi-mempool feature. By default its disabled. > > Bugzilla

RE: [EXT] Re: [PATCH v5 1/1] app/testpmd: add valid check to verify multi mempool feature

> -Original Message- > From: Ferruh Yigit > Sent: Monday, November 21, 2022 6:53 PM > To: Hanumanth Reddy Pothula ; Aman Singh > ; Yuying Zhang > Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; > tho...@monjalon.net; yux.ji...@intel.com; Jerin Jacob Kollanukkaran > ; Nithin Kumar Dabil

[PATCH] compress/mlx5: add Bluefield-3 device ID

This adds the Bluefield-3 device ids to the list of supported NVIDIA devices that run the MLX5 compress PMDs. Signed-off-by: Raslan Darawsheh --- drivers/compress/mlx5/mlx5_compress.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compres

RE: release candidate 22.11-rc3

> -Original Message- > From: Jiang, YuX > Sent: Thursday, November 17, 2022 4:49 PM > To: Thomas Monjalon ; dev (dev@dpdk.org) > > Cc: Devlin, Michelle ; Mcnamara, John > ; Richardson, Bruce > ; Zhang, Qi Z > Subject: RE: release candidate 22.11-rc3 > > > -Original Message- > > Fr

Re: [EXT] [dpdk-dev v6] doc: support IPsec Multi-buffer lib v1.3

Hi Akhil, Agreed. Thanks for clarification. Regards, Fan On 11/21/2022 11:35 AM, Akhil Goyal wrote: Hi Fan, Hi Akhil, From 22.11 the ipsec-mb PMDs will be working on two different libraries that may or may not work the same. We also have two different contributor groups working on addin

Re: [EXT] Re: [PATCH v5 1/1] app/testpmd: add valid check to verify multi mempool feature

On 11/21/2022 1:36 PM, Hanumanth Reddy Pothula wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, November 21, 2022 6:53 PM >> To: Hanumanth Reddy Pothula ; Aman Singh >> ; Yuying Zhang >> Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; >> tho...@monjalon.net; yux.

Re: release candidate 22.11-rc3

On 11/21/2022 1:50 PM, Jiang, YuX wrote: > Update the test status for Intel part. Till now dpdk22.11-rc3 validation test > is almost finished. > 3 bugs are found, Bug1 & Bug2 are critical issues, hope they can be fixed in > 22.11. > Bug1： https://bugs.dpdk.org/show_bug.cgi?id=1128 [dpdk22.11-rc

[PATCH v2] compress/mlx5: add Bluefield-3 device ID

This adds the Bluefield-3 device ids to the list of supported NVIDIA devices that run the MLX5 compress PMDs. The devices is still in development stage. Signed-off-by: Raslan Darawsheh --- v2: update commit msg to mention the device is actually still in development stage. --- drivers/compress/m

RE: Regarding User Data in DPDK ACL Library.

> > > On Thu, 17 Nov 2022 19:28:12 +0530 > > > venkatesh bs wrote: > > > > > > > Hi DPDK Team, > > > > > > > > After the ACL match for highest priority DPDK Classification API > > > > returns User Data Which is as mentioned below in the document. > > > > > > > > 53. Packet Classification and Acc

[PATCH] pipeline: fix validate header instruction

From: Yogesh Jangra The exported data structure for the header validate instruction did not populate its struct_id field, which results in segmentation fault. Fixes: 216bc906d00 ("pipeline: export pipeline instructions to file") Cc: sta...@dpdk.org Signed-off-by: Yogesh Jangra Acked-by: Cristi

[PATCH v6 1/1] app/testpmd: add valid check to verify multi mempool feature

Validate ethdev parameter 'max_rx_mempools' to know whether device supports multi-mempool feature or not. Also, add new testpmd command line argument, multi-mempool, to control multi-mempool feature. By default its disabled. Bugzilla ID: 1128 Fixes: 4f04edcda769 ("app/testpmd: support multiple mb

Re: [PATCH 2/2] doc: update MLX5 LRO limitation

17/11/2022 15:39, Gregory Etelson: > Maximal LRO message size must be multiply of 256. > Otherwise, TCP payload may not fit into a single WQE. > > Cc: sta...@dpdk.org > Signed-off-by: Gregory Etelson > Acked-by: Matan Azrad Why the doc update is not in the same patch as the code change? > @@ -

RE: [PATCH v2] doc: update QAT device support

Acked-by: Kai Ji > -Original Message- > From: Dooley, Brian > Sent: Friday, November 18, 2022 5:19 PM > To: Ji, Kai > Cc: dev@dpdk.org; sta...@dpdk.org; gak...@marvell.com; Dooley, Brian > > Subject: [PATCH v2] doc: update QAT device support > > Update what drivers and devices are sup

[dpdk-dev v7] doc: support IPsec Multi-buffer lib v1.3

From: Pablo de Lara Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G and CHACHA20_POLY1305 PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara Acked-by: Ciara Power Acked-by: Brian Dooley Signed-off-by: Kai Ji

RE: Regarding User Data in DPDK ACL Library.

> > > > > On Thu, 17 Nov 2022 19:28:12 +0530 venkatesh bs > > > > wrote: > > > > > > > > > Hi DPDK Team, > > > > > > > > > > After the ACL match for highest priority DPDK Classification API > > > > > returns User Data Which is as mentioned below in the document. > > > > > > > > > > 53. Packet Cl

Re: [PATCH v6 1/1] app/testpmd: add valid check to verify multi mempool feature

On 11/21/2022 2:33 PM, Hanumanth Pothula wrote: > Validate ethdev parameter 'max_rx_mempools' to know whether > device supports multi-mempool feature or not. > Validation 'max_rx_mempools' is not main purpose of this patch, I would move below paragraph up. > Also, add new testpmd command line ar

RE: [EXT] Re: [PATCH v6 1/1] app/testpmd: add valid check to verify multi mempool feature

> -Original Message- > From: Ferruh Yigit > Sent: Monday, November 21, 2022 11:02 PM > To: Hanumanth Reddy Pothula ; Aman Singh > ; Yuying Zhang > Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; > tho...@monjalon.net; yux.ji...@intel.com; Jerin Jacob Kollanukkaran > ; Nithin Kumar Dabi

Re: [EXT] Re: [PATCH v6 1/1] app/testpmd: add valid check to verify multi mempool feature

On 11/21/2022 5:45 PM, Hanumanth Reddy Pothula wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, November 21, 2022 11:02 PM >> To: Hanumanth Reddy Pothula ; Aman Singh >> ; Yuying Zhang >> Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; >> tho...@monjalon.net; yux

[PATCH v7 1/1] app/testpmd: add valid check to verify multi mempool feature

Validate ethdev parameter 'max_rx_mempools' to know whether device supports multi-mempool feature or not. Also, add new testpmd command line argument, multi-mempool, to control multi-mempool feature. By default its disabled. Bugzilla ID: 1128 Fixes: 4f04edcda769 ("app/testpmd: support multiple mb

Re: [PATCH v7 1/1] app/testpmd: add valid check to verify multi mempool feature

On 11/21/2022 6:07 PM, Hanumanth Pothula wrote: > Validate ethdev parameter 'max_rx_mempools' to know whether > device supports multi-mempool feature or not. > > Also, add new testpmd command line argument, multi-mempool, > to control multi-mempool feature. By default its disabled. s/multi-mempoo

Re: [PATCH v2] compress/mlx5: add Bluefield-3 device ID

21/11/2022 15:12, Raslan Darawsheh: > This adds the Bluefield-3 device ids to the list of > supported NVIDIA devices that run the MLX5 compress PMDs. > The devices is still in development stage. > > Signed-off-by: Raslan Darawsheh Applied, thanks.

Re: [PATCH] doc: improve event core description in vDPA mlx5

> > The event core is mlx5 vDPA driver devarg that selects the CPU core for > > the internal timer thread used to manage data-path events into the > > driver. > > > > Emphasize that this CPU should be isolated for vDPA mlx5 devices only in > > order to save the performance and latency of the devic

Re: [PATCH] ring: build with global includes

On Mon, Nov 21, 2022 at 10:31:29AM +, Bruce Richardson wrote: > On Fri, Nov 18, 2022 at 03:22:07PM -0800, Tyler Retzlaff wrote: > > ring has no dependencies and should be able to be built standalone but > > cannot be since it cannot find rte_config.h. this change directs meson > > to include gl

[PATCH] doc: announce the legacy pipeline API deprecation

Announce the deprecation of the legacy pipeline, table and port library API and gradual stabilization of the new API. Signed-off-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.

Re: [PATCH] doc: add tested platforms with NVIDIA NICs

21/11/2022 10:10, Raslan Darawsheh: > Add tested platforms with NVIDIA NICs to the 22.11 release notes. > > Signed-off-by: Raslan Darawsheh Applied with few typos fixed, thanks.

Re: release candidate 22.11-rc3

IBM - Power Systems DPDK 22.11.0-rc3 * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. * OS: RHEL 8.5 kernel: 4.18.0-348.el8.ppc64le with gcc version 8.5.0 20210514 (Red Hat 8.5.0-10) RHEL 9.0 kernel: 5.14.0-70.13.1.el9_0.ppc64le w

[PATCH 01/11] ethdev: check return result of rte_eth_dev_info_get

From: Sinan Kaya rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get is not checked, potentially leaving dev_info uninitialized. Signed-off-by: Sinan Kaya --- lib/ethdev/rte_class_eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rt

[PATCH 00/11] codeql fixes for various subsystems

From: Sinan Kaya Following up the codeql reported problems first submitted by Stephen Hemminger here: https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ Posting a series of fixes about potential null pointer accesses. Sinan Kaya (11): ethdev: check return result of rte_eth_d

[PATCH 04/11] memzone: check result of malloc_elem_from_data

From: Sinan Kaya In memzone_reserve_aligned_thread_unsafe result of call to malloc_elem_from_data is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/common/eal_common_memzone.c

[PATCH 02/11] net/tap: check if name is null

From: Sinan Kaya In rte_pmd_tun_probe result of call to rte_vdev_device_name is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- drivers/net/tap/rte_eth_tap.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c i

[PATCH 05/11] malloc: malloc_elem_join_adjacent_free can return null

From: Sinan Kaya In malloc_heap_add_memory result of call to malloc_elem_join_adjacent_free is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/mall

[PATCH 06/11] malloc: check result of rte_mem_virt2memseg_list

From: Sinan Kaya In alloc_pages_on_heap result of call to rte_mem_virt2memseg_list is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c

[PATCH 03/11] memzone: check result of rte_fbarray_get

From: Sinan Kaya In memzone_lookup_thread_unsafe result of call to rte_fbarray_get is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_memzone.

[PATCH 08/11] malloc: check result of rte_mem_virt2memseg

From: Sinan Kaya In malloc_elem_find_max_iova_contig result of call to rte_mem_virt2memseg is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_elem.c | 11 --- lib/eal/common/malloc_heap.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-)

[PATCH 07/11] malloc: check result of rte_fbarray_get

From: Sinan Kaya In eal_memalloc_is_contig result of call to rte_fbarray_get is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memalloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_memalloc.c b/l

[PATCH 09/11] malloc: check result of malloc_elem_free

From: Sinan Kaya In malloc_heap_free result of call to malloc_elem_free is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c index 1bf2

RE: [PATCH] ring: build with global includes

> -Original Message- > From: Tyler Retzlaff > Sent: Monday, November 21, 2022 7:53 PM > To: Bruce Richardson > Cc: dev@dpdk.org > Subject: Re: [PATCH] ring: build with global includes > > On Mon, Nov 21, 2022 at 10:31:29AM +, Bruce Richardson wrote: > > On Fri, Nov 18, 2022 at 03:

Re: [PATCH v2 0/6] doc: some fixes

> Michael Baum (6): > doc: fix underlines too long in testpmd documentation > doc: fix the colon type in listing aged flow rules > doc: fix miss blank line in testpmd flow syntax doc > doc: fix miss blank line in release notes > doc: add mlx5 HWS aging support to release notes > doc: ad

Re: [PATCH] ring: build with global includes

21/11/2022 22:27, Konstantin Ananyev: > From: Tyler Retzlaff > > e.g. i don't see. > > > > deps += ['eal'] > > > > is the dependency on eal the library or just eal headers? because if it > > is header only it is equivalent to telemetry i think? > > rte_ring.c uses bunch of EAL functions: > rte_

Re: [PATCH 02/11] net/tap: check if name is null

21/11/2022 21:40, ok...@kernel.org: > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -2340,6 +2340,10 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev) > struct rte_eth_dev *eth_dev; > > name = rte_vdev_device_name(dev); > + if (!name) { Please it

Re: [PATCH 02/11] net/tap: check if name is null

On Mon, 2022-11-21 at 22:41 +0100, Thomas Monjalon wrote: > 21/11/2022 21:40, ok...@kernel.org: > > --- a/drivers/net/tap/rte_eth_tap.c+++ > > b/drivers/net/tap/rte_eth_tap.c@@ -2340,6 +2340,10 @@ > > rte_pmd_tun_probe(struct rte_vdev_device *dev) struct > > rte_eth_dev *eth_dev; name =

[PATCH v2 00/11] codeql fixes for various subsystems

From: Sinan Kaya Following up the codeql reported problems first submitted by Stephen Hemminger here: https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ Posting a series of fixes about potential null pointer accesses. Changes from v1: - Remove braces around single line stateme

[PATCH v2 01/11] ethdev: check return result of rte_eth_dev_info_get

From: Sinan Kaya rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get is not checked, potentially leaving dev_info uninitialized. Signed-off-by: Sinan Kaya --- lib/ethdev/rte_class_eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rt

[PATCH v2 02/11] net/tap: check if name is null

From: Sinan Kaya In rte_pmd_tun_probe result of call to rte_vdev_device_name is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- drivers/net/tap/rte_eth_tap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c in

[PATCH v2 03/11] memzone: check result of rte_fbarray_get

From: Sinan Kaya In memzone_lookup_thread_unsafe result of call to rte_fbarray_get is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_memzone.

[PATCH v2 04/11] memzone: check result of malloc_elem_from_data

From: Sinan Kaya In memzone_reserve_aligned_thread_unsafe result of call to malloc_elem_from_data is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/common/eal_common_memzone.c

[PATCH v2 05/11] malloc: malloc_elem_join_adjacent_free can return null

From: Sinan Kaya In malloc_heap_add_memory result of call to malloc_elem_join_adjacent_free is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/mallo

[PATCH v2 06/11] malloc: check result of rte_mem_virt2memseg_list

From: Sinan Kaya In alloc_pages_on_heap result of call to rte_mem_virt2memseg_list is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c

[PATCH v2 07/11] malloc: check result of rte_fbarray_get

From: Sinan Kaya In eal_memalloc_is_contig result of call to rte_fbarray_get is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memalloc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_memalloc.c b/

[PATCH v2 08/11] malloc: check result of rte_mem_virt2memseg

From: Sinan Kaya In malloc_elem_find_max_iova_contig result of call to rte_mem_virt2memseg is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_elem.c | 11 --- lib/eal/common/malloc_heap.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-)

[PATCH v2 09/11] malloc: check result of malloc_elem_free

From: Sinan Kaya In malloc_heap_free result of call to malloc_elem_free is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c index 8827

Re: [PATCH] ring: build with global includes

On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > 21/11/2022 22:27, Konstantin Ananyev: > > From: Tyler Retzlaff > > > e.g. i don't see. > > > > > > deps += ['eal'] > > > > > > is the dependency on eal the library or just eal headers? because if it > > > is header only it is equ

Re: [PATCH v3 0/3] ethdev: document special cases of port start and stop

> Dariusz Sosnowski (3): > net/mlx5: fix log level on failed transfer proxy stop > net/mlx5: document E-Switch limitations with HWS in mlx5 PMD > ethdev: document special cases of port start and stop There is a change in testpmd but it looks simple enough for -rc4. Applied, thanks.

Re: [PATCH 02/11] net/tap: check if name is null

On 11/21/2022 10:03 PM, Sinan Kaya wrote: > On Mon, 2022-11-21 at 22:41 +0100, Thomas Monjalon wrote: >> 21/11/2022 21:40, >> ok...@kernel.org >> >> : >>> --- a/drivers/net/tap/rte_eth_tap.c >>> +++ b/drivers/net/tap/rte_eth_tap.c >>> @@ -2340,6 +2340,10 @@ rte_pmd_tun_p

Re: [PATCH] net/nfp: fix return path in TSO processing function

On 11/18/2022 4:23 PM, Niklas Söderlund wrote: > From: Fei Qin > > When enable TSO, nfp_net_nfdk_tx_tso() fills segment information in Tx > descriptor. However, the return path for TSO is lost and the LSO related > fields of Tx descriptor is filled with zeros which prevents packets from > being s

[PATCH v2 1/2] net/mlx5: fix port private max LRO msg size

The PMD analyzes each Rx queue maximal LRO size and selects one that fits all queues to configure TIR LRO attribute. TIR LRO attribute is number of 256 bytes chunks that match the selected maximal LRO size. PMD used `priv->max_lro_msg_size` for selected maximal LRO size and number of TIR chunks.

[PATCH v2 2/2] doc: update MLX5 LRO limitation

Maximal LRO message size must be multiply of 256. Otherwise, TCP payload may not fit into a single WQE. Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Matan Azrad --- v2: move the patch to LRO section. --- doc/guides/nics/mlx5.rst | 2 ++ 1 file changed, 2 insertions(+) diff --gi

RE: [PATCH 2/2] doc: update MLX5 LRO limitation

Hello Thomas, > > .. note:: > > > > MAC addresses not already present in the bridge table of the > associated > > If you would like to read the doc, I guess you'd prefer to find this info > in the section dedicated to LRO, not in a random place. > I moved the patch location in v2 Regards,

[Bug 1131] [22.11-rc3] vmdq && kni meson build error with gcc12.2.1+debug on Fedora37

https://bugs.dpdk.org/show_bug.cgi?id=1131 huang chenyu (chenyux.hu...@intel.com) changed: What|Removed |Added Resolution|INVALID |--- Status|R

RE: [PATCH v7 1/1] app/testpmd: add valid check to verify multi mempool feature

> -Original Message- > From: Hanumanth Pothula > Sent: Tuesday, November 22, 2022 2:08 AM > To: Singh, Aman Deep ; Zhang, Yuying > > Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; > tho...@monjalon.net; Jiang, YuX ; > jer...@marvell.com; ndabilpu...@marvell.com; hpoth...@marvell.com >

RE: [PATCH v7 1/1] app/testpmd: add valid check to verify multi mempool feature

> -Original Message- > From: Han, YingyaX > Sent: Tuesday, November 22, 2022 2:43 PM > To: Hanumanth Pothula ; Singh, Aman Deep > ; Zhang, Yuying > Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; tho...@monjalon.net; > Jiang, YuX ; jer...@marvell.com; > ndabilpu...@marvell.com > Subjec