Hi Fan, > Hi Akhil, > > > From 22.11 the ipsec-mb PMDs will be working on two different libraries > that may or may not work the same. > > We also have two different contributor groups working on adding features > on top of each library, again one may or may not be compatible to another. > > I believe there should be some words necessary to distinguish each > library support as well as the credits for adding certain features for > one platform.
Ok, but release notes is not a correct place to mention that. It should be part of the respective driver documentation. > > > On 11/21/2022 6:57 AM, Akhil Goyal wrote: > >> diff --git a/doc/guides/rel_notes/release_22_11.rst > >> b/doc/guides/rel_notes/release_22_11.rst > >> index 4e55b543ef..b98b603fe7 100644 > >> --- a/doc/guides/rel_notes/release_22_11.rst > >> +++ b/doc/guides/rel_notes/release_22_11.rst > >> @@ -240,7 +240,16 @@ New Features > >> > >> * **Updated ipsec_mb crypto driver.** > >> > >> - Added SNOW-3G and ZUC support for ARM platform. > >> + * Added ARM64 port of ipsec-mb library support and SNOW-3G and ZUC > >> + support for ARM platform. > > You need not update the above line. > > * Added SNOW-3G and ZUC support for ARM platform. > > Should be good enough. > >> + * Added Intel IPsec MB v1.3 library support for x86 platform, > >> + see the following guides for more details: > >> + :doc:`../cryptodevs/aesni_gcm` > >> + :doc:`../cryptodevs/aesni_mb` > >> + :doc:`../cryptodevs/chacha20_poly1305` > >> + :doc:`../cryptodevs/kasumi` > >> + :doc:`../cryptodevs/snow3g` > >> + :doc:`../cryptodevs/zuc` > > I believe adding reference for each guide is not needed. > > > > * Added Intel IPsec MB v1.3 library support for x86 platform. > > Added details in the guides for all the drivers supported by ipsec_mb. > > What the guideline Pablo/Kai added here only applies for x86 as > > a. ARM does not support algorithms other than SNOW3G and ZUC. This should be distinguished in the .rst file. For release notes, above thing is sufficient. > > b. The performance guideline may not apply to ARM. Again, it should be part of driver documentation and not release notes. And for each of the release note bullet that I suggested are mentioning the Platform on which the support is added.
