On 11/21/2022 10:03 PM, Sinan Kaya wrote: > On Mon, 2022-11-21 at 22:41 +0100, Thomas Monjalon wrote: >> 21/11/2022 21:40, >> ok...@kernel.org >> <mailto:ok...@kernel.org> >> : >>> --- a/drivers/net/tap/rte_eth_tap.c >>> +++ b/drivers/net/tap/rte_eth_tap.c >>> @@ -2340,6 +2340,10 @@ rte_pmd_tun_probe(struct rte_vdev_device *dev) >>> struct rte_eth_dev *eth_dev; >>> >>> name = rte_vdev_device_name(dev); >>> + if (!name) { >> >> Please it is preferred to check against NULL, >> because name is not a boolean, thanks. >> I know it's longer but it is more explicit. > > Sure, I can do that. Getting used to dpdk coding style. I wasn't sure > what to do with braces on single line too. At least, I got a warning on > that too. >
DPDK coding convention is documented if it helps: https://doc.dpdk.org/guides/contributing/coding_style.html >> >> Thanks for the fixes in this series. >> >> > > Cheers >
