On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > 21/11/2022 22:27, Konstantin Ananyev: > > From: Tyler Retzlaff <roret...@linux.microsoft.com> > > > e.g. i don't see. > > > > > > deps += ['eal'] > > > > > > is the dependency on eal the library or just eal headers? because if it > > > is header only it is equivalent to telemetry i think? > > > > rte_ring.c uses bunch of EAL functions: > > rte_zmalloc, rte_memzone_*, rte_log*, rte_mcfg*, etc. > > I think deps += ['eal'] is missing in ring meson file.
i guess that's what i'm kind of getting at... if it was there then the patch i submitted is not required since depending on eal would drag in global_inc.
