Re: [EXT] Re: [PATCH v9 13/14] baseband/acc: add PF configure companion function

2022-10-12 Thread Maxime Coquelin
On 10/11/22 23:18, Chautru, Nicolas wrote: Hi Akhil, Maxime, -Original Message- From: Akhil Goyal Sent: Monday, October 10, 2022 11:12 AM To: Chautru, Nicolas ; Maxime Coquelin ; dev@dpdk.org Cc: t...@redhat.com; m...@ashroe.eu; Richardson, Bruce ; hemant.agra...@nxp.com; david.marc

RE: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec

2022-10-12 Thread Pei, Andy
Hi Chenbo, Sure. I will address in next version. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 2:09 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 3/8] vdpa/ifc: set max que

RE: [PATCH v3 3/8] vdpa/ifc: set max queues based on virtio spec

2022-10-12 Thread Pei, Andy
Hi Chenbo, Sure. I will address in next version. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 2:09 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 3/8] vdpa/ifc: set max que

[Bug 1101] [dpdk-22.11.0rc1][meson test] driver-tests/eventdev_selftest_sw test failed

2022-10-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1101 Morten Brørup (m...@smartsharesystems.com) changed: What|Removed |Added CC||dev@dpdk.org -- You

RE: [PATCH v3 2/8] vdpa/ifc: add multi-queue support

2022-10-12 Thread Pei, Andy
Hi Chenbo, Sure. I will address in next version. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 11:02 AM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 2/8] vdpa/ifc: add multi-

Re: [PATCH v8 3/9] memarea: support alloc/free/update-refcnt API

2022-10-12 Thread fengchengwen
Hi Dmitry, On 2022/10/11 23:58, Dmitry Kozlyuk wrote: > 2022-10-11 12:17 (UTC+), Chengwen Feng: >> This patch supports rte_memarea_alloc()/rte_memarea_free()/ >> rte_memarea_update_refcnt() API. >> ... >> + >> +void >> +rte_memarea_update_refcnt(struct rte_memarea *ma, void *ptr, int16_t val

Re: [PATCH 7/8] trace: remove limitation on trace point name

2022-10-12 Thread David Marchand
On Tue, Oct 11, 2022 at 4:49 PM Jerin Jacob wrote: > > On Wed, Sep 21, 2022 at 5:35 PM David Marchand > wrote: > > > > The name of a trace point is provided as a constant string via the > > RTE_TRACE_POINT_REGISTER macro. > > We can rely on the constant string in the binary and simply point at it

Re: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

2022-10-12 Thread kumaraparameshwaran rathinavel
Shall I raise a PR with the change ? On Wed, Oct 12, 2022 at 7:04 AM Jun Qiu wrote: > Yes, It's better to do it before the tcp_dl check. > > > >1. /* trim the tail padding bytes */ >2. ip_tlen = rte_be_to_cpu_16(ipv4_hdr->total_length); >3. *if* (pkt->pkt_len > (uint32_t)(ip_tlen +

[PATCH] test/member: fix incorrect expression

2022-10-12 Thread Leyi Rong
Fix incorrect expression by cast division operand to type double to match ceil() and fabs() definitions. Coverity issue: 381398, 381401, 381402 Fixes: db354bd2e1f8 ("member: add NitroSketch mode") Signed-off-by: Leyi Rong --- app/test/test_member.c | 16 app/test/test_memb

Re: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

2022-10-12 Thread David Marchand
On Wed, Oct 12, 2022 at 9:48 AM kumaraparameshwaran rathinavel wrote: > > Shall I raise a PR with the change ? Let's give some time to Jiayu and Jun to reply. Thanks. -- David Marchand

[PATCH] app/testpmd: fix slave port reset action

2022-10-12 Thread Qiming Yang
As stop action has been forbidden in secondary process, so the reset action should also not be allowed. Fixes: a550baf24af9 ("app/testpmd: support multi-process") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- app/test-pmd/testpmd.c| 18 ++ doc/guides/testpmd

RE: [PATCH] net/mlx5: fix thread termination check on Windows

2022-10-12 Thread Slava Ovsiienko
> -Original Message- > From: Tal Shnaiderman > Sent: Wednesday, October 12, 2022 9:50 > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; Matan > Azrad ; Slava Ovsiienko ; Raslan > Darawsheh ; paul203...@gmail.com; Idan Hackmon > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5:

Re: [PATCH v8 7/9] memarea: support backup memory mechanism

2022-10-12 Thread fengchengwen
Hi Dmitry, On 2022/10/11 23:58, Dmitry Kozlyuk wrote: > 2022-10-11 12:17 (UTC+), Chengwen Feng: >> This patch adds a memarea backup mechanism, where an allocation request >> which cannot be met by the current memarea is deferred to its backup >> memarea. > > This is a controversial feature. >

Re: [PATCH v8 9/9] app/test: add memarea to malloc-perf-autotest

2022-10-12 Thread fengchengwen
Hi Dmitry, On 2022/10/11 23:58, Dmitry Kozlyuk wrote: > 2022-10-11 12:17 (UTC+), Chengwen Feng: >> This patch adds memarea to malloc_perf_autotest. >> >> Test platform: Kunpeng920 >> Test command: dpdk-test -a :7d:00.3 -l 10-12 >> Test result: >> USER1: Performance: rte_memarea >> USER1:

Re: CRC offload from application's POV

2022-10-12 Thread Ferruh Yigit
On 10/12/2022 3:29 AM, Wu, Wenjun1 wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, October 11, 2022 9:46 PM To: Viacheslav Galaktionov ; Su, Simei ; Wu, Wenjun1 Cc: Denis Pryazhennikov ; dev@dpdk.org Subject: Re: CRC offload from application's POV On 10/11/2022 12:54 PM,

RE: [PATCH v2 02/14] net/idpf/base: add logs and OS specific implementation

2022-10-12 Thread Wu, Wenjun1
> -Original Message- > From: Junfeng Guo > Sent: Monday, September 5, 2022 6:58 PM > To: Zhang, Qi Z ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Wang, Xiao W ; Guo, Junfeng > > Subject: [PATCH v2 02/14] net/idpf/base: add logs and OS specific > implementation > > Add PMD logs

RE: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register

2022-10-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register > > Write queue count to IFCVF_

rte_event_dev_xstats_reset id type

2022-10-12 Thread Morten Brørup
Hi Jerin (eventdev maintainer), While looking into bug #1101 [1], I noticed a mix of unsigned int and uint32_t in the test code, which will fail on 64-bit big endian CPUs. Specifically, rte_event_dev_xstats_reset() is called with the "ids" parameter pointing to an unsigned int [2], but that par

RE: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue

2022-10-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue > > when configure the hardware que

RE: [PATCH v3 4/8] vdpa/ifc: write queue count to MQ register

2022-10-12 Thread Pei, Andy
Hi Chenbo Thanks for your reply, my reply inline. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 4:08 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 4/8] vdpa/ifc: write queu

RE: CRC offload from application's POV

2022-10-12 Thread Wu, Wenjun1
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 12, 2022 4:07 PM > To: Wu, Wenjun1 ; Viacheslav Galaktionov > ; Su, Simei > Cc: Denis Pryazhennikov ; > dev@dpdk.org > Subject: Re: CRC offload from application's POV > > On 10/12/2022 3:29 AM, Wu, Wenjun1 wrote: > >

Re: Opensource ethdev tests

2022-10-12 Thread Andrew Rybchenko
Hi Honnappa, On 10/11/22 21:43, Honnappa Nagarahalli wrote: Hi Andrew, Few questions inline. -Original Message- From: Andrew Rybchenko Sent: Monday, October 3, 2022 5:00 AM To: tho...@monjalon.net Cc: dev@dpdk.org; Ferruh Yigit ; Ajit Khaparde (ajit.khapa...@broadcom.com) ; je

RE: [PATCH v3 6/8] vdpa/ifc: support dynamic enable/disable queue

2022-10-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v3 6/8] vdpa/ifc: support dynamic enable/disable queue > > From: Huang Wei > > S

Re: CRC offload from application's POV

2022-10-12 Thread Ferruh Yigit
On 10/12/2022 9:18 AM, Wu, Wenjun1 wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, October 12, 2022 4:07 PM To: Wu, Wenjun1 ; Viacheslav Galaktionov ; Su, Simei Cc: Denis Pryazhennikov ; dev@dpdk.org Subject: Re: CRC offload from application's POV On 10/12/2022 3:29 AM

Re: [PATCH v8 7/9] memarea: support backup memory mechanism

2022-10-12 Thread fengchengwen
Hi Mattias, On 2022/10/12 4:26, Mattias Rönnblom wrote: > On 2022-10-11 17:58, Dmitry Kozlyuk wrote: >> 2022-10-11 12:17 (UTC+), Chengwen Feng: >>> This patch adds a memarea backup mechanism, where an allocation request >>> which cannot be met by the current memarea is deferred to its backup >

[PATCH] power: fix resource leak by open file pointers

2022-10-12 Thread Tadhg Kearney
Close file pointers to Intel uncore sysfiles. Coverity issue: 381400 381397 Fixes: 60b8a661a957 ("power: add Intel uncore frequency control") CC: david.h...@intel.com Signed-off-by: Tadhg Kearney --- lib/power/rte_power_intel_uncore.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib

RE: [PATCH v3 5/8] vdpa/ifc: only configure enabled queue

2022-10-12 Thread Pei, Andy
Hi Chenbo, Thanks for your effort. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 4:12 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 5/8] vdpa/ifc: only configure enabled qu

Re: [PATCH v2] IGC: Remove I225_I_PHY_ID checking

2022-10-12 Thread Kevin Traynor
On 12/10/2022 08:45, Mah, Yock Gen wrote: -Original Message- From: Kevin Traynor Sent: Tuesday, 11 October, 2022 7:05 PM To: IOTG DPDK Ref App ; Zhang, Qi Z Cc: dev@dpdk.org Subject: Re: [PATCH v2] IGC: Remove I225_I_PHY_ID checking On 31/08/2022 23:51, iotg.dpdk.ref@intel.com w

[PATCH v4] pci: read amd iommu virtual address width

2022-10-12 Thread Michael Piszczek
Add code to read the virtual address width for AMD processors. Signed-off-by: Michael Piszczek --- drivers/bus/pci/linux/pci.c | 48 - 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c ind

[PATCH v4] pci: read amd iommu virtual address width

2022-10-12 Thread Michael Piszczek
Add code to read the virtual address width for AMD processors. Signed-off-by: Michael Piszczek --- drivers/bus/pci/linux/pci.c | 48 - 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c ind

RE: [PATCH v2] IGC: Remove I225_I_PHY_ID checking

2022-10-12 Thread Mah, Yock Gen
-Original Message- From: Kevin Traynor Sent: Tuesday, 11 October, 2022 7:05 PM To: IOTG DPDK Ref App ; Zhang, Qi Z Cc: dev@dpdk.org Subject: Re: [PATCH v2] IGC: Remove I225_I_PHY_ID checking On 31/08/2022 23:51, iotg.dpdk.ref@intel.com wrote: > From: NSWE SWS DPDK Dev > > i225

Re: CRC offload from application's POV

2022-10-12 Thread Viacheslav Galaktionov
On 10/12/22 12:21, Ferruh Yigit wrote: On 10/12/2022 9:18 AM, Wu, Wenjun1 wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, October 12, 2022 4:07 PM To: Wu, Wenjun1 ; Viacheslav Galaktionov ; Su, Simei Cc: Denis Pryazhennikov ; dev@dpdk.org Subject: Re: CRC offload from

RE: [EXT] [PATCH v5 5/5] examples/l3fwd: use em vector path for event vector

2022-10-12 Thread Shijith Thotton
>From: Pavan Nikhilesh > >Use em vector path to process event vector. > >Signed-off-by: Pavan Nikhilesh >--- > examples/l3fwd/l3fwd_em.c| 13 +++-- > examples/l3fwd/l3fwd_em.h| 29 +-- > examples/l3fwd/l3fwd_em_hlm.h| 72 +--- > example

RE: [PATCH v2 1/3] app/testpmd: support congestion management CLIs

2022-10-12 Thread Sunil Kumar Kori
Please review the following changes and provide feedback. Regards Sunil Kumar Kori > -Original Message- > From: sk...@marvell.com > Sent: Thursday, September 29, 2022 3:25 PM > To: Aman Singh ; Yuying Zhang > > Cc: dev@dpdk.org; Sunil Kumar Kori > Subject: [PATCH v2 1/3] app/testpmd:

RE: [EXT] [PATCH v2 1/9] trace: fix mode for new trace point

2022-10-12 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Tuesday, October 4, 2022 3:14 PM > To: dev@dpdk.org > Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran ; > sta...@dpdk.org; Sunil Kumar Kori > Subject: [EXT] [PATCH v2 1/9] trace: fix mode for new trace point > > External Email > >

RE: [EXT] [PATCH v2 2/9] trace: fix mode change

2022-10-12 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Tuesday, October 4, 2022 3:14 PM > To: dev@dpdk.org > Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran ; > sta...@dpdk.org; Sunil Kumar Kori > Subject: [EXT] [PATCH v2 2/9] trace: fix mode change > > External Email > > -

RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue is ready

2022-10-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:16 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue > is ready > > When boot

RE: CRC offload from application's POV

2022-10-12 Thread Wu, Wenjun1
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 12, 2022 4:21 PM > To: Wu, Wenjun1 ; Viacheslav Galaktionov > ; Su, Simei > Cc: Denis Pryazhennikov ; > dev@dpdk.org > Subject: Re: CRC offload from application's POV > > On 10/12/2022 9:18 AM, Wu, Wenjun1 wrote: > >

RE: [EXT] [PATCH v2 3/9] trace: fix leak with regexp

2022-10-12 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Tuesday, October 4, 2022 3:14 PM > To: dev@dpdk.org > Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran ; > sta...@dpdk.org; Sunil Kumar Kori > Subject: [EXT] [PATCH v2 3/9] trace: fix leak with regexp > > External Email > >

RE: [EXT] [PATCH v2 4/9] trace: rework loop on trace points

2022-10-12 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Tuesday, October 4, 2022 3:14 PM > To: dev@dpdk.org > Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran ; > Sunil Kumar Kori > Subject: [EXT] [PATCH v2 4/9] trace: rework loop on trace points > > External Email > > --

Re: [PATCH v4] pci: read amd iommu virtual address width

2022-10-12 Thread Ferruh Yigit
On 10/11/2022 3:08 PM, Michael Piszczek wrote: Add code to read the virtual address width for AMD processors. Signed-off-by: Michael Piszczek --- drivers/bus/pci/linux/pci.c | 48 - 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/drivers/bu

RE: [EXT] [PATCH v2 5/9] trace: fix dynamically enabling trace points

2022-10-12 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Tuesday, October 4, 2022 3:14 PM > To: dev@dpdk.org > Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran ; > sta...@dpdk.org; Sunil Kumar Kori > Subject: [EXT] [PATCH v2 5/9] trace: fix dynamically enabling trace points > > External Email

[PATCH] devtools: add tracepoint check in checkpatch

2022-10-12 Thread Ankur Dwivedi
This patch adds a check in checkpatch tool, to check if a tracepoint is present in any new function added in cryptodev library. It uses the existing build_map_changes() function and version.map file to create a list of newly added functions. The definition of these functions are checked if they co

RE: [EXT] [PATCH v2 6/9] trace: fix race in debug dump

2022-10-12 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Tuesday, October 4, 2022 3:14 PM > To: dev@dpdk.org > Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran ; > sta...@dpdk.org; Sunil Kumar Kori > Subject: [EXT] [PATCH v2 6/9] trace: fix race in debug dump > > External Email > > --

RE: [EXT] [PATCH v2 7/9] trace: fix metadata dump

2022-10-12 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Tuesday, October 4, 2022 3:14 PM > To: dev@dpdk.org > Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran ; > sta...@dpdk.org; Sunil Kumar Kori > Subject: [EXT] [PATCH v2 7/9] trace: fix metadata dump > > External Email > > ---

RE: [EXT] [PATCH v2 9/9] trace: remove limitation on directory

2022-10-12 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Tuesday, October 4, 2022 3:14 PM > To: dev@dpdk.org > Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran ; > Sunil Kumar Kori > Subject: [EXT] [PATCH v2 9/9] trace: remove limitation on directory > > External Email > > ---

RE: [PATCH v3 8/8] vhost: improve vDPA blk device readiness condition

2022-10-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Friday, September 16, 2022 2:17 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Xu, Rosen ; > Huang, Wei ; Cao, Gang ; > maxime.coque...@redhat.com > Subject: [PATCH v3 8/8] vhost: improve vDPA blk device readiness condition > > In the virtio blk v

Re: [PATCH 7/8] trace: remove limitation on trace point name

2022-10-12 Thread Jerin Jacob
On Wed, Oct 12, 2022 at 1:18 PM David Marchand wrote: > > On Tue, Oct 11, 2022 at 4:49 PM Jerin Jacob wrote: > > > > On Wed, Sep 21, 2022 at 5:35 PM David Marchand > > wrote: > > > > > > The name of a trace point is provided as a constant string via the > > > RTE_TRACE_POINT_REGISTER macro. > >

Re: rte_event_dev_xstats_reset id type

2022-10-12 Thread Jerin Jacob
On Wed, Oct 12, 2022 at 1:40 PM Morten Brørup wrote: > > Hi Jerin (eventdev maintainer), + harry.van.haa...@intel.com as the changes in drivers/event/sw. > > While looking into bug #1101 [1], I noticed a mix of unsigned int and > uint32_t in the test code, which will fail on 64-bit big endian

Re: [EXT] Re: [PATCH v2 1/4] ethdev: add trace points

2022-10-12 Thread Jerin Jacob
On Thu, Oct 6, 2022 at 1:27 PM David Marchand wrote: > > On Thu, Oct 6, 2022 at 9:50 AM Andrew Rybchenko > wrote: > > > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index > > > 3def7bfd24..e3d603cc9a 100644 > > > --- a/lib/ethdev/version.map > > > +++ b/lib/ethdev/

Re: [EXT] Re: [PATCH v2 1/4] ethdev: add trace points

2022-10-12 Thread David Marchand
On Wed, Oct 12, 2022 at 11:50 AM Jerin Jacob wrote: > On Thu, Oct 6, 2022 at 1:27 PM David Marchand > wrote: > > On Thu, Oct 6, 2022 at 9:50 AM Andrew Rybchenko > > wrote: > > > > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index > > > > 3def7bfd24..e3d603cc9a 100644 >

Re: [EXT] [PATCH v2 5/9] trace: fix dynamically enabling trace points

2022-10-12 Thread David Marchand
On Wed, Oct 12, 2022 at 11:24 AM Sunil Kumar Kori wrote: > > diff --git a/lib/eal/common/eal_common_trace_utils.c > > b/lib/eal/common/eal_common_trace_utils.c > > index 2b55dbec65..7bf1c05e12 100644 > > --- a/lib/eal/common/eal_common_trace_utils.c > > +++ b/lib/eal/common/eal_common_trace_utils.

RE: [EXT] [PATCH v2 5/9] trace: fix dynamically enabling trace points

2022-10-12 Thread Sunil Kumar Kori
> -Original Message- > From: David Marchand > Sent: Wednesday, October 12, 2022 3:27 PM > To: Sunil Kumar Kori > Cc: dev@dpdk.org; sk...@mavell.com; Jerin Jacob Kollanukkaran > ; sta...@dpdk.org > Subject: Re: [EXT] [PATCH v2 5/9] trace: fix dynamically enabling trace points > > On Wed,

RE: rte_event_dev_xstats_reset id type

2022-10-12 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, October 12, 2022 10:45 AM > To: Morten Brørup ; Van Haaren, Harry > > Cc: Jerin Jacob ; dev@dpdk.org; Li, WeiyuanX > ; Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko > Subject: Re: rte_event_dev_xstats_reset id type > > On

[PATCH v3 2/2] build: make version file optional for drivers

2022-10-12 Thread Abdullah Ömer Yamaç
In this patch, we removed the necessity of the version files and you don't need to update these files for each release, you can just remove them. Signed-off-by: Abdullah Ömer Yamaç Suggested-by: Ferruh Yigit Series-acked-by: Bruce Richardson --- drivers/baseband/la12xx/version.map | 3 --- d

[PATCH v3 1/2] build: make version file optional for drivers

2022-10-12 Thread Abdullah Ömer Yamaç
In this patch, we removed the necessity of the version files and you don't need to update these files for each release, you can just remove them. Signed-off-by: Abdullah Ömer Yamaç Suggested-by: Ferruh Yigit Series-acked-by: Bruce Richardson --- drivers/meson.build | 65 +++

RE: rte_event_dev_xstats_reset id type

2022-10-12 Thread Morten Brørup
> From: Van Haaren, Harry [mailto:harry.van.haa...@intel.com] > Sent: Wednesday, 12 October 2022 12.30 > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, October 12, 2022 10:45 AM > > > > On Wed, Oct 12, 2022 at 1:40 PM Morten Brørup > > > wrote: > > > > > > Hi Jerin (ev

[PATCH v4 1/2] build: make version file optional for drivers

2022-10-12 Thread Abdullah Ömer Yamaç
In this patch, we removed the necessity of the version files and you don't need to update these files for each release, you can just remove them. Signed-off-by: Abdullah Ömer Yamaç Suggested-by: Ferruh Yigit Series-acked-by: Bruce Richardson --- drivers/meson.build | 65 +++

[PATCH v4 2/2] drivers: remove the unnecessary

2022-10-12 Thread Abdullah Ömer Yamaç
With the previous patch, some version.map files are not necessary. In this patch, we removed them. Signed-off-by: Abdullah Ömer Yamaç Suggested-by: Ferruh Yigit Series-acked-by: Bruce Richardson --- drivers/baseband/la12xx/version.map | 3 --- drivers/baseband/null/version.map | 3 --- d

[PATCH] fix: rename dpdk-ioat to dpdk-dma in example

2022-10-12 Thread Conor Walsh
When the dpdk-ioat app was renamed to dpdk-dma this example command was missed, this patch corrects that issue. Fixes: bb4141dbe5da ("examples/dma: rename ioat application example") Signed-off-by: Conor Walsh --- doc/guides/sample_app_ug/dma.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v9 0/7] introduce memarea library

2022-10-12 Thread Chengwen Feng
The memarea library is an allocator of variable-size object which based on a memory region. The main features are as follows: - The memory region can be initialized from the following memory sources: 1. HEAP: e.g. invoke rte_malloc_socket. 2. LIBC: e.g. invoke posix_memalign. 3. Another me

[PATCH v9 4/7] test/memarea: support alloc/free/refcnt-update test

2022-10-12 Thread Chengwen Feng
This patch supports rte_memarea_alloc()/rte_memarea_free()/ rte_memarea_refcnt_update() test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 145 +++- 1 file changed, 144 insertions(+), 1 deletion(-) diff --git a/app/test/test_memarea.c b/app/test

[PATCH v9 2/7] test/memarea: support memarea test

2022-10-12 Thread Chengwen Feng
This patch supports memarea test of rte_memarea_create() and rte_memarea_destroy() API. Signed-off-by: Chengwen Feng --- MAINTAINERS | 1 + app/test/meson.build| 2 + app/test/test_memarea.c | 142 3 files changed, 145 insertions(+) c

[PATCH v9 6/7] test/memarea: support dump test

2022-10-12 Thread Chengwen Feng
This patch supports rte_memarea_dump() test. Signed-off-by: Chengwen Feng --- app/test/test_memarea.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/app/test/test_memarea.c b/app/test/test_memarea.c index 5252d47fc1..5aa0683427 100644 --- a/app/test/test

[PATCH v9 3/7] memarea: support alloc/free/refcnt-update API

2022-10-12 Thread Chengwen Feng
This patch supports rte_memarea_alloc()/rte_memarea_free()/ rte_memarea_refcnt_update() API. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 10 ++ lib/memarea/memarea_private.h | 3 + lib/memarea/rte_memarea.c | 157 ++ lib

[PATCH v9 7/7] app/test: add memarea to malloc-perf-autotest

2022-10-12 Thread Chengwen Feng
This patch adds memarea to malloc_perf_autotest. Test platform: Kunpeng920 Test command: dpdk-test -a :7d:00.3 -l 10-12 Test result: USER1: Performance: rte_memarea USER1:Size (B) Runs Alloc (us) Free (us) Total (us) memset (us) USER1: 64 10.04 0.04 0.0

[PATCH v9 1/7] memarea: introduce memarea library

2022-10-12 Thread Chengwen Feng
The memarea library is an allocator of variable-size object which based on a memory region. This patch provides rte_memarea_create() and rte_memarea_destroy() API. Signed-off-by: Chengwen Feng --- MAINTAINERS| 5 + doc/api/doxy-api-index.md | 3 +- d

[PATCH v9 5/7] memarea: support dump API

2022-10-12 Thread Chengwen Feng
This patch supports rte_memarea_dump() API which could be used for debug. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 3 + lib/memarea/rte_memarea.c | 98 +++ lib/memarea/rte_memarea.h | 21 ++ lib/memarea/version.

RE: [PATCH v3 6/8] vdpa/ifc: support dynamic enable/disable queue

2022-10-12 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 4:20 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 6/8] vdpa/ifc: suppor

Re: [PATCH v4 1/2] build: make version file optional for drivers

2022-10-12 Thread Ferruh Yigit
On 10/12/2022 11:42 AM, Abdullah Ömer Yamaç wrote: In this patch, we removed the necessity of the version files and you don't need to update these files for each release, you can just remove them. Signed-off-by: Abdullah Ömer Yamaç Suggested-by: Ferruh Yigit Series-acked-by: Bruce Richardson

[PATCH] power: fix pstate number parsing

2022-10-12 Thread Markus Theil
From: Markus Theil When converting atoi to strtol in a revision of introducing sysfs support for turbo percentage, a necessary check against '\n' returned by sysfs was not introduced. Fixes: de254dac608e ("power: read P-state turbo percentage from sysfs") Signed-off-by: Markus Theil --- lib/po

[PATCH] net/bonding: fix socket_id type

2022-10-12 Thread Markus Theil
From: Thorben Roemer DPDK uses int or u32 in most other places for socket IDs. Fix compilation warnings by also using int in the bonding code. Signed-off-by: Thorben Roemer --- drivers/net/bonding/rte_eth_bond.h | 2 +- drivers/net/bonding/rte_eth_bond_api.c | 2 +- 2 files changed, 2 inse

[PATCH v2] devtools: add tracepoint check in checkpatch

2022-10-12 Thread Ankur Dwivedi
This patch adds a check in checkpatch tool, to check if a tracepoint is present in any new function added in cryptodev library. It uses the existing build_map_changes() function and version.map file to create a list of newly added functions. The definition of these functions are checked if they co

[PATCH] ethdev: add include for vtune

2022-10-12 Thread Markus Theil
From: Michael Pfeiffer Adding this include allowed us to use vtune with DPDK. Signed-off-by: Michael Pfeiffer --- lib/ethdev/ethdev_profile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/ethdev_profile.c b/lib/ethdev/ethdev_profile.c index 7978f351ac..90339cb2ee 100644 --- a/

[PATCH] telemetry: make usable from C++

2022-10-12 Thread Markus Theil
From: Markus Theil Add missing include in order to make C++ compilers happy. Signed-off-by: Markus Theil --- lib/telemetry/rte_telemetry.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h index 5e5ddaa25d..ded8e26b8b 100644 --- a

[PATCH v2 1/2] crypto/cnxk: align HW accessible field to ROC align

2022-10-12 Thread Anoob Joseph
Hardware accessible memory need to be aligned to ROC. Enforce the same. Move software specific fields to padding space. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 33 -- drivers/crypto/cnxk/cn10k_ipsec.c | 77 +++ drivers/crypt

[PATCH v2 2/2] crypto/cnxk: fix failure from session rework

2022-10-12 Thread Anoob Joseph
Post security session rework, CPTR got changed affecting cn9k IPsec functionality. Address the same. Also, move all s/w accessible fast path fields to rte_security_session cacheline for better perf. Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") Signed-off-by: Anoob Joseph --- v2

RE: [PATCH v3 7/8] vhost: vDPA blk device gets ready when any queue is ready

2022-10-12 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, October 12, 2022 5:09 PM > To: Pei, Andy ; dev@dpdk.org > Cc: Xu, Rosen ; Huang, Wei ; > Cao, Gang ; maxime.coque...@redhat.com > Subject: RE: [PATCH v3 7/8] vhost: vDPA blk

RE: rte_event_dev_xstats_reset id type

2022-10-12 Thread Van Haaren, Harry
> -Original Message- > From: Morten Brørup > Sent: Wednesday, October 12, 2022 11:41 AM > To: Van Haaren, Harry ; Jerin Jacob > > Cc: Jerin Jacob ; dev@dpdk.org; Li, WeiyuanX > ; Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko > Subject: RE: rte_event_dev_xstats_reset id type > > >

Re: [PATCH] net/bonding: fix socket_id type

2022-10-12 Thread Ferruh Yigit
On 10/12/2022 12:45 PM, Markus Theil wrote: From: Thorben Roemer DPDK uses int or u32 in most other places for socket IDs. Fix compilation warnings by also using int in the bonding code. Hi Markus, 'rte_eth_bond_create()' is part of API, so changing it impacts the users. Since 'rte_socket_

RE: [PATCH v7 0/4] Add lcore poll busyness telemetry

2022-10-12 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Monday, 10 October 2022 19.39 > > On 2022-10-10 17:22, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >> Sent: Thursday, 6 October 2022 17.27 > >> > >> On 2022-10-06 15:25, Morten Brørup wrot

RE: [PATCH] power: fix pstate number parsing

2022-10-12 Thread Pattan, Reshma
> -Original Message- > From: Markus Theil > +#include This is not needed right. > #include > #include > #include > @@ -96,7 +97,7 @@ power_read_turbo_pct(uint64_t *outVal) > > errno = 0; > *outVal = (uint64_t) strtol(val, &endptr, 10); > - if (*endptr != 0 ||

Re: [PATCH] ethdev: add include for vtune

2022-10-12 Thread Ferruh Yigit
On 10/12/2022 1:02 PM, Markus Theil wrote: From: Michael Pfeiffer Adding this include allowed us to use vtune with DPDK. Signed-off-by: Michael Pfeiffer --- lib/ethdev/ethdev_profile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/ethdev_profile.c b/lib/ethdev/ethdev_profi

[PATCH] net/ice: null field checks in ice_{r,t}x_queue_release

2022-10-12 Thread Markus Theil
From: Tomasz Jonak In case rte_eth_dma_zone_reserve fails in ice_tx_queue_setup ice_tx_queue_release is called on 0 allocated but not initialized txq struct. This may happen on ENOMEM condition, size exhaustion of memconfig->memzones array as well as some others. Signed-off-by: Tomasz Jonak ---

[PATCH v3 0/9] Trace subsystem fixes

2022-10-12 Thread David Marchand
Hello, This series addresses a number of issues and limitations I have identified over time in the trace subsystem. The main issue was with dynamically enabling trace points which was not working if no trace point had been enabled at rte_eal_init() time. This is 22.11 material. We may start thi

[PATCH v3 1/9] trace: fix mode for new trace point

2022-10-12 Thread David Marchand
If an application registers trace points later than rte_eal_init(), changes in the trace point mode were not applied. Fixes: 84c4fae4628f ("trace: implement operation APIs") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Jerin Jacob Acked-by: Sunil Kumar Kori --- lib/eal/common/e

[PATCH v3 3/9] trace: fix leak with regexp

2022-10-12 Thread David Marchand
The precompiled buffer initialised in regcomp must be freed before leaving rte_trace_regexp. Fixes: 84c4fae4628f ("trace: implement operation APIs") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Jerin Jacob Acked-by: Sunil Kumar Kori --- Changes since v1: - split patch in two, ke

[PATCH v3 2/9] trace: fix mode change

2022-10-12 Thread David Marchand
The API does not state that changing mode should be refused if no trace point is enabled. Remove this limitation. Fixes: 84c4fae4628f ("trace: implement operation APIs") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Sunil Kumar Kori --- app/test/test_trace.c | 3 ---

[PATCH v3 4/9] trace: rework loop on trace points

2022-10-12 Thread David Marchand
Directly skip the block when a trace point does not match the user criteria. Signed-off-by: David Marchand Acked-by: Jerin Jacob Acked-by: Sunil Kumar Kori --- lib/eal/common/eal_common_trace.c | 34 +-- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git

[PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-12 Thread David Marchand
Enabling trace points at runtime was not working if no trace point had been enabled first at rte_eal_init() time. The reason was that trace.args reflected the arguments passed to --trace= EAL option. To fix this: - the trace subsystem initialisation is updated: trace directory creation is deferr

[PATCH v3 6/9] trace: fix race in debug dump

2022-10-12 Thread David Marchand
trace->nb_trace_mem_list access must be under trace->lock to avoid races with threads allocating/freeing their trace buffers. Fixes: f6b2d65dcd5d ("trace: implement debug dump") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Jerin Jacob Acked-by: Sunil Kumar Kori --- lib/eal/comm

[PATCH v3 7/9] trace: fix metadata dump

2022-10-12 Thread David Marchand
The API does not describe that metadata dump is conditioned to enabling any trace points. While at it, merge dump unit tests into the generic trace_autotest to enhance coverage. Fixes: f6b2d65dcd5d ("trace: implement debug dump") Cc: sta...@dpdk.org Signed-off-by: David Marchand Acked-by: Sunil

[PATCH v3 9/9] trace: remove limitation on directory

2022-10-12 Thread David Marchand
Remove arbitrary limit on 12 characters of the file prefix used for the directory where to store the traces. Simplify the code by relying on dynamic allocations. Signed-off-by: David Marchand Acked-by: Jerin Jacob Acked-by: Sunil Kumar Kori --- lib/eal/common/eal_common_trace_utils.c | 68

[PATCH v3 8/9] trace: remove limitation on trace point name

2022-10-12 Thread David Marchand
The name of a trace point is provided as a constant string via the RTE_TRACE_POINT_REGISTER macro. We can rely on an explicit constant string in the binary and simply point at it. There is then no need for a (fixed size) copy. Signed-off-by: David Marchand --- Changes since v2: - stored trace poi

RE: [EXT] [PATCH v11 06/16] baseband/acc: add info get function for ACC200

2022-10-12 Thread Akhil Goyal
> From: Nic Chautru > > Added support for info_get to allow to query the device. > Null capability exposed. > > Signed-off-by: Nic Chautru > Reviewed-by: Maxime Coquelin > --- > drivers/baseband/acc/acc200_pmd.h | 1 + > drivers/baseband/acc/rte_acc200_pmd.c | 231 ++

[PATCH] event/sw: fix selftest xstats reset API usage

2022-10-12 Thread Harry van Haaren
The eventdev xstats reset API takes an ID of "uint32_t", while the rest of the xstats APIs require an "unsigned int". On some platforms these might not be the same bitwidth, however this was assumed in the code. Fix by providing a uint32_t to the xstats_reset() function. Fixes: e21df4b062b5 ("test

[PATCH v2] power: fix pstate number parsing

2022-10-12 Thread Markus Theil
From: Markus Theil When converting atoi to strtol in a revision of introducing sysfs support for turbo percentage, a necessary check against '\n' returned by sysfs was not introduced. Fixes: de254dac608e ("power: read P-state turbo percentage from sysfs") Reviewed-by: Reshma Pattan Acked-by: Re

RE: [EXT] [PATCH v11 16/16] test-bbdev: unit test capability extension

2022-10-12 Thread Akhil Goyal
> +in_sequence_size = > +24 > + > +in_leading_padding = > +0 > + > +out_sequence_size = > +3 > + > +out_leading_depadding = > +0 > + > +window_index = > +0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 > + > +cs_bitmap = > +255 > + > +num_antennas_log2 = > +3 > + > +ifft_log2 = > +5 > + > +fft_log2 = > +2 > + >

[PATCH v4] usertools: add check for IOMMU support in dpdk-devbind

2022-10-12 Thread Fidaullah Noonari
binding with vfio driver, when IOMMU is disabled, causes program to crash. this patch adds a flag for noiommmu-mode. when this is set, if IOMMU is disabled, it changes vfio into unsafe noiommu mode and prints warning message. Signed-off-by: Fidaullah Noonari --- usertools/dpdk-devbind.py | 45 ++

[PATCH] build: make headroom and max memzones configurable

2022-10-12 Thread Markus Theil
We often set headroom and memzones to a different value in our builds. This should also be useful in other projects. Signed-off-by: Markus Theil --- config/meson.build | 2 ++ config/rte_config.h | 2 -- meson_options.txt | 4 3 files changed, 6 insertions(+), 2 deletions(-) diff --git

  1   2   >