> -----Original Message-----
> From: David Marchand <david.march...@redhat.com>
> Sent: Tuesday, October 4, 2022 3:14 PM
> To: dev@dpdk.org
> Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran <jer...@marvell.com>;
> sta...@dpdk.org; Sunil Kumar Kori <sk...@marvell.com>
> Subject: [EXT] [PATCH v2 1/9] trace: fix mode for new trace point
> 
> External Email
> 
> ----------------------------------------------------------------------
> If an application registers trace points later than rte_eal_init(), changes 
> in the
> trace point mode were not applied.
> 
> Fixes: 84c4fae4628f ("trace: implement operation APIs")
> Cc: sta...@dpdk.org
> 
> Signed-off-by: David Marchand <david.march...@redhat.com>
> ---
>  lib/eal/common/eal_common_trace.c | 1 +
>  1 file changed, 1 insertion(+)
> 


Acked-by: Sunil Kumar Kori <sk...@marvell.com>

> diff --git a/lib/eal/common/eal_common_trace.c
> b/lib/eal/common/eal_common_trace.c
> index f9b187d15f..d5dbc7d667 100644
> --- a/lib/eal/common/eal_common_trace.c
> +++ b/lib/eal/common/eal_common_trace.c
> @@ -512,6 +512,7 @@ __rte_trace_point_register(rte_trace_point_t
> *handle, const char *name,
>       /* Form the trace handle */
>       *handle = sz;
>       *handle |= trace.nb_trace_points << __RTE_TRACE_FIELD_ID_SHIFT;
> +     trace_mode_set(handle, trace.mode);
> 
>       trace.nb_trace_points++;
>       tp->handle = handle;
> --
> 2.37.3

Reply via email to