On Wed, Oct 12, 2022 at 1:40 PM Morten Brørup <m...@smartsharesystems.com> wrote: > > Hi Jerin (eventdev maintainer),
+ harry.van.haa...@intel.com as the changes in drivers/event/sw. > > While looking into bug #1101 [1], I noticed a mix of unsigned int and > uint32_t in the test code, which will fail on 64-bit big endian CPUs. > > Specifically, rte_event_dev_xstats_reset() is called with the "ids" parameter > pointing to an unsigned int [2], but that parameter is a pointer to an > uint32_t. > > I think the type of the ids array parameter to rte_event_dev_xstats_reset() > should be changed to unsigned int array, like in the other > rte_event_dev_xxx() functions. > > Or even better, use the same type for an "xstats id" across all device types. > For ethdev devices, they are uint64_t, but I don't know why. (They are passed > around as arrays, so they could be 32 bit. I guess that they were originally > not used in arrays, so unsigned int seemed the logical choice.) > > > [1]: https://bugs.dpdk.org/show_bug.cgi?id=1101 > [2]: https://git.dpdk.org/dpdk/tree/drivers/event/sw/sw_evdev_selftest.c#n1766 > > > Med venlig hilsen / Kind regards, > -Morten Brørup >
