> -----Original Message-----
> From: David Marchand <david.march...@redhat.com>
> Sent: Tuesday, October 4, 2022 3:14 PM
> To: dev@dpdk.org
> Cc: sk...@mavell.com; Jerin Jacob Kollanukkaran <jer...@marvell.com>;
> sta...@dpdk.org; Sunil Kumar Kori <sk...@marvell.com>
> Subject: [EXT] [PATCH v2 2/9] trace: fix mode change
>
> External Email
>
> ----------------------------------------------------------------------
> The API does not state that changing mode should be refused if no trace
> point is enabled. Remove this limitation.
>
> Fixes: 84c4fae4628f ("trace: implement operation APIs")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand <david.march...@redhat.com>
> ---
> app/test/test_trace.c | 3 ---
> lib/eal/common/eal_common_trace.c | 3 ---
> 2 files changed, 6 deletions(-)
>
Acked-by: Sunil Kumar Kori <sk...@marvell.com>
> diff --git a/app/test/test_trace.c b/app/test/test_trace.c index
> 76af79162b..44ac38a4fa 100644
> --- a/app/test/test_trace.c
> +++ b/app/test/test_trace.c
> @@ -126,9 +126,6 @@ test_trace_mode(void)
>
> current = rte_trace_mode_get();
>
> - if (!rte_trace_is_enabled())
> - return TEST_SKIPPED;
> -
> rte_trace_mode_set(RTE_TRACE_MODE_DISCARD);
> if (rte_trace_mode_get() != RTE_TRACE_MODE_DISCARD)
> goto failed;
> diff --git a/lib/eal/common/eal_common_trace.c
> b/lib/eal/common/eal_common_trace.c
> index d5dbc7d667..1b86f5d2d2 100644
> --- a/lib/eal/common/eal_common_trace.c
> +++ b/lib/eal/common/eal_common_trace.c
> @@ -127,9 +127,6 @@ rte_trace_mode_set(enum rte_trace_mode mode) {
> struct trace_point *tp;
>
> - if (!rte_trace_is_enabled())
> - return;
> -
> STAILQ_FOREACH(tp, &tp_list, next)
> trace_mode_set(tp->handle, mode);
>
> --
> 2.37.3
