Re: rte_service unit test failing randomly

2022-10-06 Thread David Marchand
On Thu, Oct 6, 2022 at 8:53 AM Morten Brørup wrote: > > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > Sent: Wednesday, 5 October 2022 23.34 > > > > On 2022-10-05 22:52, Thomas Monjalon wrote: > > > 05/10/2022 22:33, Mattias Rönnblom: > > >> On 2022-10-05 21:14, David Marchand

RE: [PATCH v5 1/2] mem: telemetry support for memseg and element information

2022-10-06 Thread Amit Prakash Shukla
Hi David, If no other review comments, could you please pick this series for 22.11 rc1 ? Thanks, Amit Shukla > -Original Message- > From: Amit Prakash Shukla > Sent: Thursday, September 29, 2022 5:13 PM > To: Anatoly Burakov > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > david.march

Re: [PATCH v2 1/4] ethdev: add trace points

2022-10-06 Thread Andrew Rybchenko
On 9/29/22 13:29, Ankur Dwivedi wrote: Add trace points for ethdev functions. Signed-off-by: Ankur Dwivedi [snip] @@ -5867,6 +6010,7 @@ rte_eth_rx_metadata_negotiate(uint16_t port_id, uint64_t *features) { struct rte_eth_dev *dev; + rte_eth_trace_rx_metadata_negotiate(port_id,

Re: [PATCH v2 0/4] add trace points in ethdev library

2022-10-06 Thread Andrew Rybchenko
On 9/29/22 13:29, Ankur Dwivedi wrote: This series adds trace points for functions in the ethdev library. The trace points are added in ethdev, flow, mtr and tm files. v2: - Made rte_eth_trace_call_rx_callbacks and rte_eth_trace_call_tx_callbacks as fastpath trace functions. - Moved some

[PATCH 1/2] drivers: suggestion on meson without version file

2022-10-06 Thread Abdullah Ömer Yamaç
Most of the drivers don't have a special version.map file. They just included due to the compilation issue and needs to be updated for each release. These version.map files include: DPDK_23 { local: *; }; In this patch, we removed the necessity of the version files and you don't need to update

[PATCH 2/2] drivers: remove the unnecessary version.map

2022-10-06 Thread Abdullah Ömer Yamaç
With the previous patch, some version.map files are not necessary. In this patch, we removed them. Signed-off-by: Abdullah Ömer Yamaç Suggested-by: Ferruh Yigit --- Depends on: patch-116222 ("build: increase minimum meson version to 0.53") --- drivers/baseband/la12xx/version.map | 3 --- dri

RE: [PATCH v3] vhost: compilation fix for GCC-12

2022-10-06 Thread Amit Prakash Shukla
Ping. > -Original Message- > From: Amit Prakash Shukla > Sent: Friday, September 2, 2022 8:36 PM > To: Maxime Coquelin ; Chenbo Xia > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > sta...@dpdk.org; ruifeng.w...@arm.com; Amit Prakash Shukla > > Subject: [PATCH v3] vhost: compilation

Re: [PATCH v3] vhost: compilation fix for GCC-12

2022-10-06 Thread Maxime Coquelin
Hi Amit, On 10/6/22 09:22, Amit Prakash Shukla wrote: Ping. I posted a patch yesterday that fixes this issue without having to change the runtime behavior: http://patches.dpdk.org/project/dpdk/patch/20221005203524.89336-1-maxime.coque...@redhat.com/ Could you test it and provide ack if OK on

RE: [EXT] Re: [PATCH v2 1/4] ethdev: add trace points

2022-10-06 Thread Ankur Dwivedi
Hi Andrew, >-Original Message- >From: Andrew Rybchenko >Sent: Thursday, October 6, 2022 12:40 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; >ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; ciara.lof...

Re: [EXT] Re: [PATCH v2 1/4] ethdev: add trace points

2022-10-06 Thread Andrew Rybchenko
On 10/6/22 10:24, Ankur Dwivedi wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Thursday, October 6, 2022 12:40 PM To: Ankur Dwivedi ; dev@dpdk.org Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com; l

RE: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library

2022-10-06 Thread Ankur Dwivedi
Hi Andrew, >-Original Message- >From: Andrew Rybchenko >Sent: Thursday, October 6, 2022 12:40 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; >ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; ciara.lof...

Re: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library

2022-10-06 Thread Andrew Rybchenko
On 10/6/22 10:26, Ankur Dwivedi wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Thursday, October 6, 2022 12:40 PM To: Ankur Dwivedi ; dev@dpdk.org Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com; l

RE: [EXT] Re: [PATCH v2 1/4] ethdev: add trace points

2022-10-06 Thread Ankur Dwivedi
>-Original Message- >From: Andrew Rybchenko >Sent: Thursday, October 6, 2022 12:58 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; >ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; ciara.lof...@intel.com

Re: [PATCH 08/15] net/dpaa2: fix buffer free on transmit SG packets

2022-10-06 Thread Ferruh Yigit
On 9/28/2022 6:25 AM, Gagandeep Singh wrote: When using SG list to TX with external and direct buffers, HW free the direct buffers and driver free the external buffers. Software scans the complete SG mbuf list to find the external buffers to free, but this is wrong as hardware can free the direc

RE: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library

2022-10-06 Thread Ankur Dwivedi
>-Original Message- >From: Andrew Rybchenko >Sent: Thursday, October 6, 2022 12:59 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; >ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; ciara.lof...@intel.com

Re: [EXT] Re: [PATCH v2 1/4] ethdev: add trace points

2022-10-06 Thread Andrew Rybchenko
@David, see small question below. @Thomas, @Ferruh, @Jerin see question below as well. On 10/6/22 10:43, Ankur Dwivedi wrote: -Original Message- From: Andrew Rybchenko Sent: Thursday, October 6, 2022 12:58 PM To: Ankur Dwivedi ; dev@dpdk.org Cc: tho...@monjalon.net; m...@ashroe.eu;

RE: rte_service unit test failing randomly

2022-10-06 Thread Morten Brørup
+CC: DTS mailing list. > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 6 October 2022 09.05 > > On Thu, Oct 6, 2022 at 8:53 AM Morten Brørup > wrote: [...] > > Forgive me, if I am sidetracking a bit here... The issue discussed > seems to be related to some threads w

Re: rte_service unit test failing randomly

2022-10-06 Thread Mattias Rönnblom
On 2022-10-06 08:53, Morten Brørup wrote: >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] >> Sent: Wednesday, 5 October 2022 23.34 >> >> On 2022-10-05 22:52, Thomas Monjalon wrote: >>> 05/10/2022 22:33, Mattias Rönnblom: On 2022-10-05 21:14, David Marchand wrote: > Hello,

Re: [PATCH v3] vhost: fix build issues with GCC 12

2022-10-06 Thread Maxime Coquelin
Hi Stephen, On 10/6/22 02:01, Stephen Hemminger wrote: On Wed, 5 Oct 2022 22:35:24 +0200 Maxime Coquelin wrote: In practice, it would never happen since 'pkt->pkt_len' is unlikely to be close to UINT32_MAX, but let's just change 'size' to uint64_t to make the compiler happy without having to

Re: [EXT] Re: [PATCH v2 1/4] ethdev: add trace points

2022-10-06 Thread David Marchand
On Thu, Oct 6, 2022 at 9:50 AM Andrew Rybchenko wrote: > > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index > > 3def7bfd24..e3d603cc9a 100644 > > --- a/lib/ethdev/version.map > > +++ b/lib/ethdev/version.map > > @@ -288,6 +288,150 @@ EXPERIMENTAL { > > > >

Re: [PATCH] app/testpmd: fix incorrect flow arguments name

2022-10-06 Thread Singh, Aman Deep
On 9/30/2022 5:09 PM, Suanming Mou wrote: There should be no spaces in flow command arguments name. This commit removes incorrect arguments name in queue based table template. Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations") Cc: akozy...@nvidia.com Signed-off-by:

RE: [EXT] Re: [PATCH v3] vhost: compilation fix for GCC-12

2022-10-06 Thread Amit Prakash Shukla
Hi Maxime, Sure, I will test and reply on your patch. Thanks, Amit Shukla > -Original Message- > From: Maxime Coquelin > Sent: Thursday, October 6, 2022 12:55 PM > To: Amit Prakash Shukla ; Chenbo Xia > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > sta...@dpdk.org; ruifeng.w...@arm

[dpdk-dev v4] lib/cryptodev: multi-process IPC request handler

2022-10-06 Thread Kai Ji
As some cryptode PMDs have multiprocess support, the secondary process needs queue-pair to be configured by the primary process before to use. This patch adds an IPC register function to help the primary process to register IPC action that allow secondary process to configure cryptodev queue-pair v

[PATCH] test/service: fix spurious failures by extending timeout

2022-10-06 Thread Harry van Haaren
This commit extends the timeout for service_may_be_active() from 100ms to 1000ms. Local testing on a idle and loaded system (compiling DPDK with all cores) always completes after 1 ms. The same timeout waiting code was duplicated in two tests, and is now refactored to a standalone function avoidin

RE: rte_service unit test failing randomly

2022-10-06 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Thursday, 6 October 2022 09.51 > > On 2022-10-06 08:53, Morten Brørup wrote: [...] > > I have been wondering how accurate the tests really are. Where can I > see what is being done to ensure that the EAL worker threads are f

RE: [EXT] Re: [PATCH v3] vhost: fix build issues with GCC 12

2022-10-06 Thread Amit Prakash Shukla
Hi Maxime, Compiled this patch with aarch64-linux-gnu-gcc (GCC) 12.2.0 and it compiles fine. Thanks, Amit Shukla > -Original Message- > From: Maxime Coquelin > Sent: Thursday, October 6, 2022 1:21 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; cheng1.ji...@intel.com; chenbo@intel.

[PATCH] crypto/mvsam: fix build for session rework

2022-10-06 Thread Akhil Goyal
mvsam build was broken due to the recent session rework, as it was not enabled in default build. This patch fixes the build. Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") Fixes: bdce2564dbf7 ("cryptodev: rework session framework") Fixes: 66837861d375 ("drivers/crypto: support secu

Re: [PATCH v4 1/3] ethdev: introduce ethdev desc dump API

2022-10-06 Thread Dongdong Liu
Hi Ferruh Many thanks for your review. On 2022/10/4 6:40, Ferruh Yigit wrote: On 9/23/2022 8:43 AM, Dongdong Liu wrote: From: "Min Hu (Connor)" Added the ethdev Rx/Tx desc dump API which provides functions for query descriptor from device. HW descriptor info differs in different NICs. The i

[PATCH v2] test/service: fix spurious failures by extending timeout

2022-10-06 Thread Harry van Haaren
This commit extends the timeout for service_may_be_active() from 100ms to 1000ms. Local testing on a idle and loaded system (compiling DPDK with all cores) always completes after 1 ms. The wait time for a service-lcore to finish is also extended from 100ms to 1000ms. The same timeout waiting code

Re: [PATCH v5 1/6] eal: add thread attributes

2022-10-06 Thread David Marchand
On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff wrote: > @@ -57,7 +65,105 @@ enum rte_thread_priority { > __rte_experimental > rte_thread_t rte_thread_self(void); > > -#ifdef RTE_HAS_CPUSET > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice. > + * > + * Check if

Re: [PATCH v5 4/6] test/threads: add tests for thread lifetime API

2022-10-06 Thread David Marchand
On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff wrote: > > Test basic functionality and demonstrate use of following thread > lifetime api. > > * rte_thread_create > * rte_thread_detach And, to some extent, rte_thread_equal. > * rte_thread_join > > Signed-off-by: Narcisa Vasile > Sign

Re: [PATCH v4] ethdev: support congestion management

2022-10-06 Thread Andrew Rybchenko
@Jerin, could you confirm if my minor changes are OK for you and, if so, I'll proceed with applying the patch. On 10/4/22 12:02, Andrew Rybchenko wrote: From: Jerin Jacob NIC HW controllers often come with congestion management support on various HW objects such as Rx queue depth or mempool qu

Re: [PATCH] test/service: fix spurious failures by extending timeout

2022-10-06 Thread Mattias Rönnblom
On 2022-10-06 10:17, Harry van Haaren wrote: > This commit extends the timeout for service_may_be_active() > from 100ms to 1000ms. Local testing on a idle and loaded system > (compiling DPDK with all cores) always completes after 1 ms. > > The same timeout waiting code was duplicated in two tests,

Re: [PATCH v2] test/service: fix spurious failures by extending timeout

2022-10-06 Thread David Marchand
On Thu, Oct 6, 2022 at 10:28 AM Harry van Haaren wrote: > > This commit extends the timeout for service_may_be_active() > from 100ms to 1000ms. Local testing on a idle and loaded system > (compiling DPDK with all cores) always completes after 1 ms. > > The wait time for a service-lcore to finish i

RE: [PATCH 06/15] net/dpaa: support ESP packet type in packet parsing

2022-10-06 Thread Gagandeep Singh
Hi > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 5, 2022 7:51 PM > To: Gagandeep Singh > Cc: dev@dpdk.org > Subject: Re: [PATCH 06/15] net/dpaa: support ESP packet type in packet > parsing > > On 9/28/2022 6:25 AM, Gagandeep Singh wrote: > > Add support of ESP pac

RE: [PATCH 07/15] net/dpaa2: use internal mempool for SG table

2022-10-06 Thread Gagandeep Singh
Hi > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 5, 2022 7:51 PM > To: Gagandeep Singh ; dev@dpdk.org > Subject: Re: [PATCH 07/15] net/dpaa2: use internal mempool for SG table > > On 9/28/2022 6:25 AM, Gagandeep Singh wrote: > > Creating and using driver's mempool

RE: [PATCH 15/15] net/dpaa: fix buffer free in slow path

2022-10-06 Thread Gagandeep Singh
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 5, 2022 7:52 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH 15/15] net/dpaa: fix buffer free in slow path > > On 9/28/2022 6:25 AM, Gagandeep Singh wrote: > > Adding a check in s

RE: [PATCH 11/15] bus/dpaa: pass interface name as a string instead of pointer

2022-10-06 Thread Gagandeep Singh
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 5, 2022 7:52 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: Rohit Raj > Subject: Re: [PATCH 11/15] bus/dpaa: pass interface name as a string instead > of pointer > > On 9/28/2022 6:25 AM, Gagandeep Singh wrote: > > Fro

Re: [Patch v10 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD

2022-10-06 Thread Ferruh Yigit
On 10/6/2022 12:21 AM, lon...@linuxonhyperv.com wrote: From: Long Li MANA is a network interface card to be used in the Azure cloud environment. MANA provides safe access to user memory through memory registration. It has IOMMU built into the hardware. MANA uses IB verbs and RDMA layer to co

Re: [PATCH v2] test/service: fix spurious failures by extending timeout

2022-10-06 Thread Mattias Rönnblom
On 2022-10-06 10:39, David Marchand wrote: > On Thu, Oct 6, 2022 at 10:28 AM Harry van Haaren > wrote: >> >> This commit extends the timeout for service_may_be_active() >> from 100ms to 1000ms. Local testing on a idle and loaded system >> (compiling DPDK with all cores) always completes after 1 ms

Re: rte_service unit test failing randomly

2022-10-06 Thread Mattias Rönnblom
On 2022-10-06 10:18, Morten Brørup wrote: >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] >> Sent: Thursday, 6 October 2022 09.51 >> >> On 2022-10-06 08:53, Morten Brørup wrote: > > [...] > >>> I have been wondering how accurate the tests really are. Where can I >> see what is be

Re: [EXT] Re: [PATCH v3] vhost: fix build issues with GCC 12

2022-10-06 Thread Maxime Coquelin
On 10/6/22 10:22, Amit Prakash Shukla wrote: Hi Maxime, Compiled this patch with aarch64-linux-gnu-gcc (GCC) 12.2.0 and it compiles fine. Thanks Amit! Thanks, Amit Shukla -Original Message- From: Maxime Coquelin Sent: Thursday, October 6, 2022 1:21 PM To: Stephen Hemminger Cc

Re: [EXT] DPDK build for Arm with GCC 12

2022-10-06 Thread Thomas Monjalon
06/10/2022 08:14, Rahul Bhansali: > Hi Thomas, > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, October 4, 2022 6:17 PM > > To: Rahul Bhansali ; Akhil Goyal > > > > Cc: dev@dpdk.org; ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com > > Subject: [EXT] DPDK build for

Re: [PATCH v2] examples: compilation fix for GCC-12

2022-10-06 Thread Thomas Monjalon
06/10/2022 08:31, Amit Prakash Shukla: > checkpatch complains about coding style error. It looks like a false positive > ? Yes we can ignore this checkpatch warning.

Re: [PATCH v2] examples: compilation fix for GCC-12

2022-10-06 Thread Thomas Monjalon
02/09/2022 09:43, Amit Prakash Shukla: > GCC-12 warns when a pointer of type union points to an array of same > defined size, as union internally gets paded with pad bytes. > > ../examples/common/neon/port_group.h:42:21: error: array subscript > 'union [0]' is partly outside array bounds of

Re: [PATCH 07/15] net/dpaa2: use internal mempool for SG table

2022-10-06 Thread Ferruh Yigit
On 10/6/2022 9:49 AM, Gagandeep Singh wrote: Hi -Original Message- From: Ferruh Yigit Sent: Wednesday, October 5, 2022 7:51 PM To: Gagandeep Singh ; dev@dpdk.org Subject: Re: [PATCH 07/15] net/dpaa2: use internal mempool for SG table On 9/28/2022 6:25 AM, Gagandeep Singh wrote: Creat

[PATCH v9 0/3] add Intel uncore api to be called through l3fwd-power

2022-10-06 Thread Tadhg Kearney
This is targeting 22.11 and aims to add an API to DPDK power library to allow uncore frequency adjustment. This will be called through the l3fwd-power app and gives the ability to set the minimum and maximum uncore frequency to both min, max or specific frequency index. Signed-off-by: tadhgkearney

[PATCH v9 1/3] power: add Intel uncore frequency control API to power library

2022-10-06 Thread Tadhg Kearney
Add API to allow uncore frequency adjustment. Uncore is a term used by Intel to describe function of a microprocessor that are closely connected to the core to achieve high performance. This is done through manipulating related uncore frequency control sysfs entries to adjust the minimum and maximu

[PATCH v9 2/3] l3fwd-power: add option to call uncore API

2022-10-06 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt Acked-by: David Hunt --- ..

[PATCH v9 3/3] test/power: add unit tests for uncore API

2022-10-06 Thread Tadhg Kearney
Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt Acked-by: David Hunt --- app/test/meson.build | 2 + app/test/test_power_intel_uncore.c | 301 + 2 files changed, 303 insertions(+) create mode

Re: [PATCH 11/15] bus/dpaa: pass interface name as a string instead of pointer

2022-10-06 Thread Ferruh Yigit
On 10/6/2022 9:51 AM, Gagandeep Singh wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, October 5, 2022 7:52 PM To: Gagandeep Singh ; dev@dpdk.org Cc: Rohit Raj Subject: Re: [PATCH 11/15] bus/dpaa: pass interface name as a string instead of pointer On 9/28/2022 6:25 AM,

Re: [PATCH 15/15] net/dpaa: fix buffer free in slow path

2022-10-06 Thread Ferruh Yigit
On 10/6/2022 9:51 AM, Gagandeep Singh wrote: Hi, -Original Message- From: Ferruh Yigit Sent: Wednesday, October 5, 2022 7:52 PM To: Gagandeep Singh ; dev@dpdk.org Cc: sta...@dpdk.org Subject: Re: [PATCH 15/15] net/dpaa: fix buffer free in slow path On 9/28/2022 6:25 AM, Gagandeep Sing

RE: rte_service unit test failing randomly

2022-10-06 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Thursday, 6 October 2022 10.59 > > On 2022-10-06 10:18, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >> Sent: Thursday, 6 October 2022 09.51 > >> > >> On 2022-10-06 08:53, Morten Br

Re: [PATCH 1/2] net/i40e: compilation fix for GCC-12

2022-10-06 Thread Thomas Monjalon
24/08/2022 16:03, Amit Prakash Shukla: > GCC 12 raises the following warning: > > meson --werror --buildtype=debugoptimized > --cross-file config/x86/cross-mingw -Dexamples=helloworld build > ninja -C build > > In function 'i40e_hash_get_pattern_type', > inlined from 'i40e_hash_get_patt

Re: [PATCH 2/2] net/qede/base: compilation fix for GCC-12

2022-10-06 Thread Thomas Monjalon
24/08/2022 16:03, Amit Prakash Shukla: > GCC 12 raises the following warning: > > ../drivers/net/qede/base/ecore_init_fw_funcs.c: In function > 'ecore_dmae_to_grc.constprop.isra': > ../drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25: > error: array subscript 1 is outside array bounds of

[PATCH] mem: close rtemap files

2022-10-06 Thread huzaifa.rahman
Bugzilla ID: 560 The memory subsystem is leaving open a file descriptor for each rtemap file. This can lead to hundreds of extra open file descriptors which has negative side effects. For example, the application may go over its maximum file descriptor limit, or the application may be using limite

Re: [PATCH v8 1/4] ethdev: introduce protocol header API

2022-10-06 Thread Andrew Rybchenko
On 10/6/22 02:18, Yuan Wang wrote: Add a new ethdev API to retrieve supported protocol headers of a PMD, which helps to configure protocol header based buffer split. Signed-off-by: Yuan Wang Signed-off-by: Xuan Ding Signed-off-by: Wenxuan Wu Reviewed-by: Andrew Rybchenko New function shoul

Re: [PATCH v8 2/4] ethdev: introduce protocol hdr based buffer split

2022-10-06 Thread Andrew Rybchenko
On 10/6/22 02:18, Yuan Wang wrote: Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD will be able to split the received packets into multiple segments. However, length based buffer split is

Re: [PATCH v8 3/4] app/testpmd: add rxhdrs commands and parameters

2022-10-06 Thread Andrew Rybchenko
On 10/6/22 02:18, Yuan Wang wrote: Add command line parameter: --rxhdrs=eth[,ipv4,udp] Set the protocol_hdr of segments to scatter packets on receiving if split feature is engaged. And the queues with BUFFER_SPLIT flag. Add interactive mode command: testpmd>set rxhdrs eth,ipv4,udp (protocol seq

Re: [PATCH v8 4/4] net/ice: support buffer split in Rx path

2022-10-06 Thread Andrew Rybchenko
On 10/6/22 02:18, Yuan Wang wrote: This patch adds support for protocol based buffer split in normal Rx "This patch adds" -> "Add" data paths. When the Rx queue is configured with specific protocol type, packets received will be directly split into protocol header and payload parts limitation

Re: [PATCH v8 0/4] support protocol based buffer split

2022-10-06 Thread Andrew Rybchenko
On 10/6/22 02:18, Yuan Wang wrote: Protocol type based buffer split consists of splitting a received packet into several separate segments based on the packet content. It is useful in some scenarios, such as GPU acceleration. The splitting will help to enable true zero copy and hence improve the

Re: [PATCH] crypto/mvsam: fix build for session rework

2022-10-06 Thread Thomas Monjalon
06/10/2022 10:22, Akhil Goyal: > mvsam build was broken due to the recent session rework, > as it was not enabled in default build. > This patch fixes the build. > > Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") > Fixes: bdce2564dbf7 ("cryptodev: rework session framework") > Fixes

Re: [PATCH v3] vhost: fix build issues with GCC 12

2022-10-06 Thread Thomas Monjalon
05/10/2022 22:35, Maxime Coquelin: > This patch fixes a compilation issue met with GCC 12 on > LoongArch64: > > In function ‘mbuf_to_desc’, > inlined from ‘vhost_enqueue_async_packed’ at > ../../../dpdk/lib/vhost/virtio_net.c:1822:6, > inlined from ‘virtio_dev_rx_async_packed’ at > ../..

Re: [PATCH] net/qede/base: fix 32-bit build with GCC 12

2022-10-06 Thread Thomas Monjalon
04/10/2022 13:18, Thomas Monjalon: > A pointer is passed to a macro and it seems mistakenly referenced. > This issue is seen only when compiling with GCC 12 for 32-bit: > > drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25: > error: array subscript 1 is outside array bounds of ‘u32[1]’ >

Re: [PATCH] net/i40e: fix build with MinGW GCC 12

2022-10-06 Thread Thomas Monjalon
04/10/2022 13:21, Thomas Monjalon: > 04/10/2022 13:17, Thomas Monjalon: > > When compiling with MinGW GCC 12, > > the rte_flow_item array is seen as read out of bound: > > > > net/i40e/i40e_hash.c:389:47: error: > > array subscript 50 is above array bounds of ‘const uint64_t[50]’ > > {aka

Re: [PATCH] examples/l2fwd-cat: fix build

2022-10-06 Thread Thomas Monjalon
05/10/2022 17:28, David Marchand: > On Wed, Oct 5, 2022 at 5:24 PM Kevin Traynor wrote: > > > > and need to be included for the build > > since they were removed from . > > > > ../examples/l2fwd-cat/cat.c: In function ‘parse_set’: > > ../examples/l2fwd-cat/cat.c:66:16: > > warning: implicit decl

Re: [PATCH v2] rcu: fix build failure with debug dp log level

2022-10-06 Thread Thomas Monjalon
29/09/2022 12:27, Anoob Joseph: > Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the > same by including the required header. > > ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’ > 678 |"%s: status: least acked token = %" PRIu64, > |

Re: [PATCH] mem: close rtemap files

2022-10-06 Thread Dmitry Kozlyuk
2022-10-06 10:04 (UTC+), huzaifa.rahman: > Bugzilla ID: 560 > > The memory subsystem is leaving open a file descriptor for each > rtemap file. This can lead to hundreds of extra open file descriptors > which has negative side effects. For example, the application may go > over its maximum file

[PATCH v2 0/8] ethdev: introduce hairpin memory capabilities

2022-10-06 Thread Dariusz Sosnowski
The hairpin queues are used to transmit packets received on the wire, back to the wire. How hairpin queues are implemented and configured is decided internally by the PMD and applications have no control over the configuration of Rx and Tx hairpin queues. This patchset addresses that by: - Exten

[PATCH v2 1/8] ethdev: introduce hairpin memory capabilities

2022-10-06 Thread Dariusz Sosnowski
Before this patch, implementation details and configuration of hairpin queues were decided internally by the PMD. Applications had no control over the configuration of Rx and Tx hairpin queues, despite number of descriptors, explicit Tx flow mode and disabling automatic binding. This patch addresse

[PATCH v2 2/8] common/mlx5: add hairpin SQ buffer type capabilities

2022-10-06 Thread Dariusz Sosnowski
This patch extends HCA_CAP and SQ Context structs available in PRM. This fields allow checking if NIC supports storing hairpin SQ's WQ buffer in host memory and configuring such memory placement. HCA capabilities are extended with the following fields: - hairpin_sq_wq_in_host_mem - If set, then N

[PATCH v2 3/8] common/mlx5: add hairpin RQ buffer type capabilities

2022-10-06 Thread Dariusz Sosnowski
This patch adds new HCA capability related to hairpin RQs. This new capability, hairpin_data_buffer_locked, indicates whether HCA supports locking data buffer of hairpin RQ in ICMC (Interconnect Context Memory Cache). Struct used to define RQ configuration (RQ context) is extended with hairpin_dat

[PATCH v2 4/8] net/mlx5: allow hairpin Tx queue in RTE memory

2022-10-06 Thread Dariusz Sosnowski
This patch adds a capability to place hairpin Tx queue in host memory managed by DPDK. This capability is equivalent to storing hairpin SQ's WQ buffer in host memory. Hairpin Tx queue creation is extended with allocating a memory buffer of proper size (calculated from required number of packets an

[PATCH v2 5/8] net/mlx5: allow hairpin Rx queue in locked memory

2022-10-06 Thread Dariusz Sosnowski
This patch adds a capability to place hairpin Rx queue in locked device memory. This capability is equivalent to storing hairpin RQ's data buffers in locked internal device memory. Hairpin Rx queue creation is extended with requesting that RQ is allocated in locked internal device memory. If alloc

[PATCH v2 6/8] doc: add notes for hairpin to mlx5 documentation

2022-10-06 Thread Dariusz Sosnowski
This patch extends mlx5 PMD documentation with more information regarding hairpin support. The following is added to mlx5 PMD documentation: - description of the default behavior of hairpin queues, - description of use_locked_device_memory effect on hairpin queue configuration, - description of

[PATCH v2 7/8] app/testpmd: add hairpin queues memory modes

2022-10-06 Thread Dariusz Sosnowski
This patch extends hairpin-mode command line option of test-pmd application with an ability to configure whether Rx/Tx hairpin queue should use locked device memory or RTE memory. For purposes of this configurations the following bits of 32 bit hairpin-mode are reserved: - Bit 8 - If set, then fo

[PATCH v2 8/8] app/flow-perf: add hairpin queue memory config

2022-10-06 Thread Dariusz Sosnowski
This patch adds the hairpin-conf command line parameter to flow-perf application. hairpin-conf parameter takes a hexadecimal bitmask with bits having the following meaning: - Bit 0 - Force memory settings of hairpin RX queue. - Bit 1 - Force memory settings of hairpin TX queue. - Bit 4 - Use locke

RE: [PATCH 7/7] app/flow-perf: add hairpin queue memory config

2022-10-06 Thread Dariusz Sosnowski
Hi, > -Original Message- > From: Wisam Monther > Sent: Tuesday, October 4, 2022 14:25 > To: Dariusz Sosnowski > Cc: dev@dpdk.org > Subject: RE: [PATCH 7/7] app/flow-perf: add hairpin queue memory config > > Hi Dariusz, > > > -Original Message- > > From: Dariusz Sosnowski > > S

Re: [dpdklab] RE: rte_service unit test failing randomly

2022-10-06 Thread Lincoln Lavoie
On Thu, Oct 6, 2022 at 5:49 AM Morten Brørup wrote: > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > Sent: Thursday, 6 October 2022 10.59 > > > > On 2022-10-06 10:18, Morten Brørup wrote: > > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > >> Sent: Thursd

RE: [PATCH 0/7] ethdev: introduce hairpin memory capabilities

2022-10-06 Thread Dariusz Sosnowski
Hi Thomas, I sent the v2 of the patches. > 1/ motivation (why is this needed) I added the feature motivation in the cover letter of v2. > 2/ compilation on Windows > looks like devx_umem_reg has 5 parameters in Windows glue! Fix for that is included in v2. Best regards, Dariusz Sosnowsk

RE: [PATCH 00/15] DPAA and DPAA2 driver changes

2022-10-06 Thread Hemant Agrawal
Series- Acked-by: Hemant Agrawal > -Original Message- > From: Gagandeep Singh > Sent: Wednesday, September 28, 2022 10:55 AM > To: ferruh.yi...@amd.com; dev@dpdk.org > Cc: Gagandeep Singh > Subject: [PATCH 00/15] DPAA and DPAA2 driver changes > > This series have list of patch for bug

RE: [PATCH 07/15] net/dpaa2: use internal mempool for SG table

2022-10-06 Thread Gagandeep Singh
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 6, 2022 3:08 PM > To: Gagandeep Singh ; dev@dpdk.org > Subject: Re: [PATCH 07/15] net/dpaa2: use internal mempool for SG table > > On 10/6/2022 9:49 AM, Gagandeep Singh wrote: > > Hi > > > >> -Original Message-

RE: [PATCH 11/15] bus/dpaa: pass interface name as a string instead of pointer

2022-10-06 Thread Gagandeep Singh
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 6, 2022 3:10 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: Rohit Raj > Subject: Re: [PATCH 11/15] bus/dpaa: pass interface name as a string instead > of pointer > > On 10/6/2022 9:51 AM, Gagandeep Singh wrote: > > > >

RE: [PATCH 15/15] net/dpaa: fix buffer free in slow path

2022-10-06 Thread Gagandeep Singh
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 6, 2022 3:12 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH 15/15] net/dpaa: fix buffer free in slow path > > On 10/6/2022 9:51 AM, Gagandeep Singh wrote: > > Hi, > > > >> -Origi

RE: [PATCH 1/7] ethdev: introduce hairpin memory capabilities

2022-10-06 Thread Dariusz Sosnowski
Hi Thomas, > What is the benefit? Goal of this patchset is to present application developers with more options to fine tune hairpin configuration to their use case. I added more details regarding the possible benefits and motivation to the cover letter of v2. > How the user knows what to use?

Re: [PATCH v8 0/6] Introduce support for LoongArch architecture

2022-10-06 Thread David Marchand
Hello Min, On Tue, Oct 4, 2022 at 5:41 PM Min Zhou wrote: > > Dear team, > > The following patch set is intended to support DPDK running on LoongArch > architecture. > > LoongArch is the general processor architecture of Loongson Corporation > and is a new RISC ISA, which is a bit like MIPS or RI

RE: [dpdklab] RE: rte_service unit test failing randomly

2022-10-06 Thread Morten Brørup
From: Lincoln Lavoie [mailto:lylav...@iol.unh.edu] Sent: Thursday, 6 October 2022 13.07 > On Thu, Oct 6, 2022 at 5:49 AM Morten Brørup > wrote: > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > Sent: Thursday, 6 October 2022 10.59 > > > > On 2022-10-06 10:18, Morten Brørup w

[PATCH v5 0/3] support ethdev Rx/Tx descriptor dump

2022-10-06 Thread Dongdong Liu
Support ethdev Rx/Tx descriptor dump by using procinfo tool. Thanks to Ferruh, Andrew and Reshma help to review the patchset. NOTE: October 1st to October 7th is China's National Day holiday. I don't have a test environment available at the moment. I will test this patchset on October 8th. Curre

[PATCH v5 1/3] ethdev: introduce ethdev desc dump API

2022-10-06 Thread Dongdong Liu
Added the ethdev Rx/Tx desc dump API which provides functions for query descriptor from device. HW descriptor info differs in different NICs. The information demonstrates I/O process which is important for debug. As the information is different between NICs, the new API is introduced. Signed-off-b

[PATCH v5 2/3] net/hns3: support Rx/Tx bd dump

2022-10-06 Thread Dongdong Liu
This patch support query HW descriptor from hns3 device. HW descriptor is also called BD(buffer description) which is shared memory between software and hardware. Signed-off-by: Min Hu (Connor) Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_dump.c | 88 ++

[PATCH v5 3/3] app/procinfo: support descriptor dump

2022-10-06 Thread Dongdong Liu
This patch support Rx/Tx descriptor dump The command is like: dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-rx-descriptor queue_id:offset:num dpdk-proc-info -a :xx:xx.x --file-prefix=xxx -- --show-tx-descriptor queue_id:offset:num queue_id: A queue identifier on this port. offse

Re: [EXT] Re: [PATCH v3] vhost: compilation fix for GCC-12

2022-10-06 Thread David Marchand
On Thu, Oct 6, 2022 at 10:05 AM Amit Prakash Shukla wrote: > > Hi Maxime, > > Sure, I will test and reply on your patch. Thomas merged Maxime alternative. Marking this patch as rejected. Thanks. -- David Marchand

Re: [PATCH v8 0/6] Introduce support for LoongArch architecture

2022-10-06 Thread zhoumin
Hi, David, It is hard to find words to express my gratitude. On Thu, Oct 6, 2022 at 19:49, David Marchand wrote: Hello Min, On Tue, Oct 4, 2022 at 5:41 PM Min Zhou wrote: Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the gen

[PATCH v3] test/service: fix spurious failures by extending timeout

2022-10-06 Thread Harry van Haaren
This commit extends the timeout for service_may_be_active() from 100ms to 1000ms. Local testing on a idle and loaded system (compiling DPDK with all cores) always completes after 1 ms. The wait time for a service-lcore to finish is also extended from 100ms to 1000ms. The same timeout waiting code

RE: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library

2022-10-06 Thread Ankur Dwivedi
Hi Andrew, >-Original Message- >From: Ankur Dwivedi >Sent: Thursday, October 6, 2022 1:18 PM >To: Andrew Rybchenko ; dev@dpdk.org >Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; >ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; ciara.lof...@i

Re: [PATCH] net/virtio: remove declaration of undefined function

2022-10-06 Thread Maxime Coquelin
On 9/29/22 14:22, Olivier Matz wrote: This function is not defined, remove its declaration. Fixes: c1f86306a026 ("virtio: add new driver") Signed-off-by: Olivier Matz --- drivers/net/virtio/virtqueue.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/virtio/virtqueue.h

Re: [PATCH] net/virtio: add queue and port ID in some logs

2022-10-06 Thread Maxime Coquelin
On 9/29/22 14:22, Olivier Matz wrote: Add the queue id and/or the port id in some logs, so it is easier to understand what happens. Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 6 -- drivers/net/virtio/virtio_rxtx.c | 3 ++- 2 files changed, 6 insertions(+),

RE: [PATCH v2 1/2] examples/fips_validation: share test callback with multiple keys

2022-10-06 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Friday, August 12, 2022 12:52 PM > To: dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > ; Dooley, Brian ; Akhil > Goyal ; jer...@marvell.com; Gowrishankar > Muthukrishnan > Subject: [PATCH v2 1/2] examples/fips_validation:

RE: [PATCH v7 0/4] Add lcore poll busyness telemetry

2022-10-06 Thread Morten Brørup
> From: Kevin Laatz [mailto:kevin.la...@intel.com] > Sent: Wednesday, 5 October 2022 15.45 > > On 14/09/2022 10:29, Kevin Laatz wrote: > > Currently, there is no way to measure lcore polling busyness in a > passive > > way, without any modifications to the application. This patchset adds > a new >

RE: [PATCH v3] test/service: fix spurious failures by extending timeout

2022-10-06 Thread Morten Brørup
> From: Harry van Haaren [mailto:harry.van.haa...@intel.com] > Sent: Thursday, 6 October 2022 14.53 > > This commit extends the timeout for service_may_be_active() > from 100ms to 1000ms. Local testing on a idle and loaded system > (compiling DPDK with all cores) always completes after 1 ms. > >

  1   2   3   >