Hi Andrew,
>-----Original Message-----
>From: Ankur Dwivedi
>Sent: Thursday, October 6, 2022 1:18 PM
>To: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>; dev@dpdk.org
>Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com;
>ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com;
>linvi...@tuxdriver.com; ciara.lof...@intel.com; qi.z.zh...@intel.com;
>m...@semihalf.com; m...@semihalf.com; shaib...@amazon.com;
>evge...@amazon.com; igo...@amazon.com; cha...@amd.com; Igor
>Russkikh <irussk...@marvell.com>; shepard.sie...@atomicrules.com;
>ed.cz...@atomicrules.com; john.mil...@atomicrules.com;
>ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Jerin Jacob
>Kollanukkaran <jer...@marvell.com>; Maciej Czekaj [C]
><mcze...@marvell.com>; Shijith Thotton <sthot...@marvell.com>;
>Srisivasubramanian Srinivasan <sriniva...@marvell.com>; Harman Kalra
><hka...@marvell.com>; rahul.lakkire...@chelsio.com; johnd...@cisco.com;
>hyon...@cisco.com; liudongdo...@huawei.com;
>yisen.zhu...@huawei.com; xuanziya...@huawei.com;
>cloud.wangxiao...@huawei.com; zhouguoy...@huawei.com;
>simei...@intel.com; wenjun1...@intel.com; qiming.y...@intel.com;
>yuying.zh...@intel.com; beilei.x...@intel.com; xiao.w.w...@intel.com;
>jingjing...@intel.com; junfeng....@intel.com; rosen...@intel.com; Nithin
>Kumar Dabilpuram <ndabilpu...@marvell.com>; Kiran Kumar Kokkilagadda
><kirankum...@marvell.com>; Sunil Kumar Kori <sk...@marvell.com>; Satha
>Koteswara Rao Kottidi <skotesh...@marvell.com>; Liron Himi
><lir...@marvell.com>; z...@semihalf.com; Radha Chintakuntla
><rad...@marvell.com>; Veerasenareddy Burru <vbu...@marvell.com>;
>Sathesh B Edara <sed...@marvell.com>; ma...@nvidia.com;
>viachesl...@nvidia.com; sthem...@microsoft.com; lon...@microsoft.com;
>spin...@cesnet.cz; chaoyong...@corigine.com;
>niklas.soderl...@corigine.com; hemant.agra...@nxp.com;
>sachin.sax...@oss.nxp.com; g.si...@nxp.com; apeksha.gu...@nxp.com;
>sachin.sax...@nxp.com; abo...@pensando.io; Rasesh Mody
><rm...@marvell.com>; Shahed Shaikh <shsha...@marvell.com>; Devendra
>Singh Rawat <dsinghra...@marvell.com>; jiawe...@trustnetic.com;
>jianw...@trustnetic.com; jbehr...@vmware.com;
>maxime.coque...@redhat.com; chenbo....@intel.com;
>steven.webs...@windriver.com; matt.pet...@windriver.com;
>bruce.richard...@intel.com; mtetsu...@gmail.com; gr...@u256.net;
>jasvinder.si...@intel.com; cristian.dumitre...@intel.com;
>jgraj...@cisco.com
>Subject: RE: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library
>
>
>
>>-----Original Message-----
>>From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
>>Sent: Thursday, October 6, 2022 12:59 PM
>>To: Ankur Dwivedi <adwiv...@marvell.com>; dev@dpdk.org
>>Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com;
>>ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com;
>>linvi...@tuxdriver.com; ciara.lof...@intel.com; qi.z.zh...@intel.com;
>>m...@semihalf.com; m...@semihalf.com; shaib...@amazon.com;
>>evge...@amazon.com; igo...@amazon.com; cha...@amd.com; Igor
>Russkikh
>><irussk...@marvell.com>; shepard.sie...@atomicrules.com;
>>ed.cz...@atomicrules.com; john.mil...@atomicrules.com;
>>ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Jerin Jacob
>>Kollanukkaran <jer...@marvell.com>; Maciej Czekaj [C]
>><mcze...@marvell.com>; Shijith Thotton <sthot...@marvell.com>;
>>Srisivasubramanian Srinivasan <sriniva...@marvell.com>; Harman Kalra
>><hka...@marvell.com>; rahul.lakkire...@chelsio.com;
>johnd...@cisco.com;
>>hyon...@cisco.com; liudongdo...@huawei.com;
>yisen.zhu...@huawei.com;
>>xuanziya...@huawei.com; cloud.wangxiao...@huawei.com;
>>zhouguoy...@huawei.com; simei...@intel.com; wenjun1...@intel.com;
>>qiming.y...@intel.com; yuying.zh...@intel.com; beilei.x...@intel.com;
>>xiao.w.w...@intel.com; jingjing...@intel.com; junfeng....@intel.com;
>>rosen...@intel.com; Nithin Kumar Dabilpuram
><ndabilpu...@marvell.com>;
>>Kiran Kumar Kokkilagadda <kirankum...@marvell.com>; Sunil Kumar Kori
>><sk...@marvell.com>; Satha Koteswara Rao Kottidi
>><skotesh...@marvell.com>; Liron Himi <lir...@marvell.com>;
>>z...@semihalf.com; Radha Chintakuntla <rad...@marvell.com>;
>>Veerasenareddy Burru <vbu...@marvell.com>; Sathesh B Edara
>><sed...@marvell.com>; ma...@nvidia.com; viachesl...@nvidia.com;
>>sthem...@microsoft.com; lon...@microsoft.com; spin...@cesnet.cz;
>>chaoyong...@corigine.com; niklas.soderl...@corigine.com;
>>hemant.agra...@nxp.com; sachin.sax...@oss.nxp.com; g.si...@nxp.com;
>>apeksha.gu...@nxp.com; sachin.sax...@nxp.com; abo...@pensando.io;
>>Rasesh Mody <rm...@marvell.com>; Shahed Shaikh
><shsha...@marvell.com>;
>>Devendra Singh Rawat <dsinghra...@marvell.com>;
>>jiawe...@trustnetic.com; jianw...@trustnetic.com;
>jbehr...@vmware.com;
>>maxime.coque...@redhat.com; chenbo....@intel.com;
>>steven.webs...@windriver.com; matt.pet...@windriver.com;
>>bruce.richard...@intel.com; mtetsu...@gmail.com; gr...@u256.net;
>>jasvinder.si...@intel.com; cristian.dumitre...@intel.com;
>>jgraj...@cisco.com
>>Subject: Re: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev
>>library
>>
>>On 10/6/22 10:26, Ankur Dwivedi wrote:
>>> Hi Andrew,
>>>
>>>> -----Original Message-----
>>>> From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
>>>> Sent: Thursday, October 6, 2022 12:40 PM
>>>> To: Ankur Dwivedi <adwiv...@marvell.com>; dev@dpdk.org
>>>> Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com;
>>>> ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com;
>>>> linvi...@tuxdriver.com; ciara.lof...@intel.com;
>>>> qi.z.zh...@intel.com; m...@semihalf.com; m...@semihalf.com;
>>>> shaib...@amazon.com; evge...@amazon.com; igo...@amazon.com;
>>>> cha...@amd.com; Igor
>>Russkikh
>>>> <irussk...@marvell.com>; shepard.sie...@atomicrules.com;
>>>> ed.cz...@atomicrules.com; john.mil...@atomicrules.com;
>>>> ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Jerin
>>Jacob
>>>> Kollanukkaran <jer...@marvell.com>; Maciej Czekaj [C]
>>>> <mcze...@marvell.com>; Shijith Thotton <sthot...@marvell.com>;
>>>> Srisivasubramanian Srinivasan <sriniva...@marvell.com>; Harman Kalra
>>>> <hka...@marvell.com>; rahul.lakkire...@chelsio.com;
>>>> johnd...@cisco.com; hyon...@cisco.com; liudongdo...@huawei.com;
>>>> yisen.zhu...@huawei.com; xuanziya...@huawei.com;
>>>> cloud.wangxiao...@huawei.com; zhouguoy...@huawei.com;
>>>> simei...@intel.com; wenjun1...@intel.com; qiming.y...@intel.com;
>>>> yuying.zh...@intel.com; beilei.x...@intel.com;
>>>> xiao.w.w...@intel.com; jingjing...@intel.com; junfeng....@intel.com;
>>>> rosen...@intel.com; Nithin Kumar Dabilpuram
>>>> <ndabilpu...@marvell.com>; Kiran Kumar Kokkilagadda
>>>> <kirankum...@marvell.com>; Sunil Kumar Kori <sk...@marvell.com>;
>>>> Satha Koteswara Rao Kottidi <skotesh...@marvell.com>; Liron Himi
>>>> <lir...@marvell.com>; z...@semihalf.com; Radha Chintakuntla
>>>> <rad...@marvell.com>; Veerasenareddy Burru <vbu...@marvell.com>;
>>>> Sathesh B Edara <sed...@marvell.com>; ma...@nvidia.com;
>>>> viachesl...@nvidia.com; sthem...@microsoft.com;
>>>> lon...@microsoft.com; spin...@cesnet.cz; chaoyong...@corigine.com;
>>>> niklas.soderl...@corigine.com; hemant.agra...@nxp.com;
>>>> sachin.sax...@oss.nxp.com;
>>g.si...@nxp.com;
>>>> apeksha.gu...@nxp.com; sachin.sax...@nxp.com;
>abo...@pensando.io;
>>>> Rasesh Mody <rm...@marvell.com>; Shahed Shaikh
>>>> <shsha...@marvell.com>; Devendra Singh Rawat
>>>> <dsinghra...@marvell.com>; jiawe...@trustnetic.com;
>>>> jianw...@trustnetic.com; jbehr...@vmware.com;
>>>> maxime.coque...@redhat.com; chenbo....@intel.com;
>>>> steven.webs...@windriver.com; matt.pet...@windriver.com;
>>>> bruce.richard...@intel.com; mtetsu...@gmail.com; gr...@u256.net;
>>>> jasvinder.si...@intel.com; cristian.dumitre...@intel.com;
>>>> jgraj...@cisco.com
>>>> Subject: [EXT] Re: [PATCH v2 0/4] add trace points in ethdev library
>>>>
>>>> External Email
>>>>
>>>> --------------------------------------------------------------------
>>>> -
>>>> - On 9/29/22 13:29, Ankur Dwivedi wrote:
>>>>> This series adds trace points for functions in the ethdev library.
>>>>> The trace points are added in ethdev, flow, mtr and tm files.
>>>>>
>>>>> v2:
>>>>> - Made rte_eth_trace_call_rx_callbacks and
>>rte_eth_trace_call_tx_callbacks
>>>>> as fastpath trace functions.
>>>>> - Moved some trace functions call to the end to capture return value
>and
>>>>> data.
>>>>
>>>> Looking at the patch series I still see many-many places where
>>>> tracing happens on entry point. Intentional?
>>> Yes , because the return values are not there to be captured.
>>
>>Isn't it the reason to move trace point to have return value there and
>>capture it?
>[Ankur] For some function the return value was there to be captured. But for
>some functions the return values are not possible to get unless some more
>changes are made in code, like the rte_eth_rx_metadata_negotiate() you
>mentioned in earlier mail. I have not modified the existing code of library,
>just
>added trace to capture what can be captured.
[Ankur] Identified few more functions for which trace can be shift towards the
end of a function. Will send the changes in v3.
>>
>>>>
>>>>> - Removed rte_eth_trace_tx_queue_setup as it is not required.
>>>>> rte_ethdev_trace_txq_setup() is already present in
>>>>> rte_eth_tx_queue_setup().
>>>>> - Removed trace in ethdev_driver.c
>>>>> - Removed trace function check patch.
>>>>>
>>>>> Ankur Dwivedi (4):
>>>>> ethdev: add trace points
>>>>> ethdev: add trace points for flow
>>>>> ethdev: add trace points for mtr
>>>>> ethdev: add trace points for tm
>>>>>
>>>>> lib/ethdev/ethdev_private.c | 3 +
>>>>> lib/ethdev/ethdev_trace_points.c | 699 ++++++++++
>>>>> lib/ethdev/rte_ethdev.c | 148 +++
>>>>> lib/ethdev/rte_ethdev_trace.h | 2062
>>>> ++++++++++++++++++++++++++++++
>>>>> lib/ethdev/rte_ethdev_trace_fp.h | 19 +
>>>>> lib/ethdev/rte_flow.c | 54 +
>>>>> lib/ethdev/rte_mtr.c | 27 +
>>>>> lib/ethdev/rte_tm.c | 40 +
>>>>> lib/ethdev/version.map | 232 ++++
>>>>> 9 files changed, 3284 insertions(+)
>>>>>
>>>
