Minutes of Technical Board Meeting, 2022-May-18

2022-05-31 Thread Maxime Coquelin
Members Attending --- -Aaron -Bruce -Honnappa -Konstantin -Kevin -Maxime (chair) -Olivier -Stephen -Thomas NOTE: The technical board meetings are on every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community members are welcome

RE: [PATCH v4 01/12] cryptodev: redefine ec group enum

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:04 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 01/12] cryptodev: redefine ec group enum > > - EC enum was renamed to rte_crypto_curve_id. > Ell

RE: [PATCH v4 02/12] cryptodev: separate key exchange operation enum

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:04 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 02/12] cryptodev: separate key exchange operation > enum > > - Separated key exchange enum from

RE: [PATCH v4 03/12] cryptodev: remove comment about using ephemeral key in dsa

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:05 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 03/12] cryptodev: remove comment about using > ephemeral key in dsa > > - Removed comment that s

RE: [PATCH v4 04/12] cryptodev: clarify usage of private key in dh

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:05 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 04/12] cryptodev: clarify usage of private key in dh > > - Clarified usage of private key in Dif

Re: [PATCH v6 5/5] baseband/acc100: configuration of ACC101 from PF

2022-05-31 Thread Maxime Coquelin
Hi Nicolas, Thanks for doing the API change, this part looks good to me now. I just have one comment below that was not addressed: On 5/26/22 02:55, Nicolas Chautru wrote: Adding companion function common to ACC100/ACC101 which can be called from bbdev-test when running from PF. Signed-off-by:

RE: [PATCH v4 05/12] cryptodev: move dh type from xform to dh op

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:05 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 05/12] cryptodev: move dh type from xform to dh op > > - Moved dh operation type to dh operation

RE: [PATCH v4 06/12] cryptodev: add elliptic curve diffie hellman

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:05 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX ; m...@ashroe.eu > Subject: [PATCH v4 06/12] cryptodev: add elliptic curve diffie hellman > > - Added elliptic curve D

RE: [PATCH v4 07/12] cryptodev: add public key verify option

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:05 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 07/12] cryptodev: add public key verify option > > - Added key exchange public key verify option

RE: [PATCH v4 08/12] cryptodev: add asym op flags

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:05 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 08/12] cryptodev: add asym op flags > > - Added flags to rte_crypto_asym_op struct. > It may be

RE: [PATCH v4 09/12] cryptodev: clarify usage of rsa padding hash

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:05 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 09/12] cryptodev: clarify usage of rsa padding hash > > - Clarified usage of RSA padding hash. >

Re: [PATCH 0/9] Wangxun fixes and new supports

2022-05-31 Thread Ferruh Yigit
On 5/30/2022 10:30 AM, Jiawen Wu wrote: [CAUTION: External Email] Fixed some bugs for ngbe and txgbe, and support a new PHY ID. Jiawen Wu (9): net/ngbe: fix to set force speed net/ngbe: add support for yt8531s PHY net/ngbe: fix occasional failure of reading PHY ID net/ngbe: fix exte

RE: [PATCH v4 10/12] cryptodev: move RSA padding into separate struct

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:05 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 10/12] cryptodev: move RSA padding into separate struct > > - move RSA padding into separate str

RE: [PATCH v4 11/12] cryptodev: clarify rsa verify with none padding

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:05 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 11/12] cryptodev: clarify rsa verify with none padding > > - Clarified where should output be st

RE: [PATCH v4 12/12] cryptodev: add salt length and optional label

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:05 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 12/12] cryptodev: add salt length and optional label > > - Added salt length and optional label.

RE: [PATCH v4 00/12] cryptodev: rsa, dh, ecdh changes

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 5:04 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 00/12] cryptodev: rsa, dh, ecdh changes > > This patchset introduces some of changes discussed o

Re: [PATCH v5 4/5] baseband/acc100: modify validation code for ACC101

2022-05-31 Thread Maxime Coquelin
Hi Nicolas, On 5/26/22 00:15, Chautru, Nicolas wrote: -Original Message- From: Maxime Coquelin Sent: Wednesday, May 25, 2022 7:33 AM To: Chautru, Nicolas ; dev@dpdk.org; gak...@marvell.com; t...@redhat.com Cc: tho...@monjalon.net; Kinsella, Ray ; Richardson, Bruce ; hemant.agra...@nx

Re: [PATCH v6 4/5] baseband/acc100: modify validation code for ACC101

2022-05-31 Thread Maxime Coquelin
On 5/26/22 02:55, Nicolas Chautru wrote: The validation requirement is different for the two devices. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 47 1 file changed, 35 insertions(+), 12 deletions(-) diff --git a/drivers/

[PATCH] examples/kni: clear warning about discarding const qualifier

2022-05-31 Thread Ke Zhang
The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Compulsory type conversion to clear compile warning. Signed-off-by: Ke Zhang --- kernel/linux/kni/kni_misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kern

Re: [PATCH v4 06/12] cryptodev: add elliptic curve diffie hellman

2022-05-31 Thread Ray Kinsella
Arek Kusztal writes: > - Added elliptic curve Diffie-Hellman parameters. > Point multiplication allows the user to process every phase of > ECDH, but for phase 1, user should not really care about the generator. > The user does not even need to know what the generator looks like, > therefore se

Re: [PATCH v4] kni: optimize alloc queue release

2022-05-31 Thread Naga Harish K, S V
Hi all, Looks like this patch is out there for review for quite some time. Can somebody review this patch? -Harish From: Naga Harish K S V Sent: Thursday, April 14, 2022 11:05 PM To: ferruh.yi...@xilinx.com ; Yigit, Ferruh Cc: Jayatheerthan, Jay ; dev@dpdk.org

Re: [PATCH] examples/kni: clear warning about discarding const qualifier

2022-05-31 Thread Bruce Richardson
On Tue, May 31, 2022 at 08:13:04AM +, Ke Zhang wrote: > The warning info: > warning: passing argument 1 of ‘memcpy’ discards ‘const’ > qualifier from pointer target type > > Compulsory type conversion to clear compile warning. > > Signed-off-by: Ke Zhang > --- > kernel/linux/kni/kni_misc.c

[PATCH] examples/kni: clear warning about discarding const qualifier

2022-05-31 Thread Ke Zhang
The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Compulsory type conversion to clear compile warning. Signed-off-by: Ke Zhang --- kernel/linux/kni/kni_misc.c | 4 ++-- kernel/linux/kni/kni_net.c | 2 +- 2 files changed, 3 insertions(

Re: [PATCH] examples/kni: clear warning about discarding const qualifier

2022-05-31 Thread Ferruh Yigit
On 5/31/2022 10:12 AM, Bruce Richardson wrote: [CAUTION: External Email] On Tue, May 31, 2022 at 08:13:04AM +, Ke Zhang wrote: The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Compulsory type conversion to clear compile warning.

[RFC v2] bus/fslmc: fix invalid use of default VFIO config

2022-05-31 Thread Romain Delhomel
At device probe, the fslmc bus driver calls rte_vfio_get_group_fd() to get a fd associated to a vfio group. This function first checks if the group is already opened, else it opens /dev/vfio/%u, and increases the number of active groups in default_vfio_cfg (which references the default vfio contain

[PATCH v10] sched: enable traffic class oversubscription conditionally

2022-05-31 Thread Marcin Danilewicz
Added new API for flag to enable or disable TC oversubscription for best effort traffic class at subport level. By default TC OV is enabled. Signed-off-by: Marcin Danilewicz --- History: - v1 - TC OV disabled by default - v2 - throughput improvements - v3, v4, v5 - changes from comments - v6 -

[PATCH v4] net/ice: retry sending adminQ command after failure

2022-05-31 Thread peng1x . zhang
From: Peng Zhang The origin design is if error happen during the step 3 of following given situation, it will return error directly without retry. While in current patch, it will retry again and again during certain time. If retry succeed, rule can be continuously created. It will improve succe

[PATCH v5 0/4] Add APIs for configurable power options

2022-05-31 Thread Kevin Laatz
The power library contains some variables which are currently set by defines, hard-coded values or set using sysfs values. In order to configure these, code changes and recompiles are required, making configuring these variables tedious. This patchset introduces some new get/set APIs which allow u

[PATCH v5 1/4] lib/power: add get and set API for emptypoll max

2022-05-31 Thread Kevin Laatz
Add new get/set APIs to configure emptypoll max which is used to determine when a queue can go into sleep state. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Tested-by: David Hunt --- v5: add doc entry for new API --- doc/guides/prog_guide/power_man.rst | 6 ++ lib/power/rte_power_p

[PATCH v5 2/4] lib/power: add get and set API for pause duration

2022-05-31 Thread Kevin Laatz
Add new get/set API for configuring 'pause_duration' which used to adjust the pause mode callback duration. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Acked-by: Anatoly Burakov Tested-by: David Hunt --- v5: add doc entry for new API v3: changed printf to RTE_LOG --- doc/guides/prog_gu

[PATCH v5 3/4] lib/power: add get and set API for scaling freq min and max with pstate mode

2022-05-31 Thread Kevin Laatz
Add new get/set API to allow the user or application to set the minimum and maximum frequencies to use when scaling. Previously, the frequency range was determined by the HW capabilities of the CPU. With this new API, the user or application can constrain this if required. Signed-off-by: Kevin Laa

[PATCH v5 4/4] examples/l3fwd_power: add cli for configurable options

2022-05-31 Thread Kevin Laatz
Add CLI options to l3fwd_power to utilize the new power APIs introduced in this patchset. These CLI options allow the user to configure the heuritstics made available through the new API via the l3fwd_power application options. Signed-off-by: Kevin Laatz Acked-by: Anatoly Burakov --- v3: move s

[v2 11/24] eal/loongarch: add pflock operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds pflock operations for LoongArch architecture. Let it uses generic pflock implementation. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_pflock.h | 17 + 1 file changed, 17 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_pflock.h diff --

[v2 10/24] eal/loongarch: add pause operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds architecture specific pause operations for LoongArch architecture. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_pause.h | 24 1 file changed, 24 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_pause.h diff --git a/lib/eal/loo

[v2 05/24] eal/loongarch: add spinlock operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds spinlock operations for LoongArch architecture. These implementations are based on standard atomics of toolchain and heavily reference generic spinlock codes. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_spinlock.h | 90 1 file changed, 90 in

[v2 21/24] i40e: add dummy vector implementation for LoongArch

2022-05-31 Thread Min Zhou
The purpose of this patch is used to fix building issues for LoongArch architecture. The hardware instructions based vector implementation will come in a future patch. Signed-off-by: Min Zhou --- drivers/net/i40e/i40e_rxtx_vec_lsx.c | 54 drivers/net/i40e/meson.build

[v2 00/24] Support LoongArch architecture

2022-05-31 Thread Min Zhou
Dear team, The following patch set is intended to support DPDK running on LoongArch architecture. LoongArch is the general processor architecture of Loongson and is a new RISC ISA, which is a bit like MIPS or RISC-V. The online documents of LoongArch are here: https://loongson.github.io/L

[v2 07/24] eal/loongarch: add dummy vector memcpy for LoongArch

2022-05-31 Thread Min Zhou
The hardware instructions based vector implementation for memcpy will come later. At present, this dummy implementation can also work. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_memcpy.h | 193 + lib/eal/loongarch/include/rte_vect.h | 47 ++ 2 files

[v2 12/24] eal/loongarch: add rwlock operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds rwlock operations for LoongArch architecture. These implementations refer to rte_rwlock.h of PPC. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_rwlock.h | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 lib/eal/loongarch/include/rte

[v2 04/24] eal/loongarch: add prefetch operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds architecture specific prefetch operations for LoongArch architecture. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_prefetch.h | 47 1 file changed, 47 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_prefetch.h diff --git a/li

[v2 23/24] memif: add system call number for LoongArch

2022-05-31 Thread Min Zhou
This patch adds system call number of memfd_create for LoongArch architecture. Signed-off-by: Min Zhou --- drivers/net/memif/rte_eth_memif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/memif/rte_eth_memif.h b/drivers/net/memif/rte_eth_memif.h index a5ee23d42e

[v2 01/24] eal/loongarch: add atomic operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds architecture specific atomic operations for LoongArch architecture. These implementations use standard atomics of toolchain and heavily reference generic atomics codes. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_atomic.h | 253 + 1 file chan

[v2 24/24] maintainers: claim responsibility for LoongArch

2022-05-31 Thread Min Zhou
This patch adds claim responsibility for LoongArch architecture. Signed-off-by: Min Zhou --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 17a0559ee7..69ea00cddf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -269,6 +269,15 @@ F: lib/eal/

[v2 14/24] eal/loongarch: add power operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds power operations for LoongArch architecture. In fact, these operations are temporarily not supported on LoongArch. Signed-off-by: Min Zhou --- .../loongarch/include/rte_power_intrinsics.h | 20 lib/eal/loongarch/rte_power_intrinsics.c | 51 +++ 2 fi

[v2 08/24] eal/loongarch: add io operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds io operations for LoongArch architecture. Let it uses generic I/O implementation. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_io.h | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_io.h diff --git a/lib/eal/

[v2 20/24] ixgbe: add dummy vector implementation for LoongArch

2022-05-31 Thread Min Zhou
The purpose of this patch is used to fix building issues for LoongArch architecture. The hardware instructions based vector implementation will come in a future patch. Signed-off-by: Min Zhou --- drivers/net/ixgbe/ixgbe_rxtx_vec_lsx.c | 60 ++ drivers/net/ixgbe/meson.buil

[v2 06/24] eal/loongarch: add cpu flag checks for LoongArch

2022-05-31 Thread Min Zhou
This patch uses aux vector software register to get CPU flags and add CPU flag checking support for LoongArch architecture. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_cpuflags.h | 39 ++ lib/eal/loongarch/rte_cpuflags.c | 94 2 files change

[v2 03/24] eal/loongarch: add cpu cycle operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds architecture specific cpu cycle operations for LoongArch. The RDTIME.D instruction is used to read constant frequency timer information including counter value. The CPUCFG instruction is used to dynamically identify which features of LoongArch are implemented in the running processo

[v2 02/24] eal/loongarch: add byte order operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds architecture specific byte order operations for LoongArch architecture. LoongArch bit designations are always little-endian. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_byteorder.h | 46 +++ 1 file changed, 46 insertions(+) create mode 100644 li

[v2 18/24] meson: introduce LoongArch architecture

2022-05-31 Thread Min Zhou
This patch adds some meson.build files for building DPDK on LoongArch architecture. Signed-off-by: Min Zhou --- .../loongarch/loongarch_loongarch64_linux_gcc | 16 +++ config/loongarch/meson.build | 46 +++ lib/eal/loongarch/include/meson.build | 21 +

[v2 17/24] eal/linux: set eal base address for LoongArch

2022-05-31 Thread Min Zhou
This patch sets a different eal base address for LoongArch architecture. Signed-off-by: Min Zhou --- lib/eal/linux/eal_memory.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index c890c42106..60fc8cc6ca 100644 --- a/lib/eal/linux/

[v2 09/24] eal/loongarch: add mcslock operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds mcslock operations for LoongArch architecture. Let it uses generic mcslock implementation. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_mcslock.h | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_mcslock.h di

[v2 15/24] eal/loongarch: add hypervisor operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds hypervisor operations for LoongArch architecture. In fact, these operations are currently not supported on LoongArch. Signed-off-by: Min Zhou --- lib/eal/loongarch/rte_hypervisor.c | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 lib/eal/loongarch/rte_hyperv

[v2 22/24] tap: add system call number for LoongArch

2022-05-31 Thread Min Zhou
This patch adds system call number of bpf for LoongArch architecture. Signed-off-by: Min Zhou --- drivers/net/tap/tap_bpf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/tap_bpf.h b/drivers/net/tap/tap_bpf.h index f0b9fc7a2c..b1c9600ed8 100644 --- a/drivers/

[v2 16/24] mem: add huge page size definition for LoongArch

2022-05-31 Thread Min Zhou
LoongArch architecture has a different huge page size (32MB) than other architectures. This patch adds a new huge page size for LoongArch architecture. Signed-off-by: Min Zhou --- lib/eal/include/rte_memory.h | 1 + lib/eal/include/rte_memzone.h | 1 + 2 files changed, 2 insertions(+) diff --g

[v2 13/24] eal/loongarch: add ticketlock operations for LoongArch

2022-05-31 Thread Min Zhou
This patch adds ticketlock operations for LoongArch architecture. Let it uses generic ticketlock implementation. Signed-off-by: Min Zhou --- lib/eal/loongarch/include/rte_ticketlock.h | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 lib/eal/loongarch/include/rte_tick

[v2 19/24] lpm: add dummy vector implementation for LoongArch

2022-05-31 Thread Min Zhou
The hardware instructions based vector implementation will come in a future patch. This dummy implementation can also work. Signed-off-by: Min Zhou --- app/test/test_xmmt_ops.h | 17 ++ lib/lpm/meson.build | 1 + lib/lpm/rte_lpm.h| 2 + lib/lpm/rte_lpm_lsx.h| 129 ++

RE: [v9, 00/10] Add JSON vector set support to fips validation

2022-05-31 Thread Poczatek, Jakub
Hey everyone, FIPS-140-2 tested and passed. Tested-by: Jakub Poczatek -Original Message- From: Gowrishankar Muthukrishnan Sent: Monday 30 May 2022 16:53 To: dev@dpdk.org Cc: Zhang, Roy Fan ; Dooley, Brian ; lylav...@iol.unh.edu; Anoob Joseph ; Archana Muniganti ; Jerin Jacob ; Go

Re: [RFC 1/2] ethdev: port flags for pre-configuration flow hints

2022-05-31 Thread Jack Min
On 5/31/22 00:46, Thomas Monjalon wrote: We were waiting for a v2 of this patch. Hey Thomas, Thank you for the comments. Yes, I'll send v2. More comments below. I'll update the patch in v2 accordingly. 07/04/2022 07:30, Xiaoyu Min: The data-path focused flow rule management can manage f

Re: [RFC 2/2] ethdev: queue-based flow aged report

2022-05-31 Thread Jack Min
On 5/31/22 00:42, Thomas Monjalon wrote: 07/04/2022 07:30, Xiaoyu Min: When application use queue-based flow management and operate the same flow on the same queue, e.g create/destroy/query, API for querying aged flows should also with queue id parameter just like other queue-based flow APIs. A

RE: [EXT] [PATCH v4 08/12] cryptodev: add asym op flags

2022-05-31 Thread Akhil Goyal
> -Original Message- > From: Arek Kusztal > Sent: Tuesday, May 31, 2022 9:35 AM > To: dev@dpdk.org > Cc: Akhil Goyal ; roy.fan.zh...@intel.com; Arek Kusztal > > Subject: [EXT] [PATCH v4 08/12] cryptodev: add asym op flags > > External Email > > ---

RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum

2022-05-31 Thread Akhil Goyal
> /** > diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h > index 2c2c2edeb7..7d683fd728 100644 > --- a/lib/cryptodev/rte_cryptodev.h > +++ b/lib/cryptodev/rte_cryptodev.h > @@ -168,7 +168,9 @@ struct rte_cryptodev_asymmetric_xform_capability { > /**< Transform type:

RE: [PATCH v4] net/ice: retry sending adminQ command after failure

2022-05-31 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Peng1X > Sent: Wednesday, June 1, 2022 1:48 AM > To: Yang, Qiming ; Zhang, Qi Z > ; dev@dpdk.org > Cc: Zhang, Peng1X ; sta...@dpdk.org > Subject: [PATCH v4] net/ice: retry sending adminQ command after failure > > From: Peng Zhang > > The origin des

RE: [EXT] [PATCH v4 00/12] cryptodev: rsa, dh, ecdh changes

2022-05-31 Thread Akhil Goyal
> This patchset introduces some of changes discussed on mailing list for 22.07 > release in cryptodev asym. > > Key changes: > > - It fixes API for RSA (expescially signature paddings) > - Adds Elliptic-Curve Diffie-Hellman > - Adds Eliiptic-Curve point verification > - Adds RSA missing padding f

Re: [PATCH v9] eal: add seqlock

2022-05-31 Thread David Marchand
On Mon, May 23, 2022 at 4:24 PM Mattias Rönnblom wrote: > > A sequence lock (seqlock) is a synchronization primitive which allows > for data-race free, low-overhead, high-frequency reads, suitable for > data structures shared across many cores and which are updated > relatively infrequently. > > A

[PATCH] common/cnxk: add lower bound check for SSO resources

2022-05-31 Thread Hanumanth Pothula
Observing a crash when the user runs the second test case, with the first test case using all HWGRP and HWS, SSO resources. This happens as there are no HWGRP and HWS resources left for the second test case. Make sure to process a test case only when valid HWGRPS and HWS are present by adding lowe

RE: [PATCH 1/3] ixgbe: make link update thread periodic

2022-05-31 Thread Jeff Daly
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, May 30, 2022 10:21 AM > To: Jeff Daly ; dev@dpdk.org; Yang, Qiming > ; Wu, Wenjun1 > Cc: Stephen Douthit > Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic > > Caution: This is an external email. Please take care

RE: [EXT] [PATCH v4 01/12] cryptodev: redefine ec group enum

2022-05-31 Thread Akhil Goyal
> - EC enum was renamed to rte_crypto_curve_id. > Elliptic curve enum name was incorrectly associated > with a group (it comes from the current tls registry name). > - Clarified comments about TLS deprecation. > Some curves included are deprecated with TLS 1.3. > Comments to address it were added.

RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-05-31 Thread Jeff Daly
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, May 30, 2022 9:51 AM > To: Jeff Daly ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices > > Caution: This is an external email

RE: [v9, 00/10] Add JSON vector set support to fips validation

2022-05-31 Thread Zhang, Roy Fan
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday, May 30, 2022 4:53 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; lylav...@iol.unh.edu; Anoob Joseph > ; Archana Muniganti ; > Jerin Jacob ; Gowrishankar Muthukrishnan > > Subject: [v9, 00/10] Add JSON

Re: [PATCH v6 6/9] net/vmxnet3: add version 6 support

2022-05-31 Thread Andrew Rybchenko
Hi Pankaj, On 5/25/22 20:13, Pankaj Gupta wrote: Hi Andrew, Extended interrupt structures, required implementation for additional number of queues It is about Vmxnet3_IntrConfExt. Vmxnet3_IntrConfExt  is a control data structure shared with ESX. ESX introduced it for this version to incre

Re: [RFC 2/2] ethdev: queue-based flow aged report

2022-05-31 Thread Thomas Monjalon
31/05/2022 13:06, Jack Min: > On 5/31/22 00:42, Thomas Monjalon wrote: > > 07/04/2022 07:30, Xiaoyu Min: > >> + * If queue-based flow rule management is used and port configured with > >> + * flag RTE_FLOW_PORT_FLAG_STRICT_QUEUE, RTE_ETH_EVENT_FLOW_AGED event > >> + * is triggered with ret_param se

RE: [PATCH 1/3] ixgbe: make link update thread periodic

2022-05-31 Thread Zhang, Qi Z
> -Original Message- > From: Jeff Daly > Sent: Tuesday, May 31, 2022 8:25 PM > To: Zhang, Qi Z ; dev@dpdk.org; Yang, Qiming > ; Wu, Wenjun1 > Cc: Stephen Douthit > Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic > > > > > -Original Message- > > From: Zhang,

RE: [PATCH v10] sched: enable traffic class oversubscription conditionally

2022-05-31 Thread Dumitrescu, Cristian
> -Original Message- > From: Danilewicz, MarcinX > Sent: Tuesday, May 31, 2022 10:49 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v10] sched: enable traffic class oversubscription > conditionally > > Added new API for flag to

RE: [PATCH v3] pcap: support MTU set

2022-05-31 Thread Ido Goshen
> -Original Message- > From: Ferruh Yigit > Sent: Monday, 30 May 2022 21:06 > To: Ido Goshen ; ferruh.yi...@xilinx.com; > step...@networkplumber.org > Cc: dev@dpdk.org; Tianli Lai > Subject: Re: [PATCH v3] pcap: support MTU set > > On 5/30/2022 11:36 AM, Ido Goshen wrote: > > Support rte

Re: [PATCH v2] net/nfp: fix bug of disable VLAN strip

2022-05-31 Thread Ferruh Yigit
On 5/26/2022 3:34 PM, Peng Zhang wrote: "vlan set strip off 0" can't work, due to the incorrect usage of the mask, it just represent that the status is changed or not, not represent offloaded or not, so that the driver send the error control message to the nic. Now, by first inspect the mask of

Re: [PATCH] app/testpmd: fix help of create meter command

2022-05-31 Thread Ferruh Yigit
On 4/28/2022 3:03 AM, Jin liu wrote: The help message of create meter command is incomplete, lack of policy_id param, update help string. Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color") Cc: sta...@dpdk.org Signed-off-by: Jin liu Signed-off-by: Chaoyong He Signed-off-by:

RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-05-31 Thread Zhang, Qi Z
> -Original Message- > From: Jeff Daly > Sent: Tuesday, May 31, 2022 8:31 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices > > > > > -Original Message-

Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6

2022-05-31 Thread Andrew Rybchenko
On 5/25/22 03:40, Pankaj Gupta wrote: v6 (Andrew Rybchenko): Minor style changes in patches description Split FW version get patch to have callbacks reorder seperately Minor fix in FW version get patch to put callback definition, assignment and implementation just after device

Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6

2022-05-31 Thread Andrew Rybchenko
On 5/31/22 16:40, Andrew Rybchenko wrote: On 5/25/22 03:40, Pankaj Gupta wrote: v6 (Andrew Rybchenko): Minor style changes in patches description Split FW version get patch to have callbacks reorder seperately Minor fix in FW version get patch to put callback definition, assi

RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum

2022-05-31 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 31, 2022 1:47 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange > operation enum > > > /** > > diff --git a/lib/cryptodev/rte_cryptodev.

RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum

2022-05-31 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, May 31, 2022 3:50 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange > operation enum > > > > > -Original Message- > > From: Akhil Go

[PATCH v4 0/8] Introduce support for RISC-V architecture

2022-05-31 Thread Stanislaw Kardach
This patchset adds support for building and running DPDK on 64bit RISC-V architecture. The initial support targets rv64gc (rv64imafdc) ISA and was tested on SiFive Unmatched development board with the Freedom U740 SoC running Linux (freedom-u-sdk based kernel). I have tested this codebase using DPD

[PATCH v4 1/8] eal: add initial support for RISC-V architecture

2022-05-31 Thread Stanislaw Kardach
From: Michal Mazurek Add all necessary elements for DPDK to compile and run EAL on SiFive Freedom U740 SoC which is based on SiFive U74-MC (ISA: rv64imafdc) core complex. This includes: - EAL library implementation for rv64imafdc ISA. - meson build structure for 'riscv' architecture. RTE_ARCH_R

[PATCH v4 2/8] net/ixgbe: enable vector stubs for RISC-V

2022-05-31 Thread Stanislaw Kardach
Re-use vector processing stubs in ixgbe PMD defined for PPC for RISC-V. This enables ixgbe PMD usage in scalar mode on this architecture. The ixgbe PMD driver was validated with Intel X520-DA2 NIC and the test-pmd application. Packet transfer checked using all UIO drivers available for non-IOMMU p

[PATCH v4 3/8] net/memif: set memfd syscall ID on RISC-V

2022-05-31 Thread Stanislaw Kardach
Define the missing __NR_memfd_create syscall id to enable the memif PMD. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- drivers/net/memif/meson.build | 5 - drivers/net/memif/rte_eth_memif.h | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-)

[PATCH v4 4/8] net/tap: set BPF syscall ID for RISC-V

2022-05-31 Thread Stanislaw Kardach
Define the missing __NR_bpf syscall id to enable the tap PMD. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- drivers/net/tap/meson.build | 5 - drivers/net/tap/tap_bpf.h | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/

[PATCH v4 5/8] examples/l3fwd: enable RISC-V operation

2022-05-31 Thread Stanislaw Kardach
Add missing em_mask_key() implementation and fix l3fwd_common.h inclusion in FIB lookup functions to enable the l3fwd to be run on RISC-V. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- examples/l3fwd/l3fwd_em.c | 8 examples/l3fwd/l3fwd_fib.c |

[PATCH v4 6/8] test/cpuflags: add test for RISC-V cpu flag

2022-05-31 Thread Stanislaw Kardach
From: Michal Mazurek Add checks for all flag values defined in the RISC-V misa CSR register. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Michal Mazurek Signed-off-by: Stanislaw Kardach --- app/test/test_cpuflags.c | 81 1 file cha

[PATCH v4 7/8] devtools: add RISC-V to test-meson-builds.sh

2022-05-31 Thread Stanislaw Kardach
Validate RISC-V compilation when test-meson-builds.sh is called. The check will be only performed if appropriate toolchain is present on the system (same as with other architectures). Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- devtools/test-meson-buil

[PATCH v4 8/8] ci: add RISCV64 cross compilation job

2022-05-31 Thread Stanislaw Kardach
Checks cross-compilation using Ubuntu 20.04 x86. Signed-off-by: David Marchand Signed-off-by: Stanislaw Kardach --- .ci/linux-build.sh | 4 .github/workflows/build.yml | 11 ++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.ci/linux-build.sh b/.ci/linux-

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-31 Thread Kusztal, ArkadiuszX
Hi Akhil, Sorry I have missed that, and I think we should revert this patch. It would make sense to have TLS derived numbers for these curves if DH and ECDH would be in the same op. But since we decided to split it we are going to go with separate structs for x448 and x25519 as per: https://patc

RE: [EXT] [PATCH v4 02/12] cryptodev: separate key exchange operation enum

2022-05-31 Thread Akhil Goyal
> > > /** > > > diff --git a/lib/cryptodev/rte_cryptodev.h > > > b/lib/cryptodev/rte_cryptodev.h index 2c2c2edeb7..7d683fd728 100644 > > > --- a/lib/cryptodev/rte_cryptodev.h > > > +++ b/lib/cryptodev/rte_cryptodev.h > > > @@ -168,7 +168,9 @@ struct rte_cryptodev_asymmetric_xform_capability { > >

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-31 Thread Akhil Goyal
Hi Arek, > Hi Akhil, > > Sorry I have missed that, and I think we should revert this patch. > It would make sense to have TLS derived numbers for these curves if DH and > ECDH would be in the same op. > But since we decided to split it we are going to go with separate structs for > x448 > and x25

RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves

2022-05-31 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Tuesday, May 31, 2022 4:40 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves > > Hi Arek, > > Hi Akhil, > > > > Sorry I have missed that, and I

Re: [PATCH v9 0/5] add telemetry command for show module EEPROM

2022-05-31 Thread Andrew Rybchenko
On 5/26/22 10:32, Robin Zhang wrote: Introduce a new telemetry command /ethdev/module_eeprom to show module EEPROM for each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Current the format support SFP(Small Formfactor Pluggable)/SFP+/

[PATCH v2] kni: fix build with Linux 5.18

2022-05-31 Thread Jiri Slaby
Since commit 2655926aea9b (net: Remove netif_rx_any_context() and netif_rx_ni().) in 5.18, netif_rx_ni() no longer exists as netif_rx() can be called from any context. So define HAVE_NETIF_RX_NI for older releases and call the appropriate function in kni_net. Cc: sta...@dpdk.org Signed-off-by: Jir

[PATCH] kni: fix build with Linux 5.18

2022-05-31 Thread Jiri Slaby
Since commit 2655926aea9b (net: Remove netif_rx_any_context() and netif_rx_ni().) in 5.18, netif_rx_ni() no longer exists as netif_rx() can be called from any context. So define HAVE_NETIF_RX_NI for older releases and call the appropriate function in kni_net. Cc: sta...@dpdk.org Signed-off-by: Jir

Re: [PATCH] examples/kni: clear warning about discarding const qualifier

2022-05-31 Thread Stephen Hemminger
On Tue, 31 May 2022 09:13:30 + Ke Zhang wrote: > The warning info: > warning: passing argument 1 of ‘memcpy’ discards ‘const’ > qualifier from pointer target type > > Compulsory type conversion to clear compile warning. > > Signed-off-by: Ke Zhang Agree with other comments, please use eth

Re: [PATCH 00/12] bugfix for hns3 PMD

2022-05-31 Thread Andrew Rybchenko
On 5/19/22 15:29, Min Hu (Connor) wrote: This patch set contains 12 bugfix for hns3 PMD. The patch series fails to apply to dpdk-next-net/main. Please, rebase and send v2.

  1   2   >