Hi Akhil, Sorry I have missed that, and I think we should revert this patch. It would make sense to have TLS derived numbers for these curves if DH and ECDH would be in the same op. But since we decided to split it we are going to go with separate structs for x448 and x25519 as per: https://patchwork.dpdk.org/project/dpdk/patch/20220531040439.15862-7-arkadiuszx.kusz...@intel.com/
> -----Original Message----- > From: Akhil Goyal <gak...@marvell.com> > Sent: Thursday, May 26, 2022 6:38 PM > To: Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com>; dev@dpdk.org > Cc: Zhang, Roy Fan <roy.fan.zh...@intel.com> > Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves > > > > > This commit adds support for following elliptic curves: > > > > 1) Curve25519 > > > > 2) Curve448 > > > > > > > > Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com> > > > > --- > Acked-by: Akhil Goyal <gak...@marvell.com> > > Applied to dpdk-next-crypto
