> -----Original Message-----
> From: Arek Kusztal <arkadiuszx.kusz...@intel.com>
> Sent: Tuesday, May 31, 2022 9:35 AM
> To: dev@dpdk.org
> Cc: Akhil Goyal <gak...@marvell.com>; roy.fan.zh...@intel.com; Arek Kusztal
> <arkadiuszx.kusz...@intel.com>
> Subject: [EXT] [PATCH v4 08/12] cryptodev: add asym op flags
>
> External Email
>
> ----------------------------------------------------------------------
> - Added flags to rte_crypto_asym_op struct.
> It may be shared between different algorithms.
> - Added Diffie-Hellman padding flags.
> Diffie-Hellman padding is used in certain protocols,
> in others, leading zero bytes need to be stripped.
> Even same protocol may use a different approach - most
> glaring example is TLS1.2 - TLS1.3.
> For ease of use, and to avoid additional copy
> on certain occasions, driver should be able to return both.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusz...@intel.com>
> ---
> lib/cryptodev/rte_crypto_asym.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
> index ae3ca31a89..a215f4499d 100644
> --- a/lib/cryptodev/rte_crypto_asym.h
> +++ b/lib/cryptodev/rte_crypto_asym.h
> @@ -41,6 +41,19 @@ rte_crypto_asym_ke_strings[];
> extern const char *
> rte_crypto_asym_op_strings[];
>
> +#define RTE_CRYPTO_ASYM_FLAG_PUB_KEY_NO_PADDING
> RTE_BIT32(0)
> +/**<
> + * Flag to denote public key will be returned without leading zero bytes
> + * and if the flag is not set, public key will be padded to the left with
> + * zeros to the size of the underlying algorithm (default)
> + */
> +#define RTE_CRYPTO_ASYM_FLAG_SHARED_KEY_NO_PADDING RTE_BIT32(1)
> +/**<
> + * Flag to denote shared secret will be returned without leading zero bytes
> + * and if the flag is not set, shared secret will be padded to the left with
> + * zeros to the size of the underlying algorithm (default)
> + */
> +
> /**
> * List of elliptic curves. This enum aligns with
> * TLS "Supported Groups" registry (previously known as
> @@ -613,6 +626,8 @@ struct rte_crypto_asym_op {
> struct rte_crypto_ecdsa_op_param ecdsa;
> struct rte_crypto_ecpm_op_param ecpm;
> };
> + uint16_t flags;
> + /**< Asymmetric crypto operation flags */
Reference of flags missing. I think, it was highlighted in previous version
also.
> };
>
> #ifdef __cplusplus
> --
> 2.13.6
