[dpdk-dev] [PATCH] crypto/mvsam: add comments for three crypto devs

From: Michael Shamis Till now comments explain queue mapping per one and two crypto devices. Now added comments for queue mapping for three crypto devices supported in CN9132. Signed-off-by: Michael Shamis Reviewed-by: Liron Himi --- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 18 ++

[dpdk-dev] [PATCH] crypto/mvsam: fix input args parsing

From: Dana Vardi This patch fix the input arguments assignment to the correct parameters in mrvl_pmd_init_params struct. Fixes: 25b05a1c806 ("crypto/mvsam: parse max number of sessions") Cc: sta...@dpdk.org Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/crypto/mvsam/rte_mrvl_p

[dpdk-dev] [PATCH v3 1/2] common/mlx5: add provider query port support to glue library

In order to get E-Switch vport identifiers the mlx5 PMD relies on two approaches: - use port query API if it is provided by rdma-core library - otherwise, deduce vport ids from the related VF index The latter is not reliable and may not work with newer kernel driver versions and in some configu

[dpdk-dev] [PATCH v3 2/2] common/mlx5: fix compilation flag on port query API

There is the compilation flag HAVE_MLX5DV_DR_DEVX_PORT that depends on presence of mlx5dv_query_devx_port routine in rdma-core library. The mlx5dv_query_devx_port routine is vendor specific, exists only in OFED version of rdma-core library and there are the plans to remove the routine and replace

[dpdk-dev] [PATCH] compress/mlx5: fix memory region unregistration

The issue can cause illegal physical address access while a huge-page A is released and huge-page B is allocated on the same virtual address. The old MR can be matched using the virtual address of huge-page B but the HW will access the physical address of huge-page A which is no more part of the DP

[dpdk-dev] [PATCH] common/mlx5: fix Netlink receive message buffer size

If there are many VFs the Netlink message length sent by kernel in reply to RTM_GETLINK request can be large. We should query the size of message being received in advance and allocate the large enough buffer to handle these large messages. Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove

Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK

On Thu, Jul 1, 2021 at 8:48 AM Lin, Xueqin wrote: > We also captured this type issues and selected one, reported in internal > system JARA and bugzilla in May. > Pls check https://bugs.dpdk.org/show_bug.cgi?id=722 for detail, some > developers are analysis this issue in JIRA but not resolved so

Re: [dpdk-dev] [PATCH] net/mlx5: fix match MPLS over GRE with key

From: Jack Min > Currently PMD needs previous layer information in order to set > corresponding match field for MPLSoGRE or MPLSoUDP. > > GRE_KEY item is missing as supported previous layer when translate item > MPLS, which causes flow[1] cannot match MPLS over GRE traffic. > > According to RF

Re: [dpdk-dev] [PATCH v1] doc: policy on promotion of experimental APIs

On 6/30/2021 8:56 PM, Tyler Retzlaff wrote: > On Tue, Jun 29, 2021 at 07:38:05PM +0100, Kinsella, Ray wrote: >> >> +Promotion to stable +~~~ + +Ordinarily APIs marked as ``experimental`` will be promoted to the stable API +once a maintainer and/or the

Re: [dpdk-dev] [PATCH] kni: fix compilation on SLES15-SP3

On Thu, Jun 17, 2021 at 10:25 AM Marco Varlese wrote: > > Hello, > > On 6/17/21 8:41 AM, Thomas Monjalon wrote: > > 17/06/2021 08:14, Christian Ehrhardt: > >> On Thu, Jun 10, 2021 at 12:30 PM Christian Ehrhardt > >> wrote: > >>> On Thu, Jun 10, 2021 at 10:39 AM Christian Ehrhardt > >>> wrote: >

Re: [dpdk-dev] [PATCH v2] app/eventdev: add option to enable per port pool

On Thu, Jul 1, 2021 at 11:38 AM wrote: > > From: Pavan Nikhilesh > > Add option to configure unique mempool for each ethernet device > port. Can be used with `pipeline_atq` and `pipeline_queue` tests. > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob Series applied to dpdk-next-net-eve

Re: [dpdk-dev] [PATCH] doc: fix build on Windows with meson 0.58

On Wed, 2021-06-30 at 19:22 +0300, Dmitry Kozlyuk wrote: > The `doc` target used `echo` as its command. > On Windows, `echo` is always a shell built-in, there is no binary. > Starting from meson 0.58, `run_target()` always searches for command > executable and no longer accepts `echo` as such on Wi

[dpdk-dev] DPDK will benefit from incoming linux kernel mm patch(HugeTLB related)

Hi all, FYI The incoming kernel mm patch will save ~1.6% Memory for 1G hugepage and ~1.2% for 2M hugepage, which is a good news for DPDK. https://lore.kernel.org/linux-doc/20210510030027.56044-5-songmuc...@bytedance.com/ if you run a server with 1TB Dram, you can save ~16G. this patc

Re: [dpdk-dev] [PATCH v5 5/7] power: support callbacks for multiple Rx queues

On 30/6/2021 10:52 AM, David Hunt wrote: Hi Anatoly, On 29/6/2021 4:48 PM, Anatoly Burakov wrote: Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as most DPDK use cases will poll multiple queu

Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules

On 6/21/21 12:30 PM, Thomas Monjalon wrote: > 21/06/2021 10:28, David Marchand: >> On Fri, Jun 18, 2021 at 3:41 PM Andrew Rybchenko >>> +# for gcc compiles we need -latomic for 128-bit atomic ops >>> +if cc.get_id() == 'gcc' >>> +ext_deps += cc.find_library('atomic') >>> +endif >> >> This patch

[dpdk-dev] [PATCH] test/crypto: fix typo in AES testcase description

Fixed typo in the testcase description for AES in the crypto unit test suite by changing the word 'Scater' to 'Scatter'. Fixes: c9c9c4ed8746 ("app/test: check scatter-gather for crypto drivers") Cc: tomaszx.kula...@intel.com Cc: sta...@dpdk.org Signed-off-by: Rebecca Troy --- app/test/test_cryp

Re: [dpdk-dev] [PATCH v2 0/4] net/tap: fix Rx cksum

On 6/30/21 4:51 PM, Olivier Matz wrote: > This patchset fixes the Rx checksum flags in net/tap > driver. The first two patches are the effective fixes. > > The last 2 patches introduce a new checksum API to > verify a L4 checksum and its unt test, in order to > simplify the net/tap code, or any ot

[dpdk-dev] [PATCH] net/octeontx2: support non-ethernet L2 hdr

In the inline inound path, a custom header would be present at L3 which has sequence number & SPI. L2 need to be adjusted such that the eventual packet would have L3 after L2. Remove assumption of L2 type in this handling. Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_ipsec_anti_

[dpdk-dev] [PATCH] eal: create runtime dir even when shared data is not used

When multi-process is not wanted and DPDK is run with the "no-shconf" flag, the telemetry library still needs a runtime directory to place the unix socket for telemetry connections. Therefore, rather than not creating the directory when this flag is set, we can change the code to attempt the creati

Re: [dpdk-dev] [PATCH] doc: fix build on Windows with meson 0.58

On Thu, Jul 01, 2021 at 09:34:04AM +0100, Luca Boccassi wrote: > On Wed, 2021-06-30 at 19:22 +0300, Dmitry Kozlyuk wrote: > > The `doc` target used `echo` as its command. > > On Windows, `echo` is always a shell built-in, there is no binary. > > Starting from meson 0.58, `run_target()` always searc

[dpdk-dev] [PATCH v5 0/7] Enable ETS-based Tx QoS for VF in DCF

This patch enables the ETS-based Tx QoS for IAVF. Kernel tool is used to configure ETS first. DCF is used to set bandwidth limit for VFs of each TC. IAVF is supported to query QoS capability and set queue TC mapping. Traffic Management API is utilized to configure the QoS hierarchy scheduler tree.

[dpdk-dev] [PATCH v5 1/7] common/iavf: support ETS-based QoS offload configuration

This patch adds new virtchnl opcodes and structures for QoS configuration, which includes: 1. VIRTCHNL_VF_OFFLOAD_TC, to negotiate the capability supporting QoS configuration. If VF and PF both have this flag, then the ETS-based QoS offload function is supported. 2. VIRTCHNL_OP_DCF_CONFIG_BW, DCF i

[dpdk-dev] [PATCH v5 2/7] net/ice/base: support DCF query port ETS adminq

In the adminq command query port ETS function, the root node teid is needed. However, for DCF, the root node is not initialized, which will cause error when we refer to the variable. In this patch, we will check whether the root node is available or not first. Signed-off-by: Ting Xu --- drivers/

[dpdk-dev] [PATCH v5 3/7] net/ice: support DCF link status event handling

When link status changes, DCF will receive virtchnl PF event message. Add support to handle this event, change link status and update link info. Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.h| 6 drivers/net/ice/ice_dcf_ethdev.c | 54 ++-- drivers/

[dpdk-dev] [PATCH v5 4/7] net/ice: support QoS config VF bandwidth in DCF

This patch supports the ETS-based QoS configuration. It enables the DCF to configure bandwidth limits for each VF VSI of different TCs. A hierarchy scheduler tree is built with port, TC and VSI nodes. Signed-off-by: Qiming Yang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 9 +

[dpdk-dev] [PATCH v5 5/7] net/iavf: query QoS cap and set queue TC mapping

This patch added the support for VF to config the ETS-based Tx QoS, including querying current QoS configuration from PF and config queue TC mapping. PF QoS is configured in advance and the queried info is provided to the user for future usage. VF queues are mapped to different TCs in PF through vi

[dpdk-dev] [PATCH v5 6/7] net/iavf: check Tx packet with correct UP and queue

Add check in the Tx packet preparation function, to guarantee that the packet with specific user priority is distributed to the correct Tx queue according to the configured Tx queue TC mapping. Signed-off-by: Ting Xu --- drivers/net/iavf/iavf.h | 10 + drivers/net/iavf/iavf_rxtx.c |

[dpdk-dev] [PATCH v5 7/7] doc: release note for ETS-based Tx QoS

Add 21.08 release note for ETS-based Tx QoS Signed-off-by: Ting Xu --- doc/guides/rel_notes/release_21_08.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst index a6ecfdf3ce..35aa76a270 100644 --- a/doc/

Re: [dpdk-dev] [PATCH v1] doc: policy on promotion of experimental APIs

On 30/06/2021 20:56, Tyler Retzlaff wrote: > On Tue, Jun 29, 2021 at 07:38:05PM +0100, Kinsella, Ray wrote: >> >> +Promotion to stable +~~~ + +Ordinarily APIs marked as ``experimental`` will be promoted to the stable API +once a maintainer and/or th

[dpdk-dev] [PATCH v2] doc: policy on promotion of experimental APIs

Clarifying the ABI policy on the promotion of experimental APIS to stable. We have a fair number of APIs that have been experimental for more than 2 years. This policy ammendment indicates that these APIs should be promoted or removed, or should at least form a conservation between the maintainer a

[dpdk-dev] [PATCH v3] doc: policy on the promotion of experimental APIs

Clarifying the ABI policy on the promotion of experimental APIS to stable. We have a fair number of APIs that have been experimental for more than 2 years. This policy amendment indicates that these APIs should be promoted or removed, or should at least form a conservation between the maintainer an

[dpdk-dev] [PATCH] test/crypto: fix typo in ESN testcase

Fixed typo in the crypto unit test ESN function name by replacing the word 'encryt' with the correct word 'encrypt'. test_authenticated_encryt_with_esn is now called test_authenticated_encrypt_with_esn. Fixes: 699741912d71 ("test/crypto: add case for auth only trailer") Cc: hemant.agra...@nxp.co

Re: [dpdk-dev] [PATCH] test/crypto: fix typo in ESN testcase

Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH v5 0/7] Enable ETS-based Tx QoS for VF in DCF

This patch enables the ETS-based Tx QoS for IAVF. Kernel tool is used to configure ETS first. DCF is used to set bandwidth limit for VFs of each TC. IAVF is supported to query QoS capability and set queue TC mapping. Traffic Management API is utilized to configure the QoS hierarchy scheduler tree.

[dpdk-dev] [PATCH v5 1/7] common/iavf: support ETS-based QoS offload configuration

This patch adds new virtchnl opcodes and structures for QoS configuration, which includes: 1. VIRTCHNL_VF_OFFLOAD_TC, to negotiate the capability supporting QoS configuration. If VF and PF both have this flag, then the ETS-based QoS offload function is supported. 2. VIRTCHNL_OP_DCF_CONFIG_BW, DCF i

[dpdk-dev] [PATCH v5 2/7] net/ice/base: support DCF query port ETS adminq

In the adminq command query port ETS function, the root node teid is needed. However, for DCF, the root node is not initialized, which will cause error when we refer to the variable. In this patch, we will check whether the root node is available or not first. Signed-off-by: Ting Xu --- drivers/

[dpdk-dev] [PATCH v5 3/7] net/ice: support DCF link status event handling

When link status changes, DCF will receive virtchnl PF event message. Add support to handle this event, change link status and update link info. Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.h| 6 drivers/net/ice/ice_dcf_ethdev.c | 54 ++-- drivers/

[dpdk-dev] [PATCH v5 4/7] net/ice: support QoS config VF bandwidth in DCF

This patch supports the ETS-based QoS configuration. It enables the DCF to configure bandwidth limits for each VF VSI of different TCs. A hierarchy scheduler tree is built with port, TC and VSI nodes. Signed-off-by: Qiming Yang Signed-off-by: Ting Xu --- drivers/net/ice/ice_dcf.c| 9 +

[dpdk-dev] [PATCH v5 5/7] net/iavf: query QoS cap and set queue TC mapping

This patch added the support for VF to config the ETS-based Tx QoS, including querying current QoS configuration from PF and config queue TC mapping. PF QoS is configured in advance and the queried info is provided to the user for future usage. VF queues are mapped to different TCs in PF through vi

[dpdk-dev] [PATCH v5 6/7] net/iavf: check Tx packet with correct UP and queue

Add check in the Tx packet preparation function, to guarantee that the packet with specific user priority is distributed to the correct Tx queue according to the configured Tx queue TC mapping. Signed-off-by: Ting Xu --- drivers/net/iavf/iavf.h | 10 drivers/net/iavf/iavf_rxtx.c |

[dpdk-dev] [PATCH v5 7/7] doc: release note for ETS-based Tx QoS

Add 21.08 release note for ETS-based Tx QoS Signed-off-by: Ting Xu --- doc/guides/rel_notes/release_21_08.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst index a6ecfdf3ce..35aa76a270 100644 --- a/doc/

Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules

On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko wrote: > The build works fine for me on FC34, but it has > libatomic-11.1.1-3.fc34.x86_64 installed. I first produced the issue on my "old" FC32. Afaics, for FC33 and later, gcc now depends on libatomic and the problem won't be noticed. FC32 and be

Re: [dpdk-dev] [PATCH v3 0/2] net/i40e: improve free mbuf for Tx

> -Original Message- > From: dev On Behalf Of Feifei Wang > Sent: Wednesday, June 30, 2021 2:41 PM > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang > Subject: [dpdk-dev] [PATCH v3 0/2] net/i40e: improve free mbuf for Tx > > For i40e Tx path, use bulk free of the buffers when mbuf fast fr

Re: [dpdk-dev] [PATCH v2] net/i40e: fix data path corrupt on secondary process

> -Original Message- > From: Yu, DapengX > Sent: Monday, June 21, 2021 3:24 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; Yu, DapengX > ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix data path corrupt on secondary process > > From: Dapeng Yu > > The rte_eth_devices

[dpdk-dev] [pull-request] dpdk-next-eventdev - v21.08 - RC1

https://patches.dpdk.org/user/todo/dpdk/?series=17514 series pushed to RC2 The following changes since commit 568d97c09ca00e52fd7805ef0cab522250dac18b:   common/mlx5: fix Netlink port name padding in probing (2021-06-24 13:19:54 +0200) are available in the Git repository at:   http://dpdk.org

Re: [dpdk-dev] [PATCH] net/mlx5: remove unwanted barrier

Hi, Honnappa The rte_io_rmb() was inserted not to prevent the extra access to cqe->op_own (the volatile qualifier is quite enough, if we had some doubts, we would insert rte_compiler_barrier), but the real intention of io_rmw was to isolate cqe->op_own loads on hardware level. cqe points to the

Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules

@Bruce, see below. On 7/1/21 3:34 PM, David Marchand wrote: > On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko > wrote: >> The build works fine for me on FC34, but it has >> libatomic-11.1.1-3.fc34.x86_64 installed. > > I first produced the issue on my "old" FC32. > Afaics, for FC33 and later, g

Re: [dpdk-dev] [PATCH v2] ifpga/base/meson: fix looking for librt

> -Original Message- > From: Xu, Rosen > Sent: 2021年6月30日 18:03 > To: Hussin, Mohamad Noor Alim ; > Zhang, Tianfei > Cc: dev@dpdk.org; Huang, Wei ; sta...@dpdk.org > Subject: RE: [PATCH v2] ifpga/base/meson: fix looking for librt > > CC Tianfei, who is maintainer. > > > -Original

Re: [dpdk-dev] [PATCH] kni: fix compilation on SLES15-SP3

On Thu, Jul 1, 2021 at 10:23 AM Christian Ehrhardt wrote: > > On Thu, Jun 17, 2021 at 10:25 AM Marco Varlese wrote: > > > > Hello, > > > > On 6/17/21 8:41 AM, Thomas Monjalon wrote: > > > 17/06/2021 08:14, Christian Ehrhardt: > > >> On Thu, Jun 10, 2021 at 12:30 PM Christian Ehrhardt > > >> wrot

[dpdk-dev] [PATCH v5 00/15] drivers: introduce mlx5 crypto PMD

Add a new PMD for Nvidia devices- crypto PMD. The crypto PMD will be supported on Nvidia ConnectX6. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. v2: Add data-path part. v3: Rebase. v4

[dpdk-dev] [PATCH v5 01/15] drivers: introduce mlx5 crypto PMD

Add a new PMD for Mellanox devices- crypto PMD. The crypto PMD will be supported starting Nvidia ConnectX6 and BlueField2. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. This patch add

[dpdk-dev] [PATCH v5 02/15] crypto/mlx5: add DEK object management

A DEK(Data encryption Key) is an mlx5 HW object which represents the cipher algorithm key. The DEKs are used during data encryption/decryption operations. In symmetric algorithms like AES-STS, we use the same DEK for both encryption and decryption. Use the mlx5 hash-list tool to manage the DEK ob

[dpdk-dev] [PATCH v5 03/15] crypto/mlx5: add session operations

Sessions are used in symmetric transformations in order to prepare objects and data for packet processing stage. A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct, bsf_size, bsf_p_type, block size index, encryption_order and encryption standard. Implement the next session opera

[dpdk-dev] [PATCH v5 04/15] crypto/mlx5: add basic operations

The basic dev control operations are configure, close and get info. Extended the existing support of configure and close: -mlx5_crypto_dev_configure- function used to configure device. -mlx5_crypto_dev_close- function used to close a configured device. Added config struc

[dpdk-dev] [PATCH v5 05/15] crypto/mlx5: add queue pairs operations

The HW queue pairs are a pair of send queue and receive queue of independent work queues packed together in one object for the purpose of transferring data between nodes of a network. Completion Queue is a FIFO queue of completed work requests. In crypto driver we use one QP in loopback in order

[dpdk-dev] [PATCH v5 06/15] crypto/mlx5: add dev stop and start operations

Add the dev_start function that is used to start a configured device. Add the dev_stop function that is used to stop a configured device. Both functions set the dev parameter as used and return 0. Signed-off-by: Shiri Kuzin Acked-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 17 +

[dpdk-dev] [PATCH v5 07/15] crypto/mlx5: add memory region management

Mellanox user space drivers don't deal with physical addresses as part of a memory protection mechanism. The device translates the given virtual address to a physical address using the given memory key as an address space identifier. That's why any mbuf virtual address is moved directly to the HW d

[dpdk-dev] [PATCH v5 08/15] crypto/mlx5: create login object using DevX

To work with crypto engines that are marked with wrapped_import_method, a login session is required. A crypto login object needs to be created using DevX. The crypto login object contains: - The credential pointer. - The import_KEK pointer to be used for all secured information

[dpdk-dev] [PATCH v5 09/15] crypto/mlx5: add keytag devarg

From: Suanming Mou A keytag is a piece of data encrypted together with a DEK. When a DEK is referenced by an MKEY.bsf through its index, the keytag is also supplied in the BSF as plaintext. The HW will decrypt the DEK (and the attached keytag) and will fail the operation if the keytags don't mat

[dpdk-dev] [PATCH v5 10/15] crypto/mlx5: add maximum segments devarg

From: Suanming Mou The mlx5 HW crypto operations are done by attaching crypto property to a memory region. Once done, every access to the memory via the crypto-enabled memory region will result with in-line encryption or decryption of the data. As a result, the design choice is to provide two ty

[dpdk-dev] [PATCH v5 11/15] crypto/mlx5: add WQE set initialization

From: Suanming Mou Currently, HW handles the WQEs much faster than the software, Using the constant WQE set layout can initialize most of the WQE segments in advanced, and software only needs to configure very limited segments in datapath. This accelerates the software WQE organize in datapath.

[dpdk-dev] [PATCH v5 12/15] crypto/mlx5: add enqueue and dequeue operations

From: Suanming Mou The crypto operations are done with the WQE set which contains one UMR WQE and one rdma write WQE. Most segments of the WQE set are initialized properly during queue setup, only limited segments are initialized according to the crypto detail in the datapath process. This commi

[dpdk-dev] [PATCH v5 15/15] test/crypto: add mlx5 multi segment tests

The crypto mlx5 driver supports multi segment encryption and decryption operations. Added mlx5 multi segment encryption function and multi segment decryption function that will both use the mlx5 vectors. The added tests will test both data integrity and correct stat values. Signed-off-by: Shiri

[dpdk-dev] [PATCH v5 13/15] crypto/mlx5: add statistic get and reset operations

From: Suanming Mou This commit adds mlx5 crypto statistic get and reset operations. Signed-off-by: Suanming Mou Signed-off-by: Matan Azrad --- drivers/crypto/mlx5/mlx5_crypto.c | 40 --- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/

[dpdk-dev] [PATCH v5 14/15] test/crypto: add mlx5 crypto driver

In order to test the new mlx5 crypto PMD, the driver is added to the crypto test application. Added mlx5 vectors that include 4 testing vectors with length 512 and 4096. Added mlx5 encryption function and decryption function that will both use the mlx5 vectors that will also set the dataunit_len

Re: [dpdk-dev] [PATCH v16 6/9] app/testpmd: fix parse_fec_mode return type name

On 6/29/21 11:50 PM, Jie Zhou wrote: > Passing an uint32_t pointer to an enum pointer parameter causes > pointer-sign warning on Windows (converts between pointers to > integer types with different sign), since enum is implicitly > converted to int on Windows. > > And the current enum pointer para

Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules

On Thu, Jul 01, 2021 at 04:05:56PM +0300, Andrew Rybchenko wrote: > @Bruce, see below. > > On 7/1/21 3:34 PM, David Marchand wrote: > > On Thu, Jul 1, 2021 at 11:22 AM Andrew Rybchenko > > wrote: > >> The build works fine for me on FC34, but it has > >> libatomic-11.1.1-3.fc34.x86_64 installed. >

[dpdk-dev] basicfwd

Hello, I tried to run a sample program (Skeleton) after installing DPDK according to the Getting Started Guide for Linux document, but failed, "Detected shared linkage of DPDK" is missing in the output of EAL initialization, compared with the correct output result. And the rte_eth_dev_count_ava

Re: [dpdk-dev] [PATCH v16 5/9] app/testpmd: resolve name collisions

On 6/29/21 11:50 PM, Jie Zhou wrote: > Resolve name collisions with Windows types > > Signed-off-by: Jie Zhou > Acked-by: Tal Shnaiderman > Acked-by: Dmitry Kozlyuk I'll fix long lines checkpatches.sh warnings on apply.

Re: [dpdk-dev] [PATCH v16 0/9] app/testpmd: enable testpmd on Windows

On 6/29/21 11:50 PM, Jie Zhou wrote: > This patchset is to enable testpmd on windows. It mainly includes: > - Enable building libraries on Windows that testpmd depends on > - Add necessary macros required by testpmd on Windows in rte_os_shim.h > - Add device event stubs for Windows > - Resolve name

Re: [dpdk-dev] [PATCH v5 05/24] net/ngbe: add log type and error type

Hello, Currently looking at new drivers posted on the ml. On Wed, Jun 2, 2021 at 11:40 AM Jiawen Wu wrote: > @@ -124,3 +131,12 @@ RTE_PMD_REGISTER_PCI(net_ngbe, rte_ngbe_pmd); > RTE_PMD_REGISTER_PCI_TABLE(net_ngbe, pci_id_ngbe_map); > RTE_PMD_REGISTER_KMOD_DEP(net_ngbe, "* igb_uio | uio_pci_g

Re: [dpdk-dev] [PATCH v5 01/15] drivers: introduce mlx5 crypto PMD

On Thu, Jul 1, 2021 at 3:27 PM Shiri Kuzin wrote: [snip] > +RTE_INIT(rte_mlx5_crypto_init) > +{ > + mlx5_common_init(); > + if (mlx5_glue != NULL) > + mlx5_pci_driver_register(&mlx5_crypto_driver); > +} > + > +RTE_PMD_REGISTER_CRYPTO_DRIVER(mlx5_cryptodev_driver, mlx5_d

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads for the newly attached port

On 6/19/21 6:40 PM, Viacheslav Ovsiienko wrote: > For the newly attached ports (with "port attach" command) the > default offloads settings, configured from application command > line, were not applied, causing port start failure following > the attach. For example, if scattering offload was config

Re: [dpdk-dev] [PATCH v6] ethdev: add new ext hdr for gtp psc

Hi Raslan, could you reply, please. Andrew. On 6/22/21 10:27 AM, Singh, Aman Deep wrote: > Hi Raslan, > > Can you please provide link to this RFC 38415-g30 > I just had some doubt on byte-order conversion as per RFC 1700 > > > Regards > Aman

[dpdk-dev] [PATCH] devtools: recommend new logtype helpers

Following commit eeded2044af5 ("log: register with standardized names"), the new helpers should be preferred so that we can maintain a consistent naming for logtypes. Signed-off-by: David Marchand --- devtools/checkpatches.sh | 8 1 file changed, 8 insertions(+) diff --git a/devtools/c

Re: [dpdk-dev] [PATCH 1/2] net/tap: remove useless offload capa functions

On 6/16/21 7:15 AM, Stephen Hemminger wrote: > Since these always return 0, they were doing nothing useful. > > Signed-off-by: Stephen Hemminger I have no strong opinion on the patch, but sometimes even empty functions with comments add value. So, I see no point to touch it. So, I'll wait for ma

Re: [dpdk-dev] [PATCH 2/2] net/tap: replace offload_capa function with define

On 6/16/21 7:15 AM, Stephen Hemminger wrote: > Since the offload values are always the same, these can > just be data instead of code. > > Signed-off-by: Stephen Hemminger No strong opinion as well, but above reason is not strong enough to touch the code. So, I'll wait for the maintainer here as

Re: [dpdk-dev] [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types

On 6/15/21 11:19 AM, Alvin Zhang wrote: > This patch defines new RSS offload types for IPv4 and L4 checksum, > which are required when users want to distribute packets based on the > IPv4 or L4 checksum field. > > For example "flow create 0 ingress pattern eth / ipv4 / end > actions rss types ipv4

Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect r/w lock usage in DMA unmap

Hi, Feifei Sorry for the delayed review. I think it is a good catch, thank you for the patch. Acked-by: Viacheslav Ovsiienko With best regards, Slava > -Original Message- > From: Feifei Wang > Sent: Tuesday, June 22, 2021 4:54 > To: Feifei Wang ; Matan Azrad > ; Shahaf Shuler ; Slava

Re: [dpdk-dev] [PATCH v2 1/2] net/nfp: improve PF probing logic

On 6/9/21 5:08 PM, Heinrich Kuhn wrote: > When using rte_eth_dev_pci_generic_probe() during probing a > rte_eth_dev will be created with the name field corresponding to the PCI > address of the device. NFP4000/6000 devices only have a single PF (but > potentially multiple physical ports). This mean

Re: [dpdk-dev] [PATCH v2 2/2] net/nfp: fix PF secondary process probing

On 6/9/21 5:08 PM, Heinrich Kuhn wrote: > This patch creates a new function for handling PF probing of a secondary > process. A CPP handle is obtained for the CPP bridge service and the > service itself is also registered during secondary process > initialization. DPDK services aren't shared betwee

Re: [dpdk-dev] [PATCH] eal: create runtime dir even when shared data is not used

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, 1 July 2021 11.35 > > When multi-process is not wanted and DPDK is run with the "no-shconf" > flag, the telemetry library still needs a runtime directory to place > the > unix socket for telemetry connections

Re: [dpdk-dev] [PATCH v1] doc: policy on promotion of experimental APIs

On Thu, Jul 01, 2021 at 08:56:22AM +0100, Ferruh Yigit wrote: > On 6/30/2021 8:56 PM, Tyler Retzlaff wrote: > > On Tue, Jun 29, 2021 at 07:38:05PM +0100, Kinsella, Ray wrote: > >> > >> > +Promotion to stable > +~~~ > + > +Ordinarily APIs marked as ``experimental`

Re: [dpdk-dev] [PATCH 1/2] net/cxgbe: add support for xstats API

On 6/3/21 6:30 PM, Rahul Lakkireddy wrote: > Add support to fetch port and queue stats via xstats API. > > Signed-off-by: Rahul Lakkireddy [snip] > + count = 0; > + xstats_str = cxgbe_dev_port_stats_strings; > + for (i = 0; i < CXGBE_NB_PORT_STATS; i++, count++) { > + if

Re: [dpdk-dev] [PATCH 2/2] net/cxgbe: remove queue stats from basic stats

On 6/3/21 6:30 PM, Rahul Lakkireddy wrote: > Remove queue stats from basic stats because they're now available > via xstats API. Also remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag. > > Signed-off-by: Rahul Lakkireddy > --- > drivers/net/cxgbe/cxgbe_ethdev.c | 18 +++--- > 1 file chan

Re: [dpdk-dev] [PATCH] eal: create runtime dir even when shared data is not used

On Thu, Jul 01, 2021 at 04:43:48PM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Thursday, 1 July 2021 11.35 > > > > When multi-process is not wanted and DPDK is run with the "no-shconf" > > flag, the telemetry library still needs a

Re: [dpdk-dev] [PATCH] net/memif: fix abstract socket addr_len

On 6/17/21 7:22 PM, Nathan Skrzypczak wrote: > This fixes using abstract sockets with memifs. > we were not passing the exact addr_len, which > requires zeroing the remaining sun_path and > doesn't appear well in other utilities (e.g. > lsof -U) > > Signed-off-by: Nathan Skrzypczak > --- > drive

Re: [dpdk-dev] dmadev discussion summary

On Sat, Jun 26, 2021 at 9:29 AM fengchengwen wrote: > > Hi, all > I analyzed the current DPAM DMA driver and drew this summary in conjunction > with the previous discussion, and this will as a basis for the V2 > implementation. > Feedback is welcome, thanks Thanks for the write-up. > > dpaa

Re: [dpdk-dev] [PATCH] net/hns3: fix traffic management

On 6/21/21 10:38 AM, Min Hu (Connor) wrote: > From: Huisong Li > > In a multi-TC scenario, if the length of packets destined for different > TCs is different, for example, 64B and 1500B packets destined for TC0 and > TC1 respectively. There is a problem that the bandwidth of the TC to which > lar

Re: [dpdk-dev] [PATCH v1] doc: policy on promotion of experimental APIs

On Thu, Jul 01, 2021 at 11:19:27AM +0100, Kinsella, Ray wrote: > > > On 30/06/2021 20:56, Tyler Retzlaff wrote: > > On Tue, Jun 29, 2021 at 07:38:05PM +0100, Kinsella, Ray wrote: > >> > >> > +Promotion to stable > +~~~ > + > +Ordinarily APIs marked as ``experim

Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action

On 6/25/21 9:58 AM, Singh, Aman Deep wrote: > > On 6/23/2021 7:43 PM, Andrew Rybchenko wrote: >> On 6/23/21 4:39 PM, Ori Kam wrote: >>> Hi Jan, >>> -Original Message- From: Jan Viktorin Sent: Wednesday, June 23, 2021 12:18 PM The struct rte_flow_action was missing

Re: [dpdk-dev] [PATCH 2/2] net/cxgbe: remove queue stats from basic stats

Hi Andrew, On Thursday, July 07/01/21, 2021 at 17:50:19 +0300, Andrew Rybchenko wrote: > On 6/3/21 6:30 PM, Rahul Lakkireddy wrote: > > Remove queue stats from basic stats because they're now available > > via xstats API. Also remove RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS flag. > > > > Signed-off-by:

Re: [dpdk-dev] [PATCH 2/2] net/cxgbe: remove queue stats from basic stats

Hi Rahul, On 7/1/21 6:26 PM, Rahul Lakkireddy wrote: > Hi Andrew, > > On Thursday, July 07/01/21, 2021 at 17:50:19 +0300, Andrew Rybchenko wrote: >> On 6/3/21 6:30 PM, Rahul Lakkireddy wrote: >>> Remove queue stats from basic stats because they're now available >>> via xstats API. Also remove RTE

Re: [dpdk-dev] [PATCH 0/2] provide thread unsafe async registration functions

Hi Jiayu, On 6/29/21 7:36 AM, Hu, Jiayu wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, June 7, 2021 9:20 PM >> To: Hu, Jiayu ; dev@dpdk.org >> Cc: maxime.coque...@redhat.com; Xia, Chenbo ; >> Wang, Yinan >> Subject: Re: [PATCH 0/2] provide thread u

Re: [dpdk-dev] 19.11.9 patches review and test

Hi, > -Original Message- > From: Christian Ehrhardt > Sent: Thursday, June 17, 2021 9:38 AM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christensen ; > hariprasad.govindhara...@intel.com; Hemant Agrawal > ;

Re: [dpdk-dev] 20.11.2 patches review and test

Hi, > -Original Message- > From: Xueming(Steven) Li > Sent: Sunday, June 27, 2021 2:28 AM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christensen ; > hariprasad.govindhara...@intel.com; Hemant Agrawal > ; I

Re: [dpdk-dev] [PATCH] net/memif: replace memcpy() with rte_memcpy() to improve perf

On 6/24/21 7:15 PM, Tyler Retzlaff wrote: > On Wed, Jun 23, 2021 at 01:31:54PM -0700, David Christensen wrote: >> Replacing memcpy() with rte_memcpy() improved 64 byte packet >> performance by 33% on a POWER9 system and by 10% on an x86_64 >> system. >> >> Signed-off-by: David Christensen >> --- >

Re: [dpdk-dev] [PATCH v1] lib/eal: enforce alarm APIs parameters check

On Thu, Jul 01, 2021 at 02:31:29AM +0300, Dmitry Kozlyuk wrote: > Hi Jie, > > 2021-06-23 17:36 (UTC-0700), Jie Zhou: > > From: Jie Zhou > > > > lib/eal alarm APIs rte_eal_alarm_set and rte_eal_alarm_cancel > > on Windows do not check parameters to fail fast for invalid > > parameters, which capt

Re: [dpdk-dev] [PATCH] net/memif: replace memcpy() with rte_memcpy() to improve perf

On 6/23/21 8:03 PM, Stephen Hemminger wrote: > On Wed, 23 Jun 2021 09:49:35 -0700 > David Christensen wrote: > >> Replacing memcpy() with rte_memcpy() improved 64 byte packet >> performance by 33% on a POWER9 system and by 10% on an x86_64 >> system. > > I see rte_memcpy was already used in the

[dpdk-dev] DPDK Release Status Meeting 01/07/2021

Release status meeting minutes {Date} = :Date: 1 July 2021 :toc: .Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens .Participants: * Broadcom * Canonical * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates -

  1   2   >