On 6/19/21 6:40 PM, Viacheslav Ovsiienko wrote: > For the newly attached ports (with "port attach" command) the > default offloads settings, configured from application command > line, were not applied, causing port start failure following > the attach. For example, if scattering offload was configured > in command line and rxpkts was configured for multiple segments, > the newly attached port start was failed due to missing scattering > offload enable in the new port settings. The missing code to apply > the offloads to the new device and its queues is added. > > Cc: sta...@dpdk.org > Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
Two above lines should be swapped. > > Signed-off-by: Viacheslav Ovsiienko <viachesl...@nvidia.com> The patch duplicates too much from init_config() function. Please, factor out a helper function to do the job and use it in init_config() and reconfig().