Re: [dpdk-dev] [PATCH v5 0/2] mempool: add debug stats

2021-05-04 Thread David Marchand
On Tue, Apr 27, 2021 at 6:02 PM Dharmik Thakkar wrote: > > - Add debug counters for objects put/get to/from the common pool. > - Make __MEMPOOL_STAT_ADD() more generic > Series applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH v10 00/10] app/testpmd: enable testpmd on Windows

2021-05-04 Thread Thomas Monjalon
When you receive an ack in previous versions, you should add it manually in your patch so we keep track of it.

Re: [dpdk-dev] [PATCH 1/3] common/sfc_efx/base: update MCDI headers

2021-05-04 Thread Ferruh Yigit
On 4/30/2021 6:05 PM, Ivan Malov wrote: > Hi Ferruh, > > These changes are imported. Furthermore, originally, these files are > auto-generated, so in order to fix spelling I can't just apply my edits to the > imported changes. The fixes are to be made in the original source, and I > believe > thi

Re: [dpdk-dev] [PATCH] net/bnxt: fix to prevent device access in error state

2021-05-04 Thread Ajit Khaparde
On Sun, May 2, 2021 at 10:00 PM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > Driver should prevent any DMA with the device when it > detects an error. When firmware is in fatal state, > stop tx/rx by assigning them to dummy functions. > > Fixes: be14720def9c ("ne

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix tunnel offload private items location

2021-05-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Sunday, May 2, 2021 11:08 AM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Ori Kam ; Raslan Darawsheh > ; sta...@dpdk.org; Slava Ovsiienko > ; Shahaf Shuler > Subject: [PATCH v3] net/mlx5: fix tunnel offload private it

Re: [dpdk-dev] [PATCH 1/3] common/sfc_efx/base: update MCDI headers

2021-05-04 Thread Andrew Rybchenko
Hi Ferruh, On 5/4/21 10:50 AM, Ferruh Yigit wrote: > On 4/30/2021 6:05 PM, Ivan Malov wrote: >> Hi Ferruh, >> >> These changes are imported. Furthermore, originally, these files are >> auto-generated, so in order to fix spelling I can't just apply my edits to >> the >> imported changes. The fixes

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/mlx5: fix tunnel offload private items location

2021-05-04 Thread Ferruh Yigit
On 5/2/2021 9:08 AM, Gregory Etelson wrote: > Tunnel offload API requires application to query PMD for specific flow > items and actions. Application uses these PMD specific elements to > build flow rules according to the tunnel offload model. > The model does not restrict private elements location

Re: [dpdk-dev] [PATCH v1] net/virtio: fix vectorized Rx queue stuck

2021-05-04 Thread Maxime Coquelin
On 4/14/21 4:14 PM, Xueming Li wrote: > From: ".Xueming Li" > > When Rx queue worked in vectorized mode and rxd <= 512, under traffic of > high PPS rate, testpmd often start and receive packets of rxd without > further growth. > > Testpmd started with rxq flush which tried to rx MAX_PKT_BURST

Re: [dpdk-dev] [PATCH v2] examples/vhost: fix potential overflow in args process

2021-05-04 Thread Maxime Coquelin
On 4/27/21 5:14 AM, Cheng Jiang wrote: > Change the way passing args to fix potential overflow in args process. > > Coverity issue: 363741 > Fixes: 965b06f0358 ("examples/vhost: enhance getopt_long usage") > > Signed-off-by: Cheng Jiang > --- > v2: > * Change the way passing args > * Change

Re: [dpdk-dev] [PATCH v9 0/4] add support for packed ring in async vhost

2021-05-04 Thread Maxime Coquelin
On 4/27/21 10:03 AM, Cheng Jiang wrote: > For now async vhost data path only supports split ring structure. In > order to make async vhost compatible with virtio 1.1 spec this patch > set cleans async split ring codes and enables packed ring in async > vhost data path. Batch datapath is also ena

Re: [dpdk-dev] [PATCH v5 00/26] Add DLB v2.5

2021-05-04 Thread Jerin Jacob
On Sun, May 2, 2021 at 12:35 AM McDaniel, Timothy wrote: > > From: Timothy McDaniel > > This patch series adds support for DLB v2.5 to > the current DLB V2.0 PMD. The resulting PMD supports > both hardware versions. > > The main differences between the DLB v2.5 and v2.0 hardware > are: > - Number

Re: [dpdk-dev] [PATCH v2] vdpa/mlx5: improve interrupt management

2021-05-04 Thread Maxime Coquelin
On 5/2/21 12:45 PM, Matan Azrad wrote: > The driver should notify the guest for each traffic burst detected by CQ > polling. > > The CQ polling trigger is defined by `event_mode` device argument, > either by busy polling on all the CQs or by blocked call to HW > completion event using DevX chan

Re: [dpdk-dev] [PATCH v4 0/3] Offload flags fixes

2021-05-04 Thread Maxime Coquelin
On 5/3/21 6:43 PM, David Marchand wrote: > The important part is the last patch on vhost handling of offloading > requests coming from a virtio guest interface. > > The rest are small fixes that I accumulated while reviewing the mbuf > offload flags. > > On this last patch, it has the potentia

Re: [dpdk-dev] [PATCH v3 1/1] event/dlb2: optimize Dequeue Operations

2021-05-04 Thread Jerin Jacob
On Sun, May 2, 2021 at 12:39 AM McDaniel, Timothy wrote: > > From: Timothy McDaniel > > Convert code to use x86 vector instructions, thereby significantly > improving dequeue performance. > > Signed-off-by: Timothy McDaniel > Signed-off-by: Harry Van Haaren Applied to dpdk-next-eventdev/for-m

Re: [dpdk-dev] [PATCH v5 00/35] Marvell CNXK Event device Driver

2021-05-04 Thread Jerin Jacob
On Tue, May 4, 2021 at 5:58 AM wrote: > > From: Pavan Nikhilesh > > This patchset adds support for Marvell CN106XX SoC based on 'common/cnxk' > driver. In future, CN9K a.k.a octeontx2 will also be supported by same > driver when code is ready and 'event/octeontx2' will be deprecated. Series ap

[dpdk-dev] [pull-request] dpdk-next-net-eventdev - v21.05 - rc2

2021-05-04 Thread Jerin Jacob Kollanukkaran
The following changes since commit 1b593b9c832e9b284cc59665fe662242a3fc1daf:   version: 21.05-rc1 (2021-04-22 00:28:57 +0200) are available in the Git repository at:   http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 13116d6e86fb238b77dd0f6827c690f182df6ef9:   event/c

Re: [dpdk-dev] New PMD integration to next version release

2021-05-04 Thread Ferruh Yigit
On 5/3/2021 1:17 PM, Zaheer R M wrote: > Hello “DPDK Community”, > > We are glad to inform you that we have developed 3 PMDs using DPDK version > 19.11.3 > > One of our premium customer has sponsored to develop DPDK-Ethernet-PMD using > WPJ419 Compex Platform and is willing to Contribute to DPD

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/mlx5: fix tunnel offload private items location

2021-05-04 Thread Gregory Etelson
Hello Ferruh, [:snip:] > Hi Gregory, > > The were some questions around testpmd part of this patch in previous > version, they are not answered and this version is dropping the testpmd > part. > The tunnel offload API allows application to place tunnel offload elements at any valid location i

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix tunnel offload private items location

2021-05-04 Thread Gregory Etelson
Hello Ferruh, [:snip:] > I am OK to get both to next-net, as long as driver patch is Ack'ed. > > It seems there is a relation between driver and testpmd patch, but I am > trying to figure out how tightly they are coupled, which may be sign of > something wrong. Mlx5 PMD and testpmd patches are

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-05-04 Thread Burakov, Anatoly
On 03-May-21 10:02 PM, Thomas Monjalon wrote: 21/04/2021 11:11, Conor Walsh: + The following will include a snippet from the skeleton sample app:: + + .. literalinclude:: ../../../examples/skeleton/basicfwd.c +:language: c +:start-after: Display the port MAC address. +

Re: [dpdk-dev] Questions about API with no parameter check

2021-05-04 Thread Ananyev, Konstantin
> > 2021-04-29 09:16 (UTC-0700), Tyler Retzlaff: > > On Wed, Apr 07, 2021 at 05:10:00PM +0100, Ferruh Yigit wrote: > > > On 4/7/2021 4:25 PM, Hemant Agrawal wrote: > > > >>+1 > > > >>But are we going to check all parameters? > > > > > > > >+1 > > > > > > > >It may be better to limit the number

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce modification in eventdev structure

2021-05-04 Thread Kinsella, Ray
On 03/05/2021 12:18, Akhil Goyal wrote: > Hi Ray, >>> @@ -127,6 +127,10 @@ Deprecation Notices >>>values to the function ``rte_event_eth_rx_adapter_queue_add`` using >>>the structure ``rte_event_eth_rx_adapter_queue_add``. >>> >>> +* eventdev: The function pointer ``ca_enqueue`` in struc

Re: [dpdk-dev] [PATCH v5 21/35] event/cnxk: add event port and queue xstats

2021-05-04 Thread Kinsella, Ray
On 04/05/2021 01:27, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add support for retrieving statistics from SSO HWS and HWGRP. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/common/cnxk/roc_sso.c| 63 + > drivers/common/cnxk/roc_sso.h| 19 ++

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-05-04 Thread Thomas Monjalon
04/05/2021 11:32, Burakov, Anatoly: > On 03-May-21 10:02 PM, Thomas Monjalon wrote: > > 21/04/2021 11:11, Conor Walsh: > >> + The following will include a snippet from the skeleton sample app:: > >> + > >> + .. literalinclude:: ../../../examples/skeleton/basicfwd.c > >> +:language: c

Re: [dpdk-dev] [PATCH v5 21/35] event/cnxk: add event port and queue xstats

2021-05-04 Thread Jerin Jacob
On Tue, May 4, 2021 at 3:21 PM Kinsella, Ray wrote: > > > > On 04/05/2021 01:27, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add support for retrieving statistics from SSO HWS and HWGRP. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/common/cnxk/roc_sso.c

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-05-04 Thread Ferruh Yigit
On 5/4/2021 10:59 AM, Thomas Monjalon wrote: > 04/05/2021 11:32, Burakov, Anatoly: >> On 03-May-21 10:02 PM, Thomas Monjalon wrote: >>> 21/04/2021 11:11, Conor Walsh: + The following will include a snippet from the skeleton sample app:: + + .. literalinclude:: ../../../examples

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-05-04 Thread Thomas Monjalon
04/05/2021 12:35, Ferruh Yigit: > On 5/4/2021 10:59 AM, Thomas Monjalon wrote: > > 04/05/2021 11:32, Burakov, Anatoly: > >> On 03-May-21 10:02 PM, Thomas Monjalon wrote: > >>> 21/04/2021 11:11, Conor Walsh: > + The following will include a snippet from the skeleton sample app:: > + > >>>

Re: [dpdk-dev] [PATCH v2 12/16] common/mlx5: share get ib device match function

2021-05-04 Thread Thomas Monjalon
29/04/2021 17:43, Matan Azrad: > From: Shiri Kuzin > > The get_ib_device_match function iterates over the list of ib devices > returned by the get_device_list glue function and returns the ib device > matching the provided address. > > Since this function is in use by several drivers, in this pa

Re: [dpdk-dev] [PATCH v2 15/16] common/mlx5: support register write access

2021-05-04 Thread Thomas Monjalon
29/04/2021 17:43, Matan Azrad: > From: Dekel Peled > > This patch adds support of write operation to NIC registers. > > Signed-off-by: Dekel Peled > Acked-by: Matan Azrad > --- > --- a/drivers/common/mlx5/version.map > +++ b/drivers/common/mlx5/version.map > @@ -13,8 +13,17 @@ INTERNAL { >

Re: [dpdk-dev] [PATCH v4 3/3] vhost: fix offload flags in Rx path

2021-05-04 Thread Flavio Leitner
On Mon, May 03, 2021 at 06:43:44PM +0200, David Marchand wrote: > The vhost library currently configures Tx offloading (PKT_TX_*) on any > packet received from a guest virtio device which asks for some offloading. > > This is problematic, as Tx offloading is something that the application > must a

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-05-04 Thread Ferruh Yigit
On 5/4/2021 11:44 AM, Thomas Monjalon wrote: > 04/05/2021 12:35, Ferruh Yigit: >> On 5/4/2021 10:59 AM, Thomas Monjalon wrote: >>> 04/05/2021 11:32, Burakov, Anatoly: On 03-May-21 10:02 PM, Thomas Monjalon wrote: > 21/04/2021 11:11, Conor Walsh: >> + The following will include a snipp

Re: [dpdk-dev] [PATCH v2 12/16] common/mlx5: share get ib device match function

2021-05-04 Thread Matan Azrad
Hi Thomas From: Thomas Monjalon > 29/04/2021 17:43, Matan Azrad: > > From: Shiri Kuzin > > > > The get_ib_device_match function iterates over the list of ib devices > > returned by the get_device_list glue function and returns the ib > > device matching the provided address. > > > > Since this fu

Re: [dpdk-dev] [PATCH v4 2/3] net/iavf: enable PCI bus master after reset

2021-05-04 Thread David Marchand
On Tue, Apr 27, 2021 at 4:05 PM Haiyue Wang wrote: > > The VF reset can be triggerred by the PF reset event, in this case, the > PCI bus master will be cleared, then the VF is not allowed to issue any > Memory or I/O Requests. > > So after the reset event is detected, always enable the PCI bus mas

Re: [dpdk-dev] [PATCH v2 15/16] common/mlx5: support register write access

2021-05-04 Thread Matan Azrad
From: Thomas Monjalon > 29/04/2021 17:43, Matan Azrad: > > From: Dekel Peled > > > > This patch adds support of write operation to NIC registers. > > > > Signed-off-by: Dekel Peled > > Acked-by: Matan Azrad > > --- > > --- a/drivers/common/mlx5/version.map > > +++ b/drivers/common/mlx5/versio

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-05-04 Thread Thomas Monjalon
04/05/2021 13:15, Ferruh Yigit: > On 5/4/2021 11:44 AM, Thomas Monjalon wrote: > > 04/05/2021 12:35, Ferruh Yigit: > >> On 5/4/2021 10:59 AM, Thomas Monjalon wrote: > >>> 04/05/2021 11:32, Burakov, Anatoly: > On 03-May-21 10:02 PM, Thomas Monjalon wrote: > > 21/04/2021 11:11, Conor Walsh:

Re: [dpdk-dev] [PATCH v4 04/12] raw/ioat: add explicit padding to descriptor struct

2021-05-04 Thread Bruce Richardson
On Mon, May 03, 2021 at 11:20:40PM +0200, Thomas Monjalon wrote: > 30/04/2021 17:06, Bruce Richardson: > > Add an explicit padding field to the end of the descriptor structure so > > that when the batch descriptor is defined on the stack for perform-ops, the > > unused space is all zeroed appropria

Re: [dpdk-dev] [PATCH v4 08/12] raw/ioat: add bus driver for device scanning automatically

2021-05-04 Thread Bruce Richardson
On Mon, May 03, 2021 at 11:32:04PM +0200, Thomas Monjalon wrote: > 30/04/2021 17:06, Bruce Richardson: > > Rather than using a vdev with args, DPDK can scan and initialize the > > devices automatically using a bus-type driver. This bus does not need to > > worry about registering device drivers, ra

Re: [dpdk-dev] [PATCH v4 09/12] raw/ioat: move idxd functions to separate file

2021-05-04 Thread Bruce Richardson
On Mon, May 03, 2021 at 11:35:20PM +0200, Thomas Monjalon wrote: > 30/04/2021 17:06, Bruce Richardson: > > Split the rte_ioat_rawdev_fns.h file into two separate headers, so that the > > data structures for the original ioat devices and the newer idxd ones can > > be kept separate from each other.

Re: [dpdk-dev] [PATCH] telemetry: remove internal symbol from public header

2021-05-04 Thread Bruce Richardson
On Mon, May 03, 2021 at 10:04:28PM +0530, jer...@marvell.com wrote: > From: Jerin Jacob > > Remove TELEMETRY_MAX_CALLBACKS symbol from public > rte_telemetry.h header file. > > Signed-off-by: Jerin Jacob > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v4 04/12] raw/ioat: add explicit padding to descriptor struct

2021-05-04 Thread Thomas Monjalon
04/05/2021 14:04, Bruce Richardson: > On Mon, May 03, 2021 at 11:20:40PM +0200, Thomas Monjalon wrote: > > 30/04/2021 17:06, Bruce Richardson: > > > Add an explicit padding field to the end of the descriptor structure so > > > that when the batch descriptor is defined on the stack for perform-ops,

Re: [dpdk-dev] [PATCH v4 08/12] raw/ioat: add bus driver for device scanning automatically

2021-05-04 Thread Thomas Monjalon
04/05/2021 14:07, Bruce Richardson: > On Mon, May 03, 2021 at 11:32:04PM +0200, Thomas Monjalon wrote: > > 30/04/2021 17:06, Bruce Richardson: > > You may want to allow iterating devices of the bus > > by implementing .dev_iterate callback. > > I was wondering about that. What is the expected use-

[dpdk-dev] [PATCH v2] doc: fix Arm socs list

2021-05-04 Thread David Marchand
Keep the list of socs in a single place and include it so that the documentation won't get outdated. Fixes: 8f5ea6a464ac ("config/arm: fix implementer and its SoCs") Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K") Fixes: 7cf32a22b240 ("config/arm: add Hisilicon kunpeng") Signed-off-by: Davi

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: add missing buses in dev iterator

2021-05-04 Thread Ferruh Yigit
On 4/29/2021 9:01 AM, Hemant Agrawal wrote: > > On 4/29/2021 1:26 PM, Thomas Monjalon wrote: >> 29/04/2021 07:55, Hemant Agrawal: >>> This patch fixes issue with OVS 2.15 not working on >>> DPAA/FSLMC based platform due to missing support for >>> these busses in dev_iterate. >>> This patch adds dp

Re: [dpdk-dev] [PATCH v2] doc: add config file option for hns3 PMD

2021-05-04 Thread Ferruh Yigit
On 4/29/2021 7:12 AM, Min Hu (Connor) wrote: > This patch adds description of max TQP number per PF for config file > option. > > Signed-off-by: Min Hu (Connor) Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v2 1/2] devtools: script to check meson indentation of lists

2021-05-04 Thread Thomas Monjalon
26/04/2021 12:54, Bruce Richardson: > This is a script to fix up minor formatting issues in meson files. > It scans for, and can optionally fix, indentation issues and missing > trailing commas in the lists in meson.build files. It also detects, > and can fix, multi-line lists where more than one e

[dpdk-dev] [PATCH v5 04/12] raw/ioat: expand descriptor struct to full 64 bytes

2021-05-04 Thread Bruce Richardson
Although it's unused by the driver, add the interrupt handle field in the descriptor to the descriptor structure for completeness, and explicitly add the reserved padding field on the end of the structure too. This means that when a descriptor is defined on the stack, or initialized by the compiler

[dpdk-dev] [PATCH v5 05/12] raw/ioat: fix script for configuring small number of queues

2021-05-04 Thread Bruce Richardson
The dpdk_idxd_cfg.py script included with the driver for convenience did not work properly where the number of queues to be configured was less than the number of groups or engines. This was because there would be configured groups/engines not assigned to queues. Fix this by limiting the engine and

[dpdk-dev] [PATCH v5 00/12] ioat driver updates

2021-05-04 Thread Bruce Richardson
This set contains a series of updates to the ioat driver, described in each of the individual patchsets. V5: updated following feedback on-list: * reworked commit log of patch 4 * added doxygen @file documentation to patch 9 V4: fix issue with capacity unit test [due to missed line when r

[dpdk-dev] [PATCH v5 02/12] raw/ioat: support limiting queues for idxd PCI device

2021-05-04 Thread Bruce Richardson
When using a full device instance via vfio, allow the user to specify a maximum number of queues to configure rather than always using the max number of supported queues. Signed-off-by: Bruce Richardson --- doc/guides/rawdevs/ioat.rst | 8 drivers/raw/ioat/idxd_pci.c | 28 +

[dpdk-dev] [PATCH v5 06/12] raw/ioat: make workqueue name configurable in script

2021-05-04 Thread Bruce Richardson
Add a "--name-prefix" parameter to the quick configuration script for DSA. This allows the queues configured on a DSA instance to be made available to only one DPDK process in a setup with multiple DPDK process instances. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/dpdk_idxd_cfg.py | 9

[dpdk-dev] [PATCH v5 01/12] raw/ioat: add unit tests for completion batching

2021-05-04 Thread Bruce Richardson
Add in additional unit tests to verify that we can get completion reports of multiple batches in a single completed_ops() call. Also verify we can get smaller number of completions if that is requested too. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/ioat_rawdev_test.c | 199 +++

[dpdk-dev] [PATCH v5 03/12] raw/ioat: add component prefix to log messages

2021-05-04 Thread Bruce Richardson
Add the driver prefix "IOAT" to log messages for the driver. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/ioat_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/ioat/ioat_private.h b/drivers/raw/ioat/ioat_private.h index 6c423811ec..f032d5fe3d 1006

[dpdk-dev] [PATCH v5 07/12] raw/ioat: allow perform operations function to return error

2021-05-04 Thread Bruce Richardson
From: Kevin Laatz Change the return type for the rte_ioat_perform_ops() function from void to int to allow the possibility of returning an error code in future, should it be necessary. Signed-off-by: Kevin Laatz --- drivers/raw/ioat/rte_ioat_rawdev.h | 4 +++- drivers/raw/ioat/rte_ioat_ra

[dpdk-dev] [PATCH v5 08/12] raw/ioat: add bus driver for device scanning automatically

2021-05-04 Thread Bruce Richardson
Rather than using a vdev with args, DPDK can scan and initialize the devices automatically using a bus-type driver. This bus does not need to worry about registering device drivers, rather it can initialize the devices directly on probe. The device instances (queues) to use are detected from /dev

[dpdk-dev] [PATCH v5 09/12] raw/ioat: move idxd functions to separate file

2021-05-04 Thread Bruce Richardson
Split the rte_ioat_rawdev_fns.h file into two separate headers, so that the data structures for the original ioat devices and the newer idxd ones can be kept separate from each other. This makes code management and rework easier. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/meson.build

[dpdk-dev] [PATCH v5 10/12] raw/ioat: rework SW ring layout

2021-05-04 Thread Bruce Richardson
The ring management in the idxd part of the driver is more complex than it needs to be, tracking individual batches in a ring and having null descriptors as padding to avoid having single-operation batches. This can be simplified by using a regular ring-based layout, with additional overflow at the

[dpdk-dev] [PATCH v5 11/12] raw/ioat: add API to query remaining ring space

2021-05-04 Thread Bruce Richardson
From: Kevin Laatz Add a new API to query remaining descriptor ring capacity. This API is useful, for example, when an application needs to enqueue a fragmented packet and wants to ensure that all segments of the packet will be enqueued together. Signed-off-by: Kevin Laatz Signed-off-by: Bruce R

[dpdk-dev] [PATCH v5 12/12] raw/ioat: report status of completed jobs

2021-05-04 Thread Bruce Richardson
Add improved error handling to rte_ioat_completed_ops(). This patch adds new parameters to the function to enable the user to track the completion status of each individual operation in a batch. With this addition, the function can help the user to determine firstly, how many operations may have fa

Re: [dpdk-dev] [PATCH] build: reduce max_lcores for ppc

2021-05-04 Thread Thomas Monjalon
29/04/2021 13:28, Luca Boccassi: > On Wed, 28 Apr 2021 at 21:10, David Christensen > wrote: > > > > When setting RTE_MAX_LCORES to the maximum value supported by ppc > > hardware (1536), the lcores_autotest may timeout after 30 seconds > > because the test takes nearly 60 seconds to complete. Set

Re: [dpdk-dev] [PATCH v2 1/2] devtools: script to check meson indentation of lists

2021-05-04 Thread David Marchand
On Tue, May 4, 2021 at 3:05 PM Thomas Monjalon wrote: > > 26/04/2021 12:54, Bruce Richardson: > > This is a script to fix up minor formatting issues in meson files. > > It scans for, and can optionally fix, indentation issues and missing > > trailing commas in the lists in meson.build files. It al

Re: [dpdk-dev] DPDK Release Status Meeting 29/04/2021

2021-05-04 Thread Thinh Tran
DPDK 21.05 RC1 on IBM Power result * DPDK: v21.05-rc1-0-g1b593b9c8 * OS: RHEL 8.3 kernel level: 4.18.0-240.el8.ppc64le * GCC: version 8.3.1 20191121 (Red Hat 8.3.1-5) * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. System tested: - IBM Power9 Model 8

Re: [dpdk-dev] [PATCH v5 3/5] test/hash: add additional thash tests

2021-05-04 Thread Medvedkin, Vladimir
Hi Stanislaw, On 29/04/2021 21H:45, Stanislaw Kardach wrote: On Thu, Apr 29, 2021 at 12:17:08PM +0300, Medvedkin, Vladimir wrote: Test Failed RTE>> --- stderr --- EAL: Detected 2 lcore(s) EAL: Detected 1 NUMA nodes EAL: Detected shared linkage of DPDK EAL: Multi-process socket /var/run/dpdk/th

[dpdk-dev] [PATCH] hash: fix tuple adjustment

2021-05-04 Thread Vladimir Medvedkin
rte_thash_adjust_tuple() uses random to generate a new subtuple if fn() callback reports about collision. In some cases random changes the subtuple in a way that after complementary bits are applied the original tuple is obtained. This patch replaces random with subtuple increment. Fixes: 28ebff11

Re: [dpdk-dev] [PATCH] net/hns3: fix MAC enable failed rollback

2021-05-04 Thread Ferruh Yigit
On 4/29/2021 10:03 AM, Min Hu (Connor) wrote: > From: Huisong Li > > If driver fails to enable MAC, it does not need to rollback the MAC > configuration. This patch fixes it. > > Fixes: bdaf190f8235 ("net/hns3: support link speed autoneg for PF") > > Signed-off-by: Huisong Li > Signed-off-by:

Re: [dpdk-dev] [PATCH 1/2] graph: fix memory leak

2021-05-04 Thread David Marchand
On Thu, Apr 22, 2021 at 1:52 PM Min Hu (Connor) wrote: > > From: HongBo Zheng > > Fix function 'stats_mem_populate' return without > free dynamic memory referenced by 'stats'. > > Fixes: af1ae8b6a32c ("graph: implement stats") > Cc: sta...@dpdk.org > > Signed-off-by: HongBo Zheng > Signed-off-by

[dpdk-dev] test/crypto: fix auth-cipher compare length in oop

2021-05-04 Thread Kai Ji
For out-of-place operations, comparing expected ciphertext with the operation result should skip cipher_offset bytes, as those will not be copied from source to the destination buffer, making the tests fail. Fixes: 02ed7b3871d6 ("test/crypto: add SNOW3G test cases for auth-cipher") Cc: damianx.no.

[dpdk-dev] [PATCH v2] hash: fix tuple adjustment

2021-05-04 Thread Vladimir Medvedkin
rte_thash_adjust_tuple() uses random to generate a new subtuple if fn() callback reports about collision. In some cases random changes the subtuple in a way that after complementary bits are applied the original tuple is obtained. This patch replaces random with subtuple increment. Fixes: 28ebff11

Re: [dpdk-dev] [PATCH] net/hns3: fix IEEE 1588 PTP

2021-05-04 Thread Ferruh Yigit
On 4/29/2021 10:19 AM, Min Hu (Connor) wrote: > When jumbo frame is enabled, Rx function will choose 'Scalar Scattered' > function which has no PTP handling. > > This patche fixed it by add PTP handling in 'Scalar Scattered' function. > > Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") >

Re: [dpdk-dev] [PATCH v4 2/3] net/iavf: enable PCI bus master after reset

2021-05-04 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Tuesday, May 4, 2021 19:32 > To: Wang, Haiyue > Cc: dev ; Zhang, Qi Z ; Wang, Liang-min > ; > Wu, Jingjing ; Xing, Beilei > Subject: Re: [PATCH v4 2/3] net/iavf: enable PCI bus master after reset > > On Tue, Apr 27, 2021 at 4:05 PM Ha

Re: [dpdk-dev] [PATCH v3 4/4] doc: add MLX5 PMD integrity item support

2021-05-04 Thread Ferruh Yigit
On 4/29/2021 7:36 PM, Gregory Etelson wrote: > Add MLX5 PMD integrity item support to 21.05 release notes. > > Add MLX5 PMD integrity item limitations to the PMD records. > Hi Gregory, It is expected to have doc updates with the actual patch, it seems we have missed it for this time. Can you p

Re: [dpdk-dev] [PATCH v3 4/4] doc: add MLX5 PMD integrity item support

2021-05-04 Thread Ferruh Yigit
On 5/4/2021 4:21 PM, Ferruh Yigit wrote: > On 4/29/2021 7:36 PM, Gregory Etelson wrote: >> Add MLX5 PMD integrity item support to 21.05 release notes. >> >> Add MLX5 PMD integrity item limitations to the PMD records. >> > > Hi Gregory, > > It is expected to have doc updates with the actual patch,

Re: [dpdk-dev] [PATCH 0/4] drivers/net: add NXP ENETFEC driver

2021-05-04 Thread Ferruh Yigit
On 4/30/2021 5:34 AM, Apeksha Gupta wrote: > This patch series introduce the enetfec ethernet driver, > ENET fec (Fast Ethernet Controller) is a network poll mode driver for > the inbuilt NIC found in the NXP imx8mmevk Soc. > > An overview of the enetfec driver with probe and remove are in patch 1

Re: [dpdk-dev] [PATCH v3 0/4] net/mlx5: add integrity flow item support

2021-05-04 Thread Ferruh Yigit
On 4/29/2021 7:36 PM, Gregory Etelson wrote: > v2: > Add MLX5 PMD integrity item support to 21.05 release notes. > Use RTE_BIT64() macro in RTE_FLOW_ITEM_INTEGRITY_* definition. > > v3: > Remove RTE_FLOW_ITEM_INTEGRITY_* bit masks. > > Acked-by: Viacheslav Ovsiienko > > Gregory Etelson (4): >

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: add missing buses in dev iterator

2021-05-04 Thread Thomas Monjalon
04/05/2021 14:49, Ferruh Yigit: > On 4/29/2021 9:01 AM, Hemant Agrawal wrote: > > > > On 4/29/2021 1:26 PM, Thomas Monjalon wrote: > >> 29/04/2021 07:55, Hemant Agrawal: > >>> This patch fixes issue with OVS 2.15 not working on > >>> DPAA/FSLMC based platform due to missing support for > >>> these

Re: [dpdk-dev] [PATCH v3 0/6] optimization and bugfix for hns3 PMD

2021-05-04 Thread Ferruh Yigit
On 4/30/2021 7:28 AM, Min Hu (Connor) wrote: > This patch set contains one patch for performance optimization, > this is: 'net/hns3: improve IO path data cache usage'. > The others are bugfixes for hns3 PMD. > > Chengwen Feng (6): > net/hns3: delete some unused capabilities > net/hns3: modify

Re: [dpdk-dev] test/crypto: fix auth-cipher compare length in oop

2021-05-04 Thread Zhang, Roy Fan
> -Original Message- > From: Ji, Kai > Sent: Tuesday, May 4, 2021 3:20 PM > To: dev@dpdk.org > Cc: damianx.no...@intel.com; Zhang, Roy Fan ; > Ji, Kai > Subject: [dpdk-dev] test/crypto: fix auth-cipher compare length in oop > > For out-of-place operations, comparing expected ciphertext w

Re: [dpdk-dev] [PATCH v5 00/12] ioat driver updates

2021-05-04 Thread Thomas Monjalon
04/05/2021 15:14, Bruce Richardson: > Bruce Richardson (10): > raw/ioat: add unit tests for completion batching > raw/ioat: support limiting queues for idxd PCI device > raw/ioat: add component prefix to log messages > raw/ioat: expand descriptor struct to full 64 bytes > raw/ioat: fix sc

Re: [dpdk-dev] [PATCH] telemetry: remove internal symbol from public header

2021-05-04 Thread Power, Ciara
>-Original Message- >From: Richardson, Bruce >Sent: Tuesday 4 May 2021 13:14 >To: jer...@marvell.com >Cc: Power, Ciara ; dev@dpdk.org; >tho...@monjalon.net >Subject: Re: [PATCH] telemetry: remove internal symbol from public header > >On Mon, May 03, 2021 at 10:04:28PM +0530, jer...@marvell

Re: [dpdk-dev] [PATCH 0/3] bufixes for hns3 PMD

2021-05-04 Thread Ferruh Yigit
On 4/30/2021 10:04 AM, Min Hu (Connor) wrote: > This patch set contains three bugfixes for hns3 PMD. > > Chengwen Feng (3): > net/hns3: remove read when enabling TM QCN error event > net/hns3: remove unused code of VMDq > net/hns3: fix format u64 variable readability > Series applied to dp

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: add missing buses in dev iterator

2021-05-04 Thread Ferruh Yigit
On 5/4/2021 4:50 PM, Thomas Monjalon wrote: > 04/05/2021 14:49, Ferruh Yigit: >> On 4/29/2021 9:01 AM, Hemant Agrawal wrote: >>> >>> On 4/29/2021 1:26 PM, Thomas Monjalon wrote: 29/04/2021 07:55, Hemant Agrawal: > This patch fixes issue with OVS 2.15 not working on > DPAA/FSLMC based p

Re: [dpdk-dev] [PATCH v1] eal/arm64: fix aarch64 reg platform value

2021-05-04 Thread Thomas Monjalon
> > REG_PLATFORM only uses bit 0 to indicate whether the value retrieved from > > hardware matches PLATFORM_STR. > > > > Signed-off-by: Juraj Linkeš > > Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8") > > Cc: jer...@marvell.com > > Cc: sta...@dpdk.org > > Reviewed-by: Ruifeng Wang App

Re: [dpdk-dev] [PATCH v2] eal: fix use wrong time API

2021-05-04 Thread Thomas Monjalon
29/04/2021 04:10, Min Hu (Connor): > Currently, the mp uses gettimeofday() API to get the time, and used as > timeout parameter. > > But the time which gets from gettimeofday() API isn't monotonically > increasing. The process may fail if the system time is changed. > > This fixes it by using clo

Re: [dpdk-dev] [PATCH v2 2/2] eal: fix service core index validity

2021-05-04 Thread Thomas Monjalon
+Cc Harry 29/04/2021 04:34, Min Hu (Connor): > This patch adds checking for service core index validity when parsing > service corelist. > > Fixes: 7dbd7a6413ef ("service: add -S corelist option") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- >

Re: [dpdk-dev] [PATCH v2 1/2] eal: check mp reply result

2021-05-04 Thread Thomas Monjalon
+Cc Anatoly 29/04/2021 04:34, Min Hu (Connor): > This patch adds checking for mp reply result in handle_sync(). > > Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- > lib/eal/commo

Re: [dpdk-dev] [PATCH v2] eal/windows: fix build warnings in MinGW

2021-05-04 Thread Thomas Monjalon
26/04/2021 17:58, Dmitry Kozlyuk: > 2021-04-21 19:09 (UTC+0300), Tal Shnaiderman: > > the strncasecmp macro defined in rte_os_shim.h is already > > defined in MinGW-w64, as a result the compiler prints out > > the warning below on function redefinition whenever compiling > > a file including the he

Re: [dpdk-dev] [PATCH v3] net/mlx5: add power monitoring support

2021-05-04 Thread Ferruh Yigit
On 4/29/2021 3:55 PM, Alexander Kozyrev wrote: > Support the PMD power management API in MLX5 driver. > The monitor policy of this API puts a CPU core to sleep until > a data in some monitored memory address is changed by the NIC. > Implement the get_monitor_addr function to return an address > of

Re: [dpdk-dev] [PATCH v3] net/mlx5: add power monitoring support

2021-05-04 Thread Thomas Monjalon
04/05/2021 19:40, Ferruh Yigit: > On 4/29/2021 3:55 PM, Alexander Kozyrev wrote: > > Support the PMD power management API in MLX5 driver. > > The monitor policy of this API puts a CPU core to sleep until > > a data in some monitored memory address is changed by the NIC. > > Implement the get_monito

Re: [dpdk-dev] [PATCH] mbuf: check mbuf dyn shared memory validity

2021-05-04 Thread Thomas Monjalon
28/04/2021 14:31, Olivier Matz: > Hi Chengwen, > > On Fri, Apr 23, 2021 at 04:11:04PM +0800, Min Hu (Connor) wrote: > > From: Chengwen Feng > > > > Because mbuf dyn shared memory was allocated runtime, so it's > > necessary to check validity when dump mbuf dyn info. > > > > Also this patch adds

[dpdk-dev] [PATCH v3 00/15] mlx5 common part for crypto driver

2021-05-04 Thread Matan Azrad
The crypto PMD will be supported on Nvidia ConnectX6. The crypto PMD will add the support of encryption and decryption using the AES-XTS symmetric algorithm. The crypto PMD requires rdma-core and uses mlx5 DevX. This is the mlx5 common part that added support for DevX commands needed for crypto d

[dpdk-dev] [PATCH v3 01/15] common/mlx5: remove redundant spaces in header file

2021-05-04 Thread Matan Azrad
From: Dekel Peled File drivers/common/mlx5/mlx5_prm.h includes structs representing data items as defined in PRM document. Some of these structs were copied as-is from kernel file mlx5_ifc.h. As result the structs are not all aligned with the same spacing. This patch removes redundant spaces and

[dpdk-dev] [PATCH v3 02/15] common/mlx5: update GENEVE TLV OPT obj name

2021-05-04 Thread Matan Azrad
From: Dekel Peled Rename MLX5_OBJ_TYPE_GENEVE_TLV_OPT as MLX5_GENERAL_OBJ_TYPE_GENEVE_TLV_OPT, to align with other general objects names. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 +- drivers/common/mlx5/mlx5_prm.h | 4 ++-- 2 files ch

[dpdk-dev] [PATCH v3 03/15] common/mlx5: optimize read of general obj type caps

2021-05-04 Thread Matan Azrad
From: Dekel Peled General object types support is indicated in bitmap general_obj_types, which is part of HCA capabilities list. Currently this bitmap is read multiple times, and each time a different bit is extracted. This patch optimizes the code, reading the bitmap once into a local variable,

[dpdk-dev] [PATCH v3 04/15] common/mlx5: add HCA cap for AES-XTS crypto

2021-05-04 Thread Matan Azrad
From: Dekel Peled Update the PRM structure and HCA capabilities reading, to include relevant capabilities for AES-XTS crypto. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ drivers/common/mlx5/mlx

[dpdk-dev] [PATCH v3 05/15] common/mlx5: support general object DEK create op

2021-05-04 Thread Matan Azrad
From: Dekel Peled Data Encryption Keys (DEKs) are the keys used for data encryption/decryption operations. Add reading of DEK support capability. Add function to create general object type DEK, using DevX API. Arrange common version.map file in alphabetical order. Signed-off-by: Dekel Peled A

[dpdk-dev] [PATCH v3 06/15] common/mlx5: adjust DevX MKEY fields for crypto

2021-05-04 Thread Matan Azrad
From: Dekel Peled MKEY that will be used for crypto purposes must be created with crypto_en and remote access attributes. This patch adds support for them in the DevX MKEY context. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 9 + driver

[dpdk-dev] [PATCH v3 07/15] common/mlx5: support general obj IMPORT KEK create

2021-05-04 Thread Matan Azrad
From: Dekel Peled IMPORT_KEK object is used to wrap (encrypt) critical security parameters, such as other keys and credentials, when those need to be passed between the device and the software. This patch add support of IMPORT_KEK object create operation. Add reading of IMPORT_KEK support capabi

[dpdk-dev] [PATCH v3 08/15] common/mlx5: support general obj CRYPTO LOGIN create

2021-05-04 Thread Matan Azrad
From: Dekel Peled CRYPTO_LOGIN Object is used to login to the device as crypto user or crypto officer. Required in order to perform any crypto related control operations. This patch adds support of CRYPTO_LOGIN object create operation. Add reading of CRYPTO_LOGIN support capability. Add function

[dpdk-dev] [PATCH v3 09/15] common/mlx5: add crypto BSF struct and defines

2021-05-04 Thread Matan Azrad
From: Dekel Peled This patch adds the struct defining crypto BSF segment of UMR WQE, and the related value definitions and offsets. Signed-off-by: Dekel Peled Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 66 ++ 1 file changed, 66 insertions(+) di

[dpdk-dev] [PATCH v3 10/15] common/mlx5: share hash list tool

2021-05-04 Thread Matan Azrad
From: Shiri Kuzin In order to use the hash list defined in net in other drivers, the hash list is moved to common utilities. In addition, the log definition was moved from the common utilities to a dedicated new log file in common in order to prevent a conflict. Signed-off-by: Shiri Kuzin Acke

[dpdk-dev] [PATCH v3 11/15] common/mlx5: share get ib device match function

2021-05-04 Thread Matan Azrad
From: Shiri Kuzin The get_ib_device_match function iterates over the list of ib devices returned by the get_device_list glue function and returns the ib device matching the provided address. Since this function is in use by several drivers, in this patch we share the function in common part. Si

  1   2   >