On 4/30/2021 6:05 PM, Ivan Malov wrote: > Hi Ferruh, > > These changes are imported. Furthermore, originally, these files are > auto-generated, so in order to fix spelling I can't just apply my edits to the > imported changes. The fixes are to be made in the original source, and I > believe > this should be somehow discussed internally. > > So, the changeset is either to be applied "as it is" (meaning that the fixes > are > expected to be submitted with future updates) or postponed. Maybe Andrew can > advise. > > Yes, I see the spelling warnings, they're pretty much valid. But some of them > are.. questionable. In particular, "misspelling" of the word HIST in > MC_CMD_LTSSM_HIST_MSGSET. For sure, the suggested replacement doesn't quite > fit > the intended meaning of the macro. >
You can ignore invalid warnings. > Thank you. > > On 30/04/2021 18:56, Ferruh Yigit wrote: >> On 4/28/2021 10:49 AM, Ivan Malov wrote: >>> From: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> >>> >>> Signed-off-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> >>> Signed-off-by: Ivan Malov <ivan.ma...@oktetlabs.ru> >>> --- >>> drivers/common/sfc_efx/base/efx_regs_mcdi.h | 3509 +++++++++++++++-- >>> .../common/sfc_efx/base/efx_regs_mcdi_aoe.h | 142 +- >>> .../common/sfc_efx/base/efx_regs_mcdi_strs.h | 2 +- >>> 3 files changed, 3312 insertions(+), 341 deletions(-) >> >> Hi Ivan, >> >> There are some checkpatch spelling warnings, can you please check them? >> >> Also is there a versioning on the MCDI, if so you may want to document the >> updated version in driver guide and/or release notes. >> >
