Re: [dpdk-dev] [PATCH v4 09/12] raw/ioat: move idxd functions to separate file

[Bruce Richardson]

On Mon, May 03, 2021 at 11:35:20PM +0200, Thomas Monjalon wrote:
> 30/04/2021 17:06, Bruce Richardson:
> > Split the rte_ioat_rawdev_fns.h file into two separate headers, so that the
> > data structures for the original ioat devices and the newer idxd ones can
> > be kept separate from each other. This makes code management and rework
> > easier.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> > ---
> > --- /dev/null
> > +++ b/drivers/raw/ioat/rte_idxd_rawdev_fns.h
> > @@ -0,0 +1,275 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(c) 2021 Intel Corporation
> > + */
> > +#ifndef _RTE_IDXD_RAWDEV_FNS_H_
> > +#define _RTE_IDXD_RAWDEV_FNS_H_
> 
> Please add a doxygen @file to explain the purpose of this file.
> The same is needed for rte_ioat_rawdev_fns.h.
> We miss the explanation of the difference between ioat and idxd.
> 
Agreed. Will do in new revision of this set.