Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-21 Thread Maxime Coquelin
On 1/20/21 3:54 PM, 谢华伟(此时此刻) wrote: > > On 2021/1/13 0:58, Maxime Coquelin wrote: >> >> On 1/12/21 10:37 AM, Maxime Coquelin wrote: >>> bus/pci: ... >>> >>> On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" VFIO should use the same way to map/read/write PORT IO as UIO, f

Re: [dpdk-dev] [PATCH v2 08/19] vhost: fix missing header includes

2021-01-21 Thread Maxime Coquelin
On 1/15/21 12:10 PM, Bruce Richardson wrote: > The vhost header files were missing definitions from headers to allow > them to be compiled up individually. > > Fixes: d7280c9fffcb ("vhost: support selective datapath") > Fixes: a49f758d1170 ("vhost: split vDPA header file") > Fixes: 939066d96563

Re: [dpdk-dev] [PATCH 1/1] doc: simplify OS support in features matrix

2021-01-21 Thread Andrew Rybchenko
On 1/21/21 2:03 AM, Thomas Monjalon wrote: > The networking drivers features matrix had rows to show > OS and kernel modules support: > - BSD nic_uio > - Linux UIO > - Linux VFIO > - Other kdrv > - Windows > > The kernel modules details are removed to keep only OS sup

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2021-01-21 Thread Maxime Coquelin
On 1/21/21 5:12 AM, 谢华伟(此时此刻) wrote: > > On 2021/1/13 1:37, Maxime Coquelin wrote: >> >> On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote: >>> From: "huawei.xhw" >>> >>> Legacy virtio-pci only supports PIO BAR resource. As we need to >>> create lots of >>> virtio devices and PIO resource on x86 is very li

Re: [dpdk-dev] [PATCH v2 25/44] net/virtio: make Vhost-user req sender consistent

2021-01-21 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, January 20, 2021 5:25 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 25/44] net/virtio: make Vhost-user req sender cons

Re: [dpdk-dev] [PATCH v2 36/44] net/virtio: move Vhost-user reqs to Vhost-user backend

2021-01-21 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, January 20, 2021 5:25 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 36/44] net/virtio: move Vhost-user req

Re: [dpdk-dev] [PATCH v2 01/44] bus/vdev: add helper to get vdev from eth dev

2021-01-21 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, January 20, 2021 5:24 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 01/44] bus/vdev: add helper to get vde

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-21 Thread Ferruh Yigit
On 1/19/2021 2:21 PM, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Tuesday, January 19, 2021 3:03 PM On 1/19/2021 12:27 PM, Morten Brørup wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit Sent: Tuesday, January 19, 2021 1:01 PM On 1/19/20

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-21 Thread Ferruh Yigit
On 1/15/2021 6:39 PM, Ali Alnubani wrote: Hi, Adding Ferruh and Zhaoyan, Ali, You reported some performance regression, did you confirm it? If I get no reply by monday, I'll proceed with this patch. Sure I'll confirm by Monday. Doesn't the regression also reproduce on the Lab's Intel server

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread David Marchand
On Fri, Jan 15, 2021 at 12:11 PM Bruce Richardson wrote: > > As a general principle, each header file should include any other > headers it needs to provide data type definitions or macros. For > example, any header using the uintX_t types in structures or function > prototypes should include "std

Re: [dpdk-dev] [PATCH 2/2] test/crypto: support SSL/TLS way of cipher-auth operations

2021-01-21 Thread Kusztal, ArkadiuszX
Hi Tejasree, > -Original Message- > From: dev On Behalf Of Tejasree Kondoj > Sent: piątek, 18 grudnia 2020 15:10 > To: Akhil Goyal ; Nicolau, Radu > > Cc: Tejasree Kondoj ; Anoob Joseph > ; Ankur Dwivedi ; > dev@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] test/crypto: support SSL/TLS way

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-21 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, January 21, 2021 10:19 AM > > On 1/15/2021 6:39 PM, Ali Alnubani wrote: > > Hi, > > Adding Ferruh and Zhaoyan, > > > >> Ali, > >> > >> You reported some performance regression, did you confirm it? > >> If I get n

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread Bruce Richardson
On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > On Fri, Jan 15, 2021 at 12:11 PM Bruce Richardson > wrote: > > > > As a general principle, each header file should include any other > > headers it needs to provide data type definitions or macros. For > > example, any header using

Re: [dpdk-dev] [PATCH] app/testpmd: fix RSS key

2021-01-21 Thread Zhang, AlvinX
Hi Ferruh, Thanks for your review. I will modify the patch in V2. Alvin > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 20, 2021 3:15 AM > To: Zhang, AlvinX > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix RSS key > > On 1/18/2021 8:59 A

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread Thomas Monjalon
21/01/2021 10:33, Bruce Richardson: > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > Is rte_byteorder.h inclusion in rte_mbuf.h still necessary? > > > Good question. The checks I was doing were only for missing headers. > Checking for superfluous headers is more complicated and

Re: [dpdk-dev] [PATCH v1] eal/arm: fix gcc build for 128-bit atomic compare exchange

2021-01-21 Thread Joyce Kong
>-Original Message- >From: David Marchand >Sent: Friday, January 15, 2021 11:56 PM >To: Joyce Kong >Cc: jer...@marvell.com; Ruifeng Wang ; Honnappa >Nagarahalli ; dev ; nd >; dpdk stable >Subject: Re: [PATCH v1] eal/arm: fix gcc build for 128-bit atomic compare >exchange > >On Fri, Jan 1

[dpdk-dev] [PATCH v2] app/testpmd: fix RSS key

2021-01-21 Thread Zhang,Alvin
From: Alvin Zhang Since the patch '1848b117' has initialized the variable 'key' in 'struct rte_flow_action_rss' with 'NULL', the PMD cannot get the RSS key now. Details as bellow: testpmd> flow create 0 ingress pattern eth / ipv4 / end actions rss types ipv4-other end key 12345

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread Bruce Richardson
On Thu, Jan 21, 2021 at 10:36:18AM +0100, Thomas Monjalon wrote: > 21/01/2021 10:33, Bruce Richardson: > > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > > Is rte_byteorder.h inclusion in rte_mbuf.h still necessary? > > > > > Good question. The checks I was doing were only for

Re: [dpdk-dev] [PATCH 2/2] test/crypto: support SSL/TLS way of cipher-auth operations

2021-01-21 Thread Tejasree Kondoj
Hi Arek, Please see inline. Thanks Tejasree > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, January 21, 2021 2:56 PM > To: Tejasree Kondoj ; Akhil Goyal > ; Nicolau, Radu > Cc: Anoob Joseph ; Ankur Dwivedi > ; dev@dpdk.org > Subject: [EXT] RE: [dpdk-dev] [PATCH 2/2]

Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions

2021-01-21 Thread Kinsella, Ray
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday 19 January 2021 18:32 > To: Gujjar, Abhinandan S > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Akhil Goyal ; Kinsella, Ray > ; acon...@redhat.com; david.march...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: suppo

Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions

2021-01-21 Thread Kinsella, Ray
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday 20 January 2021 13:16 > To: Gujjar, Abhinandan S ; Kinsella, Ray > ; m...@ashroe.eu > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Akhil Goyal ; acon...@redhat.com; > david.march...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-21 Thread Maxime Coquelin
On 1/14/21 4:23 PM, Matan Azrad wrote: > > > From: Maxime Coquelin >> On 1/14/21 2:09 PM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin Hi Matan, On 1/14/21 12:49 PM, Matan Azrad wrote: > Hi Maxime and David > > Thank you for Review. > > From: David Ma

Re: [dpdk-dev] [PATCH v2] mem: improve parameter checking on memory hotplug

2021-01-21 Thread Burakov, Anatoly
On 19-Jan-21 11:39 PM, Thomas Monjalon wrote: 18/01/2021 16:41, Anatoly Burakov: + /* now that we've validated the request, time for a PSA */ What is PSA? Public Service Announcement :) + eal_memalloc_mem_event_notify(RTE_MEM_EVENT_FREE, + m->free_req.ad

Re: [dpdk-dev] [PATCH] net/bnxt: fix FW version log

2021-01-21 Thread Ajit Khaparde
On Sun, Jan 17, 2021 at 7:58 PM Kalesh A P wrote: > > From: Kalesh AP > > Driver is not logging the complete FW version along with HSI version. > Fix it to indicate complete FW version string. > > Fixes: 9a891c1764ea ("net/bnxt: update HWRM to version 1.9.2") > Cc: sta...@dpdk.org > > Signed-off-

Re: [dpdk-dev] [PATCH] net/bnxt: fix ptype index calculation

2021-01-21 Thread Ajit Khaparde
On Mon, Jan 18, 2021 at 1:57 PM Lance Richardson wrote: > > Fix mask to include all four bits of hardware packet type > field. > > Fixes: 97b1db288dd0 ("net/bnxt: use table based packet type translation") > Cc: sta...@dpdk.org > Signed-off-by: Lance Richardson Patch applied to dpdk-next-net-brcm.

[dpdk-dev] Downloading the dpdk-kmods repo as a tarball

2021-01-21 Thread Ferruh Yigit
Hi Thomas, There is a user request to be able to download the 'dpdk-kmods' repo as tarball. The 'dpdk' repo can be downloaded form https://git.dpdk.org/ per each tag, but since the 'dpdk-kmods' repo doesn't have any tag, it is not possible. Also 'dpdk-kmods' is not under the download page, ht

[dpdk-dev] DPDK Release Status Meeting 21/01/2021

2021-01-21 Thread Ferruh Yigit
Meeting minutes of 21 January 2021 -- Agenda: * Release Dates * Highlights * -rc1 status * Subtrees * LTS * Opens Participants: * Arm * Broadcom * Debian/Microsoft * Intel * Nvidia * NXP * Red Hat Release Dates - * v21.02 dates * -rc1 is released

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow split combined with counter

2021-01-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Sunday, January 17, 2021 11:41 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow split combined with counter > > Currently, f

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow split combined with age action

2021-01-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Sunday, January 17, 2021 11:41 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow split combined with age > action > > Current

Re: [dpdk-dev] [PATCH v9 1/2] examples/vhost: add ioat ring space count and check

2021-01-21 Thread Maxime Coquelin
On 1/12/21 5:38 AM, Cheng Jiang wrote: > Add ioat ring space count and check, if ioat ring space is not enough > for the next async vhost packet enqueue, then just return to prevent > enqueue failure. Add rte_ioat_completed_ops() fail handler. > > Signed-off-by: Cheng Jiang > Reviewed-by: Jiay

Re: [dpdk-dev] [PATCH v9 2/2] examples/vhost: refactor vhost data path

2021-01-21 Thread Maxime Coquelin
On 1/12/21 5:38 AM, Cheng Jiang wrote: > Change the vm2vm data path to batch enqueue for better performance. > Support latest async vhost API, refactor vhost async data path, > replace rte_atomicNN_xxx to __atomic_XXX and clean some codes. > > Signed-off-by: Cheng Jiang > Reviewed-by: Jiayu Hu

[dpdk-dev] [PATCH] app/testpmd: fix queue reconfig request on Rx split update

2021-01-21 Thread Viacheslav Ovsiienko
There is the "set rxpkts" command in the testpmd interactive mode, it configures the segment sizes to split the packet on receiving. The mentioned segment sizes are provided on the Rx queue setup as part of queue configuration. Hence, to take the rxpkts command into effect the Rx queues must be exp

Re: [dpdk-dev] [PATCH 1/1] doc: simplify OS support in features matrix

2021-01-21 Thread Ferruh Yigit
On 1/21/2021 8:38 AM, Andrew Rybchenko wrote: On 1/21/21 2:03 AM, Thomas Monjalon wrote: The networking drivers features matrix had rows to show OS and kernel modules support: - BSD nic_uio - Linux UIO - Linux VFIO - Other kdrv - Windows The kernel module

Re: [dpdk-dev] [PATCH v2 0/2] net/mlx4: fix PCI probe and remove functions

2021-01-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Wednesday, January 20, 2021 10:15 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; David Marchand > Subject: [PATCH v2 0/2] net/mlx4: fix PCI probe and remove functions > > A couple of bug fixes in probing and removing

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2021-01-21 Thread 谢华伟(此时此刻)
On 2021/1/21 16:47, Maxime Coquelin wrote: On 1/21/21 5:12 AM, 谢华伟(此时此刻) wrote: On 2021/1/13 1:37, Maxime Coquelin wrote: On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource

Re: [dpdk-dev] [PATCH 1/1] doc: simplify OS support in features matrix

2021-01-21 Thread Thomas Monjalon
> >> The networking drivers features matrix had rows to show > >> OS and kernel modules support: > >>- BSD nic_uio > >>- Linux UIO > >>- Linux VFIO > >>- Other kdrv > >>- Windows > >> > >> The kernel modules details are removed to keep only OS support: > >>- FreeBSD > >>

Re: [dpdk-dev] [PATCH] net/mlx5: fix wrong Flow Tag decompression

2021-01-21 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, January 14, 2021 23:32 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad > Subject: [PATCH] net/mlx5: fix wrong Flow Tag decompression > > Packets can get a wrong Flow Tag on x86 a

[dpdk-dev] [PATCH v1] net/ice: drain out DCF AdminQ command queue

2021-01-21 Thread Haiyue Wang
The virtchnl command message response is handled by matchiing the opcode only for limitation. The DCF AdminQ command with buffer data needs two virtchnl commands, one is to handle the AdminQ header, the other is to handle AdminQ buffer. If the AdminQ header command gets the failure response, the A

[dpdk-dev] [PATCH v2] net/ice: drain out DCF AdminQ command queue

2021-01-21 Thread Haiyue Wang
The virtchnl command message response is handled by matching the opcode only for limitation. The DCF AdminQ command with buffer data needs two virtchnl commands, one is to handle the AdminQ header, the other is to handle AdminQ buffer. If the AdminQ header command gets the failure response, the Ad

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-21 Thread 谢华伟(此时此刻)
On 2021/1/21 16:29, Maxime Coquelin wrote: On 1/20/21 3:54 PM, 谢华伟(此时此刻) wrote: On 2021/1/13 0:58, Maxime Coquelin wrote: On 1/12/21 10:37 AM, Maxime Coquelin wrote: bus/pci: ... On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" VFIO should use the same way to map/read/write PORT

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-21 Thread 谢华伟(此时此刻)
" I think that using inb/outb in the case of VFIO with IOMMU enabled won't work without cap_sys_rawio, and using it in the case of VFIO with IOMMU disabled just bypasses VFIO and so is not correct. Get your concern. PIO bar:     HW virtio on HW machine: any vendor implements hardware virti

Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option

2021-01-21 Thread Juraj Linkeš
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 20, 2021 5:10 PM > To: Honnappa Nagarahalli ; Bruce > Richardson ; Juraj Linkeš > > Cc: Ruifeng Wang ; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Kha

Re: [dpdk-dev] [PATCH v4 1/3] build: add aarch64 clang to meson cross-compile

2021-01-21 Thread Juraj Linkeš
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 20, 2021 11:35 AM > To: Juraj Linkeš > Cc: david.march...@redhat.com; acon...@redhat.com; > maicolgabr...@hotmail.com; jerinjac...@gmail.com; ferruh.yi...@intel.com; > ruifeng.w...@arm.com; dev@dpdk.org; bruce.richa

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-21 Thread Dodji Seketeli
Hello Thomas and others, Thomas Monjalon writes: > Question to an expert, Dodji, Thanks for the kind words, but I am not an expert in anything, sadly. I am just trying to keep learning about these things ;-) > We have this structure: > > struct rte_cryptodev { > lot of fields... >

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread Bruce Richardson
On Thu, Jan 21, 2021 at 10:36:18AM +0100, Thomas Monjalon wrote: > 21/01/2021 10:33, Bruce Richardson: > > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > > Is rte_byteorder.h inclusion in rte_mbuf.h still necessary? > > > > > Good question. The checks I was doing were only for

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-21 Thread Maxime Coquelin
On 1/21/21 3:57 PM, 谢华伟(此时此刻) wrote: > > On 2021/1/21 16:29, Maxime Coquelin wrote: >> >> On 1/20/21 3:54 PM, 谢华伟(此时此刻) wrote: >>> On 2021/1/13 0:58, Maxime Coquelin wrote: On 1/12/21 10:37 AM, Maxime Coquelin wrote: > bus/pci: ... > > On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote:

[dpdk-dev] [PATCH v5 0/3] aarch64 clang cross compilation

2021-01-21 Thread Juraj Linkeš
Use clang/LLVM toolchain with gcc stdlib to cross compile aarch64 target. v3: Removed AARCH_GCC and AARCH_CLANG variables in favor of CC_FOR_BUILD. v4: Rebased. Updated commit msg in build: add aarch64 clang to meson cross-compile. v5: Rebased. Reworded commit msg in build: add aarch64 clang to

[dpdk-dev] [PATCH v5 1/3] build: add aarch64 clang to meson cross-compile

2021-01-21 Thread Juraj Linkeš
Create distribution specific meson cross-file arm64_armv8_linux_clang_ubuntu1804. The file is distribution specific because it contains paths to headers and libs specific to the distribution. The clang/LLVM toolchain does not provide its own c stdlib so the paths must be supplied in some manner. I

[dpdk-dev] [PATCH v5 2/3] ci: add aarch64 clang cross-compilation builds

2021-01-21 Thread Juraj Linkeš
Mirror the existing gcc jobs - build static and shared libs. Use arm64_armv8_linux_clang_ubuntu1804 meson cross file. Signed-off-by: Juraj Linkeš --- .ci/linux-build.sh | 6 +- .travis.yml| 18 ++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/.ci/lin

[dpdk-dev] [PATCH v5 3/3] doc: add clang to aarch64 cross build guide

2021-01-21 Thread Juraj Linkeš
Reorganize and update the aarch64 cross guide with clang cross compilation. Update the GNU toolchain version which clang also uses. Reorganize into common part, GNU part and clang part. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 183 ++

Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option

2021-01-21 Thread Thomas Monjalon
21/01/2021 16:02, Juraj Linkeš: > From: Thomas Monjalon > > 20/01/2021 09:41, Juraj Linkeš: > > > From: Honnappa Nagarahalli > > > > > 20/01/2021 02:04, Honnappa Nagarahalli: > > > > > > > On Tue, Jan 19, 2021 at 04:52:19PM +0100, Thomas Monjalon wrote: > > > > > > > > 19/01/2021 15:56, Juraj Lin

Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev

2021-01-21 Thread Thomas Monjalon
21/01/2021 16:15, Dodji Seketeli: > Hello Thomas and others, > > Thomas Monjalon writes: > > > Question to an expert, Dodji, > > Thanks for the kind words, but I am not an expert in anything, sadly. I > am just trying to keep learning about these things ;-) > > > We have this structure: > > >

Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option

2021-01-21 Thread Bruce Richardson
On Thu, Jan 21, 2021 at 04:52:43PM +0100, Thomas Monjalon wrote: > 21/01/2021 16:02, Juraj Linkeš: > > From: Thomas Monjalon > > > 20/01/2021 09:41, Juraj Linkeš: > > > > From: Honnappa Nagarahalli > > > > > > 20/01/2021 02:04, Honnappa Nagarahalli: > > > > > > > > On Tue, Jan 19, 2021 at 04:52:1

Re: [dpdk-dev] [PATCH v11 3/4] raw/ifpga: add OPAE API for OpenStack Cyborg

2021-01-21 Thread Ferruh Yigit
On 1/21/2021 6:03 AM, Wei Huang wrote: Cyborg is an OpenStack project that aims to provide a general purpose management framework for acceleration resources (i.e. various types of accelerators such as GPU, FPGA, NP, ODP, DPDK/SPDK and so on). It needs some OPAE type APIs to manage PACs (Programma

Re: [dpdk-dev] [PATCH v11 3/4] raw/ifpga: add OPAE API for OpenStack Cyborg

2021-01-21 Thread Ferruh Yigit
On 1/21/2021 6:03 AM, Wei Huang wrote: Cyborg is an OpenStack project that aims to provide a general purpose management framework for acceleration resources (i.e. various types of accelerators such as GPU, FPGA, NP, ODP, DPDK/SPDK and so on). It needs some OPAE type APIs to manage PACs (Programma

Re: [dpdk-dev] [dpdk-stable] [PATCH v11 1/4] raw/ifpga: add fpga rsu function

2021-01-21 Thread Ferruh Yigit
On 1/21/2021 6:03 AM, Wei Huang wrote: RSU (Remote System Update) depends on secure manager which may be different on various implementations, so a new secure manager device is implemented for adapting such difference. There are three major functions added: 1. ifpga_rawdev_update_flash() updates

Re: [dpdk-dev] [PATCH v11 3/4] raw/ifpga: add OPAE API for OpenStack Cyborg

2021-01-21 Thread Ferruh Yigit
On 1/21/2021 6:03 AM, Wei Huang wrote: +int opae_init(int eal_init_result) +{ + int ret = 0; + + if (!check_eal(0)) + return 0; + + if (eal_init_result < 0) { + if (rte_errno == EALREADY) { + eal_inited = 1; +

Re: [dpdk-dev] [dpdklab] RE: [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-21 Thread Lincoln Lavoie
Hi All, Trying to follow the specific conversation. It is correct, the lab does not list the specific throughput values achieved by the hardware, as that data can be sensitive to the hardware vendors, etc. The purpose of the lab is to check for degradations caused by patches, so the difference is

Re: [dpdk-dev] [dpdk-stable] [PATCH v11 4/4] examples/ifpga: add example for opae ifpga API

2021-01-21 Thread Ferruh Yigit
On 1/21/2021 6:03 AM, Wei Huang wrote: +get_property command + + +Display property information of specified FPGA. Property type is defined as below. +0 - All properties +1 - PCI property +2 - FME property +4 - port property +8 - BMC property +PCI property is always available,

Re: [dpdk-dev] [PATCH v3 01/11] common/mlx5: add DevX attributes for compress

2021-01-21 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH v3 01/11] common/mlx5: add DevX attributes > for compress > > Add the DevX attributes for compress related engines: > - compress > - decompress > - dma > > Signed-off-by: Matan Azrad > Acked-by: Viacheslav Ovsiienko > --- > drivers/common/mlx5/mlx

Re: [dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table

2021-01-21 Thread Slava Ovsiienko
Hi, Souvik Thank you for the patch, please see my comments below. >From: Souvik Dey >Sent: Wednesday, December 9, 2020 17:11 >To: Raslan Darawsheh ; Matan Azrad ; >Shahaf Shuler >; Slava Ovsiienko >Cc: dev@dpdk.org; Souvik Dey >Subject: [PATCH] net/mlx5:fix storing the synced MAC to internal

Re: [dpdk-dev] [PATCH v3 01/11] common/mlx5: add DevX attributes for compress

2021-01-21 Thread Matan Azrad
From: Tal Shnaiderman > Sent: Thursday, January 21, 2021 6:52 PM > To: Matan Azrad ; dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Ashish Gupta > ; Fiona Trahe ; > akhil.go...@nxp.com > Subject: RE: [dpdk-dev] [PATCH v3 01/11] common/mlx5: add DevX attributes > for compress > > > Subject: [d

[dpdk-dev] [PATCH v4 0/6] power: fix make build for power apps

2021-01-21 Thread David Hunt
The guest channel message definitions and functions in guest_channel.h are needed by applications and need to be made public. This worked pre-20.11, but now with all the meson/ninja changes, making these apps externally no longer works. To fix, we need to move the header file with the API definiti

[dpdk-dev] [PATCH v4 1/6] power: create guest channel public header file

2021-01-21 Thread David Hunt
From: Bruce Richardson In preparation for making the header file public, we first rename channel_commands.h as rte_power_guest_channel.h. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Si

[dpdk-dev] [PATCH v4 2/6] power: make channel msg functions public

2021-01-21 Thread David Hunt
From: Bruce Richardson Move the 2 public functions into rte_power_guest_channel.h Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Signed-off-by: David Hunt

[dpdk-dev] [PATCH v4 3/6] power: rename public structs

2021-01-21 Thread David Hunt
From: Bruce Richardson rename the public structs to have an rte_power_ prefix and add them to version.map in experimental section. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-of

[dpdk-dev] [PATCH v4 4/6] power: rename defines

2021-01-21 Thread David Hunt
From: Bruce Richardson Rename the #defines to have an RTE_POWER_ prefix Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Signed-off-by: David Hunt --- exa

[dpdk-dev] [PATCH v4 5/6] power: add new header file to export list

2021-01-21 Thread David Hunt
From: Bruce Richardson Adjust meson.build so that 'ninja install' copies the new header file into the installation directory. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v4 6/6] power: clean up includes

2021-01-21 Thread David Hunt
From: Bruce Richardson re-organise the including of the new public header file and remove un-needed includes Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option

2021-01-21 Thread Thomas Monjalon
21/01/2021 17:12, Bruce Richardson: > On Thu, Jan 21, 2021 at 04:52:43PM +0100, Thomas Monjalon wrote: > > 21/01/2021 16:02, Juraj Linkeš: > > > From: Thomas Monjalon > > > > 20/01/2021 09:41, Juraj Linkeš: > > > > > From: Honnappa Nagarahalli > > > > > > > 20/01/2021 02:04, Honnappa Nagarahalli:

Re: [dpdk-dev] [PATCH] build: force pkg-config for dependency detection

2021-01-21 Thread Daly, Lee
> -Original Message- > From: Richardson, Bruce > Sent: Monday, January 18, 2021 2:30 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Richardson, Bruce > ; sta...@dpdk.org; Matan Azrad > ; Shahaf Shuler ; Viacheslav > Ovsiienko ; Liron Himi ; > Trahe, Fiona ; Griffin, John > ; Jain, Deepak K

Re: [dpdk-dev] Crypto API for AES-XTS cipher algorithm

2021-01-21 Thread Matan Azrad
Hi Akhil Yes, you right regards terms of data-unit and block size. My intention was for data-unit. AES-XTS algorithm is a mode of AES so by definition the block size is 16B. So, no need capability for it. Also in the symmetric operation structure, the `length` field is described as next: /**< T

[dpdk-dev] [PATCH v3] net/ice: drain out DCF AdminQ command queue

2021-01-21 Thread Haiyue Wang
The virtchnl message is handled one by one by checking opcode to match the response for the request. The DCF AdminQ command with buffer needs two virtchnl commands, one is to handle the AdminQ descriptor, the other is to the handle AdminQ buffer. If both of them are sent to PF successfully, it nee

[dpdk-dev] [PATCH v2] app/testpmd: tx pkt clones parameter in flowgen

2021-01-21 Thread Igor Russkikh
When testing high performance numbers, it is often that CPU performance limits the max values device can reach (both in pps and in gbps) Here instead of recreating each packet separately, we use clones counter to resend the same mbuf to the line multiple times. PMDs handle that transparently due

Re: [dpdk-dev] Crypto API for AES-XTS cipher algorithm

2021-01-21 Thread Akhil Goyal
Hi Matan, Can you send an RFC patch for the changes you are looking forward in the cryptodev lib. Regards, Akhil From: Matan Azrad Sent: Thursday, January 21, 2021 11:16 PM To: Akhil Goyal ; Declan Doherty Cc: dev@dpdk.org Subject: RE: Crypto API for AES-XTS cipher algorithm Hi Akhil Yes, y

[dpdk-dev] [PATCH] doc: update i40e PMD to support on windows

2021-01-21 Thread Pallavi Kadam
Add documentation to support i40e PMD on Windows. Update the release notes for the same. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- doc/guides/nics/i40e.rst | 16 ++-- doc/guides/rel_notes/release_21_02.rst | 4 2 files changed, 18 insertions(+),

Re: [dpdk-dev] [PATCH v4 02/22] app/testpmd: fix max rx packet length for VLAN packets

2021-01-21 Thread Lance Richardson
On Mon, Jan 18, 2021 at 2:08 AM Steve Yang wrote: > > When the max rx packet length is smaller than the sum of mtu size and > ether overhead size, it should be enlarged, otherwise the VLAN packets > will be dropped. > > Removed the rx_offloads assignment for jumbo frame during command line > parsi

Re: [dpdk-dev] [PATCH v3] net/bnxt: code refactoring changes

2021-01-21 Thread Ajit Khaparde
On Wed, Jan 20, 2021 at 11:15 PM Ajit Khaparde wrote: > > From: Somnath Kotur > > Move all the individual driver fields allocation routines to one > routine - bnxt_drv_init(). This houses all such routines where > memory needs to be allocated once during the driver's lifetime > and does not need

Re: [dpdk-dev] [PATCH v3] net/bnxt: fix lock handling in stop and close

2021-01-21 Thread Ajit Khaparde
On Wed, Jan 20, 2021 at 11:17 PM Ajit Khaparde wrote: > > From: Somnath Kotur > > err_recovery_lock needs to be released before returning in > stop and close_op if FW_RESET flag is set. > > Fixes: dd3613560573 ("net/bnxt: check chip reset in dev stop and close") > Signed-off-by: Somnath Kotur >

Re: [dpdk-dev] [dpdk-stable] [PATCH] vdpa/mlx5: fix configuration mutex cleanup

2021-01-21 Thread Matan Azrad
From: Maxime Coquelin > On 1/14/21 4:23 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin > >> On 1/14/21 2:09 PM, Matan Azrad wrote: > >>> > >>> > >>> From: Maxime Coquelin > Hi Matan, > > On 1/14/21 12:49 PM, Matan Azrad wrote: > > Hi Maxime and David > > > > T

Re: [dpdk-dev] [PATCH] doc: update i40e PMD to support on windows

2021-01-21 Thread Thomas Monjalon
21/01/2021 20:09, Pallavi Kadam: > Add documentation to support i40e PMD on Windows. > Update the release notes for the same. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > doc/guides/nics/i40e.rst | 16 ++-- > doc/guides/rel_notes/release_21_02.r

Re: [dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-21 Thread Thomas Monjalon
21/01/2021 16:15, Bruce Richardson: > On Thu, Jan 21, 2021 at 10:36:18AM +0100, Thomas Monjalon wrote: > > 21/01/2021 10:33, Bruce Richardson: > > > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > > > Is rte_byteorder.h inclusion in rte_mbuf.h still necessary? > > > > > > > Good

[dpdk-dev] [PATCH 1/1] lib: fix doxygen for parameters of function pointers

2021-01-21 Thread Thomas Monjalon
Some parameters of typedef'ed function pointers were not properly listed in the doxygen comments. The error is seen with doxygen 1.9 which added this specific check: https://github.com/doxygen/doxygen/commit/d34236ba4037 Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- lib/librte_

Re: [dpdk-dev] [PATCH v9 1/2] examples/vhost: add ioat ring space count and check

2021-01-21 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, January 21, 2021 8:35 PM > To: Jiang, Cheng1 ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX > ; Wang, Yinan > Subject: Re: [PATCH v9 1/2] examples/vhost: add ioat ring space count and > check > > > > On

Re: [dpdk-dev] [dpdk-stable] [PATCH v11 1/4] raw/ifpga: add fpga rsu function

2021-01-21 Thread Huang, Wei
Hi Ferruh, Cyborg is an OpenStack project that aims to provide a general purpose management framework for acceleration resources (i.e. various types of accelerators such as GPU, FPGA, NP, ODP, DPDK/SPDK and so on). To update the FPGA flash is one of requirements from Cyborg. Originally there a

Re: [dpdk-dev] [PATCH v3] net/ice: drain out DCF AdminQ command queue

2021-01-21 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Friday, January 22, 2021 1:32 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Fu, Qi ; Wang, Haiyue > ; sta...@dpdk.org > Subject: [PATCH v3] net/ice: drain out DCF AdminQ command queue > > The virtchnl message is handled one

Re: [dpdk-dev] [PATCH] net/ice: fix symmetric rule creating

2021-01-21 Thread Zhang, Qi Z
> -Original Message- > From: Ding, Xuan > Sent: Thursday, January 21, 2021 3:27 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Ding, Xuan ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix symmetric rule creating > > Only allow to create symmetric rule for L3/

Re: [dpdk-dev] [PATCH v11 3/4] raw/ifpga: add OPAE API for OpenStack Cyborg

2021-01-21 Thread Huang, Wei
Hi Ferruh, These log information will not be output for the default log level is OPAE_LOG_ERR, they are output only when log level is set to OPAE_LOG_INFO. I can remove them if you think it's necessary. All these opae_xxx functions will check the input PCI address is valid or not, and the rawd

Re: [dpdk-dev] [PATCH v1] net/ice/base: add ethertype offset for QinQ dummy pkt

2021-01-21 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Yuying > Sent: Tuesday, January 19, 2021 3:13 PM > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Wang, Haiyue ; Guo, Junfeng > ; Zhang, Yuying > Subject: [PATCH v1] net/ice/base: add ethertype offset for QinQ dummy pkt > > Add the ethertype

Re: [dpdk-dev] [PATCH v11 3/4] raw/ifpga: add OPAE API for OpenStack Cyborg

2021-01-21 Thread Huang, Wei
Hi Ferruh, That's a good question. The answer is YES, we do need all these functions. We have complete the integrated test with Cyborg, there is no redundant function. Let me show you a use case in Cyborg. Cyborg will update FPGA flash and reboot it to make it effective, so they will call funct

[dpdk-dev] [PATCH] net/iavf: fix symmetric rule creating

2021-01-21 Thread Xuan Ding
Only allow to create symmetric rule for L3/L4. Fixes: 91f27b2e39ab("net/iavf: refactor RSS") Cc: sta...@dpdk.org Signed-off-by: Xuan Ding --- drivers/net/iavf/iavf_hash.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index

Re: [dpdk-dev] [PATCH v11 3/4] raw/ifpga: add OPAE API for OpenStack Cyborg

2021-01-21 Thread Huang, Wei
Hi Ferruh, Most of other APIs depends on EAL environment, they will make sure EAL is ready be executing their task. As replied in previous mail, these functions will be called in Python environment. Python application should initialize EAL explicitly before calling other APIs like opae_update_

Re: [dpdk-dev] [PATCH v2 26/44] net/virtio: add Virtio-user ops to set owner

2021-01-21 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, January 20, 2021 5:25 AM > To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; > amore...@redhat.com; david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 26/44] net/virtio: add Virtio-user ops to set owne

Re: [dpdk-dev] [dpdk-stable] [PATCH v11 4/4] examples/ifpga: add example for opae ifpga API

2021-01-21 Thread Huang, Wei
Hi Ferruh, Yes, all the command need PCI BDF as identifier of FPGA, because Cyborg use PCI BDF to call these APIs, Cyborg does not see any DPDK data structures. That's why I add a group of middle layer functions in ifpga_opae_api.c to isolate Cyborg from DPDK. Thanks, Wei -Original Messag

Re: [dpdk-dev] [PATCH] net/iavf: fix symmetric rule creating

2021-01-21 Thread Xing, Beilei
> -Original Message- > From: Ding, Xuan > Sent: Friday, January 22, 2021 11:19 AM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Ding, Xuan ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix symmetric rule creating > > Only allow to create symmetric rule for L3/

[dpdk-dev] [PATCH v1 0/2] fix bugs of app eventdev

2021-01-21 Thread Feifei Wang
Fix bugs of app eventdev Feifei Wang (2): app/eventdev: adjust event count order for pipeline test app/eventdev: remove redundant enqueue in burst Tx app/test-eventdev/test_pipeline_queue.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) -- 2.25.1

[dpdk-dev] [PATCH v1 1/2] app/eventdev: adjust event count order for pipeline test

2021-01-21 Thread Feifei Wang
For the fwd mode (internal_port = false) in pipeline test, processed-pkts increment should after enqueue. However, in multi_stage_fwd and multi_stage_burst_fwd, "w->processed_pkts" is increased before enqueue. To fix this, move "w->processed_pkts" increment after enqueue, and then the main core ca

[dpdk-dev] [PATCH v1 2/2] app/eventdev: remove redundant enqueue in burst Tx

2021-01-21 Thread Feifei Wang
For eventdev pipeline test, in burst_tx cases, there is no needed to set ev.op as RTE_EVENT_OP_RELEASE and call pipeline_event_enqueue_burst to release events. This is because for tx mode(internal_port=true), the capability "implicit_release" of dev is enabled, and the app can release events by "rt

Re: [dpdk-dev] [PATCH] net/ixgbe: disable NFS filtering

2021-01-21 Thread Guo, Jia
Hi, dapeng > -Original Message- > From: dapengx...@intel.com > Sent: Wednesday, January 20, 2021 5:27 PM > To: Guo, Jia ; Wang, Haiyue ; > Yang, Qiming > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: disable NFS filtering > > From: Dapeng Yu > > Disable

[dpdk-dev] [PATCH] net/iavf: fix port VLAN cfg err for AVF with SVM

2021-01-21 Thread Junfeng Guo
For AVF with single vlan mode (SVM), port vlan stripping config has already been disabled by PF. In this scenario, the error of -ENOTSUP can be ignored. Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities") Signed-off-by: Junfeng Guo --- drivers/net/iavf/iavf_ethdev.c | 3 +++ 1 file c

  1   2   >