On Thu, Jan 21, 2021 at 10:36:18AM +0100, Thomas Monjalon wrote: > 21/01/2021 10:33, Bruce Richardson: > > On Thu, Jan 21, 2021 at 10:25:07AM +0100, David Marchand wrote: > > > Is rte_byteorder.h inclusion in rte_mbuf.h still necessary? > > > > > Good question. The checks I was doing were only for missing headers. > > Checking for superfluous headers is more complicated and not something I've > > looked at. I know it was previously suggested to use the > > "include-what-you-use" tool on DPDK, if anyone wants to attempt that. > > I would love having an integration of include-what-you-use in our build > system. > I don't know whether it's trivial or difficult with meson. > +1 to that.
I'm not familiar enough with the tool to comment on how hard or difficult it would be. I try it once a few years ago, and I don't think I managed to get it working successfully standalone, let alone as part of a build system. However, I'm sure IWYU has moved on quite a bit since then...
