Hi, dapeng
> -----Original Message-----
> From: dapengx...@intel.com <dapengx...@intel.com>
> Sent: Wednesday, January 20, 2021 5:27 PM
> To: Guo, Jia <jia....@intel.com>; Wang, Haiyue <haiyue.w...@intel.com>;
> Yang, Qiming <qiming.y...@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx...@intel.com>; sta...@dpdk.org
> Subject: [PATCH] net/ixgbe: disable NFS filtering
>
> From: Dapeng Yu <dapengx...@intel.com>
>
> Disable NFS header filtering whether NFS packets coalescing are required or
> not.
>
> This behavior is aligned with ixgbe kernel driver.
>
> Fixes: b826efba6de4 ("net/ixgbe: align register setting when RSC is disabled")
I suggest to add one more fix line which related with the patch, since below
patch is what you most change the behaviors.
the Fixes: 8eecb3295aed ("ixgbe: add LRO support ")
And I saw prior fixed patch are also said it would flow the datasheet, could
you explain why you bring this change? Is it anything change about that in
kernel driver prior with currently?
> Cc: sta...@dpdk.org
>
> Signed-off-by: Dapeng Yu <dapengx...@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index cc8f70e6d..3fb55c675 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -4923,15 +4923,11 @@ ixgbe_set_rsc(struct rte_eth_dev *dev)
> /* RFCTL configuration */
> rfctl = IXGBE_READ_REG(hw, IXGBE_RFCTL);
> if ((rsc_capable) && (rx_conf->offloads &
> DEV_RX_OFFLOAD_TCP_LRO))
> - /*
> - * Since NFS packets coalescing is not supported - clear
> - * RFCTL.NFSW_DIS and RFCTL.NFSR_DIS when RSC is
> - * enabled.
> - */
> - rfctl &= ~(IXGBE_RFCTL_RSC_DIS | IXGBE_RFCTL_NFSW_DIS
> |
> - IXGBE_RFCTL_NFSR_DIS);
> + rfctl &= ~IXGBE_RFCTL_RSC_DIS;
> else
> rfctl |= IXGBE_RFCTL_RSC_DIS;
> + /* disable NFS filtering */
> + rfctl |= (IXGBE_RFCTL_NFSW_DIS | IXGBE_RFCTL_NFSR_DIS);
I thinks the "()" is no need, right?
> IXGBE_WRITE_REG(hw, IXGBE_RFCTL, rfctl);
>
> /* If LRO hasn't been requested - we are done here. */
> --
> 2.27.0
