Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix configuration of max frame size

2021-01-15 Thread Guo, Jia
Hi, Alvin > -Original Message- > From: Zhang,Alvin > Sent: Friday, January 15, 2021 3:00 PM > To: Guo, Jia ; Wang, Haiyue ; > Xie, WeiX > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: [PATCH v3] net/ixgbe: fix configuration of max frame size > > From: Alvin Zhang > >

Re: [dpdk-dev] [PATCH] test: fix buffer overflow

2021-01-15 Thread Guo, Jia
Hi, Alvin > -Original Message- > From: dev On Behalf Of Zhang,Alvin > Sent: Wednesday, November 25, 2020 5:46 PM > To: Liang, Cunming > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] test: fix buffer overflow > > From: Alvin Zhang > > The Tx buffer m

Re: [dpdk-dev] [PATCH v2 0/4] add crypto perf test graphing script

2021-01-15 Thread Doherty, Declan
On 14/01/2021 10:41 AM, Ciara Power wrote: This patchset introduces a python script to run various crypto performance test cases, and graph the results in a consumable manner. The test suites are configured via JSON file. Some config files are provided, or the user may create one. Currently th

[dpdk-dev] [PATCH v2] net/i40e: fix out-of-scope variable

2021-01-15 Thread Zhang,Alvin
From: Alvin Zhang Using "key", which points to an out-of-scope variable "rss_key_default". Coverity issue: 365293 Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") Signed-off-by: Alvin Zhang --- V2: Update the commit log. --- drivers/net/i40e/i40e_hash.c | 6 -- 1 file changed, 4 inser

Re: [dpdk-dev] [PATCH v14 05/12] build: organize Arm config into dict

2021-01-15 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Wednesday, December 23, 2020 7:48 PM > To: bruce.richard...@intel.com; Ruifeng Wang ; > Honnappa Nagarahalli ; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.khap

Re: [dpdk-dev] [PATCH v14 07/12] build: use native machine args in Arm native build

2021-01-15 Thread Ruifeng Wang
> -Original Message- > From: Juraj Linkeš > Sent: Wednesday, December 23, 2020 7:48 PM > To: bruce.richard...@intel.com; Ruifeng Wang ; > Honnappa Nagarahalli ; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.khap

Re: [dpdk-dev] [PATCH] test: fix buffer overflow

2021-01-15 Thread Guo, Jia
Acked-by: Jeff Guo > -Original Message- > From: Guo, Jia > Sent: Friday, January 15, 2021 4:31 PM > To: 'Zhang,Alvin' ; Liang, Cunming > > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] test: fix buffer overflow > > Hi, Alvin > > > -Original M

Re: [dpdk-dev] [PATCH 11/40] net/virtio: validate features at bus level

2021-01-15 Thread Maxime Coquelin
On 1/6/21 10:33 AM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin > wrote: >> diff --git a/drivers/net/virtio/virtio_ethdev.c >> b/drivers/net/virtio/virtio_ethdev.c >> index 00aa38e4ef..91a93b2b6e 100644 >> --- a/drivers/net/virtio/virtio_ethdev.c >> +++ b/drivers/n

Re: [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release

2021-01-15 Thread Li, Xiaoyun
Hi Actually, you can just type "stty echo" to solve the problem you met. But anyway, if you want to fix it in DPDK I think you misunderstood stephan's solution. You don't need to implement atexit() yourself in eal. It's a common function like exit() in rte_exit(). Then when exit() is called. Each

Re: [dpdk-dev] [PATCH 14/40] net/virtio: pack virtio HW struct

2021-01-15 Thread Maxime Coquelin
On 1/6/21 10:58 AM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin > wrote: >> >> This patch improves the virtio_hw struct packing, >> going from 88 down to 80 bytes with a 6 bytes hole in >> the end of the first cacheline. Fields only used in the >> slow path are plac

Re: [dpdk-dev] [PATCH 16/40] net/virtio: introduce generic virtio header

2021-01-15 Thread Maxime Coquelin
On 1/6/21 11:08 AM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin > wrote: >> diff --git a/drivers/net/virtio/virtio.h b/drivers/net/virtio/virtio.h >> new file mode 100644 >> index 00..eb078bc227 >> --- /dev/null >> +++ b/drivers/net/virtio/virtio.h >> @@ -0,

Re: [dpdk-dev] [PATCH v2 1/4] test/cryptodev: fix latency test csv output

2021-01-15 Thread Dybkowski, AdamX
> -Original Message- > From: Power, Ciara > Sent: Thursday, 14 January, 2021 11:41 > To: dev@dpdk.org > Cc: Doherty, Declan ; akhil.go...@nxp.com; > step...@networkplumber.org; Dybkowski, AdamX > ; Power, Ciara ; De > Lara Guarch, Pablo ; sta...@dpdk.org > Subject: [PATCH v2 1/4] test/cryp

Re: [dpdk-dev] [PATCH v2 2/4] test/cryptodev: fix csv output format

2021-01-15 Thread Dybkowski, AdamX
> -Original Message- > From: Power, Ciara > Sent: Thursday, 14 January, 2021 11:41 > To: dev@dpdk.org > Cc: Doherty, Declan ; akhil.go...@nxp.com; > step...@networkplumber.org; Dybkowski, AdamX > ; Power, Ciara ; > Burakov, Anatoly ; De Lara Guarch, Pablo > ; sta...@dpdk.org > Subject: [PA

Re: [dpdk-dev] [PATCH v2 3/4] usertools: add script to graph crypto perf results

2021-01-15 Thread Dybkowski, AdamX
> -Original Message- > From: Power, Ciara > Sent: Thursday, 14 January, 2021 11:41 > To: dev@dpdk.org > Cc: Doherty, Declan ; akhil.go...@nxp.com; > step...@networkplumber.org; Dybkowski, AdamX > ; Power, Ciara ; > Thomas Monjalon > Subject: [PATCH v2 3/4] usertools: add script to graph c

Re: [dpdk-dev] [PATCH 23/40] net/virtio: make Vhost-user req sender consistent

2021-01-15 Thread Maxime Coquelin
On 1/6/21 12:50 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subjec

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix configuration of max frame size

2021-01-15 Thread Zhang, AlvinX
Hi Guojia, Thanks for you reply. I will modify as we discussion. > -Original Message- > From: Guo, Jia > Sent: Friday, January 15, 2021 4:15 PM > To: Zhang, AlvinX ; Wang, Haiyue > ; Xie, WeiX > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: RE: [PATCH v3] net/ixgbe: fix c

Re: [dpdk-dev] [PATCH 27/40] net/virtio: add Virtio-user memory tables ops

2021-01-15 Thread Maxime Coquelin
On 1/6/21 12:57 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subjec

[dpdk-dev] [PATCH v1] eal/arm: fix gcc build for 128-bit atomic compare exchange

2021-01-15 Thread Joyce Kong
Compiling with "meson build -Dbuildtype=debug --cross-file config/arm/arm64_thunderx2_linux_gcc" shows the warnings "function returns an aggregate [-Waggregate-return]": ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function ‘__cas_128_relaxed’: ../../dpdk/lib/librte_eal/arm/include/rte

[dpdk-dev] [PATCH v4] net/ixgbe: fix configuration of max frame size

2021-01-15 Thread Zhang,Alvin
From: Alvin Zhang For 82599 NIC, jumbo frame feature is not supported in IOV mode, if a VF requests to configure the max frame size to that not bigger than RTE_ETHER_MAX_LEN, the kernel driver returns 0, but the DPDK ixgbe PMD returens -1, this will cause the VF to fail to start when the PF drive

Re: [dpdk-dev] [PATCH 28/40] net/virtio: add Virtio-user vring setting ops

2021-01-15 Thread Maxime Coquelin
On 1/6/21 1:01 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

Re: [dpdk-dev] [PATCH v2 4/4] maintainers: update crypto perf app maintainers

2021-01-15 Thread Dybkowski, AdamX
> -Original Message- > From: Power, Ciara > Sent: Thursday, 14 January, 2021 11:41 > To: dev@dpdk.org > Cc: Doherty, Declan ; akhil.go...@nxp.com; > step...@networkplumber.org; Dybkowski, AdamX > ; Power, Ciara ; > Thomas Monjalon > Subject: [PATCH v2 4/4] maintainers: update crypto perf

Re: [dpdk-dev] [PATCH 28/40] net/virtio: add Virtio-user vring setting ops

2021-01-15 Thread Maxime Coquelin
On 1/6/21 1:03 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

Re: [dpdk-dev] [PATCH 29/40] net/virtio: add Virtio-user vring file ops

2021-01-15 Thread Maxime Coquelin
On 1/6/21 1:04 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

Re: [dpdk-dev] [PATCH 30/40] net/virtio: add Virtio-user vring address ops

2021-01-15 Thread Maxime Coquelin
On 1/6/21 1:06 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

Re: [dpdk-dev] [PATCH v4] gso: add VXLAN UDP/IPv4 support

2021-01-15 Thread Thomas Monjalon
15/01/2021 04:51, yang_y_yi: > > At 2020-11-19 14:49:23, "Hu, Jiayu" wrote: > >Acked-by: Jiayu Hu > > Hi, Thomas > > This patch has been acked very long, but it isn't merged into master, what's > wrong? Sorry for the miss. Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH v6] ip_frag: remove padding length of fragment

2021-01-15 Thread Thomas Monjalon
> > In some situations, we would get several ip fragments, which total > > data length is less than min_ip_len(64) and padding with zeros. > > We simulated intermediate fragments by modifying the MTU. > > To illustrate the problem, we simplify the packet format and > > ignore the impact of the pack

Re: [dpdk-dev] [PATCH v3 01/22] ethdev: fix MTU size exceeds max rx packet length

2021-01-15 Thread oulijun
Hi Steve This is a very good job! But I have some question and suggestions. Please check it. 在 2021/1/14 17:45, Steve Yang 写道: Ethdev is using default Ethernet overhead to decide if provided 'max_rx_pkt_len' value is bigger than max (non jumbo) MTU value, and limits it to MAX if it is. Since th

Re: [dpdk-dev] [PATCH 31/40] net/virtio: add Virtio-user status ops

2021-01-15 Thread Maxime Coquelin
On 1/6/21 1:09 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

Re: [dpdk-dev] [PATCH 18/40] net/virtio: move virtqueue defines in generic header

2021-01-15 Thread Maxime Coquelin
On 1/6/21 4:53 PM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin > wrote: >> >> This patch moves the virtqueues defines from PCI header >> to the genreric one. > > > generic* > >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtio.h

Re: [dpdk-dev] [PATCH 19/40] net/virtio: move config definitions to generic header

2021-01-15 Thread Maxime Coquelin
On 1/6/21 5:01 PM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin > wrote: >> diff --git a/drivers/net/virtio/virtio.h b/drivers/net/virtio/virtio.h >> index eeeb5dba4f..5169436c9f 100644 >> --- a/drivers/net/virtio/virtio.h >> +++ b/drivers/net/virtio/virtio.h >> @@ -

[dpdk-dev] [PATCH] doc: update release notes for txgbe

2021-01-15 Thread Jiawen Wu
Add txgbe PMD new features in release notes, update user guide in txgbe.rst for flow API and traffic manager. Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst | 38 ++ doc/guides/rel_notes/release_21_02.rst | 7 + 2 files changed, 45 insertions(+)

Re: [dpdk-dev] [PATCH 33/40] net/virtio: improve Virtio-user errors handling

2021-01-15 Thread Maxime Coquelin
On 1/7/21 3:26 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

Re: [dpdk-dev] [PATCH 22/40] net/virtio: remove last PCI refs in non-PCI code

2021-01-15 Thread Maxime Coquelin
On 1/6/21 5:18 PM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin > wrote: >> >> This patch finalizes the bus isolation part of this >> refactoring. >> >> Signed-off-by: Maxime Coquelin >> --- > > [snip] > >> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net

[dpdk-dev] [PATCH v2 00/19] ensure headers have correct includes

2021-01-15 Thread Bruce Richardson
As a general principle, each header file should include any other headers it needs to provide data type definitions or macros. For example, any header using the uintX_t types in structures or function prototypes should include "stdint.h" to provide those type definitions. In practice, while many,

[dpdk-dev] [PATCH v2 01/19] eal: fix missing header inclusion

2021-01-15 Thread Bruce Richardson
The rte_reciprocal header file used standard __rte_always_inline from rte_common.h but does not include that header file, leading to compiler errors when the reciprocal header is included alone. Similarly, rte_thread.h was missing the compat header to get the __rte_experimental macro definition. F

[dpdk-dev] [PATCH v2 02/19] telemetry: fix missing header include

2021-01-15 Thread Bruce Richardson
The telemetry header file uses the rte_cpuset_t type, but does not include any header providing that type. Include rte_os.h to provide the necessary type. Fixes: febbebf7f255 ("telemetry: keep threads separate from data plane") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_

[dpdk-dev] [PATCH v2 03/19] ethdev: fix missing header include

2021-01-15 Thread Bruce Richardson
The define for RTE_ETH_FLOW_MAX is defined in rte_ethdev.h, so that header should be included in rte_eth_ctrl.h to allow it to be compiled independently. Fixes: 7fa96d696f2c ("ethdev: unification of flow types") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_ethdev/rte_eth_c

[dpdk-dev] [PATCH v2 04/19] net: fix missing header include

2021-01-15 Thread Bruce Richardson
The Geneve protocol header file is missing the rte_byteorder.h header. Fixes: ea0e711b8ae0 ("app/testpmd: add GENEVE parsing") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_net/rte_geneve.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_net/rte_geneve.h b/li

[dpdk-dev] [PATCH v2 05/19] mbuf: fix missing header include

2021-01-15 Thread Bruce Richardson
The rte_mbuf_dyn.h header file uses a number of types and macros without including the required header files to get the definitions of those macros/types. Similarly, the rte_mbuf_core.h file was missing an include for rte_byteorder.h header. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and

[dpdk-dev] [PATCH v2 06/19] bitratestats: fix missing header include

2021-01-15 Thread Bruce Richardson
The rte_compat.h header file must be included to get the definition of __rte_experimental. Fixes: f030bff72f81 ("bitrate: add free function") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_bitratestats/rte_bitrate.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/lib

[dpdk-dev] [PATCH v2 07/19] rib: fix missing header includes

2021-01-15 Thread Bruce Richardson
The standard integer types, and the size_t types are missing their required header includes in the rib header file. Fixes: 5a5793a5ffa2 ("rib: add RIB library") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_rib/rte_rib.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[dpdk-dev] [PATCH v2 09/19] ipsec: fix missing header include

2021-01-15 Thread Bruce Richardson
The rte_ipsec_sad.h header used the standard uintXX_t types, but did not include stdint.h header for them. Fixes: 401633d9c112 ("ipsec: add inbound SAD API") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_ipsec/rte_ipsec_sad.h | 1 + 1 file changed, 1 insertion(+) diff --gi

[dpdk-dev] [PATCH v2 10/19] fib: fix missing header includes

2021-01-15 Thread Bruce Richardson
Add stdint.h to get definitions of standard integer types Fixes: 39e927248416 ("fib: add FIB library") Fixes: 40d41a8a7b34 ("fib: support IPv6") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_fib/rte_fib.h | 1 + lib/librte_fib/rte_fib6.h | 1 + 2 files changed, 2 insertion

[dpdk-dev] [PATCH v2 08/19] vhost: fix missing header includes

2021-01-15 Thread Bruce Richardson
The vhost header files were missing definitions from headers to allow them to be compiled up individually. Fixes: d7280c9fffcb ("vhost: support selective datapath") Fixes: a49f758d1170 ("vhost: split vDPA header file") Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Cc: st

[dpdk-dev] [PATCH v2 11/19] table: fix missing header include

2021-01-15 Thread Bruce Richardson
The rte_lru_x86.h header, included from the main rte_lru.h header, uses the RTE_CC_IS_GNU macro from rte_common.h but fails to include that header file. Fixes: 0c9a5735a947 ("eal: fix compiler detection in public headers") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_table

[dpdk-dev] [PATCH v2 12/19] pipeline: fix missing header includes

2021-01-15 Thread Bruce Richardson
The stdio.h header needs to be included to get the definition of the FILE type. Fixes: b32c0a2c5e4c ("pipeline: add SWX table update high level API") Fixes: 3ca60ceed79a ("pipeline: add SWX pipeline specification file") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_pipeline

[dpdk-dev] [PATCH v2 13/19] metrics: fix variable declaration in header

2021-01-15 Thread Bruce Richardson
The global variable "tel_met_data" was declared in a header file, rather than in a C file, leading to duplicate definitions if more than one C file included the header. Fixes: c5b7197f662e ("telemetry: move some functions to metrics library") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson -

[dpdk-dev] [PATCH v2 14/19] node: fix missing header include

2021-01-15 Thread Bruce Richardson
The rte_compat header file is needed for the '__rte_experimental' macro. Fixes: f00708c2aa53 ("node: add IPv4 rewrite and lookup control") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_node/rte_node_ip4_api.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_no

[dpdk-dev] [PATCH v2 15/19] app: fix extra include paths for app builds

2021-01-15 Thread Bruce Richardson
The "includes" variable in the app/meson.build file was ignored when building the executable, meaning that apps couldn't pass additional include paths directly back. Fix this to align with drivers and libs. Fixes: fa036e70d794 ("app: generalize meson build") Cc: sta...@dpdk.org Signed-off-by: Bru

[dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

2021-01-15 Thread Bruce Richardson
To verify that all DPDK headers are ok for inclusion directly in a C file, and are not missing any other pre-requisite headers, we can auto-generate for each header an empty C file that includes that header. Compiling these files will throw errors if any header has unmet dependencies. The list of

[dpdk-dev] [PATCH v2 17/19] eal: add missing include to mcslock

2021-01-15 Thread Bruce Richardson
Include 'rte_branch_prediction.h' to get the likely/unlikely macro definitions. Fixes: 2173fb61 ("mcslock: add MCS queued lock implementation") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_eal/include/generic/rte_mcslock.h | 1 + 1 file changed, 1 insertion(+) diff --

[dpdk-dev] [PATCH v2 18/19] eal/x86: add architecture-specific headers to chkincs

2021-01-15 Thread Bruce Richardson
Ensure the architecture-specific header files for x86 have all necessary includes in them. Signed-off-by: Bruce Richardson --- lib/librte_eal/x86/include/meson.build | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/x86/include/meson.build b/lib/l

[dpdk-dev] [PATCH v2 19/19] test-meson-builds: add includes check to default x86 build

2021-01-15 Thread Bruce Richardson
Since the includes check is disabled by default, we need to explicitly enable it to have it run. To minimise any extra build time when running the test-meson-builds script, we just add it to the default x86 build. Signed-off-by: Bruce Richardson --- devtools/test-meson-builds.sh | 2 +- 1 file c

Re: [dpdk-dev] [PATCH 35/40] net/virtio: make server mode blocking

2021-01-15 Thread Maxime Coquelin
On 1/7/21 4:20 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

Re: [dpdk-dev] [PATCH v2] bus/dpaa: optimize device name parsing

2021-01-15 Thread Thomas Monjalon
09/11/2020 14:37, Gaetan Rivet: > Device name parsing is done on all buses during device iterations at > either EAL or ethdev levels. > > When a bus implements device name parsing slowly, all iterations are > impacted. Efficient implementation is important. > > The DPAA bus device name parsing ha

Re: [dpdk-dev] [PATCH] app/proc-info: fix security context info

2021-01-15 Thread Thomas Monjalon
24/12/2020 08:51, Hemant Agrawal: > static void > -show_security_context(uint16_t portid) > +show_security_context(uint16_t portid, uint8_t inline_offload) > { > - void *p_ctx = rte_eth_dev_get_sec_ctx(portid); > + void *p_ctx; > const struct rte_security_capability *s_cap; > > +

Re: [dpdk-dev] [PATCH v2 1/1] doc: fix figure numbering in graph guide

2021-01-15 Thread Thomas Monjalon
14/01/2021 14:42, Jerin Jacob: > On Wed, Jan 13, 2021 at 2:49 PM Thomas Monjalon wrote: > > > > Some figures had a title inside the picture but not in RST file. > > As a consequence, some versions of Sphinx are emitting a warning. > > > > Warning, treated as error: > > doc/guides/p

Re: [dpdk-dev] [PATCH v2 09/19] ipsec: fix missing header include

2021-01-15 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Friday, January 15, 2021 11:11 AM > To: dev@dpdk.org > Cc: david.march...@redhat.com; Richardson, Bruce > ; sta...@dpdk.org; Ananyev, Konstantin > ; Iremonger, Bernard > ; Medvedkin, Vladimir > ; Akhil Goyal > Subject: [PATCH v2

Re: [dpdk-dev] [PATCH v2 07/19] rib: fix missing header includes

2021-01-15 Thread Medvedkin, Vladimir
On 15/01/2021 11:10, Bruce Richardson wrote: The standard integer types, and the size_t types are missing their required header includes in the rib header file. Fixes: 5a5793a5ffa2 ("rib: add RIB library") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_rib/rte_rib.h |

Re: [dpdk-dev] [PATCH v2 09/19] ipsec: fix missing header include

2021-01-15 Thread Medvedkin, Vladimir
On 15/01/2021 11:10, Bruce Richardson wrote: The rte_ipsec_sad.h header used the standard uintXX_t types, but did not include stdint.h header for them. Fixes: 401633d9c112 ("ipsec: add inbound SAD API") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_ipsec/rte_ipsec_sad

Re: [dpdk-dev] [PATCH v2 10/19] fib: fix missing header includes

2021-01-15 Thread Medvedkin, Vladimir
On 15/01/2021 11:10, Bruce Richardson wrote: Add stdint.h to get definitions of standard integer types Fixes: 39e927248416 ("fib: add FIB library") Fixes: 40d41a8a7b34 ("fib: support IPv6") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_fib/rte_fib.h | 1 + lib/librt

Re: [dpdk-dev] [PATCH v2 09/19] ipsec: fix missing header include

2021-01-15 Thread Medvedkin, Vladimir
Hi Bruce, Just a one nit, please put before rte_ includes. On 15/01/2021 11:37, Medvedkin, Vladimir wrote: On 15/01/2021 11:10, Bruce Richardson wrote: The rte_ipsec_sad.h header used the standard uintXX_t types, but did not include stdint.h header for them. Fixes: 401633d9c112 ("ipsec: ad

Re: [dpdk-dev] [PATCH v2 09/19] ipsec: fix missing header include

2021-01-15 Thread Bruce Richardson
On Fri, Jan 15, 2021 at 11:45:11AM +, Medvedkin, Vladimir wrote: > Hi Bruce, > > Just a one nit, please put before rte_ includes. > Good point, I'll fix if I do a V3. > On 15/01/2021 11:37, Medvedkin, Vladimir wrote: > > > > > > On 15/01/2021 11:10, Bruce Richardson wrote: > > > The rte_

Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

2021-01-15 Thread Ferruh Yigit
On 1/15/2021 11:10 AM, Bruce Richardson wrote: To verify that all DPDK headers are ok for inclusion directly in a C file, and are not missing any other pre-requisite headers, we can auto-generate for each header an empty C file that includes that header. Compiling these files will throw errors if

Re: [dpdk-dev] [PATCH 39/40] net/virtio: move Vhost-kernel data to its backend

2021-01-15 Thread Maxime Coquelin
On 1/11/21 9:02 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subjec

Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

2021-01-15 Thread Bruce Richardson
On Fri, Jan 15, 2021 at 11:51:49AM +, Ferruh Yigit wrote: > On 1/15/2021 11:10 AM, Bruce Richardson wrote: > > To verify that all DPDK headers are ok for inclusion directly in a C > > file, and are not missing any other pre-requisite headers, we can > > auto-generate for each header an empty C

Re: [dpdk-dev] [PATCH 38/40] net/virtio: move Vhost-user specifics to its backend

2021-01-15 Thread Maxime Coquelin
On 1/7/21 7:32 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

Re: [dpdk-dev] [PATCH 40/40] net/virtio: move Vhost-vDPA data to its backend

2021-01-15 Thread Maxime Coquelin
On 1/7/21 7:50 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 5:14 AM >> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com; >> amore...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin >> Subject

[dpdk-dev] [PATCH] mem: improve parameter checking on memory hotplug

2021-01-15 Thread Anatoly Burakov
Currently, we don't check anything that comes in through memory hotplug subsystem using the IPC, because we always assume the data is correct. This is okay as anyone having access to the IPC socket would also have rights to crash the DPDK process through other means, but it's still a good practice

Re: [dpdk-dev] [PATCH v14 05/12] build: organize Arm config into dict

2021-01-15 Thread Juraj Linkeš
> -Original Message- > From: Ruifeng Wang > Sent: Friday, January 15, 2021 9:38 AM > To: Juraj Linkeš ; bruce.richard...@intel.com; > Honnappa Nagarahalli ; Phil Yang > ; vcchu...@amazon.com; Dharmik Thakkar > ; jerinjac...@gmail.com; > hemant.agra...@nxp.com; Ajit Khaparde (ajit.khapa..

Re: [dpdk-dev] [dpdk-dev v5 1/2] ethdev: add new tunnel type for eCPRI

2021-01-15 Thread Ferruh Yigit
On 1/15/2021 5:15 AM, Jeff Guo wrote: Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel type. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang Reviewed-by: Ferruh Yigit --- doc/guides/rel_notes/release_21_02.rst | 15 ++- lib/librte_ethdev/rte_ethdev.h | 1

Re: [dpdk-dev] [dpdk-dev v5 2/2] app/testpmd: add new UDP tunnel port for eCPRI

2021-01-15 Thread Ferruh Yigit
On 1/15/2021 5:15 AM, Jeff Guo wrote: Add new UDP tunnel port params for eCPRI configuration, the command as below: testpmd> port config 0 udp_tunnel_port add ecpri 6789 testpmd> port config 0 udp_tunnel_port rm ecpri 6789 Signed-off-by: Jeff Guo Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [dpdk-dev v5 0/2] add new UDP tunnel port configure for eCPRI

2021-01-15 Thread Ferruh Yigit
On 1/15/2021 5:15 AM, Jeff Guo wrote: Add new UDP tunnel port configure for eCPRI protocol features v5: fix a coding style issue. v4: add doc in release note for all related eCPRI features. v3: seperate the patch set and add some document Jeff Guo (2): ethdev: add new tunnel type for eCPRI

[dpdk-dev] [PATCH v1] power: vm power manager should respect core mask

2021-01-15 Thread David Hunt
when vm_power_manager is started, it takes over power management on all cores. This should be limited to cores defined in the core mask. When initialising, if a core is not on the coremask, skip it. Applies to both initialisation and exit. Signed-off-by: David Hunt --- examples/vm_power_manager

Re: [dpdk-dev] [PATCH v2 17/19] eal: add missing include to mcslock

2021-01-15 Thread Honnappa Nagarahalli
> > Include 'rte_branch_prediction.h' to get the likely/unlikely macro > definitions. > > Fixes: 2173fb61 ("mcslock: add MCS queued lock implementation") > Cc: sta...@dpdk.org > > Signed-off-by: Bruce Richardson Reviewed-by: Honnappa Nagarahalli > --- > lib/librte_eal/include/generic

[dpdk-dev] [PATCH v15 00/12] Arm build options rework

2021-01-15 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds

[dpdk-dev] [PATCH v15 01/12] build: rename Arm build variables

2021-01-15 Thread Juraj Linkeš
Rename Arm build variables and values so that they better conform to Arm specifications. Also rename generically sounding variable to names that better capture what the variables hold. Rename machine_args_generic to part_number_config_arm since the variable contains more than just the generic mach

[dpdk-dev] [PATCH v15 02/12] build: remove unused or superfluous variables

2021-01-15 Thread Juraj Linkeš
Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/c

[dpdk-dev] [PATCH v15 03/12] build: reformat and move Arm config and comments

2021-01-15 Thread Juraj Linkeš
Change formatting so that it's more consistent and readable, add/modify comments/stdout messages, move configuration options to more appropriate places and make the order consistent according to these rules: 1. First list generic configuration options, then list options that may be overwritten.

[dpdk-dev] [PATCH v15 04/12] build: simplify how Arm flags are processed

2021-01-15 Thread Juraj Linkeš
Set flags in one loop. Append flags to a list and use the list in the loop. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/meson.build | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/config/arm/meson.build

[dpdk-dev] [PATCH v15 06/12] build: isolate configuration for Arm generic build

2021-01-15 Thread Juraj Linkeš
Use generic configuration for the only build where it makes sense - the generic build. For other builds, if we don't know either of implementer ID or part number, the build is not supported. Add part numbers to cross files where fallback to generic configuration is assumed. Signed-off-by: Juraj Li

[dpdk-dev] [PATCH v15 05/12] build: organize Arm config into dict

2021-01-15 Thread Juraj Linkeš
Use dictionary lookup instead of checking for existing variables, iterating over all elements in the list or checking lists for optional configuration. Move variable contents into the dictionary for variables that would be referenced only once. Fallback to generic part number if the discovered part

[dpdk-dev] [PATCH v15 07/12] build: use native machine args in Arm native build

2021-01-15 Thread Juraj Linkeš
Letting the compiler decide is going to yield the best results for native builds, so use native machine args usable for both GCC and Clang. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang --- config/arm/meson.build | 54 ++ 1 file changed, 28 insert

[dpdk-dev] [PATCH v15 08/12] build: add core and NUMA counts to cross files

2021-01-15 Thread Juraj Linkeš
Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values to Arm config. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc

[dpdk-dev] [PATCH v15 09/12] build: disable drivers in Arm builds

2021-01-15 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works and remove unneeded driver options ported from the old makefile system, since they don't work

[dpdk-dev] [PATCH v15 11/12] build: add Arm SoC meson option

2021-01-15 Thread Juraj Linkeš
Add Arm SoC configuration to Arm meson.build and add a meson option to enable those options for native builds. This is preferable to specifying a cross file when doing aarch64 -> aarch64 builds, since the cross file specifies the toolchain as well. Signed-off-by: Juraj Linkeš Reviewed-by: Honnapp

[dpdk-dev] [PATCH v15 12/12] config: fix Arm implementer and its SoCs

2021-01-15 Thread Juraj Linkeš
Fix the implementer and part number of DPAA and ARMADA SoCs. The current values of 16 cores and 1 NUMA node don't cover all SoCs from the Arm implementer, e.g. Taishan 2280 has 64 cores and 4 NUMA nodes. Increase these to 64 and 4 to widen the coverage. Add configuration to SoC options where smalle

[dpdk-dev] [PATCH v15 10/12] build: disable libnuma in cross builds

2021-01-15 Thread Juraj Linkeš
Some Arm SoCs are not NUMA systems. Add the capability to disable NUMA for cross build and disable NUMA in Arm cross files. Signed-off-by: Juraj Linkeš Reviewed-by: Honnappa Nagarahalli --- config/arm/arm64_armada_linux_gcc | 1 + config/arm/arm64_bluefield_linux_gcc | 1

Re: [dpdk-dev] [PATCH v3 1/3] net/i40e: remove devarg use-latest-supported-vec

2021-01-15 Thread Ferruh Yigit
On 1/14/2021 6:39 AM, Leyi Rong wrote: As eal parameter --force-max-simd-bitwidth is already introduced, to make it more clear when setting rx/tx function, remove devarg use-latest-supported-vec support. Signed-off-by: Leyi Rong Acked-by: Wenzhuo Lu <...> -static eth_rx_burst_t -i40e_get_r

[dpdk-dev] [PATCH 0/3] net build fixes

2021-01-15 Thread David Marchand
Some fixes following make support removal. The first patch is a real fix. The other two are cleanups so I did not mark them for backport. -- David Marchand David Marchand (3): net/hinic: restore vectorised code net/i40e: remove vector config net/fm10k: remove vector config drivers/net/fm

[dpdk-dev] [PATCH 2/3] net/i40e: remove vector config

2021-01-15 Thread David Marchand
This config item is not exposed anymore now that we removed make support. Note: all architectures provide vectorised functions. Signed-off-by: David Marchand --- drivers/net/i40e/i40e_rxtx.c | 52 drivers/net/i40e/meson.build | 3 --- 2 files changed, 55 del

[dpdk-dev] [PATCH 1/3] net/hinic: restore vectorised code

2021-01-15 Thread David Marchand
Following make support removal, the vectorised code is not built anymore, fix the build flag check. Fixes: 3cc6ecfdfe85 ("build: remove makefiles") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/hinic/hinic_pmd_rx.c | 6 +++--- drivers/net/hinic/hinic_pmd_tx.c | 10 +

[dpdk-dev] [PATCH 3/3] net/fm10k: remove vector config

2021-01-15 Thread David Marchand
This config item is not exposed anymore now that we removed make support. Signed-off-by: David Marchand --- drivers/net/fm10k/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/fm10k/meson.build b/drivers/net/fm10k/meson.build index fa264f489f..299b9ffb58 100644 --- a/dri

Re: [dpdk-dev] [PATCH v3] pci/windows: fix build with SDK >= 10.0.20253

2021-01-15 Thread Thomas Monjalon
14/01/2021 23:06, Dmitry Kozlyuk: > On Thu, 14 Jan 2021 13:22:35 -0800, Tyler Retzlaff wrote: > > NetUIO device class and interface GUIDs are defined in system > > headers starting from platform SDK v10.0.20253. Inspect SDK > > version to avoid redefinition. > > > > Pre-release SDKs do not promise

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC array

2021-01-15 Thread Ferruh Yigit
On 12/23/2020 6:07 AM, Li, Xiaoyun wrote: -Original Message- From: stable On Behalf Of Rahul Lakkireddy Sent: Monday, December 21, 2020 06:47 To: dev@dpdk.org Cc: kaara.sat...@chelsio.com; sta...@dpdk.org Subject: [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC array

Re: [dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions

2021-01-15 Thread Thomas Monjalon
12/01/2021 00:49, Dmitry Kozlyuk: > On Mon, 11 Jan 2021 15:16:36 -0800, Tyler Retzlaff wrote: > > From: Tyler Retzlaff > > > > build rte_reciprocal.c and export the following functions on windows > > * rte_reciprocal_value > > * rte_reciprocal_value_u64 > > > > Signed-off-by: Tyler Retzlaff

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-15 Thread David Marchand
On Wed, Jan 13, 2021 at 2:28 PM Olivier Matz wrote: > > m->nb_seg must be reset on mbuf free whatever the value of m->next, > because it can happen that m->nb_seg is != 1. For instance in this > case: > > m1 = rte_pktmbuf_alloc(mp); > rte_pktmbuf_append(m1, 500); > m2 = rte_pktmbuf_alloc(mp)

Re: [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow action

2021-01-15 Thread Jerin Jacob
On Thu, Jan 14, 2021 at 8:32 PM Ori Kam wrote: > > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, January 14, 2021 4:00 PM > > Subject: Re: [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow > > action > > > > On Fri, Jan 8, 2021 at 12:02 PM Alexande

Re: [dpdk-dev] [PATCH V16 1/3] ethdev: introduce FEC API

2021-01-15 Thread Ferruh Yigit
On 10/8/2020 11:02 AM, Min Hu (Connor) wrote: This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengc

Re: [dpdk-dev] [PATCH v2 16/19] app/chkincs: add chkincs app to verify headers

2021-01-15 Thread Thomas Monjalon
15/01/2021 12:59, Bruce Richardson: > On Fri, Jan 15, 2021 at 11:51:49AM +, Ferruh Yigit wrote: > > On 1/15/2021 11:10 AM, Bruce Richardson wrote: > > > To verify that all DPDK headers are ok for inclusion directly in a C > > > file, and are not missing any other pre-requisite headers, we can >

  1   2   >