On 1/6/21 10:58 AM, David Marchand wrote: > On Sun, Dec 20, 2020 at 10:15 PM Maxime Coquelin > <maxime.coque...@redhat.com> wrote: >> >> This patch improves the virtio_hw struct packing, >> going from 88 down to 80 bytes with a 6 bytes hole in >> the end of the first cacheline. Fields only used in the >> slow path are placed in the end, so that hot path only >> uses the first cacheline. > > This also changes some boolean fields to uint8_t but we still assign > the true/false values to them (in some cases). > This works, but I would align those fields' assignments to this type change. > Fixed, note it was already inconsistent for some. Thanks, Maxime
- Re: [dpdk-dev] [PATCH 11/40] net/virtio: validate... Maxime Coquelin
- [dpdk-dev] [PATCH 12/40] net/virtio: remove bus type enum Maxime Coquelin
- Re: [dpdk-dev] [PATCH 12/40] net/virtio: remove bus t... Xia, Chenbo
- Re: [dpdk-dev] [PATCH 12/40] net/virtio: remove bus t... David Marchand
- [dpdk-dev] [PATCH 13/40] net/virtio: move PCI-specific fie... Maxime Coquelin
- Re: [dpdk-dev] [PATCH 13/40] net/virtio: move PCI-spe... Xia, Chenbo
- Re: [dpdk-dev] [PATCH 13/40] net/virtio: move PCI-spe... David Marchand
- [dpdk-dev] [PATCH 14/40] net/virtio: pack virtio HW struct Maxime Coquelin
- Re: [dpdk-dev] [PATCH 14/40] net/virtio: pack virtio ... Xia, Chenbo
- Re: [dpdk-dev] [PATCH 14/40] net/virtio: pack virtio ... David Marchand
- Re: [dpdk-dev] [PATCH 14/40] net/virtio: pack vir... Maxime Coquelin
- [dpdk-dev] [PATCH 15/40] net/virtio: move legacy IO to Vir... Maxime Coquelin
- Re: [dpdk-dev] [PATCH 15/40] net/virtio: move legacy ... Xia, Chenbo
- Re: [dpdk-dev] [PATCH 15/40] net/virtio: move legacy ... David Marchand
- [dpdk-dev] [PATCH 16/40] net/virtio: introduce generic vir... Maxime Coquelin
- Re: [dpdk-dev] [PATCH 16/40] net/virtio: introduce ge... Xia, Chenbo
- Re: [dpdk-dev] [PATCH 16/40] net/virtio: introduce ge... David Marchand
- Re: [dpdk-dev] [PATCH 16/40] net/virtio: introduc... Maxime Coquelin
- [dpdk-dev] [PATCH 17/40] net/virtio: move features definit... Maxime Coquelin
- Re: [dpdk-dev] [PATCH 17/40] net/virtio: move feature... Xia, Chenbo
- Re: [dpdk-dev] [PATCH 17/40] net/virtio: move fea... Maxime Coquelin