On Fri, Jan 15, 2021 at 11:45:11AM +0000, Medvedkin, Vladimir wrote: > Hi Bruce, > > Just a one nit, please put <stdint.h> before rte_ includes. >
Good point, I'll fix if I do a V3. > On 15/01/2021 11:37, Medvedkin, Vladimir wrote: > > > > > > On 15/01/2021 11:10, Bruce Richardson wrote: > > > The rte_ipsec_sad.h header used the standard uintXX_t types, but did not > > > include stdint.h header for them. > > > > > > Fixes: 401633d9c112 ("ipsec: add inbound SAD API") > > > Cc: sta...@dpdk.org > > > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > > --- > > > lib/librte_ipsec/rte_ipsec_sad.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/librte_ipsec/rte_ipsec_sad.h > > > b/lib/librte_ipsec/rte_ipsec_sad.h > > > index 3e67ab1e4b..66c703ff3a 100644 > > > --- a/lib/librte_ipsec/rte_ipsec_sad.h > > > +++ b/lib/librte_ipsec/rte_ipsec_sad.h > > > @@ -7,6 +7,7 @@ > > > #define _RTE_IPSEC_SAD_H_ > > > #include <rte_compat.h> > > > +#include <stdint.h> > > > /** > > > * @file rte_ipsec_sad.h > > > > > > > Acked-by: Vladimir Medvedkin <vladimir.medved...@intel.com> > > > > -- > Regards, > Vladimir