[dpdk-dev] [PATCH] common/mlx5: fix name for ConnectX VF device ID

2020-11-19 Thread Raslan Darawsheh
Starting ConnectX-6 Dx, the VF device ID is generic and not per chip. https://pci-ids.ucw.cz/v2.2/pci.ids 101e ConnectX Family mlx5Gen Virtual Function This means that all will have the same VF device ID. Fixes: 5fc66630bed5 ("net/mlx5: add ConnectX6-DX device ID") Cc: sta...@dpdk.org Signed-

Re: [dpdk-dev] [PATCH] common/mlx5: fix name for ConnectX VF device ID

2020-11-19 Thread Slava Ovsiienko
> -Original Message- > From: Raslan Darawsheh > Sent: Thursday, November 19, 2020 10:06 > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [PATCH] common/mlx5: fix name for ConnectX VF device ID > > Starting ConnectX-6 Dx, the VF device ID is generic and

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix sample and mirror use incorrect devices

2020-11-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, November 19, 2020 3:20 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: fix sample and mirror use incorrect devices > > The sample and mirror action objects are

Re: [dpdk-dev] [PATCH] net/mlx5: fix link state update

2020-11-19 Thread Matan Azrad
+@Asaf Penso From: Benoit Ganne > >> 2. To change documentation of ethdev API to say that only link status > >> is mandatory report. (all others "nice to have" or "best effort"): > >>This is for you - I suggest to send prior patch to ethdev > >>for this and let the community to decide. >

Re: [dpdk-dev] [PATCH] net/virtio: improve logs in Vhost-vDPA DMA mapping

2020-11-19 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, November 18, 2020 4:08 PM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH] net/virtio: improve logs in Vhost-vDPA DMA mapping > > This patch adds debug logs in vhost_

[dpdk-dev] [PATCH v2] event/octeontx2: unlink queues during port release

2020-11-19 Thread Shijith Thotton
Unlinking queues from port should be done during port release. Doing it during device re-configuration could result in segfault as ports array is re-allocated based on new number of ports. Fixes: f7ac8b66b23c ("event/octeontx2: support linking queues to ports") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v2] net/i40e: fix global register recovery

2020-11-19 Thread beilei . xing
From: Beilei Xing PMD configures the global register I40E_GLINT_CTL during device initialization to work around the Rx write back issue. But when a device is bound from DPDK to kernel, the global register is not recovered to the original state, it will cause kernel driver performance drop issue.

Re: [dpdk-dev] Question about recent change to rte_mbuf struct - user data and udata64 feels (breaks SPDK)

2020-11-19 Thread Thomas Monjalon
Hi, 19/11/2020 01:17, Luse, Paul E: > Hi, > > Recently this patch > https://github.com/DPDK/dpdk/commit/5284adad3e95025f9901869f581c8c04ea642d32 > made the following change: > > * mbuf: Removed the unioned fields ``userdata`` and ``udata64`` > from the structure ``rte_mbuf``. It is replaced

Re: [dpdk-dev] [PATCH v2 1/7] app/procinfo: fix redundant condition

2020-11-19 Thread Ferruh Yigit
On 11/18/2020 2:10 PM, David Marchand wrote: On Wed, Nov 18, 2020 at 12:46 PM Ferruh Yigit wrote: '_filters' is compared twice, second one will be always false, removing it using the message more relevant to the '_filters'. Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id")

Re: [dpdk-dev] [PATCH] common/mlx5: fix name for ConnectX VF device ID

2020-11-19 Thread Raslan Darawsheh
Hi Slava, thanks for your comments, > -Original Message- > From: Slava Ovsiienko > Sent: Thursday, November 19, 2020 10:13 AM > To: Raslan Darawsheh ; dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: RE: [PATCH] common/mlx5: fix name for ConnectX VF device ID > > > -Origin

[dpdk-dev] [PATCH] usertools: fix parsing error from dpdk-pmdinfo.py

2020-11-19 Thread Julien Massonneau
In the display_pmd_info_strings function, the script parses the section until to find a byte between 32 and 127, and get all data until a byte equals to 0. After, it searches "PMD_INFO_STRING" in the data and passes the whole string in the parse_pmd_info_string function, which split the string with

Re: [dpdk-dev] [dpdk-announce] release candidate 20.11-rc4

2020-11-19 Thread Yu, PingX
All, 20.11-rc4 test from Intel part is almost done. No new issue except below one. Issue: start testpmd failed with max-pkt-len param. It effected all of jumboframe feature. Ferruh has summitted a new patch to revert the bad commit id on rc5. Regards, Yu Ping > -Original Message- > Fr

[dpdk-dev] [PATCH v3 0/2] build: add Wformat to fix gcc compile warnings and format fixes

2020-11-19 Thread Conor Walsh
On some systems Wformat-nonliteral and Wformat-security could not be checked without Wformat also being specified this causes a compile warning on these systems. This patchset adds Wformat to config/meson.build and fixes some format issues that this exposed. --- v3: add sta...@dpdk.org to cc list

[dpdk-dev] [PATCH v3 1/2] build: fix gcc compile warnings by adding wformat

2020-11-19 Thread Conor Walsh
On some CentOS/RHEL systems using gcc 8.3.1 to compile dpdk, gcc shows a warning on every build step saying that -Wformat-nonliteral and -Wformat-security warnings will be ignored unless -Wformat is also specified as a compiler flag. When the build is run with -werror the build will fail due to the

[dpdk-dev] [PATCH v3 2/2] net/bnxt: fix format characters for unsigned values

2020-11-19 Thread Conor Walsh
&device requires the %u format specifer not the %d specifier, as &device is unsigned. Fixes: a46bbb57605b ("net/bnxt: update multi device design") Cc: michael.wi...@broadcom.com Signed-off-by: Conor Walsh --- drivers/net/bnxt/tf_core/tf_core.c | 8 1 file changed, 4 insertions(+), 4 de

Re: [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile warnings and format fixes

2020-11-19 Thread Walsh, Conor
Thank you for your feedback Luca, I pushed a v3 that now has stable cc'ed. /Conor > From: Luca Boccassi > Sent: Wednesday 18 November 2020 18:38 > To: Walsh, Conor ; Richardson, Bruce > ; ajit.khapa...@broadcom.com; > somnath.ko...@broadcom.com; stuart.schac...@broadcom.com; > venkatkumar.duvv...

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd packets dump overlapping

2020-11-19 Thread Ferruh Yigit
On 11/18/2020 6:09 PM, Jiawei(Jonny) Wang wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Sent: Tuesday, November 17, 2020 8:07 PM To: Jiawei(Jonny) Wang ; wenzhuo...@intel.com; beilei.x...@intel.com; bernard.iremon...@intel.com; Ori Kam ; NBU-Contact-Thomas Monjalon ; Raslan D

[dpdk-dev] [PATCH] doc: allow sphinx build with no DPDK version

2020-11-19 Thread Anatoly Burakov
Currently, when building sphinx documentation, the build will only succeed if being run from the build system, because the conf.py script expects DPDK_VERSION environment variable to be set, and crashes if it is not. However, there are certain external tools (such as sphinx documentation preview e

Re: [dpdk-dev] [PATCH] compress/isal: check allocation in qp setup

2020-11-19 Thread Daly, Lee
> From: wangyunjian > Sent: Monday, November 2, 2020 11:36 AM > To: dev@dpdk.org > Cc: Daly, Lee ; jerry.lili...@huawei.com; > xudin...@huawei.com; Yunjian Wang ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] compress/isal: check allocation in qp setup > > From: Yunjian Wang > > The function

Re: [dpdk-dev] [PATCH] net/mlx5: fix eCPRI item value with mask

2020-11-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, November 19, 2020 4:42 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix eCPRI item value with mask > > When creating a flow with eCPRI

[dpdk-dev] [PATCH v4 1/2] doc: clarify instructions on running as non-root

2020-11-19 Thread Anatoly Burakov
The current instructions are slightly out of date when it comes to providing information about setting up the system for using DPDK as non-root, so update them. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Reviewed-by: Ferruh Yigit Acked-by: Bruce Richardson --- Notes: v2: - Mov

[dpdk-dev] [PATCH v4 2/2] doc/linux_gsg: update information on using hugepages

2020-11-19 Thread Anatoly Burakov
Current information regarding hugepage usage is a little out of date. Update it to include information on in-memory mode, as well as on default mountpoints provided by systemd. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v3: - Clarified word

Re: [dpdk-dev] [PATCH] net/mlx5: fix restore info in non-tunnel traffic.

2020-11-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Wednesday, November 18, 2020 8:24 PM > To: Gregory Etelson > Cc: dev@dpdk.org; Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko ; Shahaf > Shuler > Subject: [PATCH] net/mlx5: fix restore info in non-tunnel traffic. > > Tunnel o

Re: [dpdk-dev] [PATCH] common/mlx5: fix name for ConnectX VF device ID

2020-11-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Thursday, November 19, 2020 10:06 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] common/mlx5: fix name for ConnectX VF > device ID > > Starting ConnectX

Re: [dpdk-dev] [PATCH v2 1/4] doc: move VFIO driver to be first

2020-11-19 Thread Burakov, Anatoly
On 18-Nov-20 6:24 PM, David Marchand wrote: On Wed, Nov 18, 2020 at 4:38 PM Anatoly Burakov wrote: Currently, the Linux GSG mentions UIO drivers first. This is not ideal as for the longest time, the recommended way to use DPDK with hardware devices has been to use VFIO driver. This commit sim

[dpdk-dev] [PATCH v2] app/testpmd: fix flow tunnel commands

2020-11-19 Thread Gregory Etelson
testpmd provides commands to test tunnel offload rte_flow capabilities. Testpmd tunnel commands allow to configure new ofloaded tunnel types, list existing offloaded tunnels and destroy existing offloaded tunnels. Tunnel offload commands allowed parameters repetition. For example, the following com

Re: [dpdk-dev] [ovs-dev] ovs-vswitchd with DPDK crashed when guest VM restarts network service

2020-11-19 Thread Stokes, Ian
> Hi, >We are seeing a ovs-vswitchd service crash with segfault in the > librte_vhost library when a DPDK application within a guest VM is stopped. > >We are using OVS 2.11.1 on CentOS 7.6 (3.10.0-1062 Linux > kernel) with > DPDK 18.11.2. Hi, Is there a reason yo

Re: [dpdk-dev] [PATCH] doc: allow sphinx build with no DPDK version

2020-11-19 Thread Bruce Richardson
On Thu, Nov 19, 2020 at 10:41:56AM +, Anatoly Burakov wrote: > Currently, when building sphinx documentation, the build will only > succeed if being run from the build system, because the conf.py script > expects DPDK_VERSION environment variable to be set, and crashes if it > is not. > > Howe

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for reading FW version

2020-11-19 Thread Sebastian, Selwin
[AMD Official Use Only - Internal Distribution Only] +Amar -Original Message- From: dev On Behalf Of selwin.sebast...@amd.com Sent: Thursday, November 19, 2020 12:56 PM To: dev@dpdk.org Subject: [dpdk-dev] [PATCH v1] net/axgbe: add support for reading FW version [CAUTION: External Email

[dpdk-dev] [PATCH v3 1/4] doc: move VFIO driver to be first

2020-11-19 Thread Anatoly Burakov
Currently, the Linux GSG mentions UIO drivers first. This is not ideal as for the longest time, the recommended way to use DPDK with hardware devices has been to use VFIO driver. This commit simply moves UIO section after VFIO, with minor edits. Signed-off-by: Anatoly Burakov --- doc/guides/lin

[dpdk-dev] [PATCH v3 2/4] doc: reword VFIO and UIO Linux GSG section

2020-11-19 Thread Anatoly Burakov
Make sure that we always prioritize VFIO over UIO. Also, minor wording corrections and improvements. Signed-off-by: Anatoly Burakov --- Notes: v3: - Rebase on top of rc4 - Add a label for instructions for running as non-root, and refer to it v2: - Fix formatting for VF t

[dpdk-dev] [PATCH v3 3/4] doc: add VFIO no-IOMMU Linux GSG section

2020-11-19 Thread Anatoly Burakov
Currently, we have no documentation on how to use VFIO in no-IOMMU mode. Add such documentation. Signed-off-by: Anatoly Burakov --- Notes: v2: - Fixed the noiommu parameter name doc/guides/linux_gsg/linux_drivers.rst | 28 +- 1 file changed, 27 insertions(+), 1

[dpdk-dev] [PATCH v3 4/4] doc: add VFIO troubleshooting section

2020-11-19 Thread Anatoly Burakov
There are common problems with VFIO that get asked over and over on the mailing list. Document common problems with VFIO and how to fix them or at least figure out what went wrong. Signed-off-by: Anatoly Burakov --- doc/guides/linux_gsg/linux_drivers.rst | 43 ++ 1 file c

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for reading FW version

2020-11-19 Thread Somalapuram, Amaranath
-Original Message- From: Sebastian, Selwin Sent: Thursday, November 19, 2020 4:56 PM To: Sebastian, Selwin ; dev@dpdk.org Cc: Somalapuram, Amaranath Subject: RE: [dpdk-dev] [PATCH v1] net/axgbe: add support for reading FW version [AMD Official Use Only - Internal Distribution Only] +

Re: [dpdk-dev] [PATCH] doc: allow sphinx build with no DPDK version

2020-11-19 Thread Burakov, Anatoly
On 19-Nov-20 11:24 AM, Bruce Richardson wrote: On Thu, Nov 19, 2020 at 10:41:56AM +, Anatoly Burakov wrote: Currently, when building sphinx documentation, the build will only succeed if being run from the build system, because the conf.py script expects DPDK_VERSION environment variable to b

Re: [dpdk-dev] [PATCH] doc: allow sphinx build with no DPDK version

2020-11-19 Thread Bruce Richardson
On Thu, Nov 19, 2020 at 11:44:06AM +, Burakov, Anatoly wrote: > On 19-Nov-20 11:24 AM, Bruce Richardson wrote: > > On Thu, Nov 19, 2020 at 10:41:56AM +, Anatoly Burakov wrote: > > > Currently, when building sphinx documentation, the build will only > > > succeed if being run from the build

[dpdk-dev] [v21.02 v3 00/10] cppcheck

2020-11-19 Thread Ferruh Yigit
Fix a few of issues identified by cppcheck. There are more to address, cppcheck can be run as: "cppcheck --enable=all --force ." These are very trivial issues, I think can be postponed to next release. Ferruh Yigit (10): app/procinfo: fix redundant condition app/procinfo: fix negative check o

[dpdk-dev] [v21.02 v3 01/10] app/procinfo: fix redundant condition

2020-11-19 Thread Ferruh Yigit
'_filters' is compared twice, second one will be always false, removing it using the message more relevant to the '_filters'. Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- app/proc-info/main.c | 4 +--- 1 file changed,

[dpdk-dev] [v21.02 v3 02/10] app/procinfo: fix negative check on unsigned variable

2020-11-19 Thread Ferruh Yigit
'parse_xstats_ids()' return 'int'. The return value is assigned to 'nb_xstats_ids' unsigned value, later negative check on this variable is wrong. Adding interim 'int' variable for negative check. Fixes: 7ac16a3660c0 ("app/proc-info: support xstats by ID and by name") Cc: sta...@dpdk.org Signed-

[dpdk-dev] [v21.02 v3 04/10] app/procinfo: remove useless assignment

2020-11-19 Thread Ferruh Yigit
'flag' is initialized to '0' but it is overwritten later, moving the declaration where it is used and initialize with actual value. Fixes: 0101a0ec6217 ("app/procinfo: add --show-mempool") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand --- app/proc-info/main.c | 4

[dpdk-dev] [v21.02 v3 03/10] app/procinfo: remove suspicious sizeof

2020-11-19 Thread Ferruh Yigit
The intention with the "sizeof(0)" usage is not clear, but the 'stats' already 'memset' by 'rte_cryptodev_stats_get()' API, removing 'memset' in application. Fixes: fe773600fe3e ("app/procinfo: add --show-crypto") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand ---

[dpdk-dev] [v21.02 v3 05/10] net/pcap: remove local variable shadowing outer one

2020-11-19 Thread Ferruh Yigit
'ret' is already defined in the function scope, removing the 'ret' in the block scope. Fixes: c9507cd0cada ("net/pcap: support physical interface MAC address") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- v3: * Eliminated block scope 'ret' variable usage completely. --- drivers/net/pcap/

[dpdk-dev] [v21.02 v3 06/10] net/bonding: remove local variable shadowing outer one

2020-11-19 Thread Ferruh Yigit
'retval' is already defined in the function scope, removing the 'retval' in the block scope. Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: tomaszx.kula...@intel.com --- drivers/net/bonding/rte_eth_bond_8023a

[dpdk-dev] [v21.02 v3 07/10] net/af_xdp: remove useless assignment

2020-11-19 Thread Ferruh Yigit
Assignment of function parameter 'umem' removed. Fixes: f0ce7af0e182 ("net/af_xdp: remove resources when port is closed") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand --- drivers/net/af_xdp/rte_eth_af_xdp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[dpdk-dev] [v21.02 v3 08/10] net/bnxt: fix redundant return

2020-11-19 Thread Ferruh Yigit
Removing useless 'return' statement. Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit Reviewed-by: David Marchand Acked-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_em_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/d

[dpdk-dev] [v21.02 v3 09/10] app/crypto-perf: remove always true condition

2020-11-19 Thread Ferruh Yigit
This is already 'else' leg of the opposite comparison, simple 'else' will be logically same. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- app/test-crypto-perf/main.c | 4 ++-- 1 file changed, 2 insertions(+),

[dpdk-dev] [v21.02 v3 10/10] net/avp: remove always true condition

2020-11-19 Thread Ferruh Yigit
There is already a break above for the case "count >= 1", so at this stage 'count' should be always '0'. Fixes: 1a85922369c4 ("net/avp: add device configuration") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- drivers/net/avp/avp_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [dpdk-dev] [PATCH] doc: allow sphinx build with no DPDK version

2020-11-19 Thread Burakov, Anatoly
On 19-Nov-20 11:48 AM, Bruce Richardson wrote: On Thu, Nov 19, 2020 at 11:44:06AM +, Burakov, Anatoly wrote: On 19-Nov-20 11:24 AM, Bruce Richardson wrote: On Thu, Nov 19, 2020 at 10:41:56AM +, Anatoly Burakov wrote: Currently, when building sphinx documentation, the build will only su

Re: [dpdk-dev] [ovs-dev] ovs-vswitchd with DPDK crashed when guest VM restarts network service

2020-11-19 Thread Kevin Traynor
On 19/11/2020 11:21, Stokes, Ian wrote: >> Hi, >>We are seeing a ovs-vswitchd service crash with segfault in >> the >> librte_vhost library when a DPDK application within a guest VM is stopped. >> >>We are using OVS 2.11.1 on CentOS 7.6 (3.10.0-1062 Linux >> kernel

Re: [dpdk-dev] [PATCH v3] usertools/devbind: fix binding for built-in kernel drivers

2020-11-19 Thread Burakov, Anatoly
On 19-Nov-20 7:16 AM, Yongxin Liu wrote: A driver can be loaded as a dynamic module or a built-in module. In commit 681a67288655 ("usertools: check if module is loaded before binding"), script only checks modules in /sys/module/. However, for built-in kernel driver, it only shows up in /sys/modu

Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection

2020-11-19 Thread Bruce Richardson
On Wed, Nov 18, 2020 at 03:23:13PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Thomas Monjalon > > Sent: Wednesday, November 18, 2020 3:43 PM > > To: Bruce Richardson ; Juraj Linkeš > > > > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > > phil.y...@arm.com

Re: [dpdk-dev] [PATCH] doc: allow sphinx build with no DPDK version

2020-11-19 Thread Bruce Richardson
On Thu, Nov 19, 2020 at 12:03:11PM +, Burakov, Anatoly wrote: > On 19-Nov-20 11:48 AM, Bruce Richardson wrote: > > On Thu, Nov 19, 2020 at 11:44:06AM +, Burakov, Anatoly wrote: > > > On 19-Nov-20 11:24 AM, Bruce Richardson wrote: > > > > On Thu, Nov 19, 2020 at 10:41:56AM +, Anatoly Bur

[dpdk-dev] [PATCH 1/2] event/octeontx2: remove selftest from dev args

2020-11-19 Thread pbhagavatula
From: Pavan Nikhilesh Since selftest now depends on dynamic mbuf fields it is not feasible to run selftest on device probe. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 8 drivers/event/octeontx2/otx2_evdev.h | 1 - 2 files changed, 9 deletions(-) diff --

[dpdk-dev] [PATCH 2/2] event/octeontx: remove selftest from dev args

2020-11-19 Thread pbhagavatula
From: Pavan Nikhilesh Since selftest now depends on dynamic mbuf fields it is not feasible to run selftest on device probe. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/ssovf_evdev.c | 22 -- drivers/event/octeontx/ssovf_evdev.h | 2 -- 2 files changed, 4 inse

Re: [dpdk-dev] [PATCH 1/2] event/octeontx2: remove selftest from dev args

2020-11-19 Thread David Marchand
On Thu, Nov 19, 2020 at 1:24 PM wrote: > > From: Pavan Nikhilesh > > Since selftest now depends on dynamic mbuf fields it is not > feasible to run selftest on device probe. Indeed, this is something that I missed with the seqn rework. Can't you call rte_event_dev_selftest() from within the pmd?

Re: [dpdk-dev] Windows: A fundamental issue (was eal/windows: definition for ETOOMANYREFS errno)

2020-11-19 Thread Tal Shnaiderman
> Subject: Re: Windows: A fundamental issue (was eal/windows: definition for > ETOOMANYREFS errno) > > External email: Use caution opening links or attachments > > > Hi Nick, > > > This means that rte_os.h should not include POSIX/Linux definitions to > > avoid clashes such as the one seen with

[dpdk-dev] [PATCH v1] net/axgbe: add support for device reset

2020-11-19 Thread selwin . sebastian
From: Selwin Sebastian Added support for device reset Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_ethdev.c | 75 1 file changed, 56 insertions(+), 19 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c

Re: [dpdk-dev] [EXT] Re: [PATCH 1/2] event/octeontx2: remove selftest from dev args

2020-11-19 Thread Pavan Nikhilesh Bhagavatula
>On Thu, Nov 19, 2020 at 1:24 PM wrote: >> >> From: Pavan Nikhilesh >> >> Since selftest now depends on dynamic mbuf fields it is not >> feasible to run selftest on device probe. > >Indeed, this is something that I missed with the seqn rework. >Can't you call rte_event_dev_selftest() from within

Re: [dpdk-dev] [EXT] Re: [PATCH 1/2] event/octeontx2: remove selftest from dev args

2020-11-19 Thread David Marchand
On Thu, Nov 19, 2020 at 2:31 PM Pavan Nikhilesh Bhagavatula wrote: > We can but generally selftest is run as a safety net before an > custom application runs but now since selftest uses dynamic > mbuf fields the custom application would be starved of that > field since there is no way to unregiste

Re: [dpdk-dev] [EXT] Re: [PATCH 1/2] event/octeontx2: remove selftest from dev args

2020-11-19 Thread Pavan Nikhilesh Bhagavatula
> >On Thu, Nov 19, 2020 at 2:31 PM Pavan Nikhilesh Bhagavatula > wrote: >> We can but generally selftest is run as a safety net before an >> custom application runs but now since selftest uses dynamic >> mbuf fields the custom application would be starved of that >> field since there is no way to u

[dpdk-dev] [PATCH v2 1/2] event/octeontx2: remove selftest from dev args

2020-11-19 Thread pbhagavatula
From: Pavan Nikhilesh Since selftest now depends on dynamic mbuf fields it is not feasible to run selftest on device probe. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - remove selftest from doc. doc/guides/eventdevs/octeontx2.rst | 9 - drivers/event/octeontx2/otx2_evdev.c | 8

[dpdk-dev] [PATCH v2 2/2] event/octeontx: remove selftest from dev args

2020-11-19 Thread pbhagavatula
From: Pavan Nikhilesh Since selftest now depends on dynamic mbuf fields it is not feasible to run selftest on device probe. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx.rst| 12 drivers/event/octeontx/ssovf_evdev.c | 22 -- drivers/event

Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection

2020-11-19 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Thursday, November 19, 2020 1:20 PM > To: Juraj Linkeš > Cc: Thomas Monjalon ; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com; phil.y...@arm.com; > vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com; > hemant.a

[dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd

2020-11-19 Thread Tal Shnaiderman
Linux epoll mechanism is not implemented in Windows. Add stub similarly to freeBSD. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/windows/eal_interrupts.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrup

Re: [dpdk-dev] [PATCH] doc: allow sphinx build with no DPDK version

2020-11-19 Thread Thomas Monjalon
19/11/2020 13:22, Bruce Richardson: > On Thu, Nov 19, 2020 at 12:03:11PM +, Burakov, Anatoly wrote: > > On 19-Nov-20 11:48 AM, Bruce Richardson wrote: > > > On Thu, Nov 19, 2020 at 11:44:06AM +, Burakov, Anatoly wrote: > > > > On 19-Nov-20 11:24 AM, Bruce Richardson wrote: > > > > > On Thu,

[dpdk-dev] [PATCH v2] net/mlx5: fix link state update

2020-11-19 Thread Raslan Darawsheh
From: Benoît Ganne mlx5 PMD refuses to update link state if link speed is defined but status is down or if link speed is undefined but status is up, even if the ioctl() succeeded. This prevents application to detect link up/down event, especially when the link speed is not correctly detected. As

[dpdk-dev] DPDK Release Status Meeting 19/11/2020

2020-11-19 Thread Ferruh Yigit
Meeting minutes of 19 November 2020 --- Agenda: * Release Dates * -rc4 status * Subtrees * LTS * OvS * Opens Participants: * Arm * Broadcom * Debian/Microsoft * Intel * Marvell * Nvidia * NXP * Red Hat Release Dates - * v20.11 dates * -rc4 is rele

Re: [dpdk-dev] Windows: A fundamental issue (was eal/windows: definition for ETOOMANYREFS errno)

2020-11-19 Thread Thomas Monjalon
19/11/2020 14:21, Tal Shnaiderman: > > Subject: Re: Windows: A fundamental issue (was eal/windows: definition for > > ETOOMANYREFS errno) > > > > External email: Use caution opening links or attachments > > > > > > Hi Nick, > > > > > This means that rte_os.h should not include POSIX/Linux defin

Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection

2020-11-19 Thread Bruce Richardson
On Thu, Nov 19, 2020 at 01:57:59PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Thursday, November 19, 2020 1:20 PM > > To: Juraj Linkeš > > Cc: Thomas Monjalon ; ruifeng.w...@arm.com; > > honnappa.nagaraha...@arm.com; phil.y...@arm.com; > >

[dpdk-dev] [PATCH] raw/ifpga/base: fix uninitialized variables gcc warning

2020-11-19 Thread Conor Walsh
On Ubuntu 18.04 using gcc 7.5, gcc sees size and start as possibly being uninitialized. This patch initialises size and start to correct this warning. Exact warning: ../drivers/raw/ifpga/base/opae_intel_max10.c:488:22: warning: ‘size’ may be used uninitialized in this function [-Wmaybe-uninitializ

Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd

2020-11-19 Thread David Marchand
On Thu, Nov 19, 2020 at 3:00 PM Tal Shnaiderman wrote: > > Linux epoll mechanism is not implemented in Windows. > > Add stub similarly to freeBSD. > > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/windows/eal_interrupts.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/lib

Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd

2020-11-19 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for > rte_intr_free_epoll_fd > > External email: Use caution opening links or attachments > > > On Thu, Nov 19, 2020 at 3:00 PM Tal Shnaiderman > wrote: > > > > Linux epoll mechanism is not implemented in Windows. > > > > Add stub similarl

[dpdk-dev] [PATCH v2] eal/windows: add stub for rte_intr_free_epoll_fd

2020-11-19 Thread Tal Shnaiderman
Linux epoll mechanism is not implemented in Windows. Add stub similarly to freeBSD. Signed-off-by: Tal Shnaiderman --- v2: add missing export in def file [DavidM] --- lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/windows/eal_interrupts.c | 6 ++ 2 files changed, 7 insertion

Re: [dpdk-dev] Windows: A fundamental issue (was eal/windows: definition for ETOOMANYREFS errno)

2020-11-19 Thread Tal Shnaiderman
> Subject: Re: Windows: A fundamental issue (was eal/windows: definition for > ETOOMANYREFS errno) > > External email: Use caution opening links or attachments > > > 19/11/2020 14:21, Tal Shnaiderman: > > > Subject: Re: Windows: A fundamental issue (was eal/windows: > > > definition for ETOOMANY

Re: [dpdk-dev] Windows: A fundamental issue (was eal/windows: definition for ETOOMANYREFS errno)

2020-11-19 Thread Nick Connolly
Thanks Tal. On 19/11/2020 15:27, Tal Shnaiderman wrote: Subject: Re: Windows: A fundamental issue (was eal/windows: definition for ETOOMANYREFS errno) External email: Use caution opening links or attachments 19/11/2020 14:21, Tal Shnaiderman: Subject: Re: Windows: A fundamental issue (was e

[dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS

2020-11-19 Thread Tal Shnaiderman
This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4. The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it. Fixes: c917b54b0c ("eal/windows: add definition of ETOOMANYREFS") Cc: sta...@dpdk.org Signed-off-by: Tal Shnaiderman --- lib

Re: [dpdk-dev] [PATCH] eal/windows: revert definition of ETOOMANYREFS

2020-11-19 Thread Nick Connolly
Reviewed-by: Nick Connolly On 19/11/2020 15:43, Tal Shnaiderman wrote: This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4. The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it. Fixes: c917b54b0c ("eal/windows: add definition of E

Re: [dpdk-dev] [PATCH 0/3] ASO age action fixes

2020-11-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Wednesday, November 18, 2020 11:00 AM > To: Slava Ovsiienko ; Shahaf Shuler > ; Matan Azrad > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 0/3] ASO age action fixes > > The age action using ASO was recently introduce

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update

2020-11-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Raslan Darawsheh > Sent: Thursday, November 19, 2020 4:20 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon > ; Benoît Ganne > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update > > Fro

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix flow tunnel commands

2020-11-19 Thread Ori Kam
Hi Gregory, > -Original Message- > From: Gregory Etelson > Sent: Thursday, November 19, 2020 1:10 PM > Subject: [PATCH v2] app/testpmd: fix flow tunnel commands > > testpmd provides commands to test tunnel offload rte_flow > capabilities. Testpmd tunnel commands allow to configure new of

Re: [dpdk-dev] [PATCH] doc: update the OS versions

2020-11-19 Thread Ferruh Yigit
On 11/17/2020 5:10 AM, Ajit Khaparde wrote: Update the OS versions. Remove some old OS versions. Signed-off-by: Ajit Khaparde --- doc/guides/nics/bnxt.rst | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/bnxt.rst b/doc/guides/nics/bnxt.rst index d9a

Re: [dpdk-dev] Question about recent change to rte_mbuf struct - user data and udata64 feels (breaks SPDK)

2020-11-19 Thread Luse, Paul E
Great, thanks for the quick response!! -Paul From: Thomas Monjalon Date: Thursday, November 19, 2020 at 2:30 AM To: Luse, Paul E Cc: dev@dpdk.org , olivier.m...@6wind.com Subject: Re: [dpdk-dev] Question about recent change to rte_mbuf struct - user data and udata64 feels (breaks SPDK) Hi, 1

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix flow tunnel commands

2020-11-19 Thread Ferruh Yigit
On 11/19/2020 4:50 PM, Ori Kam wrote: Hi Gregory, -Original Message- From: Gregory Etelson Sent: Thursday, November 19, 2020 1:10 PM Subject: [PATCH v2] app/testpmd: fix flow tunnel commands testpmd provides commands to test tunnel offload rte_flow capabilities. Testpmd tunnel command

Re: [dpdk-dev] [PATCH] net/iavf: fix SPDX license text

2020-11-19 Thread Ferruh Yigit
On 11/16/2020 9:30 AM, Ferruh Yigit wrote: On 11/16/2020 2:14 AM, Stephen Hemminger wrote: Obvious spelling error in SPDX license header. Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction") Cc: jia@intel.com Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit A

Re: [dpdk-dev] [PATCH] doc: update the OS versions

2020-11-19 Thread Ferruh Yigit
On 11/19/2020 5:36 PM, Ajit Khaparde wrote: On Thu, Nov 19, 2020 at 9:12 AM Ferruh Yigit wrote: On 11/17/2020 5:10 AM, Ajit Khaparde wrote: Update the OS versions. Remove some old OS versions. Signed-off-by: Ajit Khaparde --- doc/guides/nics/bnxt.rst | 8 +++- 1 file changed, 3 ins

[dpdk-dev] [Bug 580] [dpdk-20.11] testpmd: Ubuntu 16.04: Failed to start port as mlx5_pci can't allocate hash list.

2020-11-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=580 Bug ID: 580 Summary: [dpdk-20.11] testpmd: Ubuntu 16.04: Failed to start port as mlx5_pci can't allocate hash list. Product: DPDK Version: 20.11 Hardware: x86 OS: Li

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update

2020-11-19 Thread Ferruh Yigit
On 11/19/2020 2:20 PM, Raslan Darawsheh wrote: From: Benoît Ganne mlx5 PMD refuses to update link state if link speed is defined but status is down or if link speed is undefined but status is up, even if the ioctl() succeeded. This prevents application to detect link up/down event, especially w

[dpdk-dev] [PATCH] doc: update supported hardware offloads in mlx5

2020-11-19 Thread Asaf Penso
In DPDK 20.11 the following offload features are added: * Buffer Split * Sampling * Tunnel offload * 2-port hairpin * RSS shared action Update the relevant tables with OFED/rdma-core/NIC versions. Signed-off-by: Asaf Penso --- doc/guides/nics/mlx5.rst | 26 +- 1 file cha

Re: [dpdk-dev] DTS Test Nic Single Core Perf Scapy Naming Conflict

2020-11-19 Thread David Liu
Hi Lijuan, Thank you for the help. I can run DTS without that error now, Thanks, David On Tue, Nov 17, 2020 at 9:12 PM Tu, Lijuan wrote: > Hi David, > > > > Snice some protocols are only supported by scapy 2.4.4, it's recemented > that scapy 2.4.4 as major version for DTS. > > However perf use

Re: [dpdk-dev] [PATCH] net/i40e: fix counters

2020-11-19 Thread Igor Ryzhov
CC maintainers and Thomas. This fix should be 20.11. The issue is seen multiple times a day under ~20G traffic with stats collection once per second. Igor On Tue, Nov 17, 2020 at 11:56 AM Igor Ryzhov wrote: > When low and high registers are read separately, this opens the door to > a race cond

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update

2020-11-19 Thread Thomas Monjalon
19/11/2020 18:48, Ferruh Yigit: > On 11/19/2020 2:20 PM, Raslan Darawsheh wrote: > > From: Benoît Ganne > > > > mlx5 PMD refuses to update link state if link speed is defined but > > status is down or if link speed is undefined but status is up, even if > > the ioctl() succeeded. > > This prevent

Re: [dpdk-dev] [PATCH 2/3] doc: fix coremask option for eventdev pipeline

2020-11-19 Thread Thomas Monjalon
16/11/2020 11:06, David Marchand: > -w option in this context is an application option for coremask. > Restore it. > > Fixes: db27370b5720 ("eal: replace blacklist/whitelist options") > > Signed-off-by: David Marchand That's my mistake. Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH 3/3] bus/vdev: fix comment

2020-11-19 Thread Thomas Monjalon
16/11/2020 11:06, David Marchand: > RTE_DEV_WHITELISTED is now replaced with RTE_DEV_ALLOWED. > > Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums") > > Signed-off-by: David Marchand Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH 1/3] test/eal: remove unneeded command

2020-11-19 Thread Thomas Monjalon
16/11/2020 11:06, David Marchand: > All EAL flags tests are run by calling the "eal_flags_autotest" command. > There is no compatibility to maintain for sub commands only called by > meson. > > Fixes: db27370b5720 ("eal: replace blacklist/whitelist options") > > Signed-off-by: David Marchand Ac

Re: [dpdk-dev] [RFC] remove unused functions

2020-11-19 Thread Stephen Hemminger
On Thu, 19 Nov 2020 03:52:36 + Ferruh Yigit wrote: > drivers/net/netvsc/hn_rndis.c | 31 - > drivers/net/netvsc/hn_rndis.h |1 - > drivers/net/netvsc/hn_var.h |3 - > drivers/net/netvsc/hn_vf.c| 25 - Thanks t

[dpdk-dev] [PATCH] net/mlx5: make ethernet xstats names compliant

2020-11-19 Thread Viacheslav Ovsiienko
xstats names for simple stats are mostly standardized in ethdev drivers and should be compliant with [1] [1] http://doc.dpdk.org/guides/prog_guide/poll_mode_drv.html?highlight=xstats#extended-statistics-api Reported-by: Igor Ryzhov Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linu

[dpdk-dev] [PATCH] net/mlx5: make Tx scheduling xstats names compliant

2020-11-19 Thread Viacheslav Ovsiienko
xstats names for Tx packet scheduling should be compliant with [1] [1] http://doc.dpdk.org/guides/prog_guide/poll_mode_drv.html?highlight=xstats#extended-statistics-api Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_txpp.c | 16 1 file changed, 8 insertions(+),

Re: [dpdk-dev] DTS Test Nic Single Core Perf Scapy Naming Conflict

2020-11-19 Thread David Liu
Hi Lijuan, The DTS started without error but the nic single core test failed on a "connection timeout - no response from TRex server" when I tried to run it on an intel nic. This happens when DTS uses arm-dell (traffic generator) to send packets to arm-gigabyte (DUT) using the Intel nic {Ethernet

Re: [dpdk-dev] [PATCH v4 2/2] doc/linux_gsg: update information on using hugepages

2020-11-19 Thread David Marchand
On Thu, Nov 19, 2020 at 11:53 AM Anatoly Burakov wrote: > -Once the hugepage memory is reserved, to make the memory available for DPDK > use, perform the following steps:: > +If secondary process support is not required, DPDK is able to use hugepages > +without any configuration by using "in-memo

[dpdk-dev] Pausing failing tests

2020-11-19 Thread Lincoln Lavoie
Hello All, The CI group discussed an issue that has recently come up, where some tests are failing for a well known cause. The conclusion was, in cases where the failure is well known or a patch is already in process (i.e. in DPDK or a downstream project like SPDK), a DPDK maintainer can submit a

  1   2   >