Hi, > -----Original Message----- > From: Gregory Etelson <getel...@nvidia.com> > Sent: Wednesday, November 18, 2020 8:24 PM > To: Gregory Etelson <getel...@nvidia.com> > Cc: dev@dpdk.org; Matan Azrad <ma...@nvidia.com>; Raslan Darawsheh > <rasl...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com>; Shahaf > Shuler <shah...@nvidia.com> > Subject: [PATCH] net/mlx5: fix restore info in non-tunnel traffic. > > Tunnel offload API provides applications with ability to restore > packet outer headers after partial offload. Exact feature execution > depends on hardware abilities and PMD implementation. Hardware that is > supported by MLX5 PMD places a mark on a packet after partial offload. > PMD decodes that mark and provides application with required > information. > Application can call the restore API for packets that are part of > offloaded tunnel and not. It's up to a PMD to provide correct > information. > Current MLX5 tunnel offload implementation does not allow applications > to use flow MARK actions. It is restricted to tunnel offload use only. > This fault was triggered by application that did not activate tunnel > offload and called the restore API with a marked packet. The PMD tried > to decode the mark value and crashed. The patch decodes mark value > only if tunnel offload is active. > > Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") > > Signed-off-by: Gregory Etelson <getel...@nvidia.com> > Acked-by: Viacheslav Ovsiienko <viachesl...@nvidia.com> > --- > drivers/net/mlx5/mlx5_flow.c | 5 +++++ > 1 file changed, 5 insertions(+) > Patch applied to next-net-mlx,
Kindest regards, Raslan Darawsheh