[dpdk-dev] [PATCH v7 3/4] doc: update vhost sample doc for vhost async data path

2020-10-20 Thread Cheng Jiang
Add vhost async driver arguments information for vhost async data path in vhost sample application. Signed-off-by: Cheng Jiang --- doc/guides/sample_app_ug/vhost.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vh

[dpdk-dev] [PATCH v5 0/3] net/ice: support DCF ACL capabiltiy

2020-10-20 Thread Simei Su
[PATCH v5 1/3] change API from static to non-static. [PATCH v5 2/3] get PF VSI map for DCF ACL rule. [PATCH v5 3/3] support IPV4/IPV4_UDP/IPV4_TCP/IPV4_SCTP pattern and DROP action for DCF ACL. v5: * Change acl_rule structure location. * Correct error processing in ice_acl_prof_init

[dpdk-dev] [PATCH v5 1/3] net/ice/base: change API from static to non-static

2020-10-20 Thread Simei Su
This patch changes static API "ice_flow_assoc_prof" to non-static API in order to let it be used by other files. Signed-off-by: Simei Su --- drivers/net/ice/base/ice_flow.c | 2 +- drivers/net/ice/base/ice_flow.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH v5 3/3] net/ice: support ACL filter in DCF

2020-10-20 Thread Simei Su
Add ice_acl_create_filter to create a rule and ice_acl_destroy_filter to destroy a rule. If a flow is matched by ACL filter, filter rule will be set to HW. Currently IPV4/IPV4_UDP/IPV4_TCP/IPV4_SCTP pattern and drop action are supported. Signed-off-by: Simei Su Signed-off-by: Xuan Ding --- doc/

[dpdk-dev] [PATCH v5 2/3] net/ice: get PF VSI map

2020-10-20 Thread Simei Su
This patch gets PF vsi number when issuing ACL rule in DCF. Signed-off-by: Simei Su --- drivers/net/ice/ice_dcf.c| 1 + drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_parent.c | 37 +++-- 3 files changed, 37 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH v2] examples/tep_term: deprecate this example

2020-10-20 Thread Thomas Monjalon
20/10/2020 08:11, Xiaoyun Li: > This example sets up a scenario that VXLAN packets can be received > by different PF queues based on VNID and each queue is bound to a VM > with a VNID so that the VM can receive its inner packets. > > Usually, OVS is used to do the software encap/decap for VXLAN pa

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/windows: fix missing header inclusion

2020-10-20 Thread Thomas Monjalon
20/10/2020 11:37, Dmitry Kozlyuk: > On Tue, 20 Oct 2020 11:48:15 +0300, Tal Shnaiderman wrote: > > Following the addition of the in_addr/in6_addr structs > > to in.h the header file must have stdint.h included > > for the definitions of the uint8_t/uint32_t types used > > within the new structs. >

Re: [dpdk-dev] [PATCH] rte_metrics: move maximum number of metrics into rte_config

2020-10-20 Thread Thomas Monjalon
05/09/2020 00:31, Stephen Hemminger: > If using lots of queues and ports, and having per port or per queue > metrics it is easy to exceed the upper bound of the metric library. > Move the limit into rte_config where user can change it. > > Ideally, there would be no upper bound and a dynamic struc

Re: [dpdk-dev] [PATCH v4] eal: detach memsegs on cleanup

2020-10-20 Thread Thomas Monjalon
Stephen, ping. 15/10/2020 11:54, Burakov, Anatoly: > On 14-Sep-20 2:04 PM, Anatoly Burakov wrote: > > Currently, we don't detach the shared memory on EAL cleanup, which > > leaves the page table descriptors still holding on to the file > > descriptors as well as memory space occupied by them. Fix

Re: [dpdk-dev] [PATCH v3] mbuf: minor cleanup

2020-10-20 Thread Thomas Monjalon
Hi Morten, Any update about this patch please? 07/10/2020 11:16, Olivier Matz: > Hi Morten, > > Thanks for this cleanup. Please see some comments below. > > On Wed, Sep 16, 2020 at 12:40:13PM +0200, Morten Brørup wrote: > > The mbuf header files had some commenting style errors that affected the

Re: [dpdk-dev] [PATCH] librte_eal: fix mcslock hang on weak memory

2020-10-20 Thread Thomas Monjalon
Honnappa? 07/10/2020 11:55, Diogo Behrens: > Hi Thomas, > > we are still waiting for the comments from Honnappa. In our understanding, > the missing barrier is a bug according to the model. We reproduced the > scenario in herd7, which represents the authoritative memory model: > https://develo

Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/pci: remove unused scan by address

2020-10-20 Thread Thomas Monjalon
20/10/2020 11:10, David Marchand: > On Wed, Oct 14, 2020 at 10:20 PM Thomas Monjalon wrote: > > > > The function pci_update_device was used to scan a device > > for probing by PCI address. > > This private function (and implementations) are unused > > since such probing is removed. > > > > Fixes:

[dpdk-dev] [RFC] doc: announce max Rx packet len field deprecation

2020-10-20 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- Cc: Thomas Monjalon Cc: Andrew Rybchenko Cc: Konstantin Ananyev Cc: Matan Azrad Cc: Olivier Matz Cc: Jerin Jacob --- doc/guides/rel_notes/deprecation.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/doc/guides/rel_notes/depre

Re: [dpdk-dev] [PATCH v4 1/1] vfio: modify spapr iommu support to use static window sizing

2020-10-20 Thread Thomas Monjalon
Anatoly, please could you review this patch? 15/10/2020 19:23, David Christensen: > The SPAPR IOMMU requires that a DMA window size be defined before memory > can be mapped for DMA. Current code dynamically modifies the DMA window > size in response to every new memory allocation which is potentia

[dpdk-dev] [v3 0/2] support enqueue callbacks on cryptodev

2020-10-20 Thread Abhinandan Gujjar
In an eventdev world, multiple workers (with ordered queue) will be working on IPsec ESP processing. The ESP header's sequence number is unique and has to be sequentially incremented in an orderly manner. This rises a need for incrementing sequence number in crypto stage especially in event crypto

[dpdk-dev] [v3 2/2] test: add testcase for crypto enqueue callback

2020-10-20 Thread Abhinandan Gujjar
Signed-off-by: Abhinandan Gujjar --- app/test/test_cryptodev.c | 133 +- 1 file changed, 131 insertions(+), 2 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 1d4c46f..a083612 100644 --- a/app/test/test_cryptodev.c

[dpdk-dev] [v3 1/2] cryptodev: support enqueue callback functions

2020-10-20 Thread Abhinandan Gujjar
This patch adds APIs to add/remove callback functions. The callback function will be called for each burst of crypto ops received on a given crypto device queue pair. Signed-off-by: Abhinandan Gujjar --- config/rte_config.h| 1 + lib/librte_cryptodev/meson.build

[dpdk-dev] [PATCH] net/mlx5: fix IPv6 next proto validation

2020-10-20 Thread Dekel Peled
Previous patch added validation of the IPv6 next proto field, in order to overcome a known limitation. One of the values checked is IPPROTO_HOPOPTS, which is currently defined as value 0. The same value 0 is received when next proto field is not specified for matching, or has mask 0. This patch up

Re: [dpdk-dev] [PATCH] mbuf: allow dynamic flags to be used by secondary process

2020-10-20 Thread Olivier Matz
Hi Stephen, On Thu, Oct 15, 2020 at 10:20:19AM -0700, Stephen Hemminger wrote: > mbuf: allow dynamic flags to be used by secondary process Suggested title: mbuf: fix dynamic flags lookup from secondary process > > The dynamic flag management is broken for multi-process environment. > All calls t

[dpdk-dev] [Bug 561] EAL: secondary dpdk application fails to come up in 5.4.35 kernel due to memzone_init failure

2020-10-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=561 Bug ID: 561 Summary: EAL: secondary dpdk application fails to come up in 5.4.35 kernel due to memzone_init failure Product: DPDK Version: 18.11 Hardware: x86 OS: Lin

Re: [dpdk-dev] [PATCH v6 0/3] cleanup ethdev close operation

2020-10-20 Thread Bruce Richardson
On Fri, Oct 16, 2020 at 06:55:19PM +0100, Ferruh Yigit wrote: > On 10/16/2020 2:32 PM, Thomas Monjalon wrote: > > Most of the patches from the v3 have been merged already. The > > remaining 3 patches are reworked in v4: - reset dev_started in some > > PMDs - selectively reset pointers in rte_eth_d

Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default

2020-10-20 Thread Ferruh Yigit
On 10/20/2020 10:07 AM, Ananyev, Konstantin wrote: testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length will exceed 1518 that will cause packets dropped direc

Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability definition

2020-10-20 Thread Thomas Monjalon
20/10/2020 10:16, g...@marvell.com: > From: Guy Kaneti > > Add out of order scan capability to check PMD > support for OOS. > > Signed-off-by: Guy Kaneti > --- > --- a/lib/librte_regexdev/rte_regexdev.h > +++ b/lib/librte_regexdev/rte_regexdev.h > +#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1U

Re: [dpdk-dev] [PATCH v5 0/3] net/ice: support DCF ACL capabiltiy

2020-10-20 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Tuesday, October 20, 2020 7:33 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; Wang, Haiyue ; Xing, Beilei > ; Ding, Xuan ; Su, Simei > > Subject: [PATCH v5 0/3] net/ice: support DCF ACL capabiltiy > > [PATCH v5 1/3] change API f

Re: [dpdk-dev] [PATCH 4/8] eal: replace pci-whitelist/pci-blacklist options

2020-10-20 Thread Thomas Monjalon
Ping Stephen, Waiting a new version addressing these comments before resuming the review. Thanks 14/10/2020 18:07, David Marchand: > On Tue, Sep 22, 2020 at 4:33 PM Stephen Hemminger > wrote: > > > > Replace -w / --pci-whitelist with -a / --allow options > > and -b / --pci-blacklist with -b /

Re: [dpdk-dev] [RFC] rcu: build on Windows

2020-10-20 Thread Dharmik Thakkar
> On Oct 20, 2020, at 3:13 AM, David Marchand wrote: > > On Tue, Oct 20, 2020 at 1:34 AM Dharmik Thakkar > wrote: >> >> Build the lib for Windows. >> >> Change-Id: Ib83431a9ee56a7b38445f0474cb9a12b17cf18f9 >> Signed-off-by: Dharmik Thakkar >> --- >> lib/meson.build | 1 + >> 1 file changed

Re: [dpdk-dev] [RFC] rcu: build on Windows

2020-10-20 Thread Dharmik Thakkar
> On Oct 20, 2020, at 3:34 AM, Dmitry Kozlyuk wrote: > > On Tue, 20 Oct 2020 10:13:11 +0200, David Marchand wrote: >> On Tue, Oct 20, 2020 at 1:34 AM Dharmik Thakkar >> wrote: >>> >>> Build the lib for Windows. >>> >>> Change-Id: Ib83431a9ee56a7b38445f0474cb9a12b17cf18f9 >>> Signed-off-by:

[dpdk-dev] [PATCH] mailmap: add a mailmap file to DPDK

2020-10-20 Thread Bruce Richardson
Since a number of contributors to DPDK have submitted patches to DPDK under more than one email address, we should maintain a mailmap file to properly track their commits using "shortlog". It also helps fix up any mangled names, for example, with surname/firstname reversed, or with incorrect capita

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 3/3] eal: fix a wrong returned value when callback exists

2020-10-20 Thread David Marchand
On Fri, Jul 3, 2020 at 11:47 AM wangyunjian wrote: > > From: Yunjian Wang > > We should return an error value, when the callback is already exist. > > Fixes: a753e53d517b ("eal: add device event monitor framework") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang > --- > lib/librte_eal/com

[dpdk-dev] [PATCH V2 1/1] net/mlx5: fix IPv6 next proto validation

2020-10-20 Thread Eli Britstein
Previous patch added validation of the IPv6 next proto field, in order to overcome a known limitation. One of the values checked is IPPROTO_HOPOPTS, which is defined as 0. If proto field is not specified for matching, or mask=0, as in the following, a wrong validation takes place. flow create 0 ing

Re: [dpdk-dev] [PATCH] mailmap: add a mailmap file to DPDK

2020-10-20 Thread David Marchand
On Tue, Oct 20, 2020 at 3:07 PM Bruce Richardson wrote: > > Since a number of contributors to DPDK have submitted patches to DPDK under > more than one email address, we should maintain a mailmap file to properly > track their commits using "shortlog". It also helps fix up any mangled > names, for

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-20 Thread oulijun
在 2020/10/20 18:02, Ferruh Yigit 写道: On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigit On 10/15/2020 1:41 PM, Lijun Ou wr

Re: [dpdk-dev] [RFC] eal: introduce function to get lcore thread id

2020-10-20 Thread David Marchand
On Mon, Aug 10, 2020 at 11:37 AM Mattias Rönnblom wrote: > > Introduce function in to retrieve a lcore worker > thread's pthread id. > > This change allows applications to do things like changing the name of > a lcore thread, or detect if it's getting interrupted (e.g. getting > preempted by anot

Re: [dpdk-dev] [PATCH v2 1/1] librte_eal: rte_intr_callback_unregister_sync() - wrapper around rte_intr_callback_unregister().

2020-10-20 Thread David Marchand
On Thu, Oct 8, 2020 at 9:47 AM David Marchand wrote: > > On Mon, Aug 17, 2020 at 4:09 PM Renata Saiakhova > wrote: > > > > Avoid race with unregister interrupt hanlder if interrupt > > source has some active callbacks at the moment, use wrapper > > around rte_intr_callback_unregister() to check f

Re: [dpdk-dev] [dpdk-stable] [PATCH] EAL: Called remove() of drivers for vdev and pci buses

2020-10-20 Thread David Marchand
Hello, On Sat, Sep 12, 2020 at 9:53 PM Gaëtan Rivet wrote: > > On 08/07/20 17:03 +0500, Muhammad Bilal wrote: > > while using memif with app, the resources are not cleaned on exit, > > So an error occurred on running it second time. The cause of this problem > > is that remove() of memif driver i

Re: [dpdk-dev] [PATCH V2 1/1] net/mlx5: fix IPv6 next proto validation

2020-10-20 Thread Eli Britstein
++ On 10/20/2020 4:19 PM, Eli Britstein wrote: Previous patch added validation of the IPv6 next proto field, in order to overcome a known limitation. One of the values checked is IPPROTO_HOPOPTS, which is defined as 0. If proto field is not specified for matching, or mask=0, as in the following,

Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics

2020-10-20 Thread David Hunt
On 20/10/2020 8:35 AM, Thomas Monjalon wrote: 20/10/2020 04:49, Ruifeng Wang: From: Thomas Monjalon 15/10/2020 14:04, Anatoly Burakov: +/** + * This function is not supported on ARM. + */ +static inline void +rte_power_monitor(const volatile void *p, const uint64_t expected_value, +

Re: [dpdk-dev] [PATCH v2 03/22] event/dlb2: add private data structures and constants

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 03/22] event/dlb2: add private data structures and > constants > > The header f

Re: [dpdk-dev] [PATCH v2 10/22] event/dlb2: add queue setup

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 10/22] event/dlb2: add queue setup > > Load balanced (ldb) queues are setup here

Re: [dpdk-dev] [PATCH v2 12/22] event/dlb2: add port link

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 12/22] event/dlb2: add port link > > Add port link entry point. Directed queues

Re: [dpdk-dev] [PATCH v2 07/22] event/dlb2: add xstats

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 07/22] event/dlb2: add xstats > > Add support for DLB2 xstats. Perform initiali

Re: [dpdk-dev] [PATCH v2 09/22] event/dlb2: add queue and port default conf

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 09/22] event/dlb2: add queue and port default conf > > Add support for getting t

Re: [dpdk-dev] [PATCH v2 11/22] event/dlb2: add port setup

2020-10-20 Thread Eads, Gage
[...] > +static int > +dlb2_pf_ldb_port_create(struct dlb2_hw_dev *handle, > + struct dlb2_create_ldb_port_args *cfg, > + enum dlb2_cq_poll_modes poll_mode) > +{ > + struct dlb2_dev *dlb2_dev = (struct dlb2_dev *)handle->pf_dev; > + struct dlb2_cmd_r

Re: [dpdk-dev] [PATCH v2 17/22] event/dlb2: add eventdev stop and close

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 17/22] event/dlb2: add eventdev stop and close > > Add support for eventdev stop

Re: [dpdk-dev] [PATCH v2 08/22] event/dlb2: add infos get and configure

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 08/22] event/dlb2: add infos get and configure > > Add support for configuring t

Re: [dpdk-dev] [PATCH v2 14/22] event/dlb2: add eventdev start

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 14/22] event/dlb2: add eventdev start > > Add support for the eventdev start ent

Re: [dpdk-dev] [PATCH v2 20/22] event/dlb2: add queue and port release

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 20/22] event/dlb2: add queue and port release > > DLB does not support reconfigu

Re: [dpdk-dev] [PATCH v2 16/22] event/dlb2: add dequeue and its burst variants

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 16/22] event/dlb2: add dequeue and its burst variants > > Add support for dequeu

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-20 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Sunday, October 18, 2020 3:49 AM > To: McDaniel, Timothy > Cc: Richardson, Bruce ; Mcnamara, John > ; Kovacevic, Marko > ; Ray Kinsella ; Neil Horman > ; dpdk-dev ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren, > Harry ; Jerin Jacob ; > T

Re: [dpdk-dev] [PATCH v2 18/22] event/dlb2: add PMD's token pop public interface

2020-10-20 Thread Eads, Gage
> -Original Message- > From: McDaniel, Timothy > Sent: Saturday, October 17, 2020 1:21 PM > To: Mcnamara, John ; Kovacevic, Marko > ; Ray Kinsella ; Neil Horman > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > jer...@marvell.com > Subject: [PATCH v2 18/22]

Re: [dpdk-dev] [PATCH] eal: fix memory leak in uevent parse and process

2020-10-20 Thread David Marchand
On Sat, May 23, 2020 at 12:52 PM wangyunjian wrote: > > From: Yunjian Wang > > When the memory for uevent.devname is allocated in dev_uev_parse(). It > is not freed when parse the subsystem layer fails in dev_uev_parse(). > And Before return, it is also not freed in dev_uev_handler(). These > cau

Re: [dpdk-dev] [PATCH v2 02/22] event/dlb2: add dynamic logging

2020-10-20 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Sunday, October 18, 2020 3:57 AM > To: McDaniel, Timothy > Cc: dpdk-dev ; Carrillo, Erik G ; > Eads, Gage ; Van Haaren, Harry > ; Jerin Jacob > Subject: Re: [dpdk-dev] [PATCH v2 02/22] event/dlb2: add dynamic logging > > On Sat, Oct 17,

Re: [dpdk-dev] [PATCH] efd: fix tailq entry leak in error path

2020-10-20 Thread Thomas Monjalon
Byron, Yipeng, Please could you review? Thanks 29/09/2020 05:31, wangyunjian: > From: Yunjian Wang > > In rte_efd_create() allocated memory for tailq entry, we should > free it when error happens, otherwise it will lead to memory leak. > > Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor

Re: [dpdk-dev] [PATCH v2 05/22] event/dlb2: add inline functions

2020-10-20 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Sunday, October 18, 2020 4:00 AM > To: McDaniel, Timothy > Cc: dpdk-dev ; Carrillo, Erik G ; > Eads, Gage ; Van Haaren, Harry > ; Jerin Jacob > Subject: Re: [dpdk-dev] [PATCH v2 05/22] event/dlb2: add inline functions > > On Sat, Oct 17

Re: [dpdk-dev] [PATCH v3] eal: fix create user mem map repeatedly when it exists

2020-10-20 Thread Thomas Monjalon
16/10/2020 11:28, wangyunjian: > From: Yunjian Wang > > Currently, a issue that a container has many devices and the > application will map the same memory many times. The kernel > driver returns EEXIST as long as there are overlapping memory > areas. As a result, we repeatedly create new user me

Re: [dpdk-dev] [PATCH 06/22] event/dlb2: add probe

2020-10-20 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Sunday, October 18, 2020 4:06 AM > To: McDaniel, Timothy > Cc: Burakov, Anatoly ; dpdk-dev ; > Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > Jerin Jacob > Subject: Re: [dpdk-dev] [PATCH 06/22] event/dlb2: add probe > > On Sat,

Re: [dpdk-dev] [PATCH v2 18/22] event/dlb2: add PMD's token pop public interface

2020-10-20 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Sunday, October 18, 2020 4:14 AM > To: McDaniel, Timothy > Cc: Mcnamara, John ; Kovacevic, Marko > ; Ray Kinsella ; Neil Horman > ; dpdk-dev ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren, > Harry ; Jerin Jacob > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH v2 22/22] doc: add new DLB2 eventdev driver to relnotes

2020-10-20 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Sunday, October 18, 2020 4:23 AM > To: McDaniel, Timothy > Cc: Thomas Monjalon ; Mcnamara, John > ; Kovacevic, Marko > ; dpdk-dev ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren, > Harry ; Jerin Jacob > Subject: Re: [dpdk-dev] [PATCH v2 2

Re: [dpdk-dev] [PATCH 1/2] Fix build of apps with external dependencies

2020-10-20 Thread Thomas Monjalon
15/09/2020 10:38, Felix Moessbauer: > This fix initializes the dependency object with the external > dependency list. Previously, the external dependencies were > just ignored. > > Signed-off-by: Felix Moessbauer > --- > --- a/app/meson.build > +++ b/app/meson.build > if build > -

Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics

2020-10-20 Thread David Hunt
On 20/10/2020 3:01 PM, David Hunt wrote: On 20/10/2020 8:35 AM, Thomas Monjalon wrote: 20/10/2020 04:49, Ruifeng Wang: From: Thomas Monjalon 15/10/2020 14:04, Anatoly Burakov: +/** + * This function is not supported on ARM. + */ +static inline void +rte_power_monitor(const volatile void *

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-20 Thread Thomas Monjalon
19/10/2020 16:53, David Marchand: > On Fri, Oct 16, 2020 at 12:54 AM Honnappa Nagarahalli > wrote: > > > > IMO, this is not a performance critical path and it is not a difficult > > > > solution to > > > store these values in the application. My suggestion is to skip adding > > > the API > > > a

Re: [dpdk-dev] [EXT] Re: [PATCH v1] regexdev: add OOS capability definition

2020-10-20 Thread Guy Kaneti
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 20, 2020 3:37 PM > To: Guy Kaneti > Cc: or...@nvidia.com; dev@dpdk.org; Smadar Fuks > ; Dovrat Zifroni ; Jerin Jacob > Kollanukkaran > Subject: [EXT] Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability > definiti

Re: [dpdk-dev] [PATCH] mailmap: add a mailmap file to DPDK

2020-10-20 Thread Thomas Monjalon
20/10/2020 15:07, Bruce Richardson: > Since a number of contributors to DPDK have submitted patches to DPDK under > more than one email address, we should maintain a mailmap file to properly > track their commits using "shortlog". It also helps fix up any mangled > names, for example, with surname/

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 3/3] eal: fix a wrong returned value when callback exists

2020-10-20 Thread wangyunjian
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, October 20, 2020 9:19 PM > To: wangyunjian ; Jeff Guo > Cc: dev ; Lilijun (Jerry) ; xudingke > ; dpdk stable > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 3/3] eal: fix a wrong returned > v

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-20 Thread Medvedkin, Vladimir
Hi, On 20/10/2020 15:22, Thomas Monjalon wrote: 19/10/2020 16:53, David Marchand: On Fri, Oct 16, 2020 at 12:54 AM Honnappa Nagarahalli wrote: IMO, this is not a performance critical path and it is not a difficult solution to store these values in the application. My suggestion is to skip a

Re: [dpdk-dev] [PATCH 1/2] Fix build of apps with external dependencies

2020-10-20 Thread Bruce Richardson
On Tue, Oct 20, 2020 at 04:12:58PM +0200, Thomas Monjalon wrote: > 15/09/2020 10:38, Felix Moessbauer: > > This fix initializes the dependency object with the external > > dependency list. Previously, the external dependencies were > > just ignored. > > > > Signed-off-by: Felix Moessbauer > > ---

Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics

2020-10-20 Thread Thomas Monjalon
20/10/2020 16:17, David Hunt: > On 20/10/2020 3:01 PM, David Hunt wrote: > > On 20/10/2020 8:35 AM, Thomas Monjalon wrote: > >> 20/10/2020 04:49, Ruifeng Wang: > >>> From: Thomas Monjalon > 15/10/2020 14:04, Anatoly Burakov: > > +/** > > + * This function is not supported on ARM. > >>

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-20 Thread Ferruh Yigit
On 10/20/2020 2:35 PM, oulijun wrote: 在 2020/10/20 18:02, Ferruh Yigit 写道: On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigi

Re: [dpdk-dev] Building without AVX2 support, with Clang 11, on Ubuntu 20.04.1

2020-10-20 Thread Ivan Serdyuk
On Mon, Oct 19, 2020 at 4:34 PM Bruce Richardson wrote: > On Mon, Oct 19, 2020 at 04:17:36PM +0300, Ivan Serdyuk wrote: > Hi Ivan > Hello, Bruce. > Why are you exporting these CPP and CXX flags? The CXX flags will have no > effect on the DPDK build as it does not use c++ code. > Probably my m

Re: [dpdk-dev] [PATCH 14/14] ethdev: remove legacy filter API functions

2020-10-20 Thread Ferruh Yigit
On 10/18/2020 3:09 PM, Andrew Rybchenko wrote: The legacy filter API, including rte_eth_dev_filter_supported() and rte_eth_dev_filter_ctrl() is removed. Flow API should be used. examples/tep_termination build is broken. Signed-off-by: Andrew Rybchenko <...> --- a/lib/librte_ethdev/rte_eth_

Re: [dpdk-dev] [PATCH 4/8] eal: replace pci-whitelist/pci-blacklist options

2020-10-20 Thread Stephen Hemminger
On Tue, 20 Oct 2020 14:43:20 +0200 Thomas Monjalon wrote: > Ping Stephen, > > Waiting a new version addressing these comments > before resuming the review. > > Thanks > I wanted to get the master/slave set in first.

[dpdk-dev] [PATCH] net/thunderx: fix memory leak when allocate rbdr desc ring fails

2020-10-20 Thread wangyunjian
From: Yunjian Wang In nicvf_qset_rbdr_alloc(), we allocate memory for the 'rbdr' structure but not released when allocate 'rbdr desc ring' fails. Fixes: 7413feee662d ("net/thunderx: add device start/stop and close") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/thunderx/nicv

Re: [dpdk-dev] [PATCH] rte_metrics: move maximum number of metrics into rte_config

2020-10-20 Thread Stephen Hemminger
On Tue, 20 Oct 2020 13:50:55 +0200 Thomas Monjalon wrote: > 05/09/2020 00:31, Stephen Hemminger: > > If using lots of queues and ports, and having per port or per queue > > metrics it is easy to exceed the upper bound of the metric library. > > Move the limit into rte_config where user can change

Re: [dpdk-dev] [PATCH] mailmap: add a mailmap file to DPDK

2020-10-20 Thread Bruce Richardson
On Tue, Oct 20, 2020 at 04:29:18PM +0200, Thomas Monjalon wrote: > 20/10/2020 15:07, Bruce Richardson: > > Since a number of contributors to DPDK have submitted patches to DPDK under > > more than one email address, we should maintain a mailmap file to properly > > track their commits using "shortl

Re: [dpdk-dev] [PATCH] rte_metrics: move maximum number of metrics into rte_config

2020-10-20 Thread Thomas Monjalon
20/10/2020 17:02, Stephen Hemminger: > Thomas Monjalon wrote: > > 05/09/2020 00:31, Stephen Hemminger: > > > If using lots of queues and ports, and having per port or per queue > > > metrics it is easy to exceed the upper bound of the metric library. > > > Move the limit into rte_config where user

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-20 Thread McDaniel, Timothy
> -Original Message- > From: Bruce Richardson > Sent: Monday, October 19, 2020 3:34 AM > To: Jerin Jacob > Cc: McDaniel, Timothy ; Mcnamara, John > ; Kovacevic, Marko > ; Ray Kinsella ; Neil Horman > ; dpdk-dev ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren, > Harry ; Jerin Jacob ; > T

Re: [dpdk-dev] [PATCH] mailmap: add a mailmap file to DPDK

2020-10-20 Thread Thomas Monjalon
20/10/2020 17:03, Bruce Richardson: > On Tue, Oct 20, 2020 at 04:29:18PM +0200, Thomas Monjalon wrote: > > 20/10/2020 15:07, Bruce Richardson: > > > Since a number of contributors to DPDK have submitted patches to DPDK > > > under > > > more than one email address, we should maintain a mailmap fil

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-20 Thread Thomas Monjalon
20/10/2020 17:17, McDaniel, Timothy: > From: Bruce Richardson > > On Sun, Oct 18, 2020 at 02:18:32PM +0530, Jerin Jacob wrote: > > > On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel > > > wrote: > > > > > > > > Adds the meson build infrastructure, which includes > > > > compile-time constants in

[dpdk-dev] [PATCH v2 1/3] virtio-user: fix backend selection if stat fails

2020-10-20 Thread Adrian Moreno
If stat fails because the file does not exist, it means that the backend must be vhost-user in server mode. Also, log the detected backend type. Bugzilla ID: 559 Fixes: f908b22ea47a ("net/virtio: move backend type selection to ethdev") Cc: sta...@dpdk.org Signed-off-by: Adrian Moreno --- drive

[dpdk-dev] [PATCH v2 0/3] virtio-user: fix virtio-user server mode

2020-10-20 Thread Adrian Moreno
This series addresses some issues identified in the virtio-user driver when configured in server mode. Firstly, properly identify the backend type in this mode. Secondly, ensure no get/set status commands are sent before protocol feature negotiation to avoid sending them to a backend that does no

[dpdk-dev] [PATCH v2 2/3] virtio_user: don't set/get_status until FEATURES_OK

2020-10-20 Thread Adrian Moreno
According to the virtio spec, ACK and DRIVER status bits should be set before feature negotiation. However, until the protocol features are negotiated, the driver does not know if the device actually supports the those vhost-user messages. Therefore, until FEATURES_OK is set, the GET/SET_STATUS me

[dpdk-dev] [PATCH v2 3/3] virtio-user: set status on virtio-user reconnect

2020-10-20 Thread Adrian Moreno
Newer vhost-user backends will rely on SET_STATUS to start the device so this required to support them. Fixes: 57912824615f ("net/virtio-user: support vhost status setting") Cc: maxime.coque...@redhat.com Cc: sta...@dpdk.org Signed-off-by: Adrian Moreno --- drivers/net/virtio/virtio_user_ethdev

Re: [dpdk-dev] [PATCH v2 1/3] virtio-user: fix backend selection if stat fails

2020-10-20 Thread Maxime Coquelin
On 10/20/20 5:20 PM, Adrian Moreno wrote: > If stat fails because the file does not exist, it means that > the backend must be vhost-user in server mode. > > Also, log the detected backend type. > > Bugzilla ID: 559 > Fixes: f908b22ea47a ("net/virtio: move backend type selection to ethdev") >

Re: [dpdk-dev] [PATCH] mailmap: add a mailmap file to DPDK

2020-10-20 Thread Bruce Richardson
On Tue, Oct 20, 2020 at 05:17:58PM +0200, Thomas Monjalon wrote: > 20/10/2020 17:03, Bruce Richardson: > > On Tue, Oct 20, 2020 at 04:29:18PM +0200, Thomas Monjalon wrote: > > > 20/10/2020 15:07, Bruce Richardson: > > > > Since a number of contributors to DPDK have submitted patches to > > > > DPDK

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-20 Thread McDaniel, Timothy
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 20, 2020 10:21 AM > To: McDaniel, Timothy ; Eads, Gage > > Cc: Richardson, Bruce ; Jerin Jacob > ; Mcnamara, John ; > Kovacevic, Marko ; Ray Kinsella > ; Neil Horman ; dpdk-dev > ; Carrillo, Erik G ; Van Haaren, > H

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-20 Thread Bruce Richardson
On Tue, Oct 20, 2020 at 04:17:13PM +0100, McDaniel, Timothy wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Monday, October 19, 2020 3:34 AM > > To: Jerin Jacob > > Cc: McDaniel, Timothy ; Mcnamara, John > > ; Kovacevic, Marko > > ; Ray Kinsella ; Neil Horman > >

Re: [dpdk-dev] [PATCH] mailmap: add a mailmap file to DPDK

2020-10-20 Thread Thomas Monjalon
20/10/2020 17:32, Bruce Richardson: > On Tue, Oct 20, 2020 at 05:17:58PM +0200, Thomas Monjalon wrote: > > 20/10/2020 17:03, Bruce Richardson: > > > On Tue, Oct 20, 2020 at 04:29:18PM +0200, Thomas Monjalon wrote: > > > > 20/10/2020 15:07, Bruce Richardson: > > > > > Since a number of contributors

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-20 Thread Bruce Richardson
On Tue, Oct 20, 2020 at 04:33:42PM +0100, McDaniel, Timothy wrote: > > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, October 20, 2020 10:21 AM > > To: McDaniel, Timothy ; Eads, Gage > > > > Cc: Richardson, Bruce ; Jerin Jacob > > ; Mcnamara, John ; > > Kovacevic, M

Re: [dpdk-dev] [RFC] rcu: build on Windows

2020-10-20 Thread Honnappa Nagarahalli
> > > On Oct 20, 2020, at 3:34 AM, Dmitry Kozlyuk > wrote: > > > > On Tue, 20 Oct 2020 10:13:11 +0200, David Marchand wrote: > >> On Tue, Oct 20, 2020 at 1:34 AM Dharmik Thakkar > wrote: > >>> > >>> Build the lib for Windows. > >>> > >>> Change-Id: Ib83431a9ee56a7b38445f0474cb9a12b17cf18f9 > >>

Re: [dpdk-dev] [PATCH] mailmap: add a mailmap file to DPDK

2020-10-20 Thread Bruce Richardson
On Tue, Oct 20, 2020 at 05:38:43PM +0200, Thomas Monjalon wrote: > 20/10/2020 17:32, Bruce Richardson: > > On Tue, Oct 20, 2020 at 05:17:58PM +0200, Thomas Monjalon wrote: > > > 20/10/2020 17:03, Bruce Richardson: > > > > On Tue, Oct 20, 2020 at 04:29:18PM +0200, Thomas Monjalon wrote: > > > > > 20

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-20 Thread McDaniel, Timothy
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, October 20, 2020 10:35 AM > To: McDaniel, Timothy > Cc: Jerin Jacob ; Mcnamara, John > ; Kovacevic, Marko > ; Ray Kinsella ; Neil Horman > ; dpdk-dev ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren, > Harry ; Jerin Jacob ; >

Re: [dpdk-dev] [PATCH v2] net/softnic: fix out of bound access

2020-10-20 Thread Ferruh Yigit
On 10/19/2020 2:16 PM, Dumitrescu, Cristian wrote: -Original Message- From: Dharmappa, Savinay Sent: Monday, October 19, 2020 12:52 PM To: Dumitrescu, Cristian ; Singh, Jasvinder ; dev@dpdk.org Cc: Dharmappa, Savinay Subject: [PATCH v2] net/softnic: fix out of bound access This patc

Re: [dpdk-dev] Building without AVX2 support, with Clang 11, on Ubuntu 20.04.1

2020-10-20 Thread Ivan Serdyuk
It was compiled - but I can't make it run: ~/dpdk-20.08/build-clang/app$ ./dpdk-pdump > Illegal instruction (core dumped) > ~/dpdk-20.08/build-clang/app$ ./dpdk-proc-info > Illegal instruction (core dumped) > ~/dpdk-20.08/build-clang/app$ ./dpdk-test-acl > Illegal instruction (core dumped) > ~/dpd

Re: [dpdk-dev] [RFC] rcu: build on Windows

2020-10-20 Thread Dmitry Kozlyuk
On Tue, 20 Oct 2020 12:51:14 +, Dharmik Thakkar wrote: > I tried cross-compilation on Linux (Ubuntu 18.04) with MinGW-w64 toolchain, > but I am seeing some compilation error: > > ../lib/librte_eal/common/eal_common_dev.c: In function ‘rte_dev_probe’: > ../lib/librte_eal/common/eal_common_dev.

Re: [dpdk-dev] Building without AVX2 support, with Clang 11, on Ubuntu 20.04.1

2020-10-20 Thread Bruce Richardson
On Tue, Oct 20, 2020 at 06:49:10PM +0300, Ivan Serdyuk wrote: >It was compiled - but I can't make it run: > > ~/dpdk-20.08/build-clang/app$ ./dpdk-pdump > Illegal instruction (core dumped) > ~/dpdk-20.08/build-clang/app$ ./dpdk-proc-info > Illegal instruction (core dumped)

Re: [dpdk-dev] [PATCH v7 0/3] pmdinfogen: rewrite in Python

2020-10-20 Thread David Marchand
Hello Dmitry, On Wed, Oct 14, 2020 at 8:31 PM Dmitry Kozlyuk wrote: > > This patchset implements existing pmdinfogen logic in Python, replaces > and removes the old code. The goals of rewriting are: > > * easier maintenance by using a more high-level language, > * simpler build process without ho

Re: [dpdk-dev] [PATCH v3 0/7] BBDEV test updates

2020-10-20 Thread Chautru, Nicolas
Hi Akhil, Heads up on this one. Can you consider applying it for rc2 now? Thanks Nic > -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 6, 2020 11:38 PM > To: Chautru, Nicolas ; dev@dpdk.org; > t...@redhat.com > Cc: Richardson, Bruce > Subject: RE: [PATCH v3 0/7] BBDEV te

[dpdk-dev] [PATCH v5 1/4] rcu: build on Windows

2020-10-20 Thread Dharmik Thakkar
Build the lib for Windows. Signed-off-by: Dharmik Thakkar Tested-by: Dmitry Kozlyuk --- lib/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/meson.build b/lib/meson.build index dd55b5cb53e4..1bb019720c6a 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -41,6 +41,7 @@ if

[dpdk-dev] [PATCH v5 2/4] lib/hash: integrate RCU QSBR

2020-10-20 Thread Dharmik Thakkar
Currently, users have to use external RCU mechanisms to free resources when using lock free hash algorithm. Integrate RCU QSBR process to make it easier for the applications to use lock free algorithm. Refer to RCU documentation to understand various aspects of integrating RCU library into other l

[dpdk-dev] [PATCH v5 3/4] test/hash: replace rte atomic with C11 atomic APIs

2020-10-20 Thread Dharmik Thakkar
Replace rte_atomic APIs with C11 atomic APIs in test_hash_readwrite_lf_perf.c Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_hash_readwrite_lf_perf.c | 89 +++--- 1 file changed, 36 insertions(+), 53 deletions(-) diff --git a/app/test/test_hash_r

<    1   2   3   4   >