Re: [dpdk-dev] [PATCH 0/9] python2 deprecation notice

2020-07-15 Thread Robin Jarry
2020-07-13, Bruce Richardson: > In the absense of a "proper" solution, is the simplest option to > change the shebangs to all be python3, but leave the python2 > compatibility in place, and add the warnings for anyone running it > explicitly using python2? Personally, I am OK with this solution. H

[dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed

2020-07-15 Thread patrick . fu
From: Patrick Fu zmbufs should be set to NULL when getting freed to avoid double free on the same buffer pointer Fixes: b0a985d1f340 ("vhost: add dequeue zero copy") Signed-off-by: Patrick Fu --- lib/librte_vhost/vhost_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_vhos

Re: [dpdk-dev] [PATCH] app/testpmd: fix the default RSS key configuration

2020-07-15 Thread Phil Yang
> -Original Message- > From: dev On Behalf Of Lijun Ou > Sent: Thursday, July 9, 2020 9:48 PM > To: wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com; adrien.mazarg...@6wind.com; > ferruh.yi...@intel.com > Cc: dev@dpdk.org; linux...@huawei.com > Subject: [dpdk-dev]

[dpdk-dev] [PATCH 0/2] fix incorrect statistics data

2020-07-15 Thread Junyu Jiang
This patchset fixed the issue that rx_bytes and tx_bytes overflowed on 40 bit limitation by enlarging the limitation. Junyu Jiang (2): net/ice: fix incorrect Rx bytes statistics net/ice: fix incorrect Tx bytes statistics drivers/net/ice/ice_ethdev.c | 24 1 file chan

[dpdk-dev] [PATCH 2/2] net/ice: fix incorrect Tx bytes statistics

2020-07-15 Thread Junyu Jiang
This patch fixed the issue that tx_bytes overflowed on 40 bit limitation by enlarging the limitation. Fixes: a37bde56314d ("net/ice: support statistics") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang --- drivers/net/ice/ice_ethdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[dpdk-dev] [PATCH 1/2] net/ice: fix incorrect Rx bytes statistics

2020-07-15 Thread Junyu Jiang
This patch fixed the issue that rx_bytes overflowed on 40 bit limitation by enlarging the limitation. Fixes: a37bde56314d ("net/ice: support statistics") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang --- drivers/net/ice/ice_ethdev.c | 14 ++ 1 file changed, 14 insertions(+) diff -

[dpdk-dev] [PATCH v3] net/i40e: fix modify the number of qps in VF

2020-07-15 Thread alvinx . zhang
From: Alvin Zhang If a VF request PF to allocate more number of queue pairs, the PF will free the queue pairs which have been allocated and reset the VF. So, VF should stop to work until all the process is done. This patch modify the process of the request queue pairs. To improve efficiency and e

[dpdk-dev] [PATCH] net/mlx5: fix pop VLAN with decap action validate

2020-07-15 Thread Dekel Peled
The combination of decap action followed by pop VLAN action is not fully validated in existing code. This patch updates the validation function of pop vlan action. Pop VLAN with preceding Decap requires inner header with VLAN. Pop VLAN without preceding Decap requires outer header with VLAN. Fixe

[dpdk-dev] [PATCH] net/mlx5: fix push VLAN action on hairpin queue

2020-07-15 Thread Dekel Peled
Push VLAN action is allowed on Tx only, same as encap action. Flow rules for hairpin queue are created on Rx, and split by PMD to Rx and Tx rules, according to the above limitation. In current implementation the encap action is split to Tx rule. This patch adds the same handling for push-vlan actio

[dpdk-dev] [PATCH v1] vhost: support async copy free segmentations

2020-07-15 Thread patrick . fu
From: Patrick Fu Vhost async enqueue assumes that all async copies should break at packet boundary. i.e. if a packet is splited into multiple copy segments, the async engine should always report copy completion when entire packet is finished. This patch removes the assumption. Fixes: cd6760da107

Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values

2020-07-15 Thread David Marchand
On Fri, Jul 10, 2020 at 6:17 PM Thomas Monjalon wrote: > The problem is that we have an API which is taking mmap flags as input. > "int additional_flags" is a parameter of the function, > and are supposed to be mmap flags. But it is not stated clearly. > When Windows will use this function, it won

Re: [dpdk-dev] [dpdk-announce] release candidate 20.08-rc1

2020-07-15 Thread Pei Zhang
Hello all, Testing with dpdk 20.08-rc1 from Red Hat looks good. We cover below 16 scenarios and and all get PASS on RHEL8 testing: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Gue

[dpdk-dev] [PATCH] net/i40e: fix missed i40e filter pctype

2020-07-15 Thread Shougang Wang
The i40e_filter_pctype TCP_SYN_NO_ACK, UNICAST_IPV4_UDP and MULTICAST_IPV4_UDP for x722 are missed when translate RSS type to i40e_filter_pctype. This patche fix it. Fixes: da7018ec29d4 ("net/i40e: fix queue region in RSS flow") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/i

[dpdk-dev] [PATCH v2 0/9] add OCTEON TX2 lookaside IPsec support

2020-07-15 Thread Tejasree Kondoj
This series adds lookaside IPsec support in OCTEON TX2 PMD. Features supported: * IPv4 * ESP * Tunnel mode * AES-128/192/256-GCM v2: * Updated PMD documentation and release notes * Moved capabilities initialization into probe * Added patch description to all patches * Renamed few structures and m

[dpdk-dev] [PATCH v2 2/9] net/octeontx2: move otx2_sec_session struct to otx2_security.h

2020-07-15 Thread Tejasree Kondoj
This patch moves otx2_sec_session structure to otx2_security.h to make it common for inline and lookaside protocol. Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_security.h | 20 drivers/net/octeontx2/otx2_ethdev_sec.c| 1 + drivers/net/octeontx2/ot

[dpdk-dev] [PATCH v2 4/9] crypto/octeontx2: add cryptodev sec registration

2020-07-15 Thread Tejasree Kondoj
This patch registers security operations with cryptodev. Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/Makefile | 1 + drivers/crypto/octeontx2/meson.build | 3 +- drivers/crypto/octeontx2/otx2_cryptodev.c | 12 - driver

[dpdk-dev] [PATCH v2 1/9] crypto/octeontx2: move capabilities initialization into probe

2020-07-15 Thread Tejasree Kondoj
This patch moves capabilities initialization into probe. Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev.c | 2 ++ drivers/crypto/octeontx2/otx2_cryptodev_capabilities.c | 9 ++--- drivers/crypto/octeontx2/otx2_cryptodev_capabilities.h | 8 +++- dr

[dpdk-dev] [PATCH v2 3/9] crypto/octeontx2: add lookaside SA context definitions

2020-07-15 Thread Tejasree Kondoj
This patch adds lookaside IPsec SA context definitions. Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_sec.h | 58 + drivers/crypto/octeontx2/otx2_ipsec_po.h | 110 ++ drivers/crypto/octeontx2/otx2_security.

[dpdk-dev] [PATCH v2 5/9] crypto/octeontx2: add cryptodev sec capabilities

2020-07-15 Thread Tejasree Kondoj
This patch adds lookaside IPsec capabilities. Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev.c | 1 + .../octeontx2/otx2_cryptodev_capabilities.c | 101 ++ .../octeontx2/otx2_cryptodev_capabilities.h | 13 +++

[dpdk-dev] [PATCH v2 7/9] crypto/octeontx2: add cryptodev sec session create

2020-07-15 Thread Tejasree Kondoj
From: Vamsi Attunuru This patch creates session for lookaside IPsec. Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 468 +- drivers/crypto/octeontx2/otx2_ipsec_po.h | 295 +++ drivers/crypto/octeont

[dpdk-dev] [PATCH v2 9/9] crypto/octeontx2: add cryptodev sec dequeue routine

2020-07-15 Thread Tejasree Kondoj
From: Vamsi Attunuru This patch adds lookaside IPsec dequeue routine. Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/octeontx2.rst | 19 ++ doc/guides/rel_notes/release_20_08.rst| 5 +++ drivers/crypto/octeontx2/otx2_cryptodev

[dpdk-dev] [PATCH v2 6/9] crypto/octeontx2: add cryptodev sec misc callbacks

2020-07-15 Thread Tejasree Kondoj
From: Vamsi Attunuru This patch adds lookaside IPsec callback functions. Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 34 +-- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/octeo

[dpdk-dev] [PATCH v2 8/9] crypto/octeontx2: add cryptodev sec enqueue routine

2020-07-15 Thread Tejasree Kondoj
From: Vamsi Attunuru This patch adds lookaside IPsec enqueue routine. Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/octeontx2/otx2_cryptodev.h | 8 + drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 36 +++- drivers/crypto/octeontx2/otx2_ipsec_po.h

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-07-15 Thread Andrew Rybchenko
On 7/13/20 11:04 AM, Kinsella, Ray wrote: > > > On 08/07/2020 21:40, Andrey Vesnovaty wrote: >> From: Andrey Vesnovaty >> >> This commit introduces extension of DPDK flow action API enabling >> sharing of single rte_flow_action in multiple flows. The API intended for >> PMDs where multiple HW offl

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-07-15 Thread Andrew Rybchenko
I'm sorry for a duplicate of my message from July, 13. The problem is that I've not found my reply in patchwork and mail thread. Now I found out that I'm replying to Ray's mail and the mail is not in the thread since has invalid message headers. Andrew. On 7/15/20 11:54 AM, Andrew Rybchenko wrote

Re: [dpdk-dev] [PATCH] net/i40e: fix incorrect hash look up table

2020-07-15 Thread Chen, BoX C
Tested-by: zhang,xi Regards, Chen Bo > -Original Message- > From: dev On Behalf Of Shougang Wang > Sent: July 15, 2020 14:35 > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > ShougangX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix incorrect hash look up table >

Re: [dpdk-dev] [PATCH v6 0/8] fib: implement AVX512 vector lookup

2020-07-15 Thread Thomas Monjalon
14/07/2020 16:38, Stephen Hemminger: > "Kinsella, Ray" wrote: > > On 13/07/2020 23:19, Stephen Hemminger wrote: > > > Did anyone else see the recent AVX512 discussion from Linus: > > > "I hope AVX512 dies a painful death, and that Intel starts fixing real > > > problems > > >instead of try

Re: [dpdk-dev] [PATCH v4 2/2] mempool/ring: add support for new ring sync modes

2020-07-15 Thread Thomas Monjalon
14/07/2020 11:16, Ananyev, Konstantin: > > > > 13/07/2020 17:50, Konstantin Ananyev: > > > Two new sync modes were introduced into rte_ring: > > > relaxed tail sync (RTS) and head/tail sync (HTS). > > > This change provides user with ability to select these > > > modes for ring based mempool via m

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 00/10] rename blacklist/whitelist to block/allow

2020-07-15 Thread Thomas Monjalon
14/07/2020 07:33, Stephen Hemminger: > On Fri, 10 Jul 2020 17:06:11 +0200 > David Marchand wrote: > > > About deprecating existing API/EAL flags in this release, this should > > go through the standard deprecation process. > > I would go with introducing new options + full compatibility + a > > d

[dpdk-dev] Random failure in service_autotest

2020-07-15 Thread David Marchand
Hello Harry and guys who touched the service code recently :-) I spotted a failure for the service UT in Travis: https://travis-ci.com/github/ovsrobot/dpdk/jobs/361097992#L18697 I found only a single instance of this failure and tried to reproduce it with my usual "brute" active loop with no succ

Re: [dpdk-dev] [PATCH v3] net/i40e: fix modify the number of qps in VF

2020-07-15 Thread Jeff Guo
hi, alvin The processing of the queue pairs configure looks better than prior version, but still have some comment. On 7/15/2020 3:28 PM, alvinx.zh...@intel.com wrote: From: Alvin Zhang If a VF request PF to allocate more number of queue pairs, the PF will free the queue pairs which have be

Re: [dpdk-dev] Retrieving lcore worker thread id

2020-07-15 Thread Mattias Rönnblom
On 2020-07-14 22:51, Stephen Hemminger wrote: > On Tue, 14 Jul 2020 18:59:59 + > Honnappa Nagarahalli wrote: > >> >> Hi. >>> Hey, >>> In DPDK 19.11, the lcore_config struct of is made private, and with it the possibility to look up the thread id of the lcore worker th

[dpdk-dev] [PATCH v4] net/ice: fix invalid RSS type

2020-07-15 Thread Simei Su
When a RSS rule with only SRC/DST_ONLY or IPV6 prefix RSS type, it should return failure. Besides, when a RSS rule with symmetric hash function, the RSS type shouldn't carry with SRC/DST_ONLY. This patch adds invalid RSS type check for the two cases. Fixes: dfdc589f6ee0 ("net/ice: refactor PF hash

[dpdk-dev] [PATCH] app/testpmd: fix testpmd documentation typos

2020-07-15 Thread Viacheslav Ovsiienko
Fix minor typos. Fixes: 4940344dab1d ("app/testpmd: add Tx scheduling command") Signed-off-by: Viacheslav Ovsiienko --- app/test-pmd/cmdline.c | 2 +- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine

2020-07-15 Thread Phil Yang
> > -Original Message- > > From: dev On Behalf Of Lijun Ou > > Sent: Wednesday, July 1, 2020 3:43 PM > > To: wenzhuo...@intel.com; beilei.x...@intel.com; > > bernard.iremon...@intel.com; ferruh.yi...@intel.com > > Cc: dev@dpdk.org; linux...@huawei.com > > Subject: [dpdk-dev] [PATCH v2] a

Re: [dpdk-dev] [PATCH v6 0/8] fib: implement AVX512 vector lookup

2020-07-15 Thread Medvedkin, Vladimir
On 15/07/2020 10:47, Thomas Monjalon wrote: 14/07/2020 16:38, Stephen Hemminger: "Kinsella, Ray" wrote: On 13/07/2020 23:19, Stephen Hemminger wrote: Did anyone else see the recent AVX512 discussion from Linus: "I hope AVX512 dies a painful death, and that Intel starts fixing real prob

[dpdk-dev] [PATCH] net/mlx5: fix file path location of HW counters

2020-07-15 Thread Shy Shyman
When debugging performance of a DPDK application the user may need to view the different statistics of DPDK(for example out_of_buffer) This can be enabled by using testpmd command 'show port xstats ' for example. The current implementation assumes legacy mode in which the counters are at //hw_coun

Re: [dpdk-dev] Random failure in service_autotest

2020-07-15 Thread Ferruh Yigit
On 7/15/2020 11:14 AM, David Marchand wrote: > Hello Harry and guys who touched the service code recently :-) > > I spotted a failure for the service UT in Travis: > https://travis-ci.com/github/ovsrobot/dpdk/jobs/361097992#L18697 > > I found only a single instance of this failure and tried to re

[dpdk-dev] [PATCH] net/mlx5: fix file path location of HW counters

2020-07-15 Thread Shy Shyman
When debugging performance of a DPDK application the user may need to view the different statistics of DPDK(for example out_of_buffer) This can be enabled by using testpmd command 'show port xstats ' for example. The current implementation assumes legacy mode in which the counters are at //hw_coun

Re: [dpdk-dev] [PATCH] net/mlx5: fix file path location of HW counters

2020-07-15 Thread Slava Ovsiienko
> -Original Message- > From: Shy Shyman > Sent: Wednesday, July 15, 2020 13:51 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix file path location of HW counters > > When debugging performance of a DPDK application the user may need to > view the

[dpdk-dev] [PATCH V4 0/4] i40e FDIR update rate optimization

2020-07-15 Thread chenmin . sun
From: Chenmin Sun [PATCH v4 1/4] net/i40e: introducing the fdir guaranteed/shared space tracking [PATCH v4 2/4] net/i40e: FDIR flow memory management optimization [PATCH v4 2/4] net/i40e: move the i40e_get_outer_vlan to where it real needed [PATCH v4 2/4] net/i40e: FDIR update rate optimization

[dpdk-dev] [PATCH V4 3/4] net/i40e: move the i40e_get_outer_vlan to where it real needed

2020-07-15 Thread chenmin . sun
From: Chenmin Sun This patch moves the fetching the device tpid to where it really needs, rather than fetching it every time when entered the functions. This is because this operation costs too many cycles and it is used only when matching the ethernet header. Signed-off-by: Chenmin Sun --- dr

[dpdk-dev] [PATCH V4 1/4] net/i40e: introducing the fdir space tracking

2020-07-15 Thread chenmin . sun
From: Chenmin Sun This patch introduces a fdir flow management for guaranteed/shared space tracking. The fdir space is reported by the i40e_hw_capabilities.fd_filters_guaranteed and fd_filters_best_effort. The fdir space is managed by hardware and now is tracking in software. The management algor

[dpdk-dev] [PATCH V4 2/4] net/i40e: FDIR flow memory management optimization

2020-07-15 Thread chenmin . sun
From: Chenmin Sun This patch allocated some memory pool for flow management to avoid calling rte_zmalloc/rte_free every time. This patch also improves the hash table operation. When adding/removing a flow, the software will directly add/delete it from the hash table. If any error occurs, it then

[dpdk-dev] [PATCH V4 4/4] net/i40e: FDIR update rate optimization

2020-07-15 Thread chenmin . sun
From: Chenmin Sun This patch optimized the fdir update rate for i40e PF, by tracking whether the fdir rule being inserted into the guaranteed space or shared space. For the flows that are inserted to the guaranteed space, we assume that the insertion will always succeed as the hardware only repor

Re: [dpdk-dev] Fwd: Re: [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-07-15 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit & Chas Williams Any other comments? If there are not other comment, could we consider apply this patch? :-) Thanks, Xavier On 2020/5/18 19:12, Wei Hu (Xavier) wrote: On 2020/5/18 17:55, Ferruh Yigit wrote: On 5/16/2020 10:51 AM, Wei Hu (Xavier) wrote: On 2020/5/16 16

[dpdk-dev] [PATCH v2] vhost: support async copy free segmentations

2020-07-15 Thread patrick . fu
From: Patrick Fu Vhost async enqueue assumes that all async copies should break at packet boundary. i.e. if a packet is splited into multiple copy segments, the async engine should always report copy completion when entire packet is finished. This patch removes the assumption. Fixes: cd6760da107

Re: [dpdk-dev] [PATCH] lib: fix build for missing RCU library dependency

2020-07-15 Thread David Marchand
On Mon, Jul 13, 2020 at 3:51 PM Ferruh Yigit wrote: > > 'librte_rcu' is now dependency to 'librte_lpm' library, this dependency > should be reflected to build system. Good catch, thanks Ferruh. > Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation") > > Signed-off-by: Ferruh Yigit Review

Re: [dpdk-dev] [PATCH v3 2/2] raw/ifpga/base: fix NIOS SPI initial

2020-07-15 Thread Xu, Rosen
-Original Message- From: Zhang, Tianfei Sent: Wednesday, July 15, 2020 5:35 AM To: dev@dpdk.org; Xu, Rosen Cc: Zhang, Tianfei ; sta...@dpdk.org Subject: [PATCH v3 2/2] raw/ifpga/base: fix NIOS SPI initial From: Tianfei Zhang Add fecmode setting on NIOS SPI primary initialization. t

Re: [dpdk-dev] [PATCH v3 1/2] raw/ifpga/base: fix spi transaction issue

2020-07-15 Thread Xu, Rosen
-Original Message- From: Zhang, Tianfei Sent: Wednesday, July 15, 2020 5:35 AM To: dev@dpdk.org; Xu, Rosen Cc: Zhang, Tianfei ; sta...@dpdk.org Subject: [PATCH v3 1/2] raw/ifpga/base: fix spi transaction issue From: Tianfei Zhang 0x4a means idle status on physical layer. when encou

Re: [dpdk-dev] [PATCH v4 10/27] examples/qos_{meter/sched}: replace references to master lcore

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use initial lcore instead. Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [dpdk-stable] [PATCH] metrics: fix installation of metrics header

2020-07-15 Thread David Marchand
On Tue, Jul 14, 2020 at 2:43 PM Ciara Power wrote: > > If Jansson was found, the headers list is overwritten when including > rte_metrics_telemetry.h, which prevents rte_metrics.h from being > installed. This is now fixed to add to headers, rather than overwrite, > to allow both headers be install

Re: [dpdk-dev] [PATCH] app/testpmd: fix the default RSS key configuration

2020-07-15 Thread oulijun
在 2020/7/15 15:14, Phil Yang 写道: -Original Message- From: dev On Behalf Of Lijun Ou Sent: Thursday, July 9, 2020 9:48 PM To: wenzhuo...@intel.com; beilei.x...@intel.com; bernard.iremon...@intel.com; adrien.mazarg...@6wind.com; ferruh.yi...@intel.com Cc: dev@dpdk.org; linux...@huawei.c

Re: [dpdk-dev] [PATCH v4 11/27] examples/l3fwd: replace references to master lcore

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use initial lcore instead. Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v4 12/27] examples/l2fwd: replace references to master lcore

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use term initial lcore instead. Signed-off-by: Stephen Hemminger --- I'm assuming the #ifdef'ed out section in l2fwd-crypto is skipped because the cryptodev API is not being addressed at this time. Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v4 13/27] examples/multi_process: replace references to master lcore

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use initial lcore instead. Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v6 0/8] fib: implement AVX512 vector lookup

2020-07-15 Thread Thomas Monjalon
15/07/2020 12:35, Medvedkin, Vladimir: > On 15/07/2020 10:47, Thomas Monjalon wrote: > > 14/07/2020 16:38, Stephen Hemminger: > >> "Kinsella, Ray" wrote: > >>> On 13/07/2020 23:19, Stephen Hemminger wrote: > Did anyone else see the recent AVX512 discussion from Linus: > "I hope AVX512

Re: [dpdk-dev] [PATCH v4 14/27] examples/performance-thread: replace reference to master lcore

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use initial lcore instead. Signed-off-by: Stephen Hemminger --- static void * @@ -2265,7 +2265,7 @@ lthread_spawner(__rte_unused void *arg) * (main_lthread_master). */ static int -lthread_master_spawner(__rte_unused void *arg) { +lthr

[dpdk-dev] [PATCH v2] devtools: give some hints for ABI errors

2020-07-15 Thread David Marchand
abidiff can provide some more information about the ABI difference it detected. In all cases, a discussion on the mailing must happen but we can give some hints to know if this is a problem with the script calling abidiff, a potential ABI breakage or an unambiguous ABI breakage. Signed-off-by: Dav

Re: [dpdk-dev] [PATCH v4 15/27] examples/ptpclient: replace references to master lcore

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Replace master lcore with initial lcore. This API still has issue with use of term master clock. Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v4 16/27] examples/ipcsec-secgw: replace references to master lcore

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use initial lcore instead. Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v6 0/8] fib: implement AVX512 vector lookup

2020-07-15 Thread Medvedkin, Vladimir
On 15/07/2020 12:59, Thomas Monjalon wrote: 15/07/2020 12:35, Medvedkin, Vladimir: On 15/07/2020 10:47, Thomas Monjalon wrote: 14/07/2020 16:38, Stephen Hemminger: "Kinsella, Ray" wrote: On 13/07/2020 23:19, Stephen Hemminger wrote: Did anyone else see the recent AVX512 discussion from L

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-15 Thread David Marchand
On Thu, Jul 9, 2020 at 5:59 PM Phil Yang wrote: > > Use C11 atomic built-ins with explicit ordering instead of rte_atomic > ops which enforce unnecessary barriers on aarch64. > > Signed-off-by: Phil Yang > Reviewed-by: Ruifeng Wang > --- > v4: > 1. Add union for refcnt_atomic and refcnt in rte_m

Re: [dpdk-dev] [PATCH v4 17/27] examples: replace reference to master lcore

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Small changes in several examples to replace master_lcore with initial_lcore across multiple small examples. Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

[dpdk-dev] [PATCH v5 1/3] telemetry: support array values in data objects

2020-07-15 Thread Ciara Power
Arrays of type uint64_t/int/string can now be included within an array or dict. One level of embedded containers is supported. This is necessary to allow for instances such as the ethdev queue stats to be reported as a list of uint64_t values, rather than having multiple dict entries with one uint6

[dpdk-dev] [PATCH v5 3/3] ethdev: add common stats for telemetry

2020-07-15 Thread Ciara Power
The ethdev library now registers a telemetry command for common ethdev statistics. An example usage is shown below: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"version": "DPDK 20.08.0-rc1", "pid": 14119, "max_output_len": 16384} --> /ethdev/stats,0 {"/ethdev/stats": {"ipackets": 0, "opack

[dpdk-dev] [PATCH v5 0/3] add basic ethdev stats with data object recursion

2020-07-15 Thread Ciara Power
v5: Added unit tests for telemetry data to JSON conversion. v4: Added missing param description to Doxygen comment. v3: - Modified commit logs. - Changed function names to reference container. - Modified Doxygen comments to reference container. v2: - Added support for arrays to have contain

[dpdk-dev] [PATCH v5 2/3] test/test_telemetry_data: add unit tests for data to JSON

2020-07-15 Thread Ciara Power
From: Louise Kilheeney This patch adds tests for verifying telemetry data structures are converted to JSON as expected. Both flat and recursive data structures are tested, for all possible value types. Signed-off-by: Louise Kilheeney Signed-off-by: Ciara Power --- app/test/Makefile

Re: [dpdk-dev] [PATCH v4 18/27] app/test-pmd: change references to master/slave

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use new API and naming convention Signed-off-by: Stephen Hemminger --- app/test-pmd/config.c | 4 ++-- app/test-pmd/parameters.c | 2 +- app/test-pmd/softnicfwd.c | 2 +- app/test-pmd/testpmd.c| 4 ++-- 4 files changed, 6 insertions(+

Re: [dpdk-dev] [PATCH v4 19/27] test-eventdev: replace references to slave with worker lcores

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use new API terminolgy Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v6 0/8] fib: implement AVX512 vector lookup

2020-07-15 Thread Thomas Monjalon
15/07/2020 14:29, Medvedkin, Vladimir: > On 15/07/2020 12:59, Thomas Monjalon wrote: > > 15/07/2020 12:35, Medvedkin, Vladimir: > >> On 15/07/2020 10:47, Thomas Monjalon wrote: > >>> 14/07/2020 16:38, Stephen Hemminger: > "Kinsella, Ray" wrote: > > On 13/07/2020 23:19, Stephen Hemminger w

Re: [dpdk-dev] [PATCH v2] devtools: give some hints for ABI errors

2020-07-15 Thread Aaron Conole
David Marchand writes: > abidiff can provide some more information about the ABI difference it > detected. > In all cases, a discussion on the mailing must happen but we can give > some hints to know if this is a problem with the script calling abidiff, > a potential ABI breakage or an unambiguou

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-15 Thread Aaron Conole
David Marchand writes: > On Thu, Jul 9, 2020 at 5:59 PM Phil Yang wrote: >> >> Use C11 atomic built-ins with explicit ordering instead of rte_atomic >> ops which enforce unnecessary barriers on aarch64. >> >> Signed-off-by: Phil Yang >> Reviewed-by: Ruifeng Wang >> --- >> v4: >> 1. Add union f

Re: [dpdk-dev] [PATCH v3 00/10] bnxt patches

2020-07-15 Thread Ferruh Yigit
On 7/14/2020 11:36 PM, Ajit Khaparde wrote: > > > On Mon, Jul 13, 2020 at 2:47 AM Somnath Kotur > wrote: > > Minor enhancments added to the TF-ULP/Core layers > > Farah Smith (1): >   net/bnxt: add changes to support 2 table scopes > > Jay Di

Re: [dpdk-dev] Random failure in service_autotest

2020-07-15 Thread Aaron Conole
David Marchand writes: > Hello Harry and guys who touched the service code recently :-) > > I spotted a failure for the service UT in Travis: > https://travis-ci.com/github/ovsrobot/dpdk/jobs/361097992#L18697 > > I found only a single instance of this failure and tried to reproduce > it with my u

Re: [dpdk-dev] Random failure in service_autotest

2020-07-15 Thread David Marchand
On Wed, Jul 15, 2020 at 2:56 PM Aaron Conole wrote: > I guess the service_lcore_attr_get failed, but with no useful > information. We should have the test suite app turn the log level all > the way up. I realize it will increase the log data even higher, but > without it, we have no idea why thi

Re: [dpdk-dev] Random failure in service_autotest

2020-07-15 Thread Lukasz Wojciechowski
W dniu 15.07.2020 o 15:02, David Marchand pisze: > On Wed, Jul 15, 2020 at 2:56 PM Aaron Conole wrote: >> I guess the service_lcore_attr_get failed, but with no useful Why do you suspect service_lcore_attr_get() ? >> information. We should have the test suite app turn the log level all >> the w

[dpdk-dev] [PATCH 0/2] net/mlx5: scatter FCS with decapsulation

2020-07-15 Thread Suanming Mou
There are some limitations on the some NICs (at least on ConnectX-6DX and BlueField2) with supporting FCS (frame checksum) scattering for the tunnel decapsulated packets. For the case only one of the features can be supported in the same time, and the new devarg "decap_en" is introduced to provid

[dpdk-dev] [PATCH 1/2] common/mlx5: add scatter FCS with decap capability query

2020-07-15 Thread Suanming Mou
As scatter FCS might be not supported for decapsulated tunnel packets in some NIC HW, an new capability bit which indicates if scatter FCS works with decap is added. Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 5 + drivers/common/mlx

[dpdk-dev] [PATCH 2/2] net/mlx5: add decap enable device argument

2020-07-15 Thread Suanming Mou
There are some limitations on the some NICs (at least on ConnectX-6DX and BlueField2) with supporting FCS (frame checksum) scattering for the tunnel decapsulated packets. For the case only one of the features can be supported in the same time, and the new devarg "decap_en" is introduced to provid

Re: [dpdk-dev] [PATCH v4 20/27] app/test: replace refernces to master/slave

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use initial and worker when referring to lcores Signed-off-by: Stephen Hemminger --- You've changed the name of the test in test_eal_flags.c, but missed the update in meson.build to the new test name. Also, you missed updating app/test/test_lp

Re: [dpdk-dev] [PATCH v4 23/27] app/pdump: replace references to master/slave lcore

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use initial and worker lcore instead. Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v4 21/27] doc: fix incorrect reference to master process

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Correct terminolgy here is primary process. This is a bug in original doc. Fixes: fc1f2750a3ec ("doc: programmers guide") Cc: bernard.iremon...@intel.com Signed-off-by: Stephen Hemminger --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] Random failure in service_autotest

2020-07-15 Thread David Marchand
On Wed, Jul 15, 2020 at 3:09 PM Lukasz Wojciechowski wrote: > > > W dniu 15.07.2020 o 15:02, David Marchand pisze: > > On Wed, Jul 15, 2020 at 2:56 PM Aaron Conole wrote: > >> I guess the service_lcore_attr_get failed, but with no useful > Why do you suspect service_lcore_attr_get() ? https://tr

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-15 Thread Burakov, Anatoly
On 01-Jul-20 9:23 PM, Stephen Hemminger wrote: Use of old RTE_LCORE_FOREACH_SLAVE and rte_get_master_lcore_id() are marked as deprecated. All uses of these in DPDK itself is gone. This will cause warnings for applications still using them. Signed-off-by: Stephen Hemminger --- lib/librte_eal/

[dpdk-dev] [PATCH] lib/librte_eal/common/rte_malloc: remove redundant check for size and alignment

2020-07-15 Thread Sarosh Arif
Since mallock_socket() always calls malloc_heap_alloc() and this check is present inside malloc_heap_alloc() so there is no need to place it in mallock_socket(). Signed-off-by: Sarosh Arif --- lib/librte_eal/common/rte_malloc.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/librte_e

Re: [dpdk-dev] Random failure in service_autotest

2020-07-15 Thread Aaron Conole
David Marchand writes: > On Wed, Jul 15, 2020 at 3:09 PM Lukasz Wojciechowski > wrote: >> >> >> W dniu 15.07.2020 o 15:02, David Marchand pisze: >> > On Wed, Jul 15, 2020 at 2:56 PM Aaron Conole wrote: >> >> I guess the service_lcore_attr_get failed, but with no useful >> Why do you suspect ser

[dpdk-dev] [PATCH] net/i40e: fix fdir cannot receive rx writeback issue

2020-07-15 Thread chenmin . sun
From: Chenmin Sun This patch fixes the fdir connot receive rx writeback packet issue, by setting the fdir_vsi->nb_used_qps to 1. Besides this, to make sure fdir programming works fine when the port is stopped, move the fdir interrupt configure from start/stop to setup/teardown. Fixes: cfd662d22e

Re: [dpdk-dev] [PATCH] net/ice: fix tunnel type get error

2020-07-15 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, July 15, 2020 10:08 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Lu, Nannan ; > Zhao1, Wei > Subject: [PATCH] net/ice: fix tunnel type get error > > When get tunnel type for ICE_NON_TUN, there need some upodate for gtp > related

[dpdk-dev] [PATCH V2] net/i40e: fix fdir cannot receive rx writeback issue

2020-07-15 Thread chenmin . sun
From: Chenmin Sun This patch fixes the fdir cannot receive rx writeback packet issue, by setting the fdir_vsi->nb_used_qps to 1. Besides this, to make sure fdir programming works fine when the port is stopped, move the fdir interrupt configure from start/stop to setup/teardown. Fixes: cfd662d22e

Re: [dpdk-dev] [PATCH v4] net/ice: fix invalid RSS type

2020-07-15 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Wednesday, July 15, 2020 6:26 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Junfeng ; Guo, Jia > ; Xu, Ting ; Su, Simei > > Subject: [PATCH v4] net/ice: fix invalid RSS type > > When a RSS rule with only SRC/DST_ONLY or IPV6 prefix RSS t

Re: [dpdk-dev] Retrieving lcore worker thread id

2020-07-15 Thread Mattias Rönnblom
On 2020-07-14 15:08, Van Haaren, Harry wrote: >> -Original Message- >> From: dev On Behalf Of Mattias Rönnblom >> Sent: Tuesday, July 14, 2020 1:04 PM >> To: dpdk-dev >> Cc: Tomasz Piatkowski >> Subject: [dpdk-dev] Retrieving lcore worker thread id >> >> Hi. > Hey, > >> In DPDK 19.11, th

[dpdk-dev] [PATCH v5 0/2] mempool/ring: add support for new ring sync modes

2020-07-15 Thread Konstantin Ananyev
v5: few more comments from Thomas regarding the docs v4: add new section into mempool derivers guide (Thomas Monjalon comments) v3: silently ignore F_SP_PUT/F_SC_GET (Olivier Matz comments) v2: update Release Notes (Gage Eads comments) Konstantin Ananyev (2): doc: add ring based mempo

[dpdk-dev] [PATCH v5 2/2] mempool/ring: add support for new ring sync modes

2020-07-15 Thread Konstantin Ananyev
Two new sync modes were introduced into rte_ring: relaxed tail sync (RTS) and head/tail sync (HTS). This change provides user with ability to select these modes for ring based mempool via mempool ops API. Signed-off-by: Konstantin Ananyev Acked-by: Gage Eads --- doc/guides/mempool/ring.rst

[dpdk-dev] [PATCH v5 1/2] doc: add ring based mempool guide

2020-07-15 Thread Konstantin Ananyev
Add documentation for rte_ring mempool driver. Signed-off-by: Konstantin Ananyev --- doc/guides/mempool/index.rst | 1 + doc/guides/mempool/ring.rst | 34 ++ 2 files changed, 35 insertions(+) create mode 100644 doc/guides/mempool/ring.rst diff --git a/doc/guid

Re: [dpdk-dev] Fwd: Re: [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-07-15 Thread Ferruh Yigit
On 7/15/2020 12:03 PM, Wei Hu (Xavier) wrote: > Hi, Ferruh Yigit & Chas Williams > >Any other comments? > >If there are not other comment, could we consider apply this patch? :-) This is an old patch, since there is no objection up until now, Series applied to dpdk-next-net/master, than

[dpdk-dev] [PATCH v2] telemetry: add upper limit on connections

2020-07-15 Thread Ciara Power
This patch limits the number of client connections to the new telemetry socket. The limit is set to 10. Signed-off-by: Ciara Power --- lib/librte_telemetry/telemetry.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/librte_telemetry/telemetry.c b/lib/librte_telemetry/tel

Re: [dpdk-dev] [v4 1/3] examples/vm_power_manager: Make branch ratio threshold per core

2020-07-15 Thread Pattan, Reshma
> -Original Message- > From: dev On Behalf Of Rory Sexton > Sent: Tuesday, July 14, 2020 5:02 PM > To: dev@dpdk.org; Hunt, David > Subject: [dpdk-dev] [v4 1/3] examples/vm_power_manager: Make branch ratio > threshold per core > > This modification allows for the branch ratio threshold

Re: [dpdk-dev] [v4 2/3] examples/vm_power_manager: Allowing power managing of idle cores

2020-07-15 Thread Pattan, Reshma
> -Original Message- > From: dev On Behalf Of Rory Sexton > Sent: Tuesday, July 14, 2020 5:02 PM > To: dev@dpdk.org; Hunt, David > Subject: [dpdk-dev] [v4 2/3] examples/vm_power_manager: Allowing power > managing of idle cores > > This change is required to allow the branch ratio algo

Re: [dpdk-dev] [v4 3/3] doc: update vm_power_manager cmdline options in doc

2020-07-15 Thread Pattan, Reshma
> -Original Message- > From: dev On Behalf Of Rory Sexton > Signed-off-by: Rory Sexton > Reviewed-by: David Hunt > > --- > v4: no changes > --- Acked-by: Reshma Pattan

  1   2   3   >