abidiff can provide some more information about the ABI difference it
detected.
In all cases, a discussion on the mailing must happen but we can give
some hints to know if this is a problem with the script calling abidiff,
a potential ABI breakage or an unambiguous ABI breakage.
Signed-off-by: David Marchand <david.march...@redhat.com>
Acked-by: Ray Kinsella <m...@ashroe.eu>
Acked-by: Neil Horman <nhor...@tuxdriver.com>
---
Changes since v1:
- used arithmetic test,
- updated error message for generic errors,
---
devtools/check-abi.sh | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
index e17fedbd9f..172e934382 100755
--- a/devtools/check-abi.sh
+++ b/devtools/check-abi.sh
@@ -50,10 +50,22 @@ for dump in $(find $refdir -name "*.dump"); do
error=1
continue
fi
- if ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then
+ abidiff $ABIDIFF_OPTIONS $dump $dump2 || {
+ abiret=$?
echo "Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS
$dump $dump2'"
error=1
- fi
+ echo
+ if [ $(($abiret & 3)) -ne 0 ]; then
+ echo "ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, this could be
a script or environment issue."
+ fi
+ if [ $(($abiret & 4)) -ne 0 ]; then
+ echo "ABIDIFF_ABI_CHANGE, this change requires a review
(abidiff flagged this as a potential issue)."
+ fi
+ if [ $(($abiret & 8)) -ne 0 ]; then
+ echo "ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change
breaks the ABI."
+ fi
+ echo
+ }
done
[ -z "$error" ] || [ -n "$warnonly" ]
--
2.23.0
