On Fri, Jul 10, 2020 at 6:17 PM Thomas Monjalon <tho...@monjalon.net> wrote: > The problem is that we have an API which is taking mmap flags as input. > "int additional_flags" is a parameter of the function, > and are supposed to be mmap flags. But it is not stated clearly. > When Windows will use this function, it won't use mmap flags > but RTE_MAP_*. So we must accept both. > That's why the best is to make values the same. > > In 20.11, we could change the API, > make clear that only RTE_MAP_* is accepted, > and remove this workaround. > Or even better, remove pci_map_resource from the PCI lib, > and implement it in the PCI bus driver.
My preference goes to simple removal. Maybe it can be handled/rediscussed when the windows porting touches pci resources mappings. Removal needs to be announced, so something to plan right now. -- David Marchand
