Re: [dpdk-dev] [PATCH] net/ice/base: remove unnecessary code

On 04/07, Qi Zhang wrote: >Update a switch rule' action from "to VSI" to "to VSI List" >should only happen when the same rule has been programmed with >a different fwd destination. This is already handled by below >code block: > >m_entry = ice_find_adv_rule_entry(...) >if (m_entry) { > ... >

[dpdk-dev] [PATCH v1] net/axgbe: support sfp module EEPROM

From: Amaranath Somalapuram Adding API for get_module_eeprom and get_module_info. Signed-off-by: Amaranath Somalapuram --- drivers/net/axgbe/axgbe_ethdev.c | 2 + drivers/net/axgbe/axgbe_phy.h | 4 ++ drivers/net/axgbe/axgbe_phy_impl.c | 107 + 3 files ch

Re: [dpdk-dev] [PATCH v1] doc: Update ICE PMD driver/firmware/package version for DPDK 20.02

On 03/20, Chen, Zhaoyan wrote: >Update driver/firmware/package version for DPDK20.02 > >Signed-off-by: Chen, Zhaoyan Should be: Signed-off-by: Zhaoyan Chen > >--- > doc/guides/nics/ice.rst | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rs

Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements

Hello Hemant, Hemant Agrawal writes: [...] >> >> > > [Hemant] >> >> > > As per the logs: >> >> > > >> >> > > Variables changes summary: 1 Removed, 2 Changed, 0 Added >> >> > > variables >> >> > > 1 Removed variable: >> >> > > 'dpaa2_portal_dqrr per_lcore_dpaa2_held_bufs' >> >> > {per_lcore_dp

Re: [dpdk-dev] [PATCH v3 2/7] net/virtio-user: add vectorized packed ring parameter

> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, April 8, 2020 2:23 PM > To: Liu, Yong > Cc: maxime.coque...@redhat.com; Wang, Zhihong > ; Van Haaren, Harry > ; dev@dpdk.org > Subject: Re: [PATCH v3 2/7] net/virtio-user: add vectorized packed ring > parameter > > On 04/08,

Re: [dpdk-dev] [PATCH 0/3] update i40e base code

Pleas also update share code release version in readme. Thanks. > -Original Message- > From: dev On Behalf Of Jiaqi Min > Sent: Wednesday, March 25, 2020 11:24 AM > To: dev@dpdk.org > Cc: Min, JiaqiX > Subject: [dpdk-dev] [PATCH 0/3] update i40e base code > > The main changes include: >

Re: [dpdk-dev] [PATCH v1 2/4] regexdev: add regex core h file

> -Original Message- > From: dev On Behalf Of Jerin Jacob > Sent: Tuesday, April 7, 2020 7:27 PM > Subject: Re: [dpdk-dev] [PATCH v1 2/4] regexdev: add regex core h file > > On Tue, Apr 7, 2020 at 9:46 PM Ori Kam wrote: > > > Hi Guy, > > > > > -Original Message- > > > From: de

Re: [dpdk-dev] [PATCH v1 2/4] regexdev: add regex core h file

On Wed, Apr 8, 2020 at 1:07 PM Ori Kam wrote: > > > > -Original Message- > > From: dev On Behalf Of Jerin Jacob > > Sent: Tuesday, April 7, 2020 7:27 PM > > Subject: Re: [dpdk-dev] [PATCH v1 2/4] regexdev: add regex core h file > > > > On Tue, Apr 7, 2020 at 9:46 PM Ori Kam wrote: > > >

Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements

Hello Thomas, Hemant, Thomas Monjalon writes: > 07/04/2020 12:25, Hemant Agrawal: [...] >> [Hemant] I have commented on Neil's series. >> It needs more changes in existing code. >> An approach like __rte_experimental will work better. > > I guess you mean __rte_internal? > > Please Hemant don'

Re: [dpdk-dev] [PATCH v6] net/i40e: implement hash function in rte flow API

Hi Chenxu, > > > -Original Message- > > > From: dev On Behalf Of Chenxu Di > > > Sent: Monday, March 30, 2020 8:40 AM > > > To: dev@dpdk.org > > > Cc: Yang, Qiming ; Xing, Beilei > > > ; Zhao1, Wei ; Di, > > > ChenxuX > > > Subject: [dpdk-dev] [PATCH v6] net/i40e: implement hash functi

[dpdk-dev] [PATCH v3 01/30] net/ena: check if size of buffer is at least 1400B

Some of the ENA devices can't handle buffers which are smaller than a 1400B. Because of this limitation, size of the buffer is being checked and limited during the Rx queue setup. If it's below the allowed value, PMD won't finish it's configuration successfully.. Signed-off-by: Michal Krawczyk R

[dpdk-dev] [PATCH v3 00/30] Update ENA driver to v2.1.0

Hi, This patchset is including severeal changes, including: * ena_com (HAL) update * Support for upcoming device features * Refactor of the IO path * Documentation update about ENA usage on metal instances v2: * Fix comments from review v3: * Split ena_com patch for RSS into several patches * Ad

[dpdk-dev] [PATCH v3 03/30] net/ena/base: prevent allocation of 0-sized memory

From: Igor Chauskin rte_memzone_reserve() will reserve the biggest contiguous memzone available if received 0 as size param. Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK") Cc: sta...@dpdk.org Signed-off-by: Igor Chauskin Reviewed-by: Michal Krawczyk Reviewed-by: Guy Tzalik ---

[dpdk-dev] [PATCH v3 02/30] net/ena/base: make allocation macros thread-safe

From: Igor Chauskin Memory allocation region id could possibly be non-unique due to non-atomic increment, causing allocation failure. Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK") Cc: sta...@dpdk.org Signed-off-by: Igor Chauskin Reviewed-by: Michal Krawczyk Reviewed-by: Guy Tz

[dpdk-dev] [PATCH v3 06/30] net/ena/base: remove conversion of the ind tbl

After the indirection table is being saved in the device, there is no need to convert it back, as it's already saved in host_rss_ind_tbl array. As a result, the call to the ena_com_ind_tbl_convert_from_device() is not needed. Signed-off-by: Michal Krawczyk --- v3: * This patch was added - prev

[dpdk-dev] [PATCH v3 07/30] net/ena/base: rework interrupt moderation

This feature allows for adaptive interrupt moderation. It's not used by the DPDK PMD, but is a part of the newest HAL version. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 171 +-- drivers/n

[dpdk-dev] [PATCH v3 04/30] net/ena/base: generate default, random RSS hash key

Although the RSS key still cannot be set, it is now being generated every time the driver is being initialized. Multiple devices can still have the same key if they're used by the same driver. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- v2: * Remove

[dpdk-dev] [PATCH v3 05/30] net/ena/base: fix testing for supported hash func

There was a bug in ena_com_fill_hash_function(), which was causing bit to be shifted left one bit too much. To fix that, the ENA_FFS macro is being ussed (returning the location of the first bit set), hash_function value is being subtracted by 1 if any hash function is supported by the device and

[dpdk-dev] [PATCH v3 09/30] net/ena/base: add accelerated LLQ mode

In order to use the accelerated LLQ (Low-lateny queue) mode, the driver must limit the Tx burst and be aware that the device has the meta caching disabled. In that situation, the meta descriptor must be valid on each Tx packet. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-b

[dpdk-dev] [PATCH v3 12/30] net/ena/base: add error logs when preparing Tx

To make the debugging easier, the error logs were added in the Tx path. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_eth_com.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v3 10/30] net/ena/base: fix documentation of the functions

The documentation format was aligned and few typos were fixed. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/ena/bas

[dpdk-dev] [PATCH v3 11/30] net/ena/base: fix indentation in cq polling

The spaces instead of tabs were used for the indent. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena

[dpdk-dev] [PATCH v3 08/30] net/ena/base: remove extra properties strings

This buffer was never used by the ENA PMD. It could be used for debugging, but it's presence is redundant now. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 56 -- drivers/net/ena/base/ena_

[dpdk-dev] [PATCH v3 13/30] net/ena/base: use 48-bit memory addresses in ena_com

ENA device is using 48-bit memory for IO. because of that, the upper limit had to be updated. >From the driver perspective, it's just a cosmetic change to make definition of the strucutre 'ena_common_mem_addr' more descriptive and the address value was verified anyway for the valid range in the fu

[dpdk-dev] [PATCH v3 15/30] net/ena/base: fix indentation of multiple defines

As the alignemnt of the defines wasn't valid, it was removed at all, so instead of using multiple spaces or tabs, the single space after define name is being used. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.h | 8

[dpdk-dev] [PATCH v3 14/30] net/ena/base: fix types for printing timestamps

Because ena_com is being used by multiple platforms which are using different C versions, PRIu64 cannot be used directly and must be defined in the platform file. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 2 +-

[dpdk-dev] [PATCH v3 18/30] net/ena: refactor getting IO queues capabilities

Reading values from the device is about the maximum capabilities of the device. Because of that, the names of the fields storing those values, functions and temporary variables, should be more descriptive in order to improve self documentation fo the code. In connection with this, the way of getti

[dpdk-dev] [PATCH v3 16/30] net/ena/base: update gen date and commit

The current ena_com version was generated on 25.09.2019. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- v3: * Update copyright date of the modified file. drivers/net/ena/base/ena_defs/ena_gen_info.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deleti

[dpdk-dev] [PATCH v3 17/30] net/ena: set IO ring size to the valid value

IO rings were configured with the maximum allowed size for the Tx/Rx rings. However, the application could decide to create smaller rings. This patch is using value stored in the ring instead of the value from the adapter which is indicating the maximum allowed value. Fixes: df238f84c0a2 ("net/en

[dpdk-dev] [PATCH v3 19/30] net/ena: add support for large LLQ headers

Default LLQ (Low-latency queue) maximum header size is 96 bytes and can be too small for some types of packets - like IPv6 packets with multiple extension. This can be fixed, by using large LLQ headers. If the device supports larger LLQ headers, the user can activate them by using device argument

[dpdk-dev] [PATCH v3 24/30] net/ena: rework getting number of available descs

ena_com API should be preferred for getting number of used/available descriptors unless extra calculation needs to be performed. Some helper variables were added for storing values that are later reused. Moreover, for limiting the value of sent/received packets to the number of available descripto

[dpdk-dev] [PATCH v3 21/30] net/ena: add Tx drops statistic

ENA device can report in the AENQ handler amount of Tx packets that were dropped and not sent. This statistic is showing global value for the device and because rte_eth_stats is missing field that could indicate this value (it isn't the Tx error), it is being presented as a extended statistic. As

[dpdk-dev] [PATCH v3 23/30] net/ena: refactor Rx path

* Split main Rx function into multiple ones - the body of the main was very big and further there were 2 nested loops, which were making the code hard to read * Rework how the Rx mbuf chains are being created - Instead of having while loop which has conditional check if it's first segment, ha

[dpdk-dev] [PATCH v3 20/30] net/ena: remove memory barriers before doorbells

The doorbell code is already issuing the doorbell by using rte_write. Because of that, there is no need to do that before calling the function. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/ena_ethdev.c | 9 + 1 file changed, 1 in

[dpdk-dev] [PATCH v3 22/30] net/ena: disable meta caching

In the LLQ (Low-latency queue) mode, the device can indicate that meta data descriptor caching is disabled. In that case the driver should send valid meta descriptor on every Tx packet. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- v3: * Explain LLQ abb

[dpdk-dev] [PATCH v3 26/30] net/ena: use macros for ring idx operations

To improve code readability, abstraction was added for operating on IO rings indexes. Driver was defining local variable for ring mask in each function that needed to operate on the ring indexes. Now it is being stored in the ring as this value won't change unless size of the ring will change and

Re: [dpdk-dev] [PATCH v1] net/axgbe: support sfp module EEPROM

Hi Ravi, Can you acknowledge this patch. Regards, S.Amarnath -Original Message- From: Somalapuram, Amaranath Sent: Wednesday, April 8, 2020 12:38 PM To: dev@dpdk.org Cc: Kumar, Ravi1 Subject: [PATCH v1] net/axgbe: support sfp module EEPROM From: Amaranath Somalapuram Adding API for

[dpdk-dev] [PATCH v3 28/30] net/ena: reuse 0 length Rx descriptor

Some ENA devices can pass to the driver descriptor with length 0. To avoid extra allocation, the descriptor can be reused by simply putting it back to the device. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- v2: * Compare rc (error code) to 0 value exp

[dpdk-dev] [PATCH v3 30/30] net/ena: update version of the driver to v2.1.0

The v2.1.0 is refactoring Tx and Rx paths, including few bug fixes and is also adding a new features which are going to be available with the newest hardware. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- v3: * Remove features listed in this commit log

[dpdk-dev] [PATCH v3 29/30] doc: add notes on ENA usage on metal instances

As AWS metal instances are supporting IOMMU, the usage of igb_uio or vfio-pci can lead to a problems (when to use which module), especially that the vfio-pci isn't supporting SMMU on arm64. To clear up the problem of using those modules in various setup conditions (with or without IOMMU) on metal

Re: [dpdk-dev] [PATCH v1 2/4] regexdev: add regex core h file

> > From: Jerin Jacob > Sent: Wednesday, April 8, 2020 10:49 AM > Subject: Re: [dpdk-dev] [PATCH v1 2/4] regexdev: add regex core h file > > On Wed, Apr 8, 2020 at 1:07 PM Ori Kam wrote: > > > > -Original Message- > > From: dev

Re: [dpdk-dev] [PATCH v1 2/4] regexdev: add regex core h file

> > > > The rte_regex_dev which has enqueue() and dequeue() function pointer > > > should not be NOT allocated from hugepage > > > as per process it will have different enqueue() and dequeue() function > > > pointer value. Making it hugepage, another process > > > overwrites it. > > > > > > > >

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Monday, April 6, 2020 4:30 PM > To: Ori Kam ; Jerin Jacob Kollanukkaran > ; xiang.w.w...@intel.com; Pavan Nikhilesh Bhagavatula > > Cc: dev@dpdk.org; Shahaf Shuler ; > hemant.agra...@nxp.com; Opher Reviv ; Alex > Ros

Re: [dpdk-dev] [PATCH] net/nfp: fix log format specifiers

On 4/7/2020 2:43 PM, Heinrich Kuhn wrote: > > > On 2020/03/03 15:36, Ferruh Yigit wrote: >> Changing format specifier for the 'size_t' as '%z' and for 'off_t' as >> '%jd'. >> >> Also this fix enables compiling PMD for 32bit architecture. >> >> Fixes: 29a62d1476b6 ("net/nfp: add CPP bridge as serv

Re: [dpdk-dev] [PATCH v2 1/4] common/mlx5: refactor MP IPC handling codes to common driver

> -Original Message- > From: Vu Pham > Sent: Tuesday, April 7, 2020 19:48 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Ori Kam > ; Matan Azrad ; Raslan > Darawsheh ; Vu Pham > Subject: [PATCH v2 1/4] common/mlx5: refactor MP IPC handling codes to > common driver > > Refactor common mp hand

Re: [dpdk-dev] [PATCH v3 3/4] common/mlx5: refactor memory management codes

> -Original Message- > From: Vu Pham > Sent: Tuesday, April 7, 2020 20:01 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Ori Kam > ; Matan Azrad ; Raslan > Darawsheh ; Vu Pham > Subject: [PATCH v3 3/4] common/mlx5: refactor memory management codes > > Refactor common memory btree and cache m

Re: [dpdk-dev] [PATCH v3 4/4] net/mlx5: modify net PMD to use common MR driver

> -Original Message- > From: Vu Pham > Sent: Tuesday, April 7, 2020 20:01 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Ori Kam > ; Matan Azrad ; Raslan > Darawsheh ; Vu Pham > Subject: [PATCH v3 4/4] net/mlx5: modify net PMD to use common MR driver > > Modify mlx5 net pmd driver to use M

Re: [dpdk-dev] [PATCH v3 1/4] common/mlx5: refactor multi-process IPC handling codes to common driver

> -Original Message- > From: Vu Pham > Sent: Tuesday, April 7, 2020 20:01 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Ori Kam > ; Matan Azrad ; Raslan > Darawsheh ; Vu Pham > Subject: [PATCH v3 1/4] common/mlx5: refactor multi-process IPC handling > codes to common driver > > Refactor com

Re: [dpdk-dev] [PATCH v3 2/4] net/mlx5: modify net PMD to use common multi-process APIs

> -Original Message- > From: Vu Pham > Sent: Tuesday, April 7, 2020 20:01 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Ori Kam > ; Matan Azrad ; Raslan > Darawsheh ; Vu Pham > Subject: [PATCH v3 2/4] net/mlx5: modify net PMD to use common multi- > process APIs > > Modify net PMD to use mul

Re: [dpdk-dev] [PATCH v2 0/4] introduce multi-function processing support

On 4/7/2020 12:27 PM, Coyle, David wrote: > Hi Ferruh, see below > >>> >>> While DPDK's rte_cryptodev and rte_compressdev allow many >>> cryptographic and compression algorithms to be chained together in one >>> operation, there is no way to chain these with any error detection or >>> checksum alg

Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions

Hi Pavan > -Original Message- > From: dev On Behalf Of Pavan Nikhilesh Bhagavatula > Sent: Monday, April 6, 2020 3:48 PM > > Hi Ori, > > >Hi Pavan, > > > >> -Original Message- > >> From: dev On Behalf Of Pavan Nikhilesh > >Bhagavatula > >> Sent: Sunday, April 5, 2020 8:11 PM >

Re: [dpdk-dev] [PATCH v1 2/4] regexdev: add regex core h file

> > > > From: Jerin Jacob > > Sent: Wednesday, April 8, 2020 10:49 AM > > > > > > > > On Wed, Apr 8, 2020 at 1:07 PM Ori Kam wrote: > > > > > > > -Original Message- > > > From: dev On Behalf Of Jerin Jacob > > > Sent: Tuesday

Re: [dpdk-dev] [PATCH v3 07/12] service: remove rte prefix from static functions

> -Original Message- > From: Van Haaren, Harry > Sent: Friday, April 3, 2020 7:58 PM > To: Phil Yang ; tho...@monjalon.net; Ananyev, > Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; > dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; > hemant.agra...

Re: [dpdk-dev] [PATCH v3 07/12] service: remove rte prefix from static functions

> -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, April 6, 2020 5:35 AM > To: Phil Yang ; tho...@monjalon.net; > harry.van.haa...@intel.com; konstantin.anan...@intel.com; > step...@networkplumber.org; maxime.coque...@redhat.com; > dev@dpdk.org > Cc: david.march...@redhat.co

Re: [dpdk-dev] [PATCH v3 08/12] service: remove redundant code

> -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, April 6, 2020 2:35 AM > To: Van Haaren, Harry ; Phil Yang > ; tho...@monjalon.net; Ananyev, Konstantin > ; step...@networkplumber.org; > maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvel

Re: [dpdk-dev] [PATCH v3 11/12] service: optimize with c11 one-way barrier

> -Original Message- > From: Van Haaren, Harry > Sent: Friday, April 3, 2020 7:58 PM > To: Phil Yang ; tho...@monjalon.net; Ananyev, > Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; > dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; > hemant.agra...

[dpdk-dev] [PATCH v2 4/4] net/i40e/base: update version

Update share code release version in readme. Signed-off-by: Jiaqi Min --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 8a5339cff..e7b39b4d1 100644 --- a/drivers/net/i40e/base/REA

[dpdk-dev] [PATCH v2 3/4] net/i40e/base: add constants for PTP pins

Introduce constants for handling PTP pins used for external clock source. Signed-off-by: Piotr Kwapulinski Signed-off-by: Jiaqi Min Acked-by: Piotr Kwapulinski --- drivers/net/i40e/base/i40e_register.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/base/i40e_register.

[dpdk-dev] [PATCH v2 1/4] net/i40e/base: update X722/X710 FW API version to 1.10

update X722/X710 FW API version to 1.10. Signed-off-by: Piotr Azarewicz Signed-off-by: Jiaqi Min --- drivers/net/i40e/base/i40e_adminq_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h

[dpdk-dev] [PATCH v2 0/4] update i40e base code

The main changes include: * Update X722/X710 FW API version to 1.10. * New device ID introduced for V710-T*L 5G. * Add constants for PTP pins. * Update version in README. --- v2 changes: * Updated version in README Jiaqi Min (4): net/i40e/base: update X722/X710 FW API version to 1.10 net/i40e

[dpdk-dev] [PATCH v2 2/4] net/i40e/base: new device ID introduced for V710-TL 5G

This change is adding new device ID and handling it in the same way as X710-T*L head of family. A new device ID is for new V710-T*L adapter supporting speeds up to 5G. Signed-off-by: Zalfresso-Jundzillo Signed-off-by: Jiaqi Min --- drivers/net/i40e/base/i40e_common.c | 12 +--- drivers/

Re: [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

> -Original Message- > From: Phil Yang > Sent: Monday, February 24, 2020 2:42 PM > To: rsanf...@akamai.com; erik.g.carri...@intel.com; dev@dpdk.org > Cc: david.march...@redhat.com; anatoly.bura...@intel.com; > tho...@monjalon.net; jer...@marvell.com; hemant.agra...@nxp.com; > Honnappa Naga

Re: [dpdk-dev] [PATCH v3 07/12] service: remove rte prefix from static functions

> -Original Message- > From: Phil Yang > Sent: Wednesday, April 8, 2020 11:15 AM > To: Van Haaren, Harry ; tho...@monjalon.net; > Ananyev, Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; hemant.agra...

Re: [dpdk-dev] [PATCH v2 2/4] raw/aesni_mb: add aesni_mb raw device

Hi David, > -Original Message- > From: dev On Behalf Of De Lara Guarch, Pablo > Sent: Tuesday, April 7, 2020 7:51 PM > To: Coyle, David ; dev@dpdk.org > Cc: Doherty, Declan ; Trahe, Fiona > ; Ryan, Brendan ; > shreyansh.j...@nxp.com; hemant.agra...@nxp.com; O'loingsigh, Mairtin > > Subje

Re: [dpdk-dev] [PATCH v3 07/12] service: remove rte prefix from static functions

> -Original Message- > From: Van Haaren, Harry > Sent: Wednesday, April 8, 2020 6:37 PM > To: Phil Yang ; tho...@monjalon.net; Ananyev, > Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; > dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; > hemant.agra

Re: [dpdk-dev] [PATCH v1] net/nfp: fix dangling pointer on failure

On 4/7/2020 2:44 PM, Heinrich Kuhn wrote: > > > On 2020/04/07 13:37, wangyunjian wrote: >> From: Yunjian Wang >> >> When nfp_pf_create_dev() is cleaning up, it does not correctly set >> the dev_private variable to NULL, which will lead to a double free. >> >> Fixes: ef28aa96e53b ("net/nfp: suppo

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix dropping of initial IPsec pkts

In inline event mode when traffic flows and the ipsec-secgw app is started then for short period of time IPsec packets arrive at application without being decrypted and are dropped by the application. This happens because eth ports are started before creation of inline sessions and IPsec flows. Thi

Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group

On Tue, Apr 07, 2020 at 02:52:57PM +0300, Alex Kiselev wrote: > rte_lpm6: fix incorrect size of tbl8 group > Missing Cc: sta...@dpdk.org and fixes line, which I believe should be: Fixes: e480688dce6d ("lpm6: add incremental update on delete") > Signed-off-by: Alex Kiselev > --- > lib/librte_

Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements

08/04/2020 09:52, Dodji Seketeli: > Hello Thomas, Hemant, > > Thomas Monjalon writes: > > 07/04/2020 12:25, Hemant Agrawal: > > [...] > > >> [Hemant] I have commented on Neil's series. > >> It needs more changes in existing code. > >> An approach like __rte_experimental will work better. > > >

Re: [dpdk-dev] [PATCH v3 1/4] ip_frag: ensure minimum v4 fragmentation length

> >> >> The IPv4 specification says that each fragment must at least the size of > >> >> an IP header plus 8 octets. When attempting to run ipfrag using a > >> >> smaller size, the fragment library will return successful completion, > >> >> even though it is a violation of RFC791 (and updates).

[dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

libjansson4 is not enough to build telemetry. Replace it with libjansson-dev. Signed-off-by: Juraj Linkeš --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index fd4f79cfc..2d2292ff6 100644 --- a/.travis.yml +++ b/.travis.yml @@ -15,7 +

Re: [dpdk-dev] [PATCH 1/2] ethdev: deduplicate functions to get link infos

08/04/2020 07:21, Asaf Penso: > From: Thomas Monjalon > > +static int > > +get_link_infos(uint16_t port_id, struct rte_eth_link *eth_link, int wait) > > I would recommend renaming to link_get_infos, to have the same naming > convention as rte_eth_*link_get* and rte_eth_*link_get*_nowait No strong

Re: [dpdk-dev] [EXT] [PATCH v1] net/octeontx: fix dangling pointer on failure

On Tue, Apr 07, 2020 at 07:35:43PM +0800, wangyunjian wrote: > External Email > > -- > From: Yunjian Wang > > When octeontx_create() is cleaning up, it does not correctly set > the mac_addrs variable to NULL, which will lead to

[dpdk-dev] [PATCH v2 0/2] compress/qat: im buffer too small - split op

This patch implements a special way of buffer handling when internal QAT IM buffer is too small for Huffman dynamic compression operation. Instead of falling back to fixed compression, the operation is now split into multiple smaller dynamic compression requests (possible to execute on QAT) and the

[dpdk-dev] [PATCH v2 2/2] test/compress: im buffer too small - add unit tests

This patch adds a new test suite for verification of the "internal QAT IM buffer too small" case handling. These unit tests are specific to the QAT PMD only - that's why they are contained in a separate test suite. Signed-off-by: Adam Dybkowski --- app/test/test_compressdev.c | 1251

[dpdk-dev] [PATCH v2 1/2] compress/qat: im buffer too small - split op

This patch implements a special way of buffer handling when internal QAT IM buffer is too small for Huffman dynamic compression operation. Instead of falling back to fixed compression, the operation is now split into multiple smaller dynamic compression requests (possible to execute on QAT) and the

Re: [dpdk-dev] [PATCH 0/8] net/mlx5 counter optimize

Hi, > -Original Message- > From: Suanming Mou > Sent: Tuesday, April 7, 2020 7:00 AM > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 0/8] net/mlx5 counter optimize > > In the plan of save the memory consumption for rte_flow, the counter > memory consumption will be optimized from

Re: [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition

08/04/2020 05:13, Lukasz Wojciechowski: > Wrap RTE_TEST_TRACE_FAILURE macro definition into #ifndef clause > as it might be already defined. I think it should not be defined at all. Why not including rte_test.h?

Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters

08/04/2020 05:13, Lukasz Wojciechowski: > This patch adds verification of the parameters to the ret_security API > functions. All required parameters are checked if they are not NULL. [...] > --- a/config/common_base > +++ b/config/common_base > CONFIG_RTE_LIBRTE_SECURITY=y > +CONFIG_RTE_LIBRTE_SE

Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters

Hi Thomas, > 08/04/2020 05:13, Lukasz Wojciechowski: > > This patch adds verification of the parameters to the ret_security API > > functions. All required parameters are checked if they are not NULL. > [...] > > --- a/config/common_base > > +++ b/config/common_base > > CONFIG_RTE_LIBRTE_SECURITY

[dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group

rte_lpm6: fix incorrect size of tbl8 group Fixes: e480688dce6d ("lpm6: add incremental update on delete") Signed-off-by: Alex Kiselev --- lib/librte_lpm/rte_lpm6.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c index 1

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

Juraj Linkeš writes: > libjansson4 is not enough to build telemetry. Replace it with > libjansson-dev. > > Signed-off-by: Juraj Linkeš > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group

On Wed, Apr 08, 2020 at 03:07:30PM +0200, Alex Kiselev wrote: > rte_lpm6: fix incorrect size of tbl8 group > Fixes: e480688dce6d ("lpm6: add incremental update on delete") > > Signed-off-by: Alex Kiselev > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v3 00/30] Update ENA driver to v2.1.0

On 4/8/2020 9:28 AM, Michal Krawczyk wrote: > Hi, > > This patchset is including severeal changes, including: > * ena_com (HAL) update > * Support for upcoming device features > * Refactor of the IO path > * Documentation update about ENA usage on metal instances > > v2: > * Fix comments from rev

Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters

08/04/2020 15:02, Anoob Joseph: > Hi Thomas, > > > 08/04/2020 05:13, Lukasz Wojciechowski: > > > This patch adds verification of the parameters to the ret_security API > > > functions. All required parameters are checked if they are not NULL. > > [...] > > > --- a/config/common_base > > > +++ b/co

Re: [dpdk-dev] [PATCH] rte_lpm6: fix incorrect size of tbl8 group

On 08/04/2020 14:07, Alex Kiselev wrote: > rte_lpm6: fix incorrect size of tbl8 group > Fixes: e480688dce6d ("lpm6: add incremental update on delete") Cc: sta...@dpdk.org Thanks for Cc'ing stable. It is better to add the tag directly in the commit message as we automate checking for the tag in dp

[dpdk-dev] First the test fail and than get passed

About 2 days ago, I submitted a patch for a Bug 353. And I saw that "iol-testing" failed on patchwork for "openSUSE" Environment. Today I checked and it shows all the tests are passed [ http://mails.dpdk.org/archives/test-report/2020-April/124201.html]. Is this normal that first the test fail and t

[dpdk-dev] [PATCH v3] crypto/aesni_mb: support DOCSIS AES-256

This patch adds support for DOCSIS AES-256 when using AESNI-MB Signed-off-by: Mairtin o Loingsigh Acked-by: Pablo de Lara --- doc/guides/rel_notes/release_20_05.rst | 5 + drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 ++ 2 files changed, 11 insertions(+) diff --git a/doc/

[dpdk-dev] [PATCH v4] examples/ipsec-secgw: support flow director feature

Support load distribution in security gateway application using NIC load distribution feature(Flow Director). Flow Director is used to redirect the specified inbound ipsec flow to a specified queue.This is achieved by extending the SA rule syntax to support specification by adding new action_type o

Re: [dpdk-dev] [PATCH v1] net/pfe: fix to set mac_addrs to NULL after freeing

On 4/7/2020 12:39 PM, wangyunjian wrote: > From: Yunjian Wang > > It does not correctly set the mac_addrs variable to NULL after > freeing it, which will lead to a double free. > > Fixes: 67fc3ff97c39 ("net/pfe: introduce basic functions") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang

Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

On 07/04/2020 12:58, Thomas Monjalon wrote: > 07/04/2020 13:33, Neil Horman: >> On Tue, Apr 07, 2020 at 09:36:17AM +0200, David Marchand wrote: >>> On Mon, Apr 6, 2020 at 9:34 PM Neil Horman wrote: Since we've moved away from our initial abi_versioning.sh script, in >>> >>> abi_versio

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

Hi Thomas, > > -- > 08/04/2020 15:02, Anoob Joseph: > > Hi Thomas, > > > > > 08/04/2020 05:13, Lukasz Wojciechowski: > > > > This patch adds verification of the parameters to the ret_security > > > > API functions. All required p

Re: [dpdk-dev] [dpdk-stable] [v2] app/testpmd: fix PPPOES flow API

On 4/5/2020 4:12 PM, Ori Kam wrote: > Hi Xiao, > > > >> -Original Message- >> From: Xiao Zhang >> Sent: Tuesday, March 31, 2020 4:30 PM >> To: dev@dpdk.org >> Cc: Ori Kam ; qi.z.zh...@intel.com; >> wei.zh...@intel.com; Xiao Zhang ; sta...@dpdk.org >> Subject: [v2] app/testpmd: fix PPPOE

Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

On 06/04/2020 20:34, Neil Horman wrote: > Since we've moved away from our initial abi_versioning.sh script, in > favor of check_abi.sh, which uses libabigail, remove the old script from > the tree, and update the docs accordingly > > Signed-off-by: Neil Horman > CC: tho...@monjalon.net > --- >

Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree

On 07/04/2020 08:36, David Marchand wrote: > On Mon, Apr 6, 2020 at 9:34 PM Neil Horman wrote: >> >> Since we've moved away from our initial abi_versioning.sh script, in > > abi_versioning.sh does not exist (idem with the patch title). > I suppose you meant validate-abi.sh. > >> favor of chec

Re: [dpdk-dev] [PATCH v2] mbuf: replace zero-length marker with unnamed union

Hi Kevin, > -Original Message- > From: Kevin Traynor > Sent: Wednesday, April 8, 2020 1:14 AM > To: Gavin Hu ; Bruce Richardson > ; Morten Brørup > > Cc: Ferruh Yigit ; dev@dpdk.org; nd > ; david.march...@redhat.com; tho...@monjalon.net; > jer...@marvell.com; Honnappa Nagarahalli > ; Ru

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mbuf: replace zero-length marker with unnamed union

On Wed, Apr 8, 2020 at 5:05 PM Gavin Hu wrote: > > -Original Message- > > From: Kevin Traynor > > Hi Gavin, I lost track if v2 is still a candidate for merge. fwiw, it > > compiles without giving the zero-length-bounds warning on my system. > > > > Kevin. > > Yes, this path alone is a ca

Re: [dpdk-dev] [PATCH v2 1/2] compress/qat: im buffer too small - split op

> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, April 8, 2020 1:51 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 1/2] compress/qat: im buffer too small - split op > > This patch implements a special way of buffer

Re: [dpdk-dev] [PATCH v2 2/2] test/compress: im buffer too small - add unit tests

> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, April 8, 2020 1:51 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 2/2] test/compress: im buffer too small - add unit tests > > This patch adds a new test suite for v

Re: [dpdk-dev] [PATCH v3 1/4] ip_frag: ensure minimum v4 fragmentation length

"Ananyev, Konstantin" writes: >> >> >> The IPv4 specification says that each fragment must at least the size >> >> >> of >> >> >> an IP header plus 8 octets. When attempting to run ipfrag using a >> >> >> smaller size, the fragment library will return successful completion, >> >> >> even though

  1   2   >