08/04/2020 15:02, Anoob Joseph: > Hi Thomas, > > > 08/04/2020 05:13, Lukasz Wojciechowski: > > > This patch adds verification of the parameters to the ret_security API > > > functions. All required parameters are checked if they are not NULL. > > [...] > > > --- a/config/common_base > > > +++ b/config/common_base > > > CONFIG_RTE_LIBRTE_SECURITY=y > > > +CONFIG_RTE_LIBRTE_SECURITY_DEBUG=n > > > > Is it a leftover? > > > > [Anoob] It is similar to 'RTE_LIBRTE_ETHDEV_DEBUG' for usage in datapath. > Like in, > http://code.dpdk.org/dpdk/latest/source/lib/librte_ethdev/rte_ethdev.h#L4378
1/ I don't see it used in this patch 2/ Adding makefile-only option is weird 3/ Adding new compile-time options is discouraged
