Hi Thomas, > > ---------------------------------------------------------------------- > 08/04/2020 15:02, Anoob Joseph: > > Hi Thomas, > > > > > 08/04/2020 05:13, Lukasz Wojciechowski: > > > > This patch adds verification of the parameters to the ret_security > > > > API functions. All required parameters are checked if they are not NULL. > > > [...] > > > > --- a/config/common_base > > > > +++ b/config/common_base > > > > CONFIG_RTE_LIBRTE_SECURITY=y > > > > +CONFIG_RTE_LIBRTE_SECURITY_DEBUG=n > > > > > > Is it a leftover? > > > > > > > [Anoob] It is similar to 'RTE_LIBRTE_ETHDEV_DEBUG' for usage in > > datapath. Like in, > > https://urldefense.proofpoint.com/v2/url?u=http-3A__code.dpdk.org_dpdk > > _latest_source_lib_librte-5Fethdev_rte-5Fethdev.h-23L4378&d=DwICAg&c=n > > KjWec2b6R0mOyPaz7xtfQ&r=jPfB8rwwviRSxyLWs2n6B- > WYLn1v9SyTMrT5EQqh2TU&m= > > > STCBgRhcnCb9M6MWQL9CUszLwy2r0NJ_3m93_D5UX3g&s=HVsD0LKZ2Q6UCW > BSRvbw9beD > > 7OtuQyWPrRrx9eofnz8&e= > > 1/ I don't see it used in this patch
[Anoob] Following snippet uses. +#ifdef RTE_LIBRTE_SECURITY_DEBUG + RTE_PTR_CHAIN3_OR_ERR_RET(instance, ops, set_pkt_metadata, -EINVAL, + -ENOTSUP); + RTE_PTR_OR_ERR_RET(sess, -EINVAL); +#endif > 2/ Adding makefile-only option is weird > 3/ Adding new compile-time options is discouraged [Anoob] This is only introduced for data path APIs. And the same approach is followed in eth dev as well. Thanks, Anoob
