Via code inspection, I found that some partially initialized
stack variables were being passed along to called functions,
which could eventually result in those uninitialized members
being used. To fix this, make sure the local variables are
zeroed out before partially initializing them. This sho
Main changes:
1) Support GTPU uplink and downlink
2) add new ACL module
3) couple fixes and code clean
v2:
- add fixline in patch 5, and move unrelated chanages.
- add more fixes and code clean
- add IPv4 proto support in switch rule
- add IPv6 dummy packet support
- add tunnel refreence count.
-
Add new api function which allow user to choose port on which
vlan and ethertype rule going to be added.
Signed-off-by: Michal Swiatkowski
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.c | 162 ++
1 file chang
Add the device IDs for the Intel(R) Ethernet Connection E822-L and
E822-X SKUs. Update the codenames and branding strings for the previous
C822N device IDs which should be using E822-C.
Signed-off-by: Jacob Keller
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/b
Send correct recp_list to ice_remove_mac_rule. ICE_SW_LKUP_ETHERTYPE
rule list was sent instead of ICE_SW_LKUP_MAC. That caused problem
with adding new mac rule on VF, because rule wasn't removed correctly.
Fixes: c7dd15931183 ("net/ice/base: add virtual switch code")
Cc: sta...@dpdk.org
Signed-o
Read the GLGEN_CLKSTAT_SRC register to determine which PSM clock
frequency is selected. This ensures that the rate limiter profile
calculations will be correct.
Fixes: 453d087ccaff ("net/ice/base: add common functions")
Cc: sta...@dpdk.org
Signed-off-by: Ben Shelton
Signed-off-by: Paul M Stillw
For structures using the common C "struct hack" technique to create a
flexible length structure member at the end of the structure, use the
ice_struct_size macro to determine the length of the structure instead of
open coding the calculation.
Signed-off-by: Bruce Allan
Signed-off-by: Paul M Still
Use enum ice_flow_field directly so no need to be converted
from u16 for ice_flow_xtract_fld
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_flow.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ice/base/ice_flow.c
Refactor function ice_prof_bld_xlt2, a switch statement is better suited
for this situation and eliminates the need for the "found" variable.
Signed-off-by: Tony Nguyen
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_flex_pipe.c | 21 +---
As title, these macros are added for future use.
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_adminq_cmd.h | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/net/ice/base/ice_adminq_cmd.h
b/drivers/net/ice/base/ice
The variable name 'type' is not very descriptive. Replace instances of
those with a variable name that is more descriptive or replace it if not
needed.
Signed-off-by: Bruce Allan
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_flex_pipe.c | 8
This is a collection of minor fixes that were found during code review.
Changes are:
- Call ice_hweight8() instead of calculating it ourselves in
ice_bits_max_set().
- Call ice_test_and_clear_bit() over calling ice_is_bit_set() then
ice_clear_bit() in ice_rem_vsi_rss_list().
- Remove 'chrs' var
Adds functions to check for link override firmware support and get
the override settings for a port. Link override allows a user to force
link settings that are not normally supported.
Firmware support is version dependent so a function to check support has
been added.
The link FC settings will u
As title.
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_type.h | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h
index 3e24bb1dc..4979580ec 100644
--- a/drivers/net/ice/base/ice
Add a new MAC type ICE_MAC_E810 to distinguish E810 devices from other
devices. MAC types for all other devices will be ICE_MAC_GENERIC till
there's a need to distinguish further between devices.
Signed-off-by: Anirudh Venkataramanan
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
--
Enable GTPU uplink and downlink flag usage.
TCAM with different GTPU extend header flag can be saperated.
Signed-off-by: Dan Nowlin
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_flex_pipe.c | 68 +++---
drivers/net/ice/base/
Adds the Driver Shared Parameters (0x0C90) AQ command.
Signed-off-by: Lev Faerman
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_adminq_cmd.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/ice/base/ice_adminq_cmd.h
b
Adds masks indicating AN clauses to the Get PHY Capabilities
command. Changes the name of the low_power_ctrl field to be
properly descriptive of it being an AN field.
Signed-off-by: Lev Faerman
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_adminq_cmd.h
Fix abbreviations as found by abbrevcheck
Signed-off-by: Tony Nguyen
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_dcb.c | 8 +++---
drivers/net/ice/base/ice_fdir.c | 6 ++---
drivers/net/ice/base/ice_flex_pipe.c | 52 ++---
The ice_read_sr_buf_aq function implements logic to correctly break
apart NVM reads into 4Kb chunks. Additionally, it ensures that each read
never crosses a Shadow RAM sector boundary. This logic is useful when
reading the flat NVM as a byte-addressable stream.
Extract that logic in terms of bytes
Remove the ice_read_sr_aq function and implement ice_read_sr_word_aq
directly in terms of the new ice_read_flat_nvm function. This simplifies
the code by reducing a now unnecessary reading function.
Signed-off-by: Jacob Keller
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
driv
Adjust variable size between u8 and u16 to fix casting issues
Also fix couple coding style issues
Karol Kolacinski
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_adminq_cmd.h | 9
drivers/net/ice/base/ice_common.c | 4 ++--
drivers/net/ic
In this patch, we will modify the ice_copy_phy_caps_to_cfg(...) function
to conditionally fill up the
ice_aqc_set_phy_cfg_data.module_compliance_enforcement with correct
value, based on the PHY persistent feature.
Apply the ice_copy_phy_caps_to_cfg() function inside ice_set_fc()
Signed-off-by: Ch
The ice_aq_read_nvm function uses a somewhat weird construction for
verifying that the incoming offset is valid. Replace this construction
with a simple greater-than expression, and define the maximum value
(24bits) in the ice_adminq_cmd.h
By providing a macro, the check becomes more clear. Additi
Add all ACL related code.
Signed-off-by: Real Valiquette
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/Makefile |2 +
drivers/net/ice/base/ice_acl.c| 629 +
drivers/net/ice/base/ice_acl.h| 206 ++
drivers/n
Add the hook to send the PF's AdminQ command in another path, like not
directly to the firmware.
If the AdminQ command is sent through the hook path, it needs to save
the AQ error codes from firmware as the last status for admin control
queue, so that the AdminQ command function can use it to do e
Update copyright date to 2020.
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_adminq_cmd.h| 2 +-
drivers/net/ice/base/ice_alloc.h | 2 +-
drivers/net/ice/base/ice_bitops.h| 2 +-
drivers/net/ice/base/ice_common.c| 2 +-
drive
Currently the NVM and Option ROM version information is stored in
a minimal format. The ice_get_nvm_version function exists to extract
this information for display.
This needlessly complicates using these fields as the extraction
function must be called to parse the NVM and Option ROM data. Furthe
DCF runs as a VF so it can't access PF registers. And export the filter
management list static functions as public for make DCF initialization.
Signed-off-by: Haiyue Wang
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common.c| 7 +--
drivers/ne
When reading from the NVM using a flat address, it is useful to know the
upper bound on the size of the flash contents. This value is not stored
within the NVM.
We can determine the size by performing a bisection between upper and
lower bounds. It is known that the size cannot exceed 16 MB (offset
The ice_get_pfa_module_tlv and ice_read_pba_string functions primarily
deal with reading from the Shadow RAM portion of the NVM contents. As
these functions are NVM focused, move them into the ice_nvm.c file.
Signed-off-by: Jacob Keller
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
Cleanup some things found while doing code review:
- Remove unnececcary initializations, parenthesis, and braces
- Fix a couple of function headers
Signed-off-by: Tony Nguyen
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.c | 42 +
The manage MAC write command was implemented in an overly complex way
that actually didn't work, as it wasn't symmetric to the manage MAC
read command, and was feeding bytes out of order to the firmware. Fix
the implementation by just using a simple array to represent the MAC
address when it is bei
Check the OS and NVM package versions before downloading the package.
If the OS package version is not compatible with NVM then return an
appropriate error.
Split the 32-byte segment name into a 28-byte segment name and
a 4-byte Track-ID. Older packages will still work with this change
because no
In order to support switch rule for pppoe packet
with ipv6 payload, it has to use a new dummy packet
with ipv6 format.
Signed-off-by: Wei Zhao
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.c | 67 +++
1 file c
Add a lock for protecting the tunnel table while adding, removing
and searching tunnels.
Add reference counting to tunnels so that multiple instances
of the same tunnel port can be created. Only physically
destroy the tunnel when all instances of that tunnel have been
destroyed.
Signed-off-by: Da
In order to support switch rule for NVGRE packets,
it need to check ipv4 next protocol number, if it is 0x2F,
which means next payload is NVGRE, we need to use NVGRE
format dummy packet.
Signed-off-by: Wei Zhao
Signed-off-by: Qi Zhang
Signed-off-by: Paul M Stillwell Jr
---
drivers/net/ice/base
On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram
wrote:
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> index c5434f3..19ce82f 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -17,13 +17,13 @@ build_map_changes()
>
implement set hash global configurations, set symmetric hash enable
and set hash input set in rte flow API.
Signed-off-by: Chenxu Di
---
v4:
-added check for l3 pctype with l4 input set.
v3:
-modified the doc i40e.rst
v2:
-canceled remove legacy filter functions.
---
doc/guides/nics/i40e.rst
Concatenating to test_args if event_eth_tx_adapter_autotest is executed
makes all subsequent tests inherit from the drivers loading while this
is unneeded.
Fixes: 207b1c813f39 ("test: fix build without ring PMD")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
app/test/meson.build | 30 ++
On Fri, Mar 13, 2020 at 9:17 AM Ruifeng Wang wrote:
>
> In environments where hugepage are not available, such as
> containers, many cases in fast-tests suite should also run
> if no-huge EAL option is used.
>
> Flag is appended to each case in fast-tests suite to indicate
> whether it lives with
On Fri, Mar 20, 2020 at 12:58 AM Mattias Rönnblom
wrote:
Thanks for the review.
>
> On 2020-03-18 20:02, jer...@marvell.com wrote:
> > From: Jerin Jacob
> >
> > The trace function payloads such as rte_trace_ctf_* have
> > dual functions. The first to emit the payload for the registration
> > fu
On Fri, Mar 20, 2020 at 12:45 AM Mattias Rönnblom
wrote:
>
> On 2020-03-18 20:02, jer...@marvell.com wrote:
> > From: Jerin Jacob
> >
> > +
> > +#define rte_trace_ctf_u64(in)\
> > + RTE_BUILD_BUG_ON(sizeof(uint64_t) != sizeof(typeof(in)));\
> > + __rte_trace_emit_ctf_field(sizeof(uint64_
On Fri, Mar 20, 2020 at 12:37 AM Mattias Rönnblom
wrote:
>
> On 2020-03-18 20:02, jer...@marvell.com wrote:
> > From: Jerin Jacob
> > +static int
> > +trace_meta_save(struct trace *trace)
> > +{
> > + char file_name[PATH_MAX];
> > + FILE *f;
> > + int rc;
> > +
> > + rc = snprint
On Mon, Mar 23, 2020 at 09:13:22AM +0100, David Marchand wrote:
> External Email
>
> --
> On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram
> wrote:
> > diff --git a/devtools/check-symbol-change.sh
> > b/devtools/check-symbol-ch
On Mon, Mar 23, 2020 at 10:28 AM Nithin Dabilpuram
wrote:
> On Mon, Mar 23, 2020 at 09:13:22AM +0100, David Marchand wrote:
> > --
> > On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram
> > wrote:
> > > diff --git a/devtools/check
On Mon, Mar 23, 2020 at 9:56 AM David Marchand
wrote:
> I rebased this series on it, see:
> https://github.com/david-marchand/dpdk/commits/ci
>
> This makes the code easier to read from my pov:
> https://github.com/david-marchand/dpdk/blob/ci/app/test/meson.build#L421
First time I see this error:
> -Original Message-
> From: Jerin Jacob
> Sent: Friday, March 20, 2020 2:18 PM
> To: Thomas Monjalon
> Cc: Wisam Monther ; dpdk-dev ;
> Matan Azrad ; Raslan Darawsheh
>
> Subject: Re: [dpdk-dev] [RFC] app/test-flow-perf: add rte_flow perf app
>
> On Fri, Mar 20, 2020 at 5:21 PM Thoma
On 2020-03-23 10:24, Jerin Jacob wrote:
> On Fri, Mar 20, 2020 at 12:45 AM Mattias Rönnblom
> wrote:
>> On 2020-03-18 20:02, jer...@marvell.com wrote:
>>> From: Jerin Jacob
>>>
>>> +
>>> +#define rte_trace_ctf_u64(in)\
>>> + RTE_BUILD_BUG_ON(sizeof(uint64_t) != sizeof(typeof(in)));\
>>> +
On Mon, Mar 23, 2020 at 3:48 PM Mattias Rönnblom
wrote:
>
> On 2020-03-23 10:24, Jerin Jacob wrote:
> > On Fri, Mar 20, 2020 at 12:45 AM Mattias Rönnblom
> > wrote:
> >> On 2020-03-18 20:02, jer...@marvell.com wrote:
> >>> From: Jerin Jacob
> >>>
> >>> +
> >>> +#define rte_trace_ctf_u64(in)\
> >
To clean up the feature matrix, we decide merge vector path and
non-vector path into one colume, the patch remove all *_vec."
of Intel NICs, if a feature only support by non vector path,
it will be represented as "P".
Qi Zhang (4):
doc: update i40e feature list
doc: update ice feature list
d
Remove vector path feature list, if a feature only be supported
in non-vector path, use "P" to represent.
Signed-off-by: Qi Zhang
---
doc/guides/nics/features/ice.ini | 12
doc/guides/nics/features/ice_vec.ini | 35 ---
2 files changed, 8 insertio
Remove vector path feature list, if a feature only be supported
in non-vector path, use "P" to represent.
Signed-off-by: Qi Zhang
---
doc/guides/nics/features/i40e.ini| 11 +
doc/guides/nics/features/i40e_vec.ini| 41
doc/guides/nics/features/
Remove vector path feature list, if a feature only be supported
in non-vector path, use "P" to represent.
Signed-off-by: Qi Zhang
---
doc/guides/nics/features/ixgbe.ini| 16 +--
doc/guides/nics/features/ixgbe_vec.ini| 46 ---
doc/guides/nics/featur
Remove vector path feature list, if a feature only be supported
in non-vector path, use "P" to represent.
Signed-off-by: Qi Zhang
---
doc/guides/nics/features/iavf.ini | 4 ++--
doc/guides/nics/features/iavf_vec.ini | 36 ---
2 files changed, 2 insertions(+),
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of jer...@marvell.com
> Sent: Wednesday, March 18, 2020 8:02 PM
>
> From: Jerin Jacob
>
> Implement rte_trace_metadata_dump() and rte_trace_dump()
> functions. Former one used to dump the CTF metadata file and
> the latter one to dump all the r
18/03/2020 11:02, Bruce Richardson:
> On Tue, Mar 17, 2020 at 05:25:21PM +0100, David Marchand wrote:
> > Installing with ninja is quite verbose by default, hide ninja output under
> > TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE options.
> >
> > Signed-off-by: David Marchand
> > --
On Mon, Mar 23, 2020 at 4:26 PM Morten Brørup
wrote:
>
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of jer...@marvell.com
> > Sent: Wednesday, March 18, 2020 8:02 PM
> >
> > From: Jerin Jacob
> >
> > Implement rte_trace_metadata_dump() and rte_trace_dump()
> > functions. Former one used
On Mon, Mar 23, 2020 at 3:23 PM Wisam Monther wrote:
>
>
>
> > -Original Message-
> > From: Jerin Jacob
> > Sent: Friday, March 20, 2020 2:18 PM
> > To: Thomas Monjalon
> > Cc: Wisam Monther ; dpdk-dev ;
> > Matan Azrad ; Raslan Darawsheh
> >
> > Subject: Re: [dpdk-dev] [RFC] app/test-f
On Thu, Mar 19, 2020 at 4:13 PM Mattias Rönnblom
wrote:
>
> On 2020-03-18 20:02, jer...@marvell.com wrote:
> > From: Jerin Jacob
> >
> > Find epoch_sec, epoch_nsec and uptime_ticks time information
> > on eal_trace_init()/bootup to derive the time in the trace.
> >
> > Signed-off-by: Jerin Jacob
Hi Anoob,
Thank you.
Please see my response inline.
Regards,
Praveen
-Original Message-
From: Anoob Joseph
Sent: Friday, March 20, 2020 1:45 PM
To: Shetty, Praveen ; dev@dpdk.org; Doherty, Declan
; bernard.iremon...@intel.co; Ananyev, Konstantin
Cc: Narayana Prasad Raju Athreya
Su
On Sat, Mar 21, 2020 at 02:47:22PM -0400, Adel Belkhiri wrote:
> Hello guys,
>
> I'm trying to develop a monitoring tool capable of exporting some
> statistics about DPDK network interfaces. The problem with spawning a
> "secondary process", the way proc-info does, is that not all the network
> in
> -Original Message-
> From: Jerin Jacob
> Sent: Monday, March 23, 2020 1:16 PM
> To: Wisam Monther
> Cc: Thomas Monjalon ; dpdk-dev
> ; Matan Azrad ; Raslan Darawsheh
>
> Subject: Re: [dpdk-dev] [RFC] app/test-flow-perf: add rte_flow perf app
>
> On Mon, Mar 23, 2020 at 3:23 PM Wisam
https://bugs.dpdk.org/show_bug.cgi?id=397
Kiran (kiran.k...@gmail.com) changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution|---
Fix check symbol change script to detect new diff file when
it is in between "--- /dev/null" to "b/lib/...".
Current awk line expects line to start with "a/..."
which is not always true for all diffs.
As a result if in_map was '1' earlier, it will not be changed
to '0' and we get check patch error
On Thu, Mar 19, 2020 at 4:05 PM Mattias Rönnblom
wrote:
>
> On 2020-03-18 20:02, jer...@marvell.com wrote:
> > From: Jerin Jacob
> > +static bool
> > +trace_entry_compare(const char *name)
> > +{
> > + struct trace_point_head *tp_list = trace_list_head_get();
> > + struct trace_point *tp
>
> Segfault was observed when running ipsec unit test:
>
> + TestCase [10] : test_ipsec_replay_inb_repeat_null_null_wrapper
>succeeded
> + TestCase [11] : test_ipsec_replay_inb_inside_burst_null_null_wrapper
>succeeded
> + TestCase [12] : test_ipsec_c
On Thu, Mar 19, 2020 at 3:46 PM Mattias Rönnblom
wrote:
>
> On 2020-03-18 20:02, jer...@marvell.com wrote:
> > From: Jerin Jacob
> >
> > This patch implements the following public trace APIs.
All the comments in this patch will be fixed in v2.
>
> Added cpu-crypto fallback option parsing as well as tests for it
>
> Signed-off-by: Mariusz Drost
> ---
Tested-by: Konstantin Ananyev
Acked-by: Konstantin Ananyev
> 2.17.1
23/03/2020 12:41, Wisam Monther:
> From: Jerin Jacob
> > On Mon, Mar 23, 2020 at 3:23 PM Wisam Monther wrote:
> > > From: Jerin Jacob
> > > > On Fri, Mar 20, 2020 at 5:21 PM Thomas Monjalon wrote:
> > > > > 20/03/2020 07:49, Jerin Jacob:
> > > > > > On Tue, Mar 17, 2020 at 7:16 PM Wisam Jaddo wro
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, March 23, 2020 3:00 PM
> To: Jerin Jacob ; Wisam Monther
>
> Cc: dpdk-dev ; Matan Azrad ;
> Raslan Darawsheh
> Subject: Re: [dpdk-dev] [RFC] app/test-flow-perf: add rte_flow perf app
>
> 23/03/2020 12:41, Wisam Monther:
> >
On Mon, Mar 23, 2020 at 12:56 PM Nithin Dabilpuram
wrote:
>
> Fix check symbol change script to detect new diff file when
> it is in between "--- /dev/null" to "b/lib/...".
> Current awk line expects line to start with "a/..."
> which is not always true for all diffs.
> As a result if in_map was
On Mon, Mar 23, 2020 at 11:58 AM Thomas Monjalon wrote:
>
> 18/03/2020 11:02, Bruce Richardson:
> > On Tue, Mar 17, 2020 at 05:25:21PM +0100, David Marchand wrote:
> > > Installing with ninja is quite verbose by default, hide ninja output under
> > > TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_V
On Thu, Mar 19, 2020 at 3:33 PM Mattias Rönnblom
wrote:
>
> On 2020-03-18 20:02, jer...@marvell.com wrote:
> > From: Jerin Jacob
> >
> > +int
> > +__rte_trace_point_register(rte_trace_t handle, const char *name, uint32_t
> > level,
> > + void (*fn)(void))
> Maybe a more des
On Mon, Feb 17, 2020 at 11:27 PM Thomas Monjalon wrote:
>
> Some compilers raise an error when declaring a variable
> in the middle of a function. This is a C99 allowance.
> Even if DPDK switches globally to C99 or C11 standard,
> the coding rules are for declarations at the beginning
> of a block
23/03/2020 14:40, David Marchand:
> On Mon, Feb 17, 2020 at 11:27 PM Thomas Monjalon wrote:
> >
> > Some compilers raise an error when declaring a variable
> > in the middle of a function. This is a C99 allowance.
> > Even if DPDK switches globally to C99 or C11 standard,
> > the coding rules are
On Mon, Feb 17, 2020 at 11:26:54PM +0100, Thomas Monjalon wrote:
> Some compilers raise an error when declaring a variable
> in the middle of a function. This is a C99 allowance.
> Even if DPDK switches globally to C99 or C11 standard,
> the coding rules are for declarations at the beginning
> of a
Trying to create zero spec for vni wasn't allowed, to
avoid matching all packets from previous layer (udp).
This behavior is incorrect, since VXLAN is being identified
through the outer UDP destination port.
Currently, if the user didn't specify outer UDP destination
port the PMD will automaticall
On Thu, Mar 19, 2020 at 2:28 AM Mattias Rönnblom
wrote:
>
> On 2020-03-18 20:02, jer...@marvell.com wrote:
> > From: Jerin Jacob
> > +
> > +#include
> > +#include
> > +
> > +/** The trace object. The trace APIs are based on this opaque object. */
> > +typedef uint64_t *rte_trace_t;
>
> Wouldn'
On 2020-03-23 14:37, Jerin Jacob wrote:
>>> + }
>>> +
>>> + /* Initialize the trace point */
>>> + if (rte_strscpy(tp->name, name, TRACE_POINT_NAME_SIZE) < 0) {
>>> + trace_err("name is too long");
>>> + rte_errno = E2BIG;
>>> + goto free;
>>> + }
On 2020-03-23 15:29, Jerin Jacob wrote:
> On Thu, Mar 19, 2020 at 2:28 AM Mattias Rönnblom
> wrote:
>> On 2020-03-18 20:02, jer...@marvell.com wrote:
>>> From: Jerin Jacob
>>> +
>>> +#include
>>> +#include
>>> +
>>> +/** The trace object. The trace APIs are based on this opaque object. */
>>> +
On Mon, Mar 23, 2020 at 8:13 PM Mattias Rönnblom
wrote:
>
> On 2020-03-23 14:37, Jerin Jacob wrote:
> >>> + }
> >>> +
> >>> + /* Initialize the trace point */
> >>> + if (rte_strscpy(tp->name, name, TRACE_POINT_NAME_SIZE) < 0) {
> >>> + trace_err("name is too long");
> >>>
> -Original Message-
> From: David Marchand
> Sent: Monday, March 23, 2020 16:40
> To: dev@dpdk.org
> Cc: acon...@redhat.com; Ruifeng Wang ;
> sta...@dpdk.org; Reshma Pattan
> Subject: [PATCH] test: load drivers when required
>
> Concatenating to test_args if event_eth_tx_adapter_autot
> -Original Message-
> From: David Marchand
> Sent: Monday, March 23, 2020 16:57
> To: Ruifeng Wang ; Aaron Conole
>
> Cc: Michael Santana ; Bruce Richardson
> ; Ananyev, Konstantin
> ; Cristian Dumitrescu
> ; Wang, Yipeng1
> ; Gobriel, Sameh ;
> dev ; Burakov, Anatoly ;
> Gavin Hu ; Hon
> -Original Message-
> From: David Marchand
> Sent: Monday, March 23, 2020 17:33
> To: Ruifeng Wang ; Aaron Conole
>
> Cc: Michael Santana ; Bruce Richardson
> ; Ananyev, Konstantin
> ; Cristian Dumitrescu
> ; Wang, Yipeng1
> ; Gobriel, Sameh ;
> dev ; Burakov, Anatoly ;
> Gavin Hu ; Hon
> -Original Message-
> From: Wang, ShougangX
> Sent: Monday, March 23, 2020 4:16 PM
> To: Wu, Jingjing ; dev@dpdk.org
> Cc: Rong, Leyi
> Subject: RE: [PATCH] net/iavf: unify Rx ptype table
>
> > -Original Message-
> > From: Wu, Jingjing
> > Sent: Monday, March 23, 2020 10:09 A
23/03/2020 14:59, Bruce Richardson:
> On Mon, Feb 17, 2020 at 11:26:54PM +0100, Thomas Monjalon wrote:
> > Some compilers raise an error when declaring a variable
> > in the middle of a function. This is a C99 allowance.
> > Even if DPDK switches globally to C99 or C11 standard,
> > the coding rule
From: Raslan Darawsheh
> Trying to create zero spec for vni wasn't allowed, to avoid matching all
> packets from previous layer (udp).
> This behavior is incorrect, since VXLAN is being identified through the outer
> UDP destination port.
>
> Currently, if the user didn't specify outer UDP desti
On 2020-03-23 16:08, Jerin Jacob wrote:
> On Mon, Mar 23, 2020 at 8:13 PM Mattias Rönnblom
> wrote:
>> On 2020-03-23 14:37, Jerin Jacob wrote:
> + }
> +
> + /* Initialize the trace point */
> + if (rte_strscpy(tp->name, name, TRACE_POINT_NAME_SIZE) < 0) {
> +
> >
> >> Subject: Re: [dpdk-dev] Arm roadmap for 20.05
> >>
> >> On 2020-03-10 17:42, Honnappa Nagarahalli wrote:
> >>> Hello,
> >>> Following are the work items planned for 20.05:
> >>>
> >>> 1) Use C11 atomic APIs in timer library
> >>> 2) Use C11 atomic APIs in service cores
> >>> 3) Use C11
> >>
> >>> Subject: Re: [dpdk-dev] Arm roadmap for 20.05
> >>>
> >>> On 2020-03-10 17:42, Honnappa Nagarahalli wrote:
> Hello,
> Following are the work items planned for 20.05:
>
> 1) Use C11 atomic APIs in timer library
> 2) Use C11 atomic APIs in service cores
> 3
On 2020-03-23 18:14, Honnappa Nagarahalli wrote:
>
>
> Subject: Re: [dpdk-dev] Arm roadmap for 20.05
>
> On 2020-03-10 17:42, Honnappa Nagarahalli wrote:
>> Hello,
>> Following are the work items planned for 20.05:
>>
>> 1) Use C11 atomic APIs in timer library
>> 2
Thanks you for your review Jerin. See my responses are inline.
On 2020-03-20 06:24, Jerin Jacob wrote:
On Fri, Feb 21, 2020 at 4:22 AM David Wilder
wrote:
If --no-huge is set and iova-mode has not been specified force VA
mode.
If --no-huge and --iova-mode=PA is requested error out as this
The rte_vhost_get_vring_base function is being called to get the values
of last_avail_idx and last_used_idx.
These fields will not have the correct values in case the function
returns an error.
Adding a check for the function return value, and in the case of an
error, set the fields to be zero and
On Mon, Mar 23, 2020 at 10:14 PM Mattias Rönnblom
wrote:
>
> On 2020-03-23 16:08, Jerin Jacob wrote:
> > On Mon, Mar 23, 2020 at 8:13 PM Mattias Rönnblom
> > wrote:
> >> On 2020-03-23 14:37, Jerin Jacob wrote:
> > + }
> > +
> > + /* Initialize the trace point */
> > +
Hi Phil,
>
> For SA outbound packets, rte_atomic64_add_return is used to generate
> SQN atomically. This introduced an unnecessary full barrier by calling
> the '__sync' builtin implemented rte_atomic_XX API on aarch64. This
> patch optimized it with c11 atomic and eliminated the expensive barrie
> Subject: RE: [PATCH v3 06/12] ipsec: optimize with c11 atomic for sa outbound
> sqn update
>
> Hi Phil,
>
> >
> > For SA outbound packets, rte_atomic64_add_return is used to generate
> > SQN atomically. This introduced an unnecessary full barrier by calling
> > the '__sync' builtin implemente
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Monday, March 23, 2020 7:08 PM
> To: Ananyev, Konstantin ; Phil Yang
> ; tho...@monjalon.net; Van Haaren, Harry
> ; step...@networkplumber.org;
> maxime.coque...@redhat.com; dev@dpdk.org; Richardson, Bruce
>
> Cc: david.march.
This is a respin of Ruifeng series with a patch I sent earlier today.
Changelog since v3:
- patch 1 is new,
- patch 3 is the only that has differences,
--
David Marchand
David Marchand (1):
test: load drivers when required
Ruifeng Wang (4):
test: skip subtests in no-huge mode
test: allow
Concatenating to test_args if event_eth_tx_adapter_autotest is executed
makes all subsequent tests inherit from the drivers loading while this
is unneeded.
Fixes: 207b1c813f39 ("test: fix build without ring PMD")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Reviewed-by: Ruifeng Wang
---
a
1 - 100 of 114 matches
Mail list logo
