On Fri, Mar 20, 2020 at 12:37 AM Mattias Rönnblom
<mattias.ronnb...@ericsson.com> wrote:
>
> On 2020-03-18 20:02, jer...@marvell.com wrote:
> > From: Jerin Jacob <jer...@marvell.com>
> > +static int
> > +trace_meta_save(struct trace *trace)
> > +{
> > + char file_name[PATH_MAX];
> > + FILE *f;
> > + int rc;
> > +
> > + rc = snprintf(file_name, PATH_MAX, "%s/metadata", trace->dir);
> > + if (rc < 0)
> > + return rc;
> > +
> > + f = fopen(file_name, "w");
> > + if (f == NULL)
> > + return -errno;
> > +
> > + rc = rte_trace_metadata_dump(f);
> > +
> > + fclose(f);
> Check fclose() return code.
Ack. Will fix it v2.
> > + return rc;
> > +}
> > +
> > +
> > +static inline int
> > +trace_file_sz(struct __rte_trace_header *hdr)
> > +{
> > + return sizeof(struct __rte_trace_stream_header) + hdr->offset;
> > +}
> > +
> > +static int
> > +trace_mem_save(struct trace *trace, struct __rte_trace_header *hdr,
> > + uint32_t cnt)
> > +{
> > + char file_name[PATH_MAX];
> > + FILE *f;
> > + int rc;
> > +
> > + rc = snprintf(file_name, PATH_MAX, "%s/channel0_%d", trace->dir, cnt);
> > + if (rc < 0)
> > + return rc;
> > +
> > + f = fopen(file_name, "w");
> > + if (f == NULL)
> > + return -errno;
> > +
> > + rc = fwrite(&hdr->stream_header, trace_file_sz(hdr), 1, f);
> > + fclose(f);
> Again, check return code.
Ack. Will fix it v2.
