Re: [dpdk-dev] [PATCH] eal: fix compiler detection in public headers

2020-03-17 Thread Dmitry Kozlyuk
> > This case is now better fixed with a patch removing EAL dependencies > > from the PCI library, which drops rte_common.h inclusion from pmdinfogen: > > http://patches.dpdk.org/patch/66701/ > > Actually rte_common.h is directly included by > buildtools/pmdinfogen/pmdinfogen.c > so we need

Re: [dpdk-dev] [PATCH 3/4] net/vhost: leverage DMA engines to accelerate Tx operations

2020-03-17 Thread Liu, Yong
Hi Jiayu, Some comments are inline. Thanks, Marvin > -Original Message- > From: dev On Behalf Of Jiayu Hu > Sent: Tuesday, March 17, 2020 5:21 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Ye, Xiaolong ; > Wang, Zhihong ; Hu, Jiayu > Subject: [dpdk-dev] [PATCH 3/4] net/vhost:

Re: [dpdk-dev] [PATCH] testpmd: added rte_eth_dev_fw_version_get in testpmd rte_eth_dev_fw_version_get() was not called in test pmd. Added rte_eth_dev_fw_version_get() in testpmd under show port info

2020-03-17 Thread Muhammad Ahmad
Hi Ferruh, Thank you for the comments. On Mon, Mar 16, 2020 at 9:39 PM Ferruh Yigit wrote: > > On 3/16/2020 10:07 AM, Muhammad Ahmad wrote: > > From: Muhammad Ahmad > > > > Hi Muhammed, > > Can you please keep the patch title short, ~70 chars, and put the detail in > the > commit log? Sure wil

Re: [dpdk-dev] [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes

2020-03-17 Thread Gavin Hu
Hi Igor, > -Original Message- > From: Chauskin, Igor > Sent: Monday, March 16, 2020 5:35 PM > To: Gavin Hu ; dev@dpdk.org > Cc: nd ; david.march...@redhat.com; tho...@monjalon.net; > m...@semihalf.com; Tzalik, Guy ; Schmeilin, Evgeny > ; m...@semihalf.com; Honnappa Nagarahalli > ; Ruifeng

Re: [dpdk-dev] [PATCH v2 0/6] check for owned ports in portmask

2020-03-17 Thread Matan Azrad
From: Stephen Hemminger > The failsafe, bonding, and netvsc PMD use eth dev port ownership to control > sub devices. These sub devices are hidden in the normal iteration over ports > but some applications use a direct port mask. In these cases, user may still > (incorrectly) try to directly use

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx descriptor status returned value

2020-03-17 Thread Slava Ovsiienko
>> From: Didier Pallard >> Sent: Monday, March 16, 2020 19:24 >> To: Slava Ovsiienko >> Cc: dev@dpdk.org; sta...@dpdk.org; Matan Azrad >> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx descriptor status returned >> value >> Well, you're right, another way to fix the problem could be to set u

[dpdk-dev] [PATCH 1/2] net/iavf: support generic flow

2020-03-17 Thread Qiming Yang
This patch added iavf_flow_create, iavf_flow_destroy, iavf_flow_flush and iavf_flow_validate support, these are used to handle all the generic filters. This patch supported basic L2, L3, L4 and GTPU patterns. Signed-off-by: Qiming Yang --- doc/guides/rel_notes/release_20_05.rst | 5 + drivers

Re: [dpdk-dev] [PATCH 0/3] mlx: fix build with -fno-common (gcc 10)

2020-03-17 Thread Matan Azrad
From: Thomas Monjalon > In GCC 10, -fno-common will be the default. > There are 2 ways of solving issues: > - add -fcommon > - stop allocating variables in .h files > > In this patchset, the variables are declared extern, because it is cleaner > anyway. > > Series-acked-by: Matan Azrad

[dpdk-dev] [PATCH 0/2] add generic filter support for iavf

2020-03-17 Thread Qiming Yang
This patch set added generic flow APIs and supported patterns includes: /* L2 */ /* ARP */ /* IPv4 */ /* IPv6 */ /* GTPU */ /* ESP */ /* AH */ /* L2TPV3 */ /* PFCP */ Qiming Yang (2): net/iavf: support generic flow net/iavf: support more patterns doc/guides/rel_notes/release_20_05.rst |

[dpdk-dev] [PATCH 2/2] net/iavf: support more patterns

2020-03-17 Thread Qiming Yang
Add patterns support for AH/ESP/L2TPV3OIP/PFCP. Added patterns are as follows: /* GTPU */ eth/ipv4/udp/gtpu eth/ipv4/udp/gtpu/gtp_psc /* ESP */ eth/ipv4/esp eth/ipv4/udp/esp eth/ipv6/esp eth/ipv6/udp/esp /* AH */ eth/ipv4/ah eth/ipv6/ah /* L2TPV3 */ eth/ipv4/l2tpv3oip et

[dpdk-dev] [PATCH] doc: fix incorrect example for specifying log level

2020-03-17 Thread Xiaolong Ye
Now we need to add prefix like lib. to enable the log. Fixes: ffb9fd1b0808 ("log: update legacy modules dynamic logs regex") Cc: sta...@dpdk.org Reported-by: Haiyue Wang Signed-off-by: Xiaolong Ye --- doc/guides/linux_gsg/eal_args.include.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [dpdk-dev] [PATCH 0/2] fixes for bonding

2020-03-17 Thread Wei Hu (Xavier)
Are there any comments on this series? Thanks. Xavier On 2020/2/25 17:29, Wei Hu (Xavier) wrote: This series include two fixes patches for bonding PMD driver. Wei Hu (Xavier) (2): net/bonding: fix MAC address when switching active port net/bonding: fix MAC address when one port resets

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx descriptor status returned value

2020-03-17 Thread Didier Pallard
well, please do if you don't mind, You will validate it quicker, and I'm currently working on a different topic. Btw, do you think it's possible to have an implementation of [r,t]x_status_descriptor functions for vectorized implementation? thanks didier On Tue, Mar 17, 2020 at 9:33 AM Slava Ovsiie

[dpdk-dev] [PATCH 2/7] net/hns3: modify inappropriate names

2020-03-17 Thread Wei Hu (Xavier)
From: Chengchang Tang This patch modifies the name of some macro and local variable to avoid devil number and increase code readability in the internal interface function named hns3_set_port_vlan_filter. Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_e

[dpdk-dev] [PATCH 0/7] misc updates for hns3 PMD driver

2020-03-17 Thread Wei Hu (Xavier)
This series are updates and fixes for hns3 PMD driver. Chengchang Tang (2): net/hns3: remove redundant MAC addr check when setting MAC net/hns3: modify inappropriate names Chengwen Feng (3): net/hns3: fix packets's offload features flags in Rx net/hns3: fix default error code of command i

[dpdk-dev] [PATCH 4/7] net/hns3: fix default error code of command interface

2020-03-17 Thread Wei Hu (Xavier)
From: Chengwen Feng Currently, the hns3 PMD driver can interact with firmware through command to complete hardware configuration. The driver calls internal interface function named hns3_cmd_send to issues command to the firmware, and check the execution result of the command through desc_ret retu

Re: [dpdk-dev] [PATCH] pci: fix missing off_t define on FreeBSD

2020-03-17 Thread Thomas Monjalon
16/03/2020 17:37, Bruce Richardson: > When removing the extra headers from rte_pci.h stdlib should have been > removed instead of stdio, since off_t is missing for BSD builds when just > including stdlib.h > > Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file") > Cc: sta...

[dpdk-dev] [PATCH 5/7] net/hns3: fix crash when flushing RSS flow rules with FLR

2020-03-17 Thread Wei Hu (Xavier)
From: Chengwen Feng Currently, we encoutner segmentation fault when performing the following test case: 1. Run testpmd application, config the flow filter rules then flush them repeatedly. 2. Inject FLR concurrently every 5 second. The calltrace info: This GDB was configured as "aarch64-linux

[dpdk-dev] [PATCH 3/7] net/hns3: fix packets's offload features flags in Rx

2020-03-17 Thread Wei Hu (Xavier)
From: Chengwen Feng Currently there is a certain probability of the unexpected ol_flag of the Rx packets's rte_mbuf when receiving packets. The root cause as below: 1. The member variable named ol_flag of the structure named rte_mbuf is not properly initialized to zero in the '.rx_pkt_burst'

[dpdk-dev] [PATCH 1/7] net/hns3: remove redundant MAC addr check when setting MAC

2020-03-17 Thread Wei Hu (Xavier)
From: Chengchang Tang This patch removes unnecessary MAC address validity check operation in the .mac_addr_set ops implementation function named hns3_set_default_mac_addr and hns3vf_set_default_mac_addr, because it has been guaranteed that input parameter named mac_addr is valid address in the rt

[dpdk-dev] [PATCH 7/7] net/hns3: fix abnormal status after reset occurs repeatedly

2020-03-17 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, when performing the following test case: 1. Run testpmd application based on hns3 PF device. 2. Inject reset(global/IMP reset) repeatedly. After the reset, the network port can't link up. In the RESET_STAGE_DEV_INIT stage of the reset process, the driver will r

[dpdk-dev] [PATCH 6/7] net/hns3: fix configuring illeagl VLAN pvid

2020-03-17 Thread Wei Hu (Xavier)
From: "Min Hu (Connor)" The VLAN pvid ranges from 0 to 4095. The hns3 PMD driver does not support this situation that the VLAN pvid is larger than Maximum VLAN ID(4095). Fixes: 411d23b9eafb ("net/hns3: support VLAN") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) Signed-off-by: Wei Hu (Xav

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx descriptor status returned value

2020-03-17 Thread Slava Ovsiienko
From: Didier Pallard Sent: Tuesday, March 17, 2020 11:19 To: Slava Ovsiienko Cc: dev@dpdk.org; sta...@dpdk.org; Matan Azrad Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx descriptor status returned value >>>well, please do if you don't mind, OK, I will. >>>You will validate it quicker, and I

Re: [dpdk-dev] [PATCH 3/4] net/vhost: leverage DMA engines to accelerate Tx operations

2020-03-17 Thread Hu, Jiayu
Hi Marvin, Thanks for comments. Replies are inline. > -Original Message- > From: Liu, Yong > Sent: Tuesday, March 17, 2020 3:21 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Ye, Xiaolong ; > Wang, Zhihong ; Hu, Jiayu > Subject: RE: [dpdk-dev] [PATCH 3/4] net/vhost:

Re: [dpdk-dev] [PATCH 2/2] build: add module definitions and pci lib support

2020-03-17 Thread Thomas Monjalon
17/03/2020 01:48, Pallavi Kadam: > Added mman functions to eal exports list. [...] > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def This file is generated. Only the .map can be updated. > @@ -7,3 +7,5 @@ EXPORTS > rte_eal_remote_launch > rte_log >

Re: [dpdk-dev] [PATCH 2/4] net/vhost: setup vrings for DMA-accelerated datapath

2020-03-17 Thread Hu, Jiayu
Hi Marvin, > -Original Message- > From: Liu, Yong > Sent: Tuesday, March 17, 2020 2:30 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Ye, Xiaolong ; > Wang, Zhihong ; Hu, Jiayu > Subject: RE: [dpdk-dev] [PATCH 2/4] net/vhost: setup vrings for DMA- > accelerated datap

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx descriptor status returned value

2020-03-17 Thread Didier Pallard
OK, thank you best regards didier On Tue, Mar 17, 2020 at 10:25 AM Slava Ovsiienko wrote: > *From:* Didier Pallard > *Sent:* Tuesday, March 17, 2020 11:19 > *To:* Slava Ovsiienko > *Cc:* dev@dpdk.org; sta...@dpdk.org; Matan Azrad > *Subject:* Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx descriptor

Re: [dpdk-dev] [PATCH 0/4] Support DMA-accelerated Tx operations for vhost-user PMD

2020-03-17 Thread Maxime Coquelin
Hi Jiayu, On 3/17/20 10:21 AM, Jiayu Hu wrote: > In vhost-user PMD's Tx operations, where data movement is heavily involved, > performing large memory copies usually takes up a major part of CPU cycles > and becomes the hot spot. To offload expensive memory operations from the > CPU, this patch se

Re: [dpdk-dev] [PATCH] ethdev: add DBDF action to RTE Flow

2020-03-17 Thread Kiran Kumar Kokkilagadda
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Monday, March 16, 2020 7:04 PM > To: Kiran Kumar Kokkilagadda ; Wenzhuo Lu > ; Jingjing Wu ; Bernard > Iremonger ; John McNamara > ; Marko Kovacevic ; > Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko > Cc: dev@dpdk.org > Subject

Re: [dpdk-dev] [RFC PATCH] ci: reduce examples built for static builds

2020-03-17 Thread David Marchand
On Mon, Mar 16, 2020 at 6:53 PM Aaron Conole wrote: > > Bruce Richardson writes: > > > Static builds can take a lot of space, so reduce the number of examples > > built when doing those static builds. > > > > Signed-off-by: Bruce Richardson > > --- > > It looks good to me. I'll try a run with R

[dpdk-dev] [dpdk-announce] DPDK 19.11.1 released

2020-03-17 Thread luca . boccassi
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-19.11.1.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=19.11 Luca Boccassi --- .ci/linux-setup.sh| 2 +- .travis.yml |

Re: [dpdk-dev] [dpdk-users] Issue while running DPDK19.11 test-pmd with Intel X722 Nic

2020-03-17 Thread Puneet Singh
Hi Xiaoyun Li Following is the difference between eth conf of testpmd and my application. Please let us know if any parameter is critical testpmd (rte_eth_conf) e = {link_speeds = 0, rxmode = {mq_mode = ETH_MQ_RX_NONE, max_rx_pkt_len = 1518, max_lro_pkt_size = 0, split_hdr_size = 0, offloads

Re: [dpdk-dev] [PATCH] net/mlx5: fix CVLAN tag set in IP item translation

2020-03-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Monday, March 16, 2020 10:58 AM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix CVLAN tag set in IP item translation > > Previous fix added, at the end of f

Re: [dpdk-dev] [RFC PATCH] ci: reduce examples built for static builds

2020-03-17 Thread Aaron Conole
David Marchand writes: > On Mon, Mar 16, 2020 at 6:53 PM Aaron Conole wrote: >> >> Bruce Richardson writes: >> >> > Static builds can take a lot of space, so reduce the number of examples >> > built when doing those static builds. >> > >> > Signed-off-by: Bruce Richardson >> > --- >> >> It loo

Re: [dpdk-dev] [PATCH v3 1/4] test: enable tests to run in no-huge mode

2020-03-17 Thread Aaron Conole
Ruifeng Wang writes: > When running with '--no-huge' flag, tests failed with messages as: > ACL context creation with invalid NUMA should have failed! > fbk hash creation should have failed > test_table_pipeline: Check pipeline invalid params failed. > > These cases test against inval

Re: [dpdk-dev] [PATCH v3 2/4] ci: generate fast-tests suite base on hugepage availability

2020-03-17 Thread Aaron Conole
Ruifeng Wang writes: > In environments where hugepage are not available, such as > containers, many cases in fast-tests suite should also run > if no-huge EAL option is used. > > Flag is appended to each case in fast-tests suite to indicate > whether it lives with no-huge mode. > With the flag, f

Re: [dpdk-dev] [PATCH v3 3/4] ci: proceed with verification without hugepage

2020-03-17 Thread Aaron Conole
Ruifeng Wang writes: > As fast-tests suite generated with only applicable cases included, > hugepage is not a mandatory to run the test. > Ignore the result of hugepage set up, so that validation in environment > without hugepage can proceed. > > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin

Re: [dpdk-dev] [PATCH v3 4/4] ci: enable unit test for aarch64

2020-03-17 Thread Aaron Conole
Ruifeng Wang writes: > Add Travis CI jobs to run unit tests on aarch64 platform. > > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin Hu > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH 01/13] librte_security: fix verification of parameters

2020-03-17 Thread Anoob Joseph
Hi Lukasz, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Lukasz Wojciechowski > Sent: Thursday, March 12, 2020 8:47 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 01/13] librte_security: fix verification of > parameters [Anoob] I believe the title

Re: [dpdk-dev] [PATCH] net/mlx5: reduce txq completion index memory loads

2020-03-17 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Monday, March 16, 2020 5:35 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: reduce txq completion index memory loads > > There is a non-optimal check

Re: [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds

2020-03-17 Thread David Marchand
On Mon, Mar 16, 2020 at 9:48 PM David Christensen wrote: > > The include file rte_debug.h is pulled into x86 builds through the > following callchain: > > lib/librte_eal/common/include/generic/rte_cycles.h:17, > lib/librte_eal/common/include/arch/x86/rte_cycles.h:13, > lib/librte_eal/common/includ

Re: [dpdk-dev] [PATCH] ethdev: add DBDF action to RTE Flow

2020-03-17 Thread Ori Kam
HI Kiran, > -Original Message- > From: Kiran Kumar Kokkilagadda > Sent: Tuesday, March 17, 2020 12:34 PM > To: Ori Kam ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > ; John McNamara > ; Marko Kovacevic > ; Thomas Monjalon ; > Ferruh Yigit ; Andrew Rybchenko > > Cc: dev@dpdk.org > Sub

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-03-17 Thread Kusztal, ArkadiuszX
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Monday, March 16, 2020 2:09 PM > To: Trahe, Fiona > Cc: Kusztal, ArkadiuszX ; David Marchand > ; nhor...@tuxdriver.com; > bl...@debian.org; ktray...@redhat.com; Ray Kinsella ; > dev@dpdk.org; Akhil Goyal ; Yigit, Ferruh > ;

[dpdk-dev] [RFC] app/test-flow-perf: add rte_flow perf app

2020-03-17 Thread Wisam Jaddo
Introducing new application for rte_flow performance testing. The application provide the ability to test insertion rate of specific rte_flow rule, by stressing it to the NIC, and calculate the insertion rate. It also provides packet per second measurements after the insertion operation is done.

[dpdk-dev] [PATCH v2 1/7] net/hinic: fix LRO problems

2020-03-17 Thread Xiaoyun wang
Pmd driver should change the max_lro_pkt_size parameter into lro_wqe_num that used for hardware, and when packets are coalesced by hardware, PKT_RX_LRO flag should be set in the RX mbuf. Fixes: 9d4878ef0897 ("net/hinic: support LRO offload") Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hini

[dpdk-dev] [PATCH v2 2/7] net/hinic/base: fix hotupdate firmware problem

2020-03-17 Thread Xiaoyun wang
When repeatedly hotupdate firmware and start/stop port at the same time, port start may be failed when cmdq reinit failed at the fw active phase, so if deteted status of cmdq is fail, then reinit the cmdq when port start. Fixes: d9ce1917941c ("net/hinic/base: add hardware operation") Signed-off-by

[dpdk-dev] [PATCH v2 3/7] net/hinic/base: optimize doorbell area initialization

2020-03-17 Thread Xiaoyun wang
The maximum doorbell area is inited from hardware param, and not uses const macro param. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_hwif.c | 23 +-- drivers/net/hinic/base/hinic_pmd_hwif.h | 1 + 2 files changed, 18 insertions(+), 6 deletions(-) diff -

[dpdk-dev] [PATCH v2 0/7] Fix LRO issue and support Flow Control

2020-03-17 Thread Xiaoyun wang
This patch fixes LRO and hotupdate firmware problems, optimize doorbell area initialization without const macro definition, Optimize log files, support pause flow control and inner vxlan or non vxlan dport filter type. -- v1->v2: - Fix LRO problems - Fix hotupdate firmware problem - Optimize

[dpdk-dev] [PATCH v2 4/7] net/hinic: remove 40GE Mezz card id

2020-03-17 Thread Xiaoyun wang
The 40GE Mezz card is not support, so remove it from the pmd driver. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c index b81ecd0..37aa042 10064

[dpdk-dev] [PATCH v2 6/7] net/hinic/base: Optimize log files

2020-03-17 Thread Xiaoyun wang
The patch optimizes log files without "\n". Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_mbox.c | 3 +-- drivers/net/hinic/base/hinic_pmd_mgmt.c | 9 - drivers/net/hinic/base/hinic_pmd_niccfg.c | 20 +--- drivers/net/hinic/base/hinic_pmd_nicio.c

[dpdk-dev] [PATCH v2 5/7] net/hinic: Add Fdir filter type

2020-03-17 Thread Xiaoyun wang
The patch supports filter type of inner VXLAN or non vxlan dport, and use TCAM method to config these rules. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_cmd.h| 6 + drivers/net/hinic/base/hinic_pmd_niccfg.c | 184 +- drivers/net/hinic/base/hinic_pmd_niccfg.h | 81

[dpdk-dev] [PATCH v2 7/7] net/hinic/base: Support Pause flow control

2020-03-17 Thread Xiaoyun wang
The patch supports pause flow control, including getting or setting rx_pasue, tx_pause and auto_neg, auto_neg is just for Electric port type. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_niccfg.c | 29 ++ drivers/net/hinic/base/hinic_pmd_niccfg.h | 2 + drivers/net/h

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-03-17 Thread Thomas Monjalon
17/03/2020 14:27, Kusztal, ArkadiuszX: > Hi Thomas, > > > -Original Message- > > From: Thomas Monjalon > > Sent: Monday, March 16, 2020 2:09 PM > > To: Trahe, Fiona > > Cc: Kusztal, ArkadiuszX ; David Marchand > > ; nhor...@tuxdriver.com; > > bl...@debian.org; ktray...@redhat.com; Ray Ki

[dpdk-dev] [RFC] net/mlx5: new device parameter to configure hairpin queue data size

2020-03-17 Thread Bing Zhao
When configuring hairpin queues, there is an input parameter to set the number of descriptors both for TX and RX interfaces. But it is not used for mlx5 devices because of the firmware mechanism. Currently, the stride buffer is being used for every ingress packet in the firmware. PMD driver could o

[dpdk-dev] [PATCH 02/33] net/bnxt: update hwrm prep to use ptr

2020-03-17 Thread Venkat Duvvuru
From: Randy Schacher - Change HWRM_PREP to use pointer and use the full HWRM enum Signed-off-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h | 3 +- drivers/net/bnxt/bnxt_hwrm.c | 206 ++- 2 files changed, 107 in

[dpdk-dev] [PATCH 00/33] add support for host based flow table management

2020-03-17 Thread Venkat Duvvuru
This patchset introduces a new mechanism to allow host-memory based flow table management. This should allow higher flow scalability than what is currently supported. This new approach also defines a new rte_flow parser, and mapper which currently supports basic packet classification in receive pat

[dpdk-dev] [PATCH 03/33] net/bnxt: add truflow message handlers

2020-03-17 Thread Venkat Duvvuru
From: Pete Spreadborough - Add bnxt message functions for truflow APIs Signed-off-by: Pete Spreadborough Signed-off-by: Randy Schacher Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 83 drivers/n

[dpdk-dev] [PATCH 05/33] net/bnxt: add initial tf core session close support

2020-03-17 Thread Venkat Duvvuru
From: Michael Wildt - Add TruFlow session and resource support functions - Add Truflow session close API and related message support functions for both session and hw resources Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Ma

[dpdk-dev] [PATCH 04/33] net/bnxt: add initial tf core session open

2020-03-17 Thread Venkat Duvvuru
From: Michael Wildt - Add infrastructure support - Add tf_core open session support Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile| 8 + drivers/net/bnxt/bnxt.h | 7 + drivers/net/bn

[dpdk-dev] [PATCH 06/33] net/bnxt: add tf core session sram functions

2020-03-17 Thread Venkat Duvvuru
From: Michael Wildt - Add TruFlow session resource support functionality - Add TruFlow session hw flush capability as well as sram support functions. - Add resource definitions for session pools. Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde ---

[dpdk-dev] [PATCH 08/33] net/bnxt: add resource manager functionality

2020-03-17 Thread Venkat Duvvuru
From: Michael Wildt - Add TruFlow RM functionality for resource handling - Update the TruFlow Resource Manager (RM) with resource support functions for debugging as well as resource cleanup. - Add support for Internal and external pools. Signed-off-by: Michael Wildt Reviewed-by: Randy Schache

[dpdk-dev] [PATCH 09/33] net/bnxt: add tf core identifier support

2020-03-17 Thread Venkat Duvvuru
From: Farah Smith - Add TruFlow Identifier resource support - Add TruFlow public API for Identifier resources. - Add support code and stack for Identifier resource allocation control. Signed-off-by: Farah Smith Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt

[dpdk-dev] [PATCH 07/33] net/bnxt: add initial tf core resource mgmt support

2020-03-17 Thread Venkat Duvvuru
From: Shahaji Bhosle - Add TruFlow public API definitions for resources as well as RM infrastructure Signed-off-by: Shahaji Bhosle Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Makefile |1 + drivers/net/bnxt/tf_core/tf_core.c| 39 +

[dpdk-dev] [PATCH 12/33] net/bnxt: add EM/EEM functionality

2020-03-17 Thread Venkat Duvvuru
From: Pete Spreadborough - Add TruFlow flow memory support - Exact Match (EM) adds the capability to manage and manipulate data flows using on chip memory. - Extended Exact Match (EEM) behaves similarly to EM, but at a vastly increased scale by using host DDR, with performance tradeoff due

[dpdk-dev] [PATCH 10/33] net/bnxt: add tf core TCAM support

2020-03-17 Thread Venkat Duvvuru
From: Shahaji Bhosle - Add TruFlow TCAM public API functions - Add TCAM support functions as well as public APIs. Signed-off-by: Shahaji Bhosle Signed-off-by: Jay Ding Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/tf_core/tf_core.c | 163 +

[dpdk-dev] [PATCH 14/33] net/bnxt: fetch vnic info from DPDK port

2020-03-17 Thread Venkat Duvvuru
VNIC is needed for the driver to program the action record for rx flows. VNIC determines what receive rings to use to place the received packets. This patch introduces a routine that will convert a given dpdk port to VNIC. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by:

[dpdk-dev] [PATCH 11/33] net/bnxt: add tf core table scope support

2020-03-17 Thread Venkat Duvvuru
From: Farah Smith - Added TruFlow Table public API - Added Table Scope capability including Table Type support code for setting and getting Table Types. Signed-off-by: Farah Smith Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnx

[dpdk-dev] [PATCH 13/33] net/bnxt: fetch SVIF information from the firmware

2020-03-17 Thread Venkat Duvvuru
SVIF (source virtual interface) is used to represent a physical port, physical function, or a virtual function. SVIF is compared during L2 context and exact match lookups in TX direction. SVIF is masked for port information during L2 context and exact match lookup in RX direction. Hence, driver nee

[dpdk-dev] [PATCH 16/33] net/bnxt: add support for ULP session manager cleanup

2020-03-17 Thread Venkat Duvvuru
A ULP session will contain all the resources needed to support rte flow offloads. A session is initialized as part of rte_eth_device start. A DPDK application can have multiple interfaces which means rte_eth_device start will be called for each of these devices. ULP session manager will make sure t

[dpdk-dev] [PATCH 18/33] net/bnxt: add support to process action tables

2020-03-17 Thread Venkat Duvvuru
From: Mike Baucom This patch processes the action template. Iterates through the list of action info templates and processes it. Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson --- drivers/net/bnxt/Makefile

[dpdk-dev] [PATCH 17/33] net/bnxt: add helper functions for blob/regfile ops

2020-03-17 Thread Venkat Duvvuru
From: Mike Baucom 1. blob routines for managing key/mask/result data 2. regfile routines for managing temporal data during flow construction Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Kha

[dpdk-dev] [PATCH 15/33] net/bnxt: add support for ULP session manager init

2020-03-17 Thread Venkat Duvvuru
A ULP session will contain all the resources needed to support rte flow offloads. A session is initialized as part of rte_eth_device start. A DPDK application can have multiple interfaces which means rte_eth_device start will be called for each of these devices. ULP session manager will make sure t

[dpdk-dev] [PATCH 22/33] net/bnxt: match rte flow items with flow template patterns

2020-03-17 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Takes hdr_bitmap generated from the rte_flow_items 2. Iterates through the static hdr_bitmap list 3. Returns success if a match is found, otherwise an error Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: La

[dpdk-dev] [PATCH 21/33] net/bnxt: add support to alloc and program key and act tbls

2020-03-17 Thread Venkat Duvvuru
From: Mike Baucom This patch does the following 1. Gets the action tables information from the action template id 2. Gets the class tables information from the class template id 3. Initializes the registry file 4. Allocates a flow id from the flow table 5. Process the class & action tables Signe

[dpdk-dev] [PATCH 19/33] net/bnxt: add support to process key tables

2020-03-17 Thread Venkat Duvvuru
From: Mike Baucom This patch creates the classifier table entries for a flow. Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c| 773

[dpdk-dev] [PATCH 20/33] net/bnxt: add support to free key and action tables

2020-03-17 Thread Venkat Duvvuru
From: Mike Baucom This patch does the following 1. Gets all the flow resources from the flow id 2. Frees all the table resources 3. Frees the flow in the flow table Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Review

[dpdk-dev] [PATCH 24/33] net/bnxt: add support for rte flow item parsing

2020-03-17 Thread Venkat Duvvuru
From: Kishore Padmanabha 1. Registers a callback handler for each rte_flow_item type, if it is supported 2. Iterates through each rte_flow_item till RTE_FLOW_ITEM_TYPE_END 3. Invokes the header call back handler 4. Each header call back handler will populate the respective fields in hdr_fie

[dpdk-dev] [PATCH 25/33] net/bnxt: add support for rte flow action parsing

2020-03-17 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Registers a callback handler for each rte_flow_action type, if it is supported 2. Iterates through each rte_flow_action till RTE_FLOW_ACTION_TYPE_END 3. Invokes the action call back handler 4. Each action call back handler will populate

[dpdk-dev] [PATCH 23/33] net/bnxt: match rte flow actions with flow template actions

2020-03-17 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Takes act_bitmap generated from the rte_flow_actions 2. Iterates through the static act_bitmap list 3. Returns success if a match is found, otherwise an error Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by:

[dpdk-dev] [PATCH 26/33] net/bnxt: add support for rte flow create driver hook

2020-03-17 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Validates rte_flow_create arguments 2. Parses rte_flow_item types 3. Parses rte_flow_action types 4. Calls ulp_matcher_pattern_match to see if the flow is supported 5. If there is a match, calls ulp_mapper_flow_create to program key & a

[dpdk-dev] [PATCH 29/33] net/bnxt: add support for rte flow flush driver hook

2020-03-17 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Gets the ulp session information from eth_dev 2. Fetches the rte_flow table associated with this session 3. Iterates through all the flows in the flow table 4. Calls ulp_mapper_resources_free which releases the key & action tables assoc

[dpdk-dev] [PATCH 30/33] net/bnxt: register tf rte flow ops

2020-03-17 Thread Venkat Duvvuru
Register bnxt_ulp_rte_flow_ops when RTE_LIBRTE_BNXT_TRUFLOW is enabled. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_ethdev.c | 4 2 files changed, 5 insertions(+) diff --git a

[dpdk-dev] [PATCH 28/33] net/bnxt: add support for rte flow destroy driver hook

2020-03-17 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Gets the ulp session information from eth_dev 2. Fetches the flow associated with the flow id from the flow table 3. Calls ulp_mapper_resources_free which releases the key & action tables associated with that flow Signed-off-by: Kishor

[dpdk-dev] [PATCH 27/33] net/bnxt: add support for rte flow validate driver hook

2020-03-17 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Validates rte_flow_create arguments 2. Parses rte_flow_item types 3. Parses rte_flow_action types 4. Calls ulp_matcher_pattern_match to see if the flow is supported 5. If there is a match, returns success otherwise failure Signed-off-by:

[dpdk-dev] [PATCH 31/33] net/bnxt: disable vector mode when BNXT TRUFLOW is enabled

2020-03-17 Thread Venkat Duvvuru
clear BNXT_FLAG_RX_VECTOR_PKT_MODE bit in bp->flags when RTE_LIBRTE_BNXT_TRUFLOW is enabled. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnxt/bn

[dpdk-dev] [PATCH 32/33] net/bnxt: add support for injecting mark into packet’s mbuf

2020-03-17 Thread Venkat Duvvuru
When a flow is offloaded with MARK action (RTE_FLOW_ACTION_TYPE_MARK), each packet of that flow will have metadata set in its completion. This metadata will be used to fetch an index into a mark table where the actual MARK for that flow is stored. Fetch the MARK from the mark table and inject it in

[dpdk-dev] [PATCH 33/33] config: introduce BNXT TRUFLOW config flag

2020-03-17 Thread Venkat Duvvuru
BNXT_TRUFLOW flag controls TRUFLOW feature in Broadcom adapters. This flag is disabled by default. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- config/common_base | 1 + 1 file changed, 1 insertion(+) diff --git a/config/common_base b/config

Re: [dpdk-dev] [RFC] net/mlx5: add large packet size support to MPRQ

2020-03-17 Thread Slava Ovsiienko
The packet rate with 64 bytes packet size over 100 Gbps line can reach 148.8 million packets per second. The ConnectX NICs descriptor part to specify the packet data receiving buffer is 16 bytes size. So, the required PCIe bandwidth just to read descriptors by the NIC from the host memory is 148

[dpdk-dev] [PATCH] devtools: silence meson install

2020-03-17 Thread David Marchand
Installing with ninja is quite verbose by default, hide ninja output under TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE options. Signed-off-by: David Marchand --- devtools/test-meson-builds.sh | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/devtools/tes

Re: [dpdk-dev] [PATCH 02/13] librte_security: fix return types in documentation

2020-03-17 Thread Anoob Joseph
Hi Lukasz, I think you will need to change the title to something like, "security: fix return types in documentation" Also, "Fixes" tag is missing. This should be applicable for stable also. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Lukasz Wojciechowski > Sent: Thurs

Re: [dpdk-dev] [PATCH v3 0/4] no-huge unit test

2020-03-17 Thread dwilder
On 2020-03-13 01:16, Ruifeng Wang wrote: For environments (such as containers) where hugetlbfs are not available, some unit tests can be run with 'no-huge' option. fast-tests suites is generated dynamically according to hugetlbfs availability in building environment. This allows unit test to ru

Re: [dpdk-dev] [PATCH 03/13] librte_security: fix session counter

2020-03-17 Thread Anoob Joseph
Hi Lukasz, The title need to be changed (librte_security -> security). With that change, Acked-by: Anoob Joseph > -Original Message- > From: dev On Behalf Of Lukasz Wojciechowski > Sent: Thursday, March 12, 2020 8:47 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 03/13] librte_secu

Re: [dpdk-dev] [PATCH] doc: fix incorrect example for specifying log level

2020-03-17 Thread Stephen Hemminger
On Tue, 17 Mar 2020 16:31:06 +0800 Xiaolong Ye wrote: > Now we need to add prefix like lib. to enable the log. > > Fixes: ffb9fd1b0808 ("log: update legacy modules dynamic logs regex") > Cc: sta...@dpdk.org > > Reported-by: Haiyue Wang > Signed-off-by: Xiaolong Ye > --- > doc/guides/linux_gs

Re: [dpdk-dev] [PATCH 1/2] hash: add hash bulk lookup with hash signatures array

2020-03-17 Thread Wang, Yipeng1
> -Original Message- > From: Medvedkin, Vladimir > Sent: Monday, March 9, 2020 5:44 AM > To: dev@dpdk.org > Cc: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > > Subject: [PATCH 1/2] hash: add hash bulk lookup with hash signatures array > > Implement rte_hash_lookup_with_hash_bulk

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-03-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, March 17, 2020 4:10 PM > To: Trahe, Fiona ; Kusztal, ArkadiuszX > > Cc: David Marchand ; > nhor...@tuxdriver.com; bl...@debian.org; ktray...@redhat.com; Ray > Kinsella ; dev@dpdk.org; Akhil Goyal > ; Yigit, Ferruh ; Ananyev,

Re: [dpdk-dev] [PATCH v3 1/4] test: enable tests to run in no-huge mode

2020-03-17 Thread Wang, Yipeng1
> -Original Message- > From: Ruifeng Wang > Sent: Friday, March 13, 2020 1:16 AM > To: acon...@redhat.com; maicolgabr...@hotmail.com; Richardson, Bruce > ; Ananyev, Konstantin > ; Dumitrescu, Cristian > ; Wang, Yipeng1 > ; Gobriel, Sameh > Cc: dev@dpdk.org; david.march...@redhat.com; Bura

Re: [dpdk-dev] [PATCH] pci: restore access to RTE_VERIFY for Power builds

2020-03-17 Thread David Marchand
On Tue, Mar 17, 2020 at 2:21 PM David Marchand wrote: > On Mon, Mar 16, 2020 at 9:48 PM David Christensen > wrote: > > > > The include file rte_debug.h is pulled into x86 builds through the > > following callchain: > > > > lib/librte_eal/common/include/generic/rte_cycles.h:17, > > lib/librte_eal/

Re: [dpdk-dev] [PATCH 0/3] add new Double Word Key hash table

2020-03-17 Thread Wang, Yipeng1
> -Original Message- > From: Stephen Hemminger > Sent: Monday, March 16, 2020 12:33 PM > To: Medvedkin, Vladimir > Cc: Morten Brørup ; dev@dpdk.org; > Ananyev, Konstantin ; Wang, Yipeng1 > ; Gobriel, Sameh ; > Richardson, Bruce ; Suanming Mou > ; Olivier Matz ; > Xueming(Steven) Li ; Andr

[dpdk-dev] [PATCH] raw/qat introduce QAT rawdev pmd

2020-03-17 Thread Mairtin o Loingsigh
Exposes QAT via rawdev API to allow the submission of operations requiring error detect and other non symmetric crypto transforms. Signed-off-by: Mairtin o Loingsigh --- config/common_base |5 + drivers/common/qat/Makefile | 14 +- drivers/common/qat/qat_device.c | 14 +

Re: [dpdk-dev] [PATCH] eal: fix compiler detection in public headers

2020-03-17 Thread Thomas Monjalon
17/03/2020 08:09, Dmitry Kozlyuk: > > > This case is now better fixed with a patch removing EAL dependencies > > > from the PCI library, which drops rte_common.h inclusion from pmdinfogen: > > > http://patches.dpdk.org/patch/66701/ > > > > Actually rte_common.h is directly included by > > b

  1   2   >