Re: [dpdk-dev] [PATCH 19.11] vfio: fix DMA mapping of externally allocated heaps

On Tue, Nov 5, 2019 at 4:15 PM Anatoly Burakov wrote: > > Currently, externally created heaps are supposed to be automatically > mapped for VFIO DMA by EAL, however they only do so if, at the time of > heap creation, VFIO is initialized and has at least one device > available. If no devices are av

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

On Wed, Nov 6, 2019 at 2:55 PM David Marchand wrote: > > On Tue, Nov 5, 2019 at 6:14 PM Burakov, Anatoly > wrote: > > > > On 05-Nov-19 3:18 PM, Burakov, Anatoly wrote: > > > On 05-Nov-19 2:10 PM, Rajesh Ravi wrote: > > >> Thanks a lot Anatoly. > > >> Will the same solution work with DPDK 19.02 a

[dpdk-dev] [PATCH] net/mlx5: set VF MAC address from host

Allow to configure the default MAC address of a VF via its representor port in the host. An API was proposed to specify explicitly the VF as a target: https://patches.dpdk.org/patch/62176/ It has been rejected by the technical board in order to keep compatibility with behavior in Intel PMDs. http

Re: [dpdk-dev] [PATCH 1/2] test/rib: speed up rib autotests

On Thu, Nov 7, 2019 at 4:21 PM Aaron Conole wrote: > > Vladimir Medvedkin writes: > > > Split slow part of rib_autotest into rib_slow_autotest > > > > Fixes: b35df4dd666e ("test/rib: add autotests") > > > > Signed-off-by: Vladimir Medvedkin > > --- > > Acked-by: Aaron Conole Series applied, th

Re: [dpdk-dev] [PATCH v6] app/test: add tests for atomic exchanges

On Wed, Nov 6, 2019 at 10:18 PM David Christensen wrote: > > The test works by creating a token comprised of random data > and a CRC8 value, using the rte_atomicXX_exchange to exchange > the new token for a previously generated token, and then > verifying that the exchanged data is intact (i.e. th

Re: [dpdk-dev] [PATCH v2] port: fix library build order dependency

On Thu, Nov 7, 2019 at 4:23 PM Dumitrescu, Cristian wrote: > > -Original Message- > > From: Shah, Rahul R > > Sent: Wednesday, November 6, 2019 2:43 PM > > To: Dumitrescu, Cristian > > Cc: dev@dpdk.org > > Subject: [PATCH v2] port: fix library build order dependency > > > > The port libr

Re: [dpdk-dev] [PATCH v16 4/8] drivers/net: update Rx RSS hash offload capabilities

On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index 931e4f4fe..6bc85a3d5 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -248,6 +248,8 @@ mlx4_dev_configure(struct rte_eth_dev *dev) > struct

Re: [dpdk-dev] [PATCH v16 3/8] ethdev: add validation to offloads set by PMD

On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: > +static int > +validate_offloads(uint16_t port_id, uint64_t req_offloads, > + uint64_t set_offloads, const char *offload_type, > + const char *(*offload_name)(uint64_t)) > +{ > + uint64_t offloads_diff = req_off

Re: [dpdk-dev] [PATCH v2] ethdev: fix expand RSS flows

On 11/6/2019 10:12 AM, Ori Kam wrote: > > >> -Original Message- >> From: Xiaoyu Min >> Sent: Tuesday, November 5, 2019 3:43 PM >> To: Ori Kam ; Slava Ovsiienko >> ; Thomas Monjalon ; >> Adrien Mazarguil ; Ferruh Yigit >> ; Andrew Rybchenko >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject

[dpdk-dev] [PATCH v3 01/19] net/mlx5: convert internal tag endianness

Public API RTE_FLOW_ACTION_TYPE_TAG and RTE_FLOW_ITEM_TYPE_TAG present data in host-endian format, as all metadata related entities. The internal mlx5 tag related action and item should use the same endianness to be conformed. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- driver

[dpdk-dev] [PATCH v3 04/19] net/mlx5: refactor flow structure

Some rte_flow fields which are local to subflows have been moved to mlx5_flow structure. RSS attributes are grouped by mlx5_flow_rss structure. tag_resource is moved to mlx5_flow_dv structure. Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net

[dpdk-dev] [PATCH v3 00/19] net/mlx5: implement extensive metadata feature

The modern networks operate on the base of the packet switching approach, and in-network environment data are transmitted as the packets. Within the host besides the data, actually transmitted on the wire as packets, there might some out-of-band data helping to process packets. These data are named

[dpdk-dev] [PATCH v3 02/19] net/mlx5: update modify header action translator

When composing device command for modify header action, provided mask should be taken more accurate into account thus length and offset in action should be set accordingly at precise bit-wise boundaries. For the future use, metadata register copy action is also added. Signed-off-by: Yongseok Koh

[dpdk-dev] [PATCH v3 05/19] net/mlx5: update flow functions

Update flow creation/destroy functions for future reuse. List operations can be skipped inside functions and done separately out of flow creation. Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow.c | 14 ++ 1 file

[dpdk-dev] [PATCH v3 03/19] net/mlx5: add metadata register copy

Add flow metadata register copy action which is supported through modify header command. As it is an internal action, not exposed to users, item type (MLX5_RTE_FLOW_ACTION_TYPE_COPY_MREG) is negative value. This can be used when creating PMD internal subflows. Signed-off-by: Yongseok Koh Signed-o

[dpdk-dev] [PATCH v3 07/19] net/mlx5: rename structure and function

There are some renaming: - in the DV flow engine overall: flow_d_* -> flow_dv_* - in flow_dv_translate(): res -> mhdr_res Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_dv.c | 151 1

[dpdk-dev] [PATCH v3 08/19] net/mlx5: check metadata registers availability

The metadata registers reg_c provide support for TAG and SET_TAG features. Although there are 8 registers are available on the current mlx5 devices, some of them can be reserved. The availability should be queried by iterative trial-and-error implemented by mlx5_flow_discover_mreg_c() routine. If

[dpdk-dev] [PATCH v3 06/19] net/mlx5: update meta register matcher set

Introduce the dedicated matcher register field setup routine. Update the code to use this unified one. Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_dv.c | 171 +++- 1 file changed, 82 in

[dpdk-dev] [PATCH v3 09/19] net/mlx5: add devarg for extensive metadata support

The PMD parameter dv_xmeta_en is added to control extensive metadata support. A nonzero value enables extensive flow metadata support if device is capable and driver supports it. This can enable extensive support of MARK and META item of rte_flow. The newly introduced SET_TAG and SET_META actions d

[dpdk-dev] [PATCH v3 11/19] net/mlx5: check the maximal modify actions number

If the extensive metadata registers are supported, it can be regarded inclusively that the extensive metadata support is possible. E.g. metadata register copy action, supporting 16 modify header actions, reserving register across different steering domain (FDB and NIC) and so on. This patch handle

[dpdk-dev] [PATCH v3 13/19] net/mlx5: add flow tag support

Add support of new rte_flow item and action - TAG and SET_TAG. TAG is a transient value which can be kept during flow matching. This is supported through device metadata register reg_c[]. Although there are 8 registers are available on the current mlx5 device, some of them can be reserved for firm

[dpdk-dev] [PATCH v3 12/19] net/mlx5: update metadata register id query

The NIC might support up to 8 extensive metadata registers. These registers are supposed to be used by multiple features. There is register id query routine to allow determine which register is actually used by specified feature. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- dri

[dpdk-dev] [PATCH v3 14/19] net/mlx5: extend flow mark support

Flow MARK item is newly supported along with MARK action. MARK action and item are supported on both Rx and Tx. It works on the metadata reg_c[] only if extensive flow metadata register is supported. Without the support, MARK action behaves same as before - valid only on Rx and no MARK item is vali

[dpdk-dev] [PATCH v3 10/19] net/mlx5: adjust shared register according to mask

The metadata register reg_c[0] might be used by kernel or firmware for their internal purposes. The actual used mask can be queried from the kernel. The remaining bits can be used by PMD to provide META or MARK feature. The code queries the mask of reg_c[0] and adjust the resource usage dynamically

[dpdk-dev] [PATCH v3 15/19] net/mlx5: extend flow meta data support

META item is supported on both Rx and Tx. 'transfer' attribute is also supported. SET_META action is also added. Due to restriction on reg_c[meta], various bit width might be available. If devarg parameter dv_xmeta_en=1, the META uses metadata register reg_c[0], which may be required for internal

[dpdk-dev] [PATCH v3 16/19] net/mlx5: add meta data support to Rx datapath

This patch moves metadata from completion descriptor to appropriate dynamic mbuf field. Signed-off-by: Yongseok Koh Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_prm.h | 6 -- drivers/net/mlx5/mlx5_rxtx.c | 5 + drivers/n

[dpdk-dev] [PATCH v3 17/19] net/mlx5: introduce flow splitters chain

The mlx5 hardware has some limitations and flow might require to be split into multiple internal subflows. For example this is needed to provide the meter object sharing between multiple flows or to provide metadata register copying before final queue/rss action. The multiple features might requir

[dpdk-dev] [PATCH v3 18/19] net/mlx5: split Rx flows to provide metadata copy

Values set by MARK and SET_META actions should be carried over to the VF representor in case of flow miss on Tx path. However, as not all metadata registers are preserved across the different domains (NIC Rx/Tx and E-Switch FDB), as a workaround, those values should be carried by reg_c's which are

[dpdk-dev] [PATCH v3 19/19] net/mlx5: add metadata register copy table

While reg_c[meta] can be copied to reg_b simply by modify-header action (it is supported by hardware), it is not possible to copy reg_c[mark] to the STE flow_tag as flow_tag is not a metadata register and this is not supported by hardware. Instead, it should be manually set by a flow per each uniqu

Re: [dpdk-dev] [PATCH v16 4/8] drivers/net: update Rx RSS hash offload capabilities

On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index ed8cbd849..37df1c40a 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1812,6 +1812,8 @@ i40e_dev_configure(struct rt

Re: [dpdk-dev] [PATCH v16 2/8] ethdev: add mbuf RSS update as an offload

On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to > enable/disable PMDs write to `rte_mbuf::hash::rss`. > PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation > by enabling `PKT_RX

[dpdk-dev] [PATCH v4 1/1] test/compress: unit tests refactoring

Core engine refactoring (test_deflate_comp_decomp function). Smaller specialized functions created. Signed-off-by: Artur Trybula Acked-by: Adam Dybkowski --- app/test/test_compressdev.c| +--- doc/guides/rel_notes/release_19_11.rst |5 + 2 files changed,

[dpdk-dev] [PATCH v4 0/1] compression: unit tests refactoring

v4 changes: - rebase onto the recent master - API modification according to the reviewer suggestions - additional modifications after code review (functions descriptions, variables renaming, small logic modification) v3 changes: - rebase onto the recent ma

Re: [dpdk-dev] [PATCH v6 07/12] app/test: clean LTO build warnings (maybe-uninitialized)

>-Original Message- >From: Andrzej Ostruszka [mailto:a...@semihalf.com] >Sent: Monday, November 4, 2019 5:48 AM >To: Wang, Yipeng1 ; dev@dpdk.org; Gobriel, Sameh >; Richardson, Bruce >; Chas Williams ; Burakov, Anatoly > >Cc: mattias.ronnb...@ericsson.com; step...@networkplumber.org >Subj

Re: [dpdk-dev] [PATCH v7 07/12] app/test: clean LTO build warnings (maybe-uninitialized)

>-Original Message- >From: Andrzej Ostruszka [mailto:aostrus...@marvell.com] >Sent: Thursday, November 7, 2019 7:03 AM >To: dev@dpdk.org; Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; Chas Williams ; Burakov, Anatoly > >Cc: mattias.ronnb...@ericsson.com; step...@networkplumber.or

Re: [dpdk-dev] [PATCH v16 7/8] examples/l2fwd: disable ptype parsing

On 11/6/2019 7:18 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Disable packet type parsing as l2fwd doesn't rely on packet types. > > Signed-off-by: Pavan Nikhilesh > --- > examples/l2fwd/Makefile| 1 + > examples/l2fwd/main.c | 2 ++ > examples/l2fwd/meson.build |

Re: [dpdk-dev] [PATCH v16 1/8] ethdev: add set ptype function

On 11/6/2019 7:17 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add `rte_eth_dev_set_ptypes` function that will allow the application > to inform the PMD about reduced range of packet types to handle. > Based on the ptypes set PMDs can optimize their Rx path. > > -If applicatio

Re: [dpdk-dev] [PATCH v16 7/8] examples/l2fwd: disable ptype parsing

On 11/6/2019 7:18 PM, pbhagavat...@marvell.com wrote: > diff --git a/examples/l2fwd/Makefile b/examples/l2fwd/Makefile > index 230352093..123e6161c 100644 > --- a/examples/l2fwd/Makefile > +++ b/examples/l2fwd/Makefile > @@ -51,6 +51,7 @@ include $(RTE_SDK)/mk/rte.vars.mk > > CFLAGS += -O3 > CF

Re: [dpdk-dev] [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask

On 11/6/2019 7:18 PM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add command to set supported ptype mask. > Usage: > set port ptype_mask > > Disable ptype parsing by default. > > Signed-off-by: Pavan Nikhilesh > --- > app/test-pmd/cmdline.c | 83 +

Re: [dpdk-dev] [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask

On Fri, 8 Nov, 2019, 12:10 am Ferruh Yigit, wrote: > On 11/6/2019 7:18 PM, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add command to set supported ptype mask. > > Usage: > > set port ptype_mask > /* *** > > > > /* list of instructions */ > > @@ -19155,

Re: [dpdk-dev] [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask

On 11/7/2019 6:55 PM, Jerin Jacob wrote: > > > On Fri, 8 Nov, 2019, 12:10 am Ferruh Yigit, > wrote: > > On 11/6/2019 7:18 PM, pbhagavat...@marvell.com > wrote: > > From: Pavan Nikhilesh

Re: [dpdk-dev] [PATCH v12 0/2] add IOVA=VA mode support

On 11/5/2019 11:04 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > --- > V12 Changes: > * Removed previously added `--legacy-kni` eal option. > * Removed previously added kni specific mempool create routines > and mempool populate routines. > > This patch set(V12) is dependent on fol

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support API to set max LRO packet size

On 11/7/2019 12:35 PM, Dekel Peled wrote: > @@ -1266,6 +1286,18 @@ struct rte_eth_dev * > RTE_ETHER_MAX_LEN; > } > > + /* > + * If LRO is enabled, check that the maximum aggregated packet > + * size is supported by the conf

Re: [dpdk-dev] [PATCH v4 3/3] app/testpmd: use API to set max LRO packet size

On 11/7/2019 12:35 PM, Dekel Peled wrote: > This patch implements use of the API for LRO aggregated packet > max size. > It adds command-line and runtime commands to configure this value, > and adds option to show the supported value. > Documentation is updated accordingly. > > Signed-off-by: Deke

Re: [dpdk-dev] [PATCH v2] net/enic: re-enable link status change interrupt

On 11/7/2019 2:42 PM, Hyong Youb Kim wrote: > When INTx is used, the interrupt handler needs to explicitly re-enable > interrupt in order to receive another one in future. The LSC interrupt > handler currently does not, and the link state never gets updated when > INTx is used (e.g. uio_pci_generic

[dpdk-dev] [PATCH 2/2] doc: fix copyright notice in SPDX tag

Aligning the Wind River copyright notices to be consistent with the other files which bare the Wind River copyright notice. Fixes: 32113d352d3b ("doc: replace license text with SPDX tag in AVP guide") Signed-off-by: Allain Legacy --- doc/guides/nics/avp.rst | 2 +- 1 file changed, 1 insertion(+

[dpdk-dev] [PATCH 1/2] test: replace license text with SPDX tag

Replacing full license text with SPDX tag. Signed-off-by: Allain Legacy --- app/test/test_cfgfile.c | 32 ++-- 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/app/test/test_cfgfile.c b/app/test/test_cfgfile.c index 37435b395..2f596affe 100644 --- a/app/

[dpdk-dev] [PATCH] maintainers: replace for AVP driver

Resigning my maintainership of the AVP driver and adding Steve Webster as a new maintainer. Signed-off-by: Allain Legacy --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e8d79ea57..671ea10f9 100644 --- a/MAINTAINERS +++ b/MAINTAI

Re: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range

Stephen, Do we want to fix testpmd? $ git grep 192.*18 origin/master -- app/test-pmd/ origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U << 24) | (18 << 16) | (0 << 8) | 1; origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U << 24) | (18 << 16) | (0 << 8) | 2; Co

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix adapter lock usage on rule creation

On 11/3/2019 10:33 AM, Ivan Malov wrote: > The point is that adapter lock has to be held on > list accesses, as well as when talking to the HW. > > Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko Ap

[dpdk-dev] [PATCH v13 2/5] eal: add the APIs to wait until equal

From: Gavin Hu The rte_wait_until_equal_xx APIs abstract the functionality of 'polling for a memory location to become equal to a given value'. Add the RTE_ARM_USE_WFE configuration entry for aarch64, disabled by default. When it is enabled, the above APIs will call WFE instruction to save CPU c

[dpdk-dev] [PATCH v13 1/5] bus/fslmc: fix the conflicting dmb function

From: Gavin Hu There are two definitions conflicting each other, for more details, refer to [1]. include/rte_atomic_64.h:19: error: "dmb" redefined [-Werror] drivers/bus/fslmc/mc/fsl_mc_sys.h:36: note: this is the location of the previous definition #define dmb() {__asm__ __volatile__("" : : :

[dpdk-dev] [PATCH v13 3/5] ticketlock: use new API to reduce contention on aarch64

From: Gavin Hu While using ticket lock, cores repeatedly poll the lock variable. This is replaced by rte_wait_until_equal API. Running ticketlock_autotest on ThunderX2, Ampere eMAG80, and Arm N1SDP[1], there were variances between runs, but no notable performance gain or degradation were seen wi

[dpdk-dev] [PATCH v13 5/5] event/opdl: use new API to save cycles on aarch64

From: Gavin Hu Use the new API to wait in low power state instead of continuous polling to save CPU cycles and power. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Jerin Jacob --- drivers/event/opdl/Makefile| 1 + drivers/event/opdl/meson.build | 1 + drivers/event/opdl/

[dpdk-dev] [PATCH v13 4/5] net/thunderx: use new API to save cycles on aarch64

From: Gavin Hu Use the new API to wait in low power state instead of continuous polling to save CPU cycles and power. Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Acked-by: Jerin Jacob --- drivers/net/thunderx/Makefile | 1 + drivers/net/thunderx/meson.build | 1 + drivers/net/thun

[dpdk-dev] [PATCH v13 0/5] use WFE for aarch64

DPDK has multiple use cases where the core repeatedly polls a location in memory. This polling results in many cache and memory transactions. Arm architecture provides WFE (Wait For Event) instruction, which allows the cpu core to enter a low power state until woken up by the update to the memory

[dpdk-dev] [PATCH] ethdev: reserve space in main structs for extension

The struct rte_eth_dev and rte_eth_dev_data are supposed to be used internally only, but there is a chance that increasing their size would break ABI for some applications. In order to allow smooth addition of features without breaking ABI compatibility, some space is reserved. Signed-off-by: Thom

Re: [dpdk-dev] [PATCH v3 00/19] net/mlx5: implement extensive metadata feature

Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, November 7, 2019 7:10 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Thomas Monjalon ; Ori > Kam ; Yongseok Koh > Subject: [PATCH v3 00/19] net/mlx5: implement extensive metadata feature > > The mode

Re: [dpdk-dev] [PATCH v2] net/mlx5: introduce mlx5 hash list

Hi, > -Original Message- > From: Bing Zhao > Sent: Thursday, November 7, 2019 11:21 AM > To: Bing Zhao ; Slava Ovsiienko > ; Stephen Hemminger > > Cc: Ori Kam ; Raslan Darawsheh > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] net/mlx5: introduce mlx5 hash list > > Adding Stephen >

Re: [dpdk-dev] [PATCH] net/mlx5: allow jump to group lower than current

Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, November 7, 2019 1:34 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko ; > Ori Kam > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: allow jump to group lower than > current > > In current i

Re: [dpdk-dev] [PATCH] net/mlx5: fix condition to create default rule

Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Thursday, November 7, 2019 5:04 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix condition to create default rule > > Previous patch add

[dpdk-dev] [PATCH] net/pcap: truncate packet if it is too large

From: Zhike Wang Previously large packet would be dropped, instead now it is better to keep it via truncating it. Signed-off-by: Zhike Wang --- drivers/net/pcap/rte_eth_pcap.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

On 11/07, Haiyue Wang wrote: >The original design is to use rte_mbuf::udata64 to save the metadata of >protocol extraction which has network protocol data fields and type, a >private API is used to decode this metadata. > >Use the dynamic mbuf field and flags to register the needed fields in >mbuf,

Re: [dpdk-dev] [PATCH v6 1/1] fbarray: fix duplicated fbarray file in secondary

-Original Message- From: Burakov, Anatoly Sent: Tuesday, November 5, 2019 11:31 AM To: David Marchand ; Yasufumi Ogawa Cc: Ananyev, Konstantin ; dev ; dpdk stable ; Yasufumi Ogawa Subject: Re: [PATCH v6 1/1] fbarray: fix duplicated fbarray file in secondary On 05-Nov-19 10:13 AM,

Re: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range

On Thu, 7 Nov 2019 21:52:47 +0100 David Marchand wrote: > Stephen, > > Do we want to fix testpmd? > > $ git grep 192.*18 origin/master -- app/test-pmd/ > origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U << > 24) | (18 << 16) | (0 << 8) | 1; > origin/master:app/test-pmd/txonly

Re: [dpdk-dev] [PATCH] ethdev: reserve space in main structs for extension

On Thu, 7 Nov 2019 23:15:24 +0100 Thomas Monjalon wrote: > The struct rte_eth_dev and rte_eth_dev_data are supposed > to be used internally only, but there is a chance that > increasing their size would break ABI for some applications. > In order to allow smooth addition of features without brea

[dpdk-dev] [PATCH v2 01/19] net/mlx5: add meter operation callback

Add the new mlx5_flow_meter.c file for metering support. Signed-off-by: Suanming Mou --- drivers/net/mlx5/Makefile | 6 ++ drivers/net/mlx5/meson.build | 3 +++ drivers/net/mlx5/mlx5.c| 2 ++ drivers/net/mlx5/mlx5.h| 4 drivers/net/mlx5/mlx5_fl

[dpdk-dev] [PATCH v2 02/19] net/mlx5: fill meter capabilities using DevX

This commit add the support of fill and get the meter capabilities from DevX. Support items: 1. The srTCM color bind mode. 2. Meter share with multiple flows. 3. Action drop. The color aware mode and multiple meter chaining in a flow are not supported. New internal function in rte_mtr_ops callba

[dpdk-dev] [PATCH v2 00/19] net/mlx5: support meter

The patches introduce the meter action support for mlx5. The design of the implementation was introduced in RFC as below: http://inbox.dpdk.org/dev/b994cd03-02f6-cd50-120f-dcf0941e4...@mellanox.com The implementation is followed RFC to split flow with meter to three sub flows. Prefix flow -> Meter

[dpdk-dev] [PATCH v2 04/19] net/mlx5: support meter profile operations

This commit add the support of meter profile add and delete operations. New internal functions in rte_mtr_ops callback: 1. meter_profile_add() 2. meter_profile_delete() Only RTE_MTR_SRTCM_RFC2697 algorithm is supported and can be added. To add other algorithm will report an error. Signed-off-by:

[dpdk-dev] [PATCH v2 06/19] net/mlx5: prepare meter flow tables

This commit prepare the meter table and suffix table. A flow with meter will be split to three flows. The three flows are created on differnet tables. The packets transfer between the flows on the tables as below: Prefix flow -> Meter flow -> Suffix flow Prefix flow does the user defined match a

[dpdk-dev] [PATCH v2 09/19] net/mlx5: add meter action creation to the glue

This commit add the meter action creation to the glue code. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_glue.c | 30 ++ drivers/net/mlx5/mlx5_glue.h | 9 + 2 files changed, 39 insertions(+) diff --git a/drivers/net/mlx5/mlx5_glue.c b/drivers/net/ml

[dpdk-dev] [PATCH v2 08/19] net/mlx5: support basic meter operations

This commit add the basic meter operations for meter create and destroy. New internal functions in rte_mtr_ops callback: 1. create() 2. destroy() The create() callback will create the corresponding flow rules on the meter table. The destroy() callback destroys the flow rules on the meter table.

[dpdk-dev] [PATCH v2 03/19] net/mlx5: allocate flow meter registers

Meter need the metadata REG_C to have the color match between the prefix flow and the meter flow. As the user define or metadata feature will both use the REG_C in the suffix flow, the color match register meter uses will not impact the register use in the later sub flow. Another case is that tag

[dpdk-dev] [PATCH v2 15/19] net/mlx5: add meter attach and detach

Add the meter attach and detach for the flow create. When create the flow with meter, first try to find any created meter action matches the flow meter id. If the meter action is already created, just attach to it and increase the ref_cnt. If not, create one. For the dettach, decrease the ref_cnt

[dpdk-dev] [PATCH v2 11/19] net/mlx5: support meter profile update

This commit add the meter profile update support. New internal function in rte_mtr_ops callback: 1. meter_profile_update() Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_meter.c | 70 +- 1 file changed, 69 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2 12/19] net/mlx5: expose flow counters management

Expose the flow counter management mechanism for other components to use. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5.h | 4 ++ drivers/net/mlx5/mlx5_flow.c| 83 + drivers/net/mlx5/mlx5_flow.h| 11 ++ drivers/net/mlx5/mlx5_fl

[dpdk-dev] [PATCH v2 10/19] net/mlx5: support meter modification operations

This commit add meter enable and disable supoort. New internal functions in rte_mtr_ops callback: 1. meter_enable() 2. meter_disable() The meter_enable() enables the meter action and the meter_disable() disables the meter action. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow.h

[dpdk-dev] [PATCH v2 05/19] net/mlx5: validate meter profile

The add meter profile should be validated if it is valid or has been add to the list. Invalid and exist profile should not be add to the list. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_meter.c | 70 ++ drivers/net/mlx5/mlx5_prm.h| 5 +

[dpdk-dev] [PATCH v2 07/19] net/mlx5: add policer rules operations

This commit create the color rules on the meter table for the packets. As the prefix flow with meter action colors the packets, the packets are transferred to the meter table with meter color match flows. Here we create the flow rules with green yellow red actions on the meter table. Packets matc

[dpdk-dev] [PATCH v2 17/19] net/mlx5: split meter flow

The flow with meter action will be divided to three sub flows, the prefix flow, the meter flow and the suffix flow. For these three sub flows, as the prefix flow and meter flow have the meter color match. In order the make the packet from prefix flow to match with the suffix flow, an extra metadat

[dpdk-dev] [PATCH v2 18/19] net/mlx5: share tag between meter and metadata

In the meter flow split, metadata flow will be as the sub flow of meter suffix flow. In meter suffix flow, there is already a unique id tag exist as for the meter prefix and suffix flow match. Make metadata feature and meter both share the unique id tag for match. Signed-off-by: Suanming Mou ---

[dpdk-dev] [PATCH v2 14/19] net/mlx5: add meter statistics read and update

This commit add the meter statistics read and update to check the meter statistics. New internal functions in rte_mtr_ops callback: 1. stats_update() 2. stats_read() Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_meter.c | 140 - 1 file changed, 1

[dpdk-dev] [PATCH v2 16/19] net/mlx5: support meter flow action

Add meter flow action support in flow validate and translate. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_dv.c | 95 + 1 file changed, 95 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index c03

Re: [dpdk-dev] [PATCH 1/2] test: replace license text with SPDX tag

On Thu, 7 Nov 2019 14:37:43 -0600 Allain Legacy wrote: > Replacing full license text with SPDX tag. > > Signed-off-by: Allain Legacy Thanks Acked-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask

On Fri, Nov 8, 2019 at 1:11 AM Ferruh Yigit wrote: > > On 11/7/2019 6:55 PM, Jerin Jacob wrote: > > > > > > On Fri, 8 Nov, 2019, 12:10 am Ferruh Yigit, > > wrote: > > > > On 11/6/2019 7:18 PM, pbhagavat...@marvell.com > > wr

Re: [dpdk-dev] [EXT] Re: [PATCH v12 0/2] add IOVA=VA mode support

> -Original Message- > From: Ferruh Yigit > Sent: Friday, November 8, 2019 1:23 AM > To: Vamsi Krishna Attunuru ; dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > Kiran Kumar Kokkilagadda ; > olivier.m...@6wind.com; anatoly.bura...@intel.com; > arybche...@solarflare.

[dpdk-dev] SPDX check: files with missing or redundant license info

Patches are outstanding for some of these. The big area with missing SPDX tags is all the ipsec-secgw shell scripts. No local changes to save Files without SPDX License -- app/test-pmd/flowgen.c app/test-pmd/macswap.c app/test/test_cfgfile.c app/test/test_compressdev_test

[dpdk-dev] [PATCH 2/2] pdump: use dynamic logtype

The logtype USER1 should not be overloaded for library function. Instead use a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 68 1 file changed, 38 insertions(+), 30 deletions(-) diff --git a/lib/librte_pdump/rte_pdump

[dpdk-dev] [PATCH 0/2] pdump: cleanups

These are a couple of small cleanups for 19.10 which came out of work on pcapng support. Full pcapng support and BPF are planned for DPDK 20.02. Stephen Hemminger (2): pdump: use new pktmbuf copy function pdump: use dynamic logtype lib/librte_pdump/rte_pdump.c | 137 ++---

[dpdk-dev] [PATCH 1/2] pdump: use new pktmbuf copy function

The rte_pktmbuf_copy handles varying size mbuf pools correctly. Signed-off-by: Stephen Hemminger --- lib/librte_pdump/rte_pdump.c | 69 +--- 1 file changed, 1 insertion(+), 68 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c i

[dpdk-dev] [PATCH 2/3] net/mlx5: reorganize jump table resources

Jump object is associated with table object, so there is no need to use a single linked list to store it. All the jump objects could be put together with related flow tables. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.h | 1 - drivers/net/mlx5/mlx5_flow.h| 7 ++-- drivers/n

[dpdk-dev] [PATCH 1/3] net/mlx5: reorganize flow tables with hash list

In the current flow tables organization, arrays are used. This is fast for searching, creating related object that will be used in flow creation. But it introduces some limitation to the table index. Then we can reorganize the flow tables information with hash list. When using hash list, there is n

[dpdk-dev] [PATCH 0/3] Reorganize resources of flow tables

Number of flow tables is limited by the memory resource, and the index could be to as large as 2^^32 - 1. In the past, the flow tables are organized by arrays, and this organization has some advantages and disadvantages. The lookup for the table resource from a linear array is quite fast, the ID co

[dpdk-dev] [PATCH 3/3] net/mlx5: reorganize flow matcher resources

Matchers are created on the specific table. If a single linked list is used to store these, then the finding process might be the bottleneck when there are a lot of different flow matchers on a huge amount of tables. The matchers could be move into the table data resource structure in order to redu

[dpdk-dev] [PATCH] net/mlx5: optimize tag traversal with hash list

Tag action for flow mark/flag could be reused by different flows. When creating a new flow with mark, the existing tag resources will be traversed in order to confirm if the action is already created. If only one linked list is used, the searching rate will drop significantly with the number of tag

Re: [dpdk-dev] [PATCH v2] net/ice: fix link status recovery

On 11/05, Qiming Yang wrote: >This patch fix a kernel driver link status issue by recovering s/fix/fixes >link status when device stop. s/stop/stops > >Fixes: e6161345d8a9 ("net/ice: support link status change") >Cc: sta...@dpdk.org > >Signed-off-by: Qiming Yang >--- > drivers/net/ice/ice_ethd

Re: [dpdk-dev] Admin Queue ENA

Hi Michał, Please look at the below function, static int ena_com_wait_and_process_admin_cq_polling( struct ena_comp_ctx *comp_ctx, struct ena_com_admin_queue *admin_queue) { unsigned long flags = 0; u64 start_time; int ret; start_time = ENA_GET_SYSTEM_USECS();

Re: [dpdk-dev] [PATCH] net/mlx5: fix asserts for multi-segment Tx offload misconfig

From: Viacheslav Ovsiienko > To support multi-segment packet sending the Tx datapath > DEV_TX_OFFLOAD_MULTI_SEGS offload must be configured. > In debug configuration the asserts arise if the multi-segment packet is being > sent and no DEV_TX_OFFLOAD_MULTI_SEGS is set. > It was found that in some

Re: [dpdk-dev] [PATCH v2 00/19] net/mlx5: support meter

From: Suanming Mou > The patches introduce the meter action support for mlx5. > The design of the implementation was introduced in RFC as below: > https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Finbox. > dpdk.org%2Fdev%2Fb994cd03-02f6-cd50-120f- > dcf0941e4485%40mellanox.com&dat

<    1   2   3   >