Stephen,

Do we want to fix testpmd?

$ git grep 192.*18 origin/master -- app/test-pmd/
origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U <<
24) | (18 << 16) | (0 << 8) | 1;
origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U <<
24) | (18 << 16) | (0 << 8) | 2;

Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")


I will take this patch on the example, for now.

On Wed, Nov 6, 2019 at 6:36 AM Hemant Agrawal <hemant.agra...@nxp.com> wrote:
>
> > -----Original Message-----
> > From: dev <dev-boun...@dpdk.org> On Behalf Of Stephen Hemminger
> > Sent: Tuesday, November 5, 2019 9:39 PM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <step...@networkplumber.org>; Ferruh Yigit
> > <ferruh.yi...@intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved
> > address range
> >
> > The original patch used incorrect subnet range for testing.
> >
> > Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses")
>
> [Hemant]  better to also add Cc: sta...@dpdk.org

Yes.

> Acked-by: Hemant Agrawal <hemant.agra...@nxp.com>

Applied, thanks.


-- 
David Marchand

Reply via email to